From 9996fcb54d82bf3ac6fa3d3eff9454a8051c3216 Mon Sep 17 00:00:00 2001 From: cyrillefr Date: Tue, 22 Apr 2025 13:37:16 +0200 Subject: [PATCH] Strips set prefix from method in ProducerMailer --- .rubocop_todo.yml | 3 +-- app/mailers/producer_mailer.rb | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 947c30d85c..cec87cdfe6 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -221,10 +221,9 @@ Metrics/PerceivedComplexity: - 'app/models/spree/ability.rb' - 'app/models/spree/order/checkout.rb' -# Offense count: 7 +# Offense count: 6 Naming/AccessorMethodName: Exclude: - - 'app/mailers/producer_mailer.rb' - 'app/models/spree/order.rb' - 'app/services/checkout/post_checkout_actions.rb' - 'lib/spree/core/controller_helpers/common.rb' diff --git a/app/mailers/producer_mailer.rb b/app/mailers/producer_mailer.rb index 0f357aec0d..104e3adc41 100644 --- a/app/mailers/producer_mailer.rb +++ b/app/mailers/producer_mailer.rb @@ -37,7 +37,7 @@ class ProducerMailer < ApplicationMailer @receival_instructions = @order_cycle.receival_instructions_for(@producer) @total = total_from_line_items(line_items) @tax_total = tax_total_from_line_items(line_items) - @customer_line_items = set_customer_data(line_items) + @customer_line_items = customer_data(line_items) end def subject @@ -76,7 +76,7 @@ class ProducerMailer < ApplicationMailer Spree::Money.new line_items.to_a.sum(&:included_tax) end - def set_customer_data(line_items) + def customer_data(line_items) return unless @coordinator.show_customer_names_to_suppliers? @display_business_name = false