From 994dd606b9773df9c5a9f23a1907025875dd3c3f Mon Sep 17 00:00:00 2001
From: David Cook <david@redcliffs.net>
Date: Fri, 24 Nov 2023 14:08:51 +1100
Subject: [PATCH] Refactor: remove dead code

I was mistakenly thinking that you can define variables in beforeEach, but it turns out these are not used.

Rather, Jest was automatically creating variables for the elements according to their IDs. How convenient!
---
 .../stimulus/bulk_form_controller_test.js            | 12 +-----------
 spec/javascripts/stimulus/popout_controller_test.js  |  6 ------
 .../stimulus/toggle_control_controller_test.js       |  6 ------
 3 files changed, 1 insertion(+), 23 deletions(-)

diff --git a/spec/javascripts/stimulus/bulk_form_controller_test.js b/spec/javascripts/stimulus/bulk_form_controller_test.js
index a1f0ee6250..b0a3386ce9 100644
--- a/spec/javascripts/stimulus/bulk_form_controller_test.js
+++ b/spec/javascripts/stimulus/bulk_form_controller_test.js
@@ -36,7 +36,7 @@ describe("BulkFormController", () => {
           <div data-record-id="1">
             <input id="input1a" type="text" value="initial1a">
             <input id="input1b" type="text" value="initial1b">
-            <button>a button is an element, but never changed</button>
+            <button>a button is counted as a form element, but value is undefined</button>
           </div>
           <div data-record-id="2">
             <input id="input2" type="text" value="initial2">
@@ -44,16 +44,6 @@ describe("BulkFormController", () => {
           <input type="submit">
         </form>
       `;
-
-      const disable1 = document.getElementById("disable1");
-      const disable1_element = document.getElementById("disable1_element");
-      const disable2 = document.getElementById("disable2");
-      const disable2_element = document.getElementById("disable2_element");
-      const actions = document.getElementById("actions");
-      const changed_summary = document.getElementById("changed_summary");
-      const input1a = document.getElementById("input1a");
-      const input1b = document.getElementById("input1b");
-      const input2 = document.getElementById("input2");
     });
 
     describe("marking changed fields", () => {
diff --git a/spec/javascripts/stimulus/popout_controller_test.js b/spec/javascripts/stimulus/popout_controller_test.js
index 91f62e7ec5..60b6f8ce89 100644
--- a/spec/javascripts/stimulus/popout_controller_test.js
+++ b/spec/javascripts/stimulus/popout_controller_test.js
@@ -26,12 +26,6 @@ describe("PopoutController", () => {
       </div>
       <input id="input4">
     `;
-
-    const button = document.getElementById("button");
-    const input1 = document.getElementById("input1");
-    const input2 = document.getElementById("input2");
-    const input3 = document.getElementById("input3");
-    const input4 = document.getElementById("input4");
   });
 
   describe("Show", () => {
diff --git a/spec/javascripts/stimulus/toggle_control_controller_test.js b/spec/javascripts/stimulus/toggle_control_controller_test.js
index eeffc17ae6..f56686fe9d 100644
--- a/spec/javascripts/stimulus/toggle_control_controller_test.js
+++ b/spec/javascripts/stimulus/toggle_control_controller_test.js
@@ -18,9 +18,6 @@ describe("ToggleControlController", () => {
           <input id="checkbox" type="checkbox" value="1" data-action="change->toggle-control#disableIfPresent" />
           <input id="control" data-toggle-control-target="control">
         </div>`;
-
-        const checkbox = document.getElementById("checkbox");
-        const control = document.getElementById("control");
       });
 
       it("Disables when checkbox is checked", () => {
@@ -44,9 +41,6 @@ describe("ToggleControlController", () => {
           <input id="input" value="" data-action="input->toggle-control#disableIfPresent" />
           <input id="control" data-toggle-control-target="control">
         </div>`;
-
-        const input = document.getElementById("input");
-        const control = document.getElementById("control");
       });
 
       it("Disables when input is filled", () => {