From 6ea021a561e183f958b4607c493326bd90e6fc67 Mon Sep 17 00:00:00 2001 From: Luis Ramos Date: Wed, 14 Oct 2020 09:59:08 +0100 Subject: [PATCH 1/2] Update rubocop_todo.yml --- .rubocop_todo.yml | 119 ++++++++++++++++++++++------------------------ 1 file changed, 58 insertions(+), 61 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index aa3e7a88db..2c867c2ec1 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,17 +1,18 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 1400` -# on 2020-09-10 16:12:05 +1000 using RuboCop version 0.81.0. +# on 2020-10-14 09:49:36 +0100 using RuboCop version 0.81.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 2 +# Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: with_first_argument, with_fixed_indentation Layout/ArgumentAlignment: Exclude: + - 'spec/models/spree/address_spec.rb' - 'spec/models/spree/order/checkout_spec.rb' # Offense count: 1 @@ -22,10 +23,11 @@ Layout/BlockAlignment: Exclude: - 'spec/models/spree/order/checkout_spec.rb' -# Offense count: 2 +# Offense count: 3 # Cop supports --auto-correct. Layout/EmptyLines: Exclude: + - 'spec/features/admin/variants_spec.rb' - 'spec/models/spree/payment_spec.rb' # Offense count: 4 @@ -118,7 +120,7 @@ Layout/SpaceInsideHashLiteralBraces: - 'spec/services/checkout/form_data_adapter_spec.rb' - 'spec/services/user_locale_setter_spec.rb' -# Offense count: 2 +# Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: final_newline, final_blank_line @@ -126,6 +128,7 @@ Layout/TrailingEmptyLines: Exclude: - 'spec/factories.rb' - 'spec/factories/address_factory.rb' + - 'spec/support/request/stripe_helper.rb' # Offense count: 6 # Cop supports --auto-correct. @@ -171,11 +174,18 @@ Lint/UselessAccessModifier: - 'app/services/mail_configuration.rb' - 'lib/open_food_network/feature_toggle.rb' +# Offense count: 1 +Lint/UselessAssignment: + Exclude: + - 'spec/**/*' + - 'lib/spree/core/controller_helpers/common.rb' + - 'app/models/spree/taxon.rb' + # Offense count: 9 Naming/AccessorMethodName: Exclude: - 'app/controllers/spree/admin/taxonomies_controller.rb' - - 'app/models/spree/adjustment_decorator.rb' + - 'app/models/spree/adjustment.rb' - 'app/models/spree/order_decorator.rb' - 'lib/spree/core/controller_helpers/common.rb' - 'spec/support/request/shop_workflow.rb' @@ -208,14 +218,14 @@ Naming/PredicateName: - 'app/models/enterprise.rb' - 'app/models/enterprise_relationship.rb' - 'app/models/order_cycle.rb' - - 'app/models/spree/ability_decorator.rb' - - 'app/models/spree/adjustment_decorator.rb' + - 'app/models/spree/adjustment.rb' - 'app/models/spree/credit_card.rb' - 'app/models/spree/line_item_decorator.rb' - 'app/models/spree/order_decorator.rb' - 'app/models/spree/payment_method.rb' - 'app/models/spree/preferences/file_configuration.rb' - - 'app/models/spree/shipping_method_decorator.rb' + - 'app/models/spree/shipping_method.rb' + - 'app/models/spree/user.rb' - 'lib/open_food_network/customers_report.rb' - 'lib/open_food_network/order_cycle_management_report.rb' - 'lib/open_food_network/order_grouper.rb' @@ -238,6 +248,12 @@ Rails/ActiveRecordAliases: - 'spec/features/consumer/shopping/orders_spec.rb' - 'spec/requests/api/orders_spec.rb' +# Offense count: 1 +# Cop supports --auto-correct. +Rails/ApplicationController: + Exclude: + - 'engines/dfc_provider/app/controllers/dfc_provider/api/base_controller.rb' + # Offense count: 3 # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible @@ -271,15 +287,15 @@ Rails/FilePath: - 'spec/controllers/api/logos_controller_spec.rb' - 'spec/controllers/api/product_images_controller_spec.rb' - 'spec/controllers/api/promo_images_controller_spec.rb' + - 'spec/controllers/api/terms_and_conditions_controller_spec.rb' - 'spec/factories/product_factory.rb' - - 'spec/features/admin/content_spec.rb' - 'spec/features/admin/enterprises/images_spec.rb' - 'spec/models/content_configuration_spec.rb' - 'spec/models/spree/variant_spec.rb' - 'spec/serializers/api/admin/enterprise_serializer_spec.rb' - 'spec/support/downloads_helper.rb' -# Offense count: 9 +# Offense count: 7 # Cop supports --auto-correct. # Configuration parameters: Include. # Include: app/models/**/*.rb @@ -289,7 +305,6 @@ Rails/FindBy: - 'app/models/product_import/entry_processor.rb' - 'app/models/product_import/entry_validator.rb' - 'app/models/product_import/spreadsheet_data.rb' - - 'app/models/spree/shipment.rb' - 'app/models/spree/user.rb' # Offense count: 2 @@ -301,18 +316,21 @@ Rails/FindEach: - 'app/models/spree/order_decorator.rb' - 'app/models/spree/shipment.rb' -# Offense count: 6 +# Offense count: 9 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/HasAndBelongsToMany: Exclude: + - 'app/models/concerns/payment_method_distributors.rb' - 'app/models/enterprise.rb' - 'app/models/enterprise_group.rb' - - 'app/models/spree/concerns/payment_method_distributors.rb' - 'app/models/spree/line_item_decorator.rb' + - 'app/models/spree/role.rb' + - 'app/models/spree/shipping_method.rb' + - 'app/models/spree/user.rb' - 'app/models/spree/zone.rb' -# Offense count: 27 +# Offense count: 35 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/HasManyOrHasOneDependent: @@ -320,13 +338,16 @@ Rails/HasManyOrHasOneDependent: - 'app/models/customer.rb' - 'app/models/enterprise.rb' - 'app/models/order_cycle.rb' - - 'app/models/spree/adjustment_decorator.rb' + - 'app/models/spree/address.rb' + - 'app/models/spree/adjustment.rb' - 'app/models/spree/credit_card.rb' - 'app/models/spree/order_decorator.rb' - 'app/models/spree/payment_method.rb' - 'app/models/spree/property.rb' - 'app/models/spree/shipment.rb' - - 'app/models/spree/shipping_method_decorator.rb' + - 'app/models/spree/shipping_category.rb' + - 'app/models/spree/shipping_method.rb' + - 'app/models/spree/taxonomy.rb' - 'app/models/spree/user.rb' - 'app/models/spree/variant_decorator.rb' - 'app/models/subscription.rb' @@ -347,7 +368,7 @@ Rails/HelperInstanceVariable: - 'app/helpers/spree/admin/orders_helper.rb' - 'app/helpers/spree/orders_helper.rb' -# Offense count: 35 +# Offense count: 33 # Configuration parameters: Include. # Include: app/controllers/**/*.rb Rails/LexicallyScopedActionFilter: @@ -363,7 +384,6 @@ Rails/LexicallyScopedActionFilter: - 'app/controllers/spree/admin/adjustments_controller.rb' - 'app/controllers/spree/admin/payment_methods_controller.rb' - 'app/controllers/spree/admin/payments_controller.rb' - - 'app/controllers/spree/admin/product_properties_controller.rb' - 'app/controllers/spree/admin/products_controller.rb' - 'app/controllers/spree/admin/search_controller.rb' - 'app/controllers/spree/admin/shipping_methods_controller.rb' @@ -403,7 +423,7 @@ Rails/ReflectionClassName: - 'app/models/enterprise_role.rb' - 'app/models/subscription.rb' -# Offense count: 241 +# Offense count: 243 # Configuration parameters: Blacklist, Whitelist. # Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters Rails/SkipsModelValidations: @@ -419,12 +439,15 @@ Rails/SkipsModelValidations: - 'app/models/enterprise_relationship.rb' - 'app/models/product_import/inventory_reset_strategy.rb' - 'app/models/proxy_order.rb' - - 'app/models/spree/address_decorator.rb' + - 'app/models/spree/address.rb' + - 'app/models/spree/adjustment.rb' - 'app/models/spree/credit_card.rb' - 'app/models/spree/order_decorator.rb' - 'app/models/spree/payment.rb' - 'app/models/spree/shipment.rb' - - 'app/models/spree/shipping_method_decorator.rb' + - 'app/models/spree/shipping_method.rb' + - 'app/models/spree/tax_category.rb' + - 'app/models/spree/taxonomy.rb' - 'app/models/spree/zone.rb' - 'app/models/subscription.rb' - 'app/models/variant_override.rb' @@ -472,7 +495,6 @@ Rails/SkipsModelValidations: - 'spec/lib/open_food_network/products_and_inventory_report_spec.rb' - 'spec/lib/open_food_network/scope_variant_to_hub_spec.rb' - 'spec/lib/stripe/credit_card_cloner_spec.rb' - - 'spec/models/calculator/weight_spec.rb' - 'spec/models/concerns/variant_stock_spec.rb' - 'spec/models/enterprise_relationship_spec.rb' - 'spec/models/exchange_spec.rb' @@ -480,6 +502,7 @@ Rails/SkipsModelValidations: - 'spec/models/spree/asset_spec.rb' - 'spec/models/spree/line_item_spec.rb' - 'spec/models/spree/order_spec.rb' + - 'spec/models/spree/tax_category_spec.rb' - 'spec/models/spree/variant_spec.rb' - 'spec/models/tag_rule/discount_order_spec.rb' - 'spec/serializers/api/admin/subscription_line_item_serializer_spec.rb' @@ -494,7 +517,7 @@ Rails/SkipsModelValidations: - 'spec/support/request/shop_workflow.rb' - 'spec/views/spree/shared/_order_details.html.haml_spec.rb' -# Offense count: 4 +# Offense count: 5 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/UniqueValidationWithoutIndex: @@ -502,6 +525,7 @@ Rails/UniqueValidationWithoutIndex: - 'app/models/customer.rb' - 'app/models/exchange.rb' - 'app/models/spree/stock_item.rb' + - 'app/models/spree/tax_category.rb' - 'app/models/spree/zone.rb' # Offense count: 2 @@ -512,14 +536,6 @@ Rails/UnknownEnv: - 'app/models/spree/app_configuration_decorator.rb' - 'lib/spree/core/controller_helpers/ssl.rb' -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: percent_q, bare_percent -Style/BarePercentLiterals: - Exclude: - - 'spec/support/request/web_helper.rb' - # Offense count: 2 Style/CaseEquality: Exclude: @@ -608,7 +624,7 @@ Style/FormatStringToken: - 'lib/open_food_network/sales_tax_report.rb' - 'spec/features/admin/bulk_order_management_spec.rb' -# Offense count: 829 +# Offense count: 818 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never @@ -739,7 +755,6 @@ Style/FrozenStringLiteralComment: - 'app/helpers/spree/admin/taxons_helper.rb' - 'app/helpers/spree/admin/zones_helper.rb' - 'app/helpers/spree/api/api_helpers.rb' - - 'app/helpers/spree/base_helper_decorator.rb' - 'app/helpers/spree/orders_helper.rb' - 'app/helpers/spree/reports_helper.rb' - 'app/helpers/spree_currency_helper.rb' @@ -803,13 +818,7 @@ Style/FrozenStringLiteralComment: - 'app/models/product_import/unit_converter.rb' - 'app/models/proxy_order.rb' - 'app/models/schedule.rb' - - 'app/models/spree/ability_decorator.rb' - - 'app/models/spree/address_decorator.rb' - - 'app/models/spree/adjustment_decorator.rb' - 'app/models/spree/app_configuration_decorator.rb' - - 'app/models/spree/calculator_decorator.rb' - - 'app/models/spree/classification_decorator.rb' - - 'app/models/spree/concerns/payment_method_distributors.rb' - 'app/models/spree/gateway/migs.rb' - 'app/models/spree/gateway/pin.rb' - 'app/models/spree/gateway/stripe_connect.rb' @@ -823,9 +832,6 @@ Style/FrozenStringLiteralComment: - 'app/models/spree/product_property_decorator.rb' - 'app/models/spree/product_set.rb' - 'app/models/spree/property.rb' - - 'app/models/spree/shipping_method_decorator.rb' - - 'app/models/spree/tax_rate_decorator.rb' - - 'app/models/spree/taxon_decorator.rb' - 'app/models/spree/user.rb' - 'app/models/spree/variant_decorator.rb' - 'app/models/stripe_account.rb' @@ -945,6 +951,7 @@ Style/FrozenStringLiteralComment: - 'app/services/tax_rate_finder.rb' - 'app/services/upload_sanitizer.rb' - 'app/services/variant_deleter.rb' + - 'app/services/variant_units/variant_and_line_item_naming.rb' - 'app/services/variants_stock_levels.rb' - 'app/validators/date_time_string_validator.rb' - 'app/validators/distributors_validator.rb' @@ -1043,10 +1050,8 @@ Style/FrozenStringLiteralComment: - 'lib/open_food_network/tag_rule_applicator.rb' - 'lib/open_food_network/user_balance_calculator.rb' - 'lib/open_food_network/users_and_enterprises_report.rb' - - 'lib/open_food_network/variant_and_line_item_naming.rb' - 'lib/open_food_network/xero_invoices_report.rb' - 'lib/spree/api/controller_setup.rb' - - 'lib/spree/api/testing_support/setup.rb' - 'lib/spree/authentication_helpers.rb' - 'lib/spree/localized_number.rb' - 'lib/spree/money_decorator.rb' @@ -1105,6 +1110,7 @@ Style/FrozenStringLiteralComment: - 'spec/controllers/api/statuses_controller_spec.rb' - 'spec/controllers/api/taxonomies_controller_spec.rb' - 'spec/controllers/api/taxons_controller_spec.rb' + - 'spec/controllers/api/terms_and_conditions_controller_spec.rb' - 'spec/controllers/api/variants_controller_spec.rb' - 'spec/controllers/base_controller_spec.rb' - 'spec/controllers/cart_controller_spec.rb' @@ -1147,6 +1153,7 @@ Style/FrozenStringLiteralComment: - 'spec/factories/order_cycle_factory.rb' - 'spec/factories/order_factory.rb' - 'spec/factories/product_factory.rb' + - 'spec/factories/return_authorization_factory.rb' - 'spec/factories/shipment_factory.rb' - 'spec/factories/shipping_method_factory.rb' - 'spec/factories/state_factory.rb' @@ -1159,6 +1166,7 @@ Style/FrozenStringLiteralComment: - 'spec/features/admin/authentication_spec.rb' - 'spec/features/admin/bulk_order_management_spec.rb' - 'spec/features/admin/bulk_product_update_spec.rb' + - 'spec/features/admin/configuration/content_spec.rb' - 'spec/features/admin/configuration/general_settings_spec.rb' - 'spec/features/admin/configuration/image_settings_spec.rb' - 'spec/features/admin/configuration/mail_methods_spec.rb' @@ -1167,14 +1175,12 @@ Style/FrozenStringLiteralComment: - 'spec/features/admin/configuration/tax_rates_spec.rb' - 'spec/features/admin/configuration/taxonomies_spec.rb' - 'spec/features/admin/configuration/zones_spec.rb' - - 'spec/features/admin/content_spec.rb' - 'spec/features/admin/customers_spec.rb' - 'spec/features/admin/enterprise_fees_spec.rb' - 'spec/features/admin/enterprise_groups_spec.rb' - 'spec/features/admin/enterprise_relationships_spec.rb' - 'spec/features/admin/enterprise_roles_spec.rb' - 'spec/features/admin/enterprise_user_spec.rb' - - 'spec/features/admin/enterprises/images_spec.rb' - 'spec/features/admin/enterprises/index_spec.rb' - 'spec/features/admin/enterprises_spec.rb' - 'spec/features/admin/external_services_spec.rb' @@ -1250,7 +1256,6 @@ Style/FrozenStringLiteralComment: - 'spec/lib/open_food_network/group_buy_report_spec.rb' - 'spec/lib/open_food_network/i18n_config_spec.rb' - 'spec/lib/open_food_network/lettuce_share_report_spec.rb' - - 'spec/lib/open_food_network/option_value_namer_spec.rb' - 'spec/lib/open_food_network/order_and_distributor_report_spec.rb' - 'spec/lib/open_food_network/order_cycle_form_applicator_spec.rb' - 'spec/lib/open_food_network/order_cycle_management_report_spec.rb' @@ -1331,7 +1336,6 @@ Style/FrozenStringLiteralComment: - 'spec/models/spree/shipping_method_spec.rb' - 'spec/models/spree/stock/availability_validator_spec.rb' - 'spec/models/spree/tax_rate_spec.rb' - - 'spec/models/spree/taxon_spec.rb' - 'spec/models/spree/user_spec.rb' - 'spec/models/spree/variant_spec.rb' - 'spec/models/stripe_account_spec.rb' @@ -1397,6 +1401,7 @@ Style/FrozenStringLiteralComment: - 'spec/services/search_orders_spec.rb' - 'spec/services/tax_rate_finder_spec.rb' - 'spec/services/upload_sanitizer_spec.rb' + - 'spec/services/variant_units/option_value_namer_spec.rb' - 'spec/services/variants_stock_levels_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/ability_helper.rb' @@ -1425,7 +1430,7 @@ Style/FrozenStringLiteralComment: - 'spec/support/products_helper.rb' - 'spec/support/request/admin_helper.rb' - 'spec/support/request/authentication_helper.rb' - - 'spec/support/request/checkout_workflow.rb' + - 'spec/support/request/checkout_helper.rb' - 'spec/support/request/cookie_helper.rb' - 'spec/support/request/distribution_helper.rb' - 'spec/support/request/menu_helper.rb' @@ -1460,16 +1465,16 @@ Style/GuardClause: - 'app/models/enterprise.rb' - 'app/models/enterprise_group.rb' - 'app/models/producer_property.rb' - - 'app/models/spree/classification_decorator.rb' - 'app/models/spree/order_decorator.rb' - 'app/models/spree/price_decorator.rb' - 'app/models/spree/product_decorator.rb' - 'app/services/order_syncer.rb' + - 'app/services/variant_units/variant_and_line_item_naming.rb' - 'lib/discourse/single_sign_on.rb' - 'lib/open_food_network/order_cycle_form_applicator.rb' - 'lib/open_food_network/rack_request_blocker.rb' - - 'lib/open_food_network/variant_and_line_item_naming.rb' - 'spec/support/delayed_job_helper.rb' + - 'spec/support/request/checkout_helper.rb' - 'spec/support/request/distribution_helper.rb' - 'spec/support/request/shop_workflow.rb' @@ -1495,7 +1500,7 @@ Style/MixinUsage: - 'lib/open_food_network/orders_and_fulfillments_report.rb' - 'spec/lib/open_food_network/packing_report_spec.rb' -# Offense count: 37 +# Offense count: 36 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods. # SupportedStyles: predicate, comparison @@ -1508,7 +1513,6 @@ Style/NumericPredicate: - 'app/helpers/shared_helper.rb' - 'app/models/product_import/product_importer.rb' - 'app/models/product_import/spreadsheet_entry.rb' - - 'app/models/spree/adjustment_decorator.rb' - 'app/models/spree/gateway/stripe_connect.rb' - 'app/models/spree/line_item_decorator.rb' - 'app/models/spree/order_decorator.rb' @@ -1538,12 +1542,6 @@ Style/RandomWithOffset: Exclude: - 'spec/factories.rb' -# Offense count: 1 -# Cop supports --auto-correct. -Style/RedundantPercentQ: - Exclude: - - 'spec/support/request/web_helper.rb' - # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, AllowInnerSlashes. @@ -1563,7 +1561,6 @@ Style/RescueStandardError: # Offense count: 231 Style/Send: Exclude: - - 'app/models/spree/shipping_method_decorator.rb' - 'spec/controllers/admin/subscriptions_controller_spec.rb' - 'spec/controllers/checkout_controller_spec.rb' - 'spec/controllers/spree/admin/base_controller_spec.rb' @@ -1575,7 +1572,6 @@ Style/Send: - 'spec/lib/open_food_network/enterprise_fee_applicator_spec.rb' - 'spec/lib/open_food_network/enterprise_fee_calculator_spec.rb' - 'spec/lib/open_food_network/lettuce_share_report_spec.rb' - - 'spec/lib/open_food_network/option_value_namer_spec.rb' - 'spec/lib/open_food_network/order_cycle_form_applicator_spec.rb' - 'spec/lib/open_food_network/permissions_spec.rb' - 'spec/lib/open_food_network/products_and_inventory_report_spec.rb' @@ -1597,6 +1593,7 @@ Style/Send: - 'spec/models/tag_rule/filter_shipping_methods_spec.rb' - 'spec/services/cart_service_spec.rb' - 'spec/services/products_renderer_spec.rb' + - 'spec/services/variant_units/option_value_namer_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/localized_number_helper.rb' - 'spec/support/matchers/delegate_matchers.rb' From 2b6b2c1b6555a0b531cfe3ddfda806815c136357 Mon Sep 17 00:00:00 2001 From: Luis Ramos Date: Wed, 14 Oct 2020 10:11:56 +0100 Subject: [PATCH 2/2] Update rubocop manual according to latest state of the codebase --- .rubocop_manual_todo.yml | 312 ++++++++++++++++++++++----------------- 1 file changed, 178 insertions(+), 134 deletions(-) diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index 6ae7dbf880..3e32bf9faf 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -62,20 +62,13 @@ Layout/LineLength: - app/models/product_import/unit_converter.rb - app/models/proxy_order.rb - app/models/schedule.rb - - app/models/spree/ability_decorator.rb - app/models/spree/app_configuration_decorator.rb - - app/models/spree/calculator/default_tax_decorator.rb - - app/models/spree/classification_decorator.rb - - app/models/spree/concerns/payment_method_distributors.rb - app/models/spree/gateway/stripe_connect.rb + - app/models/spree/image.rb - app/models/spree/line_item_decorator.rb - app/models/spree/order_decorator.rb - - app/models/spree/payment_decorator.rb - - app/models/spree/payment_method_decorator.rb + - app/models/spree/payment_method.rb - app/models/spree/product_decorator.rb - - app/models/spree/shipping_method_decorator.rb - - app/models/spree/taxon_decorator.rb - - app/models/spree/tax_rate_decorator.rb - app/models/spree/user.rb - app/models/subscription.rb - app/models/variant_override.rb @@ -86,6 +79,8 @@ Layout/LineLength: - app/services/embedded_page_service.rb - app/services/order_cycle_form.rb - app/services/order_factory.rb + - app/services/variant_units/variant_and_line_item_naming.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - engines/order_management/app/services/order_management/subscriptions/validator.rb - engines/web/app/helpers/web/cookies_policy_helper.rb - engines/web/config/routes.rb @@ -93,7 +88,6 @@ Layout/LineLength: - Gemfile - lib/discourse/single_sign_on.rb - lib/open_food_network/available_payment_method_filter.rb - - lib/open_food_network/bulk_coop_report.rb - lib/open_food_network/customers_report.rb - lib/open_food_network/enterprise_fee_applicator.rb - lib/open_food_network/enterprise_fee_calculator.rb @@ -103,10 +97,8 @@ Layout/LineLength: - lib/open_food_network/order_cycle_form_applicator.rb - lib/open_food_network/order_cycle_management_report.rb - lib/open_food_network/payments_report.rb - - lib/open_food_network/reports/bulk_coop_allocation_report.rb - lib/open_food_network/sales_tax_report.rb - lib/open_food_network/scope_variants_for_search.rb - - lib/open_food_network/variant_and_line_item_naming.rb - lib/open_food_network/xero_invoices_report.rb - lib/spree/localized_number.rb - lib/spree/product_filters.rb @@ -134,6 +126,8 @@ Layout/LineLength: - spec/controllers/api/product_images_controller_spec.rb - spec/controllers/api/products_controller_spec.rb - spec/controllers/api/promo_images_controller_spec.rb + - spec/controllers/api/states_controller_spec.rb + - spec/controllers/api/terms_and_conditions_controller_spec.rb - spec/controllers/api/variants_controller_spec.rb - spec/controllers/cart_controller_spec.rb - spec/controllers/checkout_controller_spec.rb @@ -156,11 +150,15 @@ Layout/LineLength: - spec/controllers/stripe/callbacks_controller_spec.rb - spec/controllers/stripe/webhooks_controller_spec.rb - spec/controllers/user_confirmations_controller_spec.rb + - spec/factories/line_item_factory.rb - spec/factories/order_factory.rb - - spec/factories.rb + - spec/factories/shipment_factory.rb + - spec/factories/stock_location_factory.rb + - spec/factories/user_factory.rb - spec/features/admin/adjustments_spec.rb - spec/features/admin/bulk_order_management_spec.rb - spec/features/admin/bulk_product_update_spec.rb + - spec/features/admin/configuration/content_spec.rb - spec/features/admin/customers_spec.rb - spec/features/admin/enterprise_fees_spec.rb - spec/features/admin/enterprise_relationships_spec.rb @@ -193,7 +191,7 @@ Layout/LineLength: - spec/features/consumer/account/settings_spec.rb - spec/features/consumer/account_spec.rb - spec/features/consumer/authentication_spec.rb - - spec/features/consumer/caching/darkwarm_caching_spec.rb + - spec/features/consumer/caching/darkswarm_caching_spec.rb - spec/features/consumer/caching/shops_caching_spec.rb - spec/features/consumer/groups_spec.rb - spec/features/consumer/multilingual_spec.rb @@ -202,6 +200,7 @@ Layout/LineLength: - spec/features/consumer/shopping/cart_spec.rb - spec/features/consumer/shopping/checkout_auth_spec.rb - spec/features/consumer/shopping/checkout_spec.rb + - spec/features/consumer/shopping/checkout_stripe_spec.rb - spec/features/consumer/shopping/embedded_groups_spec.rb - spec/features/consumer/shopping/embedded_shopfronts_spec.rb - spec/features/consumer/shopping/orders_spec.rb @@ -220,18 +219,15 @@ Layout/LineLength: - spec/jobs/subscription_confirm_job_spec.rb - spec/jobs/subscription_placement_job_spec.rb - spec/lib/open_food_network/address_finder_spec.rb - - spec/lib/open_food_network/bulk_coop_report_spec.rb - spec/lib/open_food_network/customers_report_spec.rb - spec/lib/open_food_network/enterprise_fee_applicator_spec.rb - spec/lib/open_food_network/enterprise_fee_calculator_spec.rb - spec/lib/open_food_network/group_buy_report_spec.rb - spec/lib/open_food_network/lettuce_share_report_spec.rb - - spec/lib/open_food_network/option_value_namer_spec.rb - spec/lib/open_food_network/order_cycle_form_applicator_spec.rb - spec/lib/open_food_network/order_cycle_permissions_spec.rb - spec/lib/open_food_network/order_grouper_spec.rb - spec/lib/open_food_network/orders_and_fulfillments_report_spec.rb - - spec/lib/open_food_network/packing_report_spec.rb - spec/lib/open_food_network/permissions_spec.rb - spec/lib/open_food_network/products_and_inventory_report_spec.rb - spec/lib/open_food_network/scope_variant_to_hub_spec.rb @@ -239,11 +235,14 @@ Layout/LineLength: - spec/lib/open_food_network/user_balance_calculator_spec.rb - spec/lib/open_food_network/users_and_enterprises_report_spec.rb - spec/lib/open_food_network/xero_invoices_report_spec.rb + - spec/lib/spree/core/calculated_adjustments_spec.rb - spec/lib/stripe/account_connector_spec.rb - spec/lib/stripe/webhook_handler_spec.rb - spec/mailers/order_mailer_spec.rb - spec/mailers/producer_mailer_spec.rb - spec/mailers/subscription_mailer_spec.rb + - spec/models/calculator/flexi_rate_spec.rb + - spec/models/calculator/price_sack_spec.rb - spec/models/calculator/weight_spec.rb - spec/models/column_preference_spec.rb - spec/models/concerns/order_shipment_spec.rb @@ -261,9 +260,8 @@ Layout/LineLength: - spec/models/product_import/reset_absent_spec.rb - spec/models/proxy_order_spec.rb - spec/models/spree/ability_spec.rb + - spec/models/spree/address_spec.rb - spec/models/spree/adjustment_spec.rb - - spec/models/spree/calculator/flexi_rate_spec.rb - - spec/models/spree/calculator/price_sack_spec.rb - spec/models/spree/classification_spec.rb - spec/models/spree/gateway/stripe_connect_spec.rb - spec/models/spree/line_item_spec.rb @@ -273,6 +271,7 @@ Layout/LineLength: - spec/models/spree/product_set_spec.rb - spec/models/spree/product_spec.rb - spec/models/spree/shipping_method_spec.rb + - spec/models/spree/stock_item_spec.rb - spec/models/spree/taxon_spec.rb - spec/models/spree/tax_rate_spec.rb - spec/models/spree/user_spec.rb @@ -286,8 +285,8 @@ Layout/LineLength: - spec/models/variant_override_spec.rb - spec/performance/orders_controller_spec.rb - spec/performance/shop_controller_spec.rb + - spec/requests/api/orders_spec.rb - spec/requests/checkout/failed_checkout_spec.rb - - spec/requests/checkout/stripe_sca_spec.rb - spec/requests/embedded_shopfronts_headers_spec.rb - spec/serializers/api/admin/customer_serializer_spec.rb - spec/serializers/api/admin/exchange_serializer_spec.rb @@ -307,11 +306,11 @@ Layout/LineLength: - spec/services/order_cycle_form_spec.rb - spec/services/order_factory_spec.rb - spec/services/order_syncer_spec.rb - - spec/services/order_tax_adjustments_fetcher_spec.rb - spec/services/permissions/order_spec.rb - spec/services/permitted_attributes/order_cycle_spec.rb - spec/services/products_renderer_spec.rb - spec/services/product_tag_rules_filterer_spec.rb + - spec/services/variant_units/option_value_namer_spec.rb - spec/spec_helper.rb - spec/support/cancan_helper.rb - spec/support/delayed_job_helper.rb @@ -321,22 +320,8 @@ Layout/LineLength: - spec/support/request/shop_workflow.rb - spec/support/request/web_helper.rb - spec/support/seeds.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - - spec/controllers/base_controller2_spec.rb - - spec/features/consumer/caching/darkswarm_caching_spec.rb - - spec/models/calculator/flexi_rate_spec.rb - - spec/models/calculator/price_sack_spec.rb - - spec/models/spree/stock_item_spec.rb - - spec/requests/api/orders_spec.rb - spec/swagger_helper.rb - spec/views/spree/admin/payment_methods/index.html.haml_spec.rb - - app/models/spree/image.rb - - app/models/spree/payment_method.rb - - spec/factories/line_item_factory.rb - - spec/factories/shipment_factory.rb - - spec/factories/stock_location_factory.rb - - spec/factories/user_factory.rb - - spec/lib/spree/core/calculated_adjustments_spec.rb Metrics/AbcSize: Max: 15 @@ -356,6 +341,7 @@ Metrics/AbcSize: - app/controllers/api/shipments_controller.rb - app/controllers/api/taxons_controller.rb - app/controllers/api/variants_controller.rb + - app/controllers/application_controller.rb - app/controllers/cart_controller.rb - app/controllers/discourse_sso_controller.rb - app/controllers/enterprises_controller.rb @@ -371,6 +357,7 @@ Metrics/AbcSize: - app/controllers/spree/admin/search_controller.rb - app/controllers/spree/admin/taxons_controller.rb - app/controllers/spree/admin/users_controller.rb + - app/controllers/spree/admin/variants_controller.rb - app/controllers/spree/credit_cards_controller.rb - app/controllers/spree/orders_controller.rb - app/controllers/spree/user_passwords_controller.rb @@ -382,7 +369,6 @@ Metrics/AbcSize: - app/controllers/user_passwords_controller.rb - app/controllers/user_registrations_controller.rb - app/helpers/checkout_helper.rb - - app/helpers/i18n_helper.rb - app/helpers/order_cycles_helper.rb - app/helpers/spree/admin/base_helper.rb - app/helpers/spree/admin/navigation_helper.rb @@ -398,16 +384,18 @@ Metrics/AbcSize: - app/models/product_import/entry_validator.rb - app/models/product_import/product_importer.rb - app/models/proxy_order.rb - - app/models/spree/ability_decorator.rb - - app/models/spree/calculator/default_tax_decorator.rb - - app/models/spree/calculator/flexi_rate_decorator.rb + - app/models/spree/ability.rb + - app/models/spree/address.rb - app/models/spree/line_item_decorator.rb + - app/models/spree/order/checkout.rb - app/models/spree/order_decorator.rb - - app/models/spree/payment_decorator.rb + - app/models/spree/payment/processing.rb + - app/models/spree/payment.rb - app/models/spree/product_decorator.rb - app/models/spree/shipment.rb - - app/models/spree/taxon_decorator.rb - - app/models/spree/tax_rate_decorator.rb + - app/models/spree/taxon.rb + - app/models/spree/tax_rate.rb + - app/models/spree/zone.rb - app/serializers/api/admin/enterprise_serializer.rb - app/serializers/api/product_serializer.rb - app/serializers/api/variant_serializer.rb @@ -415,7 +403,10 @@ Metrics/AbcSize: - app/services/create_order_cycle.rb - app/services/order_cycle_form.rb - app/services/order_syncer.rb + - app/services/variant_units/option_value_namer.rb + - app/services/variant_units/variant_and_line_item_naming.rb - engines/order_management/app/services/order_management/order/updater.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - engines/order_management/app/services/order_management/stock/estimator.rb - engines/order_management/app/services/order_management/stock/package.rb - engines/order_management/app/services/order_management/stock/packer.rb @@ -423,12 +414,10 @@ Metrics/AbcSize: - lib/active_merchant/billing/gateways/stripe_decorator.rb - lib/active_merchant/billing/gateways/stripe_payment_intents.rb - lib/discourse/single_sign_on.rb - - lib/open_food_network/bulk_coop_report.rb - lib/open_food_network/customers_report.rb - lib/open_food_network/enterprise_issue_validator.rb - lib/open_food_network/group_buy_report.rb - lib/open_food_network/lettuce_share_report.rb - - lib/open_food_network/option_value_namer.rb - lib/open_food_network/order_and_distributor_report.rb - lib/open_food_network/order_cycle_form_applicator.rb - lib/open_food_network/order_cycle_management_report.rb @@ -440,13 +429,17 @@ Metrics/AbcSize: - lib/open_food_network/reports/line_items.rb - lib/open_food_network/sales_tax_report.rb - lib/open_food_network/users_and_enterprises_report.rb - - lib/open_food_network/variant_and_line_item_naming.rb - lib/open_food_network/xero_invoices_report.rb - lib/spree/api/controller_setup.rb + - lib/spree/core/calculated_adjustments.rb - lib/spree/core/controller_helpers/order.rb - lib/spree/core/controller_helpers/respond_with.rb - lib/spree/core/controller_helpers/ssl.rb + - lib/spree/core/delegate_belongs_to.rb + - lib/spree/core/permalinks.rb + - lib/spree/core/s3_support.rb - lib/spree/localized_number.rb + - lib/spree/money.rb - lib/stripe/account_connector.rb - lib/tasks/enterprises.rake - lib/tasks/sample_data/order_factory.rb @@ -454,25 +447,13 @@ Metrics/AbcSize: - spec/features/admin/product_import_spec.rb - spec/features/admin/reports_spec.rb - spec/features/admin/subscriptions_spec.rb - - spec/features/consumer/shopping/checkout_paypal_spec.rb - spec/features/consumer/shopping/shopping_spec.rb - spec/features/consumer/shopping/variant_overrides_spec.rb - spec/models/enterprise_spec.rb - spec/models/product_importer_spec.rb - spec/services/order_checkout_restart_spec.rb - - spec/support/performance_helper.rb - - app/controllers/application_controller.rb - - app/models/spree/order/checkout.rb - - app/models/spree/payment/processing.rb - - app/models/spree/payment.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - - app/models/spree/zone.rb - - lib/spree/core/calculated_adjustments.rb - - lib/spree/core/delegate_belongs_to.rb - - lib/spree/core/permalinks.rb - - lib/spree/core/s3_support.rb - - lib/spree/money.rb - spec/support/i18n_translations_checker.rb + - spec/support/performance_helper.rb Metrics/BlockLength: Max: 25 @@ -490,16 +471,21 @@ Metrics/BlockLength: "scenario" ] Exclude: + - app/models/spree/order/checkout.rb + - app/models/spree/payment/processing.rb - app/models/spree/shipment.rb - lib/spree/core/controller_helpers/common.rb - lib/spree/core/controller_helpers/ssl.rb - lib/tasks/data.rake - spec/controllers/spree/admin/invoices_controller_spec.rb + - spec/factories/address_factory.rb - spec/factories/enterprise_factory.rb - spec/factories/order_cycle_factory.rb - spec/factories/order_factory.rb + - spec/factories/payment_method_factory.rb - spec/factories/product_factory.rb - spec/factories.rb + - spec/factories/shipment_factory.rb - spec/factories/shipping_method_factory.rb - spec/factories/subscription_factory.rb - spec/factories/user_factory.rb @@ -507,17 +493,12 @@ Metrics/BlockLength: - spec/features/consumer/shopping/embedded_shopfronts_spec.rb - spec/lib/open_food_network/group_buy_report_spec.rb - spec/models/tag_rule/discount_order_spec.rb + - spec/requests/api/orders_spec.rb - spec/spec_helper.rb - spec/support/delayed_job_helper.rb - spec/support/matchers/select2_matchers.rb - spec/support/matchers/table_matchers.rb - - app/models/spree/order/checkout.rb - - app/models/spree/payment/processing.rb - - spec/requests/api/orders_spec.rb - spec/swagger_helper.rb - - spec/factories/address_factory.rb - - spec/factories/payment_method_factory.rb - - spec/factories/shipment_factory.rb Metrics/CyclomaticComplexity: Max: 6 @@ -527,68 +508,149 @@ Metrics/CyclomaticComplexity: - app/controllers/spree/admin/taxons_controller.rb - app/controllers/spree/orders_controller.rb - app/helpers/checkout_helper.rb - - app/helpers/i18n_helper.rb - app/helpers/order_cycles_helper.rb - app/helpers/spree/admin/base_helper.rb - app/helpers/spree/admin/navigation_helper.rb - app/models/enterprise.rb - app/models/enterprise_relationship.rb - - app/models/spree/ability_decorator.rb - - app/models/spree/payment_decorator.rb - - app/models/spree/payment_method_decorator.rb + - app/models/spree/ability.rb + - app/models/spree/address.rb + - app/models/spree/order/checkout.rb + - app/models/spree/payment_method.rb + - app/models/spree/payment.rb - app/models/spree/product_decorator.rb + - app/models/spree/zone.rb - app/models/variant_override_set.rb - app/services/cart_service.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - engines/order_management/app/services/order_management/stock/estimator.rb - lib/active_merchant/billing/gateways/stripe_payment_intents.rb - lib/discourse/single_sign_on.rb - - lib/open_food_network/bulk_coop_report.rb - lib/open_food_network/enterprise_issue_validator.rb + - lib/spree/core/calculated_adjustments.rb - lib/spree/core/controller_helpers/order.rb - lib/spree/core/controller_helpers/respond_with.rb - lib/spree/core/controller_helpers/ssl.rb - lib/spree/localized_number.rb - spec/models/product_importer_spec.rb - - app/models/spree/order/checkout.rb - - app/models/spree/payment.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - - app/models/spree/payment_method.rb - - app/models/spree/zone.rb - - lib/spree/core/calculated_adjustments.rb Metrics/PerceivedComplexity: Max: 7 Exclude: + - app/controllers/admin/enterprise_fees_controller.rb + - app/controllers/admin/enterprises_controller.rb + - app/controllers/spree/admin/taxons_controller.rb + - app/controllers/spree/orders_controller.rb + - app/helpers/checkout_helper.rb + - app/helpers/order_cycles_helper.rb + - app/helpers/spree/admin/base_helper.rb + - app/helpers/spree/admin/navigation_helper.rb + - app/models/enterprise.rb + - app/models/enterprise_relationship.rb + - app/models/spree/ability.rb + - app/models/spree/address.rb + - app/models/spree/order/checkout.rb + - app/models/spree/payment_method.rb + - app/models/spree/payment.rb + - app/models/spree/product_decorator.rb + - app/models/spree/zone.rb + - app/models/variant_override_set.rb + - app/services/cart_service.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb + - engines/order_management/app/services/order_management/stock/estimator.rb + - lib/active_merchant/billing/gateways/stripe_payment_intents.rb + - lib/discourse/single_sign_on.rb + - lib/open_food_network/enterprise_issue_validator.rb + - lib/spree/core/calculated_adjustments.rb + - lib/spree/core/controller_helpers/order.rb + - lib/spree/core/controller_helpers/respond_with.rb + - lib/spree/core/controller_helpers/ssl.rb + - lib/spree/localized_number.rb + - spec/models/product_importer_spec.rb - app/controllers/admin/enterprises_controller.rb - app/controllers/api/variants_controller.rb - app/controllers/spree/admin/taxons_controller.rb - app/controllers/spree/orders_controller.rb - app/helpers/checkout_helper.rb - - app/helpers/i18n_helper.rb - app/helpers/order_cycles_helper.rb - app/helpers/spree/admin/navigation_helper.rb - app/models/enterprise_relationship.rb - - app/models/spree/ability_decorator.rb + - app/models/spree/ability.rb + - app/models/spree/address.rb + - app/models/spree/order/checkout.rb - app/models/spree/order_decorator.rb - app/models/spree/product_decorator.rb + - app/models/spree/zone.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - engines/order_management/app/services/order_management/stock/estimator.rb - lib/active_merchant/billing/gateways/stripe_payment_intents.rb - lib/discourse/single_sign_on.rb - - lib/open_food_network/bulk_coop_report.rb - lib/open_food_network/enterprise_issue_validator.rb + - lib/spree/core/calculated_adjustments.rb - lib/spree/core/controller_helpers/order.rb - lib/spree/core/controller_helpers/respond_with.rb - lib/spree/core/controller_helpers/ssl.rb - lib/spree/localized_number.rb - spec/models/product_importer_spec.rb - - app/models/spree/order/checkout.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - - app/models/spree/zone.rb - - lib/spree/core/calculated_adjustments.rb Metrics/MethodLength: Max: 10 Exclude: + - app/controllers/admin/enterprise_fees_controller.rb + - app/controllers/admin/enterprises_controller.rb + - app/controllers/spree/admin/taxons_controller.rb + - app/controllers/spree/orders_controller.rb + - app/helpers/checkout_helper.rb + - app/helpers/order_cycles_helper.rb + - app/helpers/spree/admin/base_helper.rb + - app/helpers/spree/admin/navigation_helper.rb + - app/models/enterprise.rb + - app/models/enterprise_relationship.rb + - app/models/spree/ability.rb + - app/models/spree/address.rb + - app/models/spree/order/checkout.rb + - app/models/spree/payment_method.rb + - app/models/spree/payment.rb + - app/models/spree/product_decorator.rb + - app/models/spree/zone.rb + - app/models/variant_override_set.rb + - app/services/cart_service.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb + - engines/order_management/app/services/order_management/stock/estimator.rb + - lib/active_merchant/billing/gateways/stripe_payment_intents.rb + - lib/discourse/single_sign_on.rb + - lib/open_food_network/enterprise_issue_validator.rb + - lib/spree/core/calculated_adjustments.rb + - lib/spree/core/controller_helpers/order.rb + - lib/spree/core/controller_helpers/respond_with.rb + - lib/spree/core/controller_helpers/ssl.rb + - lib/spree/localized_number.rb + - spec/models/product_importer_spec.rb + - app/controllers/admin/enterprises_controller.rb + - app/controllers/api/variants_controller.rb + - app/controllers/spree/admin/taxons_controller.rb + - app/controllers/spree/orders_controller.rb + - app/helpers/checkout_helper.rb + - app/helpers/order_cycles_helper.rb + - app/helpers/spree/admin/navigation_helper.rb + - app/models/enterprise_relationship.rb + - app/models/spree/ability.rb + - app/models/spree/address.rb + - app/models/spree/order/checkout.rb + - app/models/spree/order_decorator.rb + - app/models/spree/product_decorator.rb + - app/models/spree/zone.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb + - engines/order_management/app/services/order_management/stock/estimator.rb + - lib/active_merchant/billing/gateways/stripe_payment_intents.rb + - lib/discourse/single_sign_on.rb + - lib/open_food_network/enterprise_issue_validator.rb + - lib/spree/core/calculated_adjustments.rb + - lib/spree/core/controller_helpers/order.rb + - lib/spree/core/controller_helpers/respond_with.rb + - lib/spree/core/controller_helpers/ssl.rb + - lib/spree/localized_number.rb + - spec/models/product_importer_spec.rb - app/controllers/admin/contents_controller.rb - app/controllers/admin/customers_controller.rb - app/controllers/admin/enterprise_fees_controller.rb @@ -614,9 +676,9 @@ Metrics/MethodLength: - app/controllers/spree/admin/tax_categories_controller.rb - app/controllers/spree/admin/taxons_controller.rb - app/controllers/spree/admin/users_controller.rb + - app/controllers/spree/admin/variants_controller.rb - app/controllers/spree/credit_cards_controller.rb - app/controllers/spree/orders_controller.rb - - app/controllers/spree/user_registrations_controller.rb - app/controllers/spree/user_sessions_controller.rb - app/controllers/stripe/callbacks_controller.rb - app/controllers/user_confirmations_controller.rb @@ -635,32 +697,38 @@ Metrics/MethodLength: - app/models/product_import/entry_processor.rb - app/models/product_import/entry_validator.rb - app/models/product_import/product_importer.rb - - app/models/spree/ability_decorator.rb - - app/models/spree/calculator/default_tax_decorator.rb - - app/models/spree/calculator/flexi_rate_decorator.rb + - app/models/spree/ability.rb + - app/models/spree/address.rb + - app/models/spree/credit_card.rb + - app/models/spree/order/checkout.rb - app/models/spree/order_decorator.rb - - app/models/spree/payment_decorator.rb - - app/models/spree/payment_method_decorator.rb + - app/models/spree/payment_method.rb + - app/models/spree/payment/processing.rb - app/models/spree/product_decorator.rb - app/models/spree/shipment.rb + - app/models/spree/taxon.rb + - app/models/spree/tax_rate.rb + - app/models/spree/zone.rb - app/serializers/api/admin/order_cycle_serializer.rb - app/serializers/api/cached_enterprise_serializer.rb - app/services/order_cycle_form.rb - app/services/permitted_attributes/checkout.rb + - app/services/variant_units/option_value_namer.rb - engines/order_management/app/services/order_management/order/updater.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_allocation_report.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_supplier_report.rb - engines/order_management/app/services/order_management/reports/enterprise_fee_summary/scope.rb - engines/order_management/app/services/order_management/stock/estimator.rb - engines/order_management/app/services/order_management/stock/package.rb - lib/active_merchant/billing/gateways/stripe_payment_intents.rb - lib/discourse/single_sign_on.rb - - lib/open_food_network/bulk_coop_report.rb - lib/open_food_network/column_preference_defaults.rb - lib/open_food_network/customers_report.rb - lib/open_food_network/enterprise_fee_calculator.rb - lib/open_food_network/enterprise_issue_validator.rb - lib/open_food_network/group_buy_report.rb - lib/open_food_network/lettuce_share_report.rb - - lib/open_food_network/option_value_namer.rb - lib/open_food_network/order_and_distributor_report.rb - lib/open_food_network/order_cycle_form_applicator.rb - lib/open_food_network/order_cycle_management_report.rb @@ -671,40 +739,25 @@ Metrics/MethodLength: - lib/open_food_network/permissions.rb - lib/open_food_network/products_and_inventory_report.rb - lib/open_food_network/rack_request_blocker.rb - - lib/open_food_network/reports/bulk_coop_allocation_report.rb - - lib/open_food_network/reports/bulk_coop_supplier_report.rb - lib/open_food_network/reports/line_items.rb - lib/open_food_network/sales_tax_report.rb - lib/open_food_network/users_and_enterprises_report.rb - lib/open_food_network/xero_invoices_report.rb - lib/spree/api/controller_setup.rb - - lib/spree/core/controller_helpers/auth.rb + - lib/spree/core/calculated_adjustments.rb - lib/spree/core/controller_helpers/order.rb - lib/spree/core/controller_helpers/respond_with.rb - - lib/spree/core/controller_helpers/ssl.rb - - lib/spree/localized_number.rb - - lib/stripe/profile_storer.rb - - lib/tasks/data/truncate_data.rb - - lib/tasks/sample_data/group_factory.rb - - lib/tasks/sample_data/order_factory.rb - - lib/tasks/sample_data/product_factory.rb - - spec/features/consumer/shopping/checkout_paypal_spec.rb - - spec/features/consumer/shopping/variant_overrides_spec.rb - - spec/models/product_importer_spec.rb - - spec/support/request/authentication_helper.rb - - app/models/spree/order/checkout.rb - - app/models/spree/payment/processing.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_allocation_report.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_supplier_report.rb - - app/models/spree/credit_card.rb - - app/models/spree/payment_method.rb - - app/models/spree/zone.rb - - lib/spree/core/calculated_adjustments.rb - lib/spree/core/delegate_belongs_to.rb - lib/spree/core/permalinks.rb - lib/spree/core/s3_support.rb + - lib/spree/localized_number.rb - lib/spree/responder.rb + - lib/stripe/profile_storer.rb + - lib/tasks/sample_data/group_factory.rb + - lib/tasks/sample_data/order_factory.rb + - lib/tasks/sample_data/product_factory.rb + - spec/features/consumer/shopping/variant_overrides_spec.rb + - spec/models/product_importer_spec.rb - spec/support/i18n_translations_checker.rb Metrics/ClassLength: @@ -729,16 +782,19 @@ Metrics/ClassLength: - app/models/product_import/entry_processor.rb - app/models/product_import/entry_validator.rb - app/models/product_import/product_importer.rb - - app/models/spree/ability_decorator.rb + - app/models/spree/ability.rb + - app/models/spree/address.rb + - app/models/spree/credit_card.rb + - app/models/spree/payment.rb - app/models/spree/shipment.rb - app/models/spree/user.rb + - app/models/spree/zone.rb - app/serializers/api/cached_enterprise_serializer.rb - app/serializers/api/enterprise_shopfront_serializer.rb - app/services/cart_service.rb - - engines/order_management/app/services/order_management/order/updater.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - engines/order_management/app/services/order_management/reports/enterprise_fee_summary/scope.rb - lib/active_merchant/billing/gateways/stripe_payment_intents.rb - - lib/open_food_network/bulk_coop_report.rb - lib/open_food_network/enterprise_fee_calculator.rb - lib/open_food_network/order_cycle_form_applicator.rb - lib/open_food_network/order_cycle_management_report.rb @@ -748,10 +804,6 @@ Metrics/ClassLength: - lib/open_food_network/permissions.rb - lib/open_food_network/users_and_enterprises_report.rb - lib/open_food_network/xero_invoices_report.rb - - app/models/spree/payment.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - - app/models/spree/credit_card.rb - - app/models/spree/zone.rb Metrics/ModuleLength: Max: 100 @@ -760,6 +812,8 @@ Metrics/ModuleLength: - app/helpers/injection_helper.rb - app/helpers/spree/admin/base_helper.rb - app/helpers/spree/admin/navigation_helper.rb + - app/models/spree/order/checkout.rb + - app/models/spree/payment/processing.rb - engines/order_management/spec/services/order_management/order/updater_spec.rb - engines/order_management/spec/services/order_management/stock/package_spec.rb - engines/order_management/spec/services/order_management/subscriptions/estimator_spec.rb @@ -769,7 +823,6 @@ Metrics/ModuleLength: - engines/order_management/spec/services/order_management/subscriptions/validator_spec.rb - engines/order_management/spec/services/order_management/subscriptions/variants_list_spec.rb - lib/open_food_network/column_preference_defaults.rb - - spec/controllers/admin/enterprises_controller_spec.rb - spec/controllers/admin/order_cycles_controller_spec.rb - spec/controllers/api/order_cycles_controller_spec.rb - spec/controllers/api/orders_controller_spec.rb @@ -777,28 +830,24 @@ Metrics/ModuleLength: - spec/lib/open_food_network/address_finder_spec.rb - spec/lib/open_food_network/customers_report_spec.rb - spec/lib/open_food_network/enterprise_fee_calculator_spec.rb - - spec/lib/open_food_network/option_value_namer_spec.rb - spec/lib/open_food_network/order_cycle_form_applicator_spec.rb - spec/lib/open_food_network/order_cycle_permissions_spec.rb - spec/lib/open_food_network/order_grouper_spec.rb + - spec/lib/open_food_network/packing_report_spec.rb - spec/lib/open_food_network/permissions_spec.rb - spec/lib/open_food_network/products_and_inventory_report_spec.rb - spec/lib/open_food_network/scope_variant_to_hub_spec.rb - spec/lib/open_food_network/tag_rule_applicator_spec.rb - spec/lib/open_food_network/user_balance_calculator_spec.rb - spec/lib/open_food_network/users_and_enterprises_report_spec.rb - - spec/models/spree/ability_spec.rb - spec/models/spree/adjustment_spec.rb + - spec/models/spree/credit_card_spec.rb - spec/models/spree/line_item_spec.rb - - spec/models/spree/payment_spec.rb - spec/models/spree/product_spec.rb + - spec/models/spree/shipping_method_spec.rb - spec/models/spree/variant_spec.rb - spec/services/permissions/order_spec.rb - - spec/support/request/web_helper.rb - - app/models/spree/order/checkout.rb - - app/models/spree/payment/processing.rb - - spec/lib/open_food_network/packing_report_spec.rb - - spec/models/spree/credit_card_spec.rb + - spec/services/variant_units/option_value_namer_spec.rb Metrics/ParameterLists: Max: 5 @@ -807,8 +856,3 @@ Metrics/ParameterLists: - app/models/product_import/entry_processor.rb - lib/open_food_network/xero_invoices_report.rb - spec/features/admin/reports_spec.rb - -Lint/UselessAssignment: - Exclude: - - 'spec/**/*' - - 'lib/spree/core/controller_helpers/common.rb'