From 97d13597b058540f3381771bf589a218bd1df5ef Mon Sep 17 00:00:00 2001 From: David Cook Date: Thu, 4 Apr 2024 13:42:33 +1100 Subject: [PATCH] Fix intermittent bug Dunno why, but this recently started occuring for me in dev and test. Browser update? --- app/webpacker/controllers/popout_controller.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/webpacker/controllers/popout_controller.js b/app/webpacker/controllers/popout_controller.js index c3d66d744f..c62d7934dd 100644 --- a/app/webpacker/controllers/popout_controller.js +++ b/app/webpacker/controllers/popout_controller.js @@ -73,7 +73,9 @@ export default class PopoutController extends Controller { } closeIfOutside(e) { - if (!this.dialogTarget.contains(e.target)) { + // Note that we need to ignore the clicked button. Even though the listener was only just + // registered, it still fires sometimes for some unkown reason. + if (!this.dialogTarget.contains(e.target) && !this.buttonTarget.contains(e.target)) { this.close(); } }