From 9728b088f91d795e4012db0872530a4e61b5d1bc Mon Sep 17 00:00:00 2001
From: Luis Ramos <luisramos0@gmail.com>
Date: Wed, 9 Dec 2020 23:38:16 +0000
Subject: [PATCH] Fix syntax for nil properties

---
 spec/factories/address_factory.rb     | 2 +-
 spec/factories/line_item_factory.rb   | 2 +-
 spec/factories/order_cycle_factory.rb | 4 ++--
 spec/factories/order_factory.rb       | 2 +-
 spec/factories/product_factory.rb     | 4 ++--
 spec/factories/taxon_factory.rb       | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/spec/factories/address_factory.rb b/spec/factories/address_factory.rb
index b2f00e7059..3a2dadf090 100644
--- a/spec/factories/address_factory.rb
+++ b/spec/factories/address_factory.rb
@@ -25,7 +25,7 @@ FactoryBot.define do
       firstname { FFaker::Name.first_name }
       lastname { FFaker::Name.last_name }
       address1 { FFaker::Address.street_address }
-      address2 nil
+      address2 { nil }
       phone { FFaker::PhoneNumber.phone_number }
     end
   end
diff --git a/spec/factories/line_item_factory.rb b/spec/factories/line_item_factory.rb
index 27400f89eb..d67dcdf24b 100644
--- a/spec/factories/line_item_factory.rb
+++ b/spec/factories/line_item_factory.rb
@@ -11,7 +11,7 @@ FactoryBot.define do
   factory :line_item_with_shipment, parent: :line_item do
     transient do
       shipping_fee { 3 }
-      shipping_method nil
+      shipping_method { nil }
     end
 
     after(:build) do |line_item, evaluator|
diff --git a/spec/factories/order_cycle_factory.rb b/spec/factories/order_cycle_factory.rb
index 4360a83be0..a241672f6d 100644
--- a/spec/factories/order_cycle_factory.rb
+++ b/spec/factories/order_cycle_factory.rb
@@ -106,8 +106,8 @@ FactoryBot.define do
   end
 
   factory :undated_order_cycle, parent: :simple_order_cycle do
-    orders_open_at  nil
-    orders_close_at nil
+    orders_open_at { nil }
+    orders_close_at { nil }
   end
 
   factory :upcoming_order_cycle, parent: :simple_order_cycle do
diff --git a/spec/factories/order_factory.rb b/spec/factories/order_factory.rb
index c2447303a7..5c769df5a9 100644
--- a/spec/factories/order_factory.rb
+++ b/spec/factories/order_factory.rb
@@ -8,7 +8,7 @@ FactoryBot.define do
 
     user
     bill_address
-    completed_at nil
+    completed_at { nil }
     email { user.email }
 
     factory :order_with_totals do
diff --git a/spec/factories/product_factory.rb b/spec/factories/product_factory.rb
index 37ef46e5a8..3ea1f39da0 100644
--- a/spec/factories/product_factory.rb
+++ b/spec/factories/product_factory.rb
@@ -8,7 +8,7 @@ FactoryBot.define do
     cost_price { 17.00 }
     sku { 'ABC' }
     available_on { 1.year.ago }
-    deleted_at nil
+    deleted_at { nil }
 
     supplier { Enterprise.is_primary_producer.first || FactoryBot.create(:supplier_enterprise) }
     primary_taxon { Spree::Taxon.first || FactoryBot.create(:taxon) }
@@ -69,7 +69,7 @@ FactoryBot.define do
     transient do
       tax_rate_amount { 0 }
       tax_rate_name { "" }
-      zone nil
+      zone { nil }
     end
 
     tax_category { create(:tax_category) }
diff --git a/spec/factories/taxon_factory.rb b/spec/factories/taxon_factory.rb
index bc767b111d..fa8bae12d3 100644
--- a/spec/factories/taxon_factory.rb
+++ b/spec/factories/taxon_factory.rb
@@ -4,6 +4,6 @@ FactoryBot.define do
   factory :taxon, class: Spree::Taxon do
     name { 'Ruby on Rails' }
     taxonomy
-    parent_id nil
+    parent_id { nil }
   end
 end