From 95ae18a1ba17f5966c968d000e75d23ab3cc9bf2 Mon Sep 17 00:00:00 2001
From: Pau Perez <saulopefa@gmail.com>
Date: Tue, 25 Sep 2018 20:57:36 +0200
Subject: [PATCH] Remove method delegation

---
 app/models/product_import/entry_processor.rb      |  5 ++---
 .../models/product_import/entry_processor_spec.rb | 15 ---------------
 2 files changed, 2 insertions(+), 18 deletions(-)

diff --git a/app/models/product_import/entry_processor.rb b/app/models/product_import/entry_processor.rb
index 5bdb0f6b4d..e770e16931 100644
--- a/app/models/product_import/entry_processor.rb
+++ b/app/models/product_import/entry_processor.rb
@@ -5,7 +5,6 @@
 module ProductImport
   class EntryProcessor
     delegate :products_reset_count, to: :reset_absent
-    delegate :importing_into_inventory?, to: :settings
 
     attr_reader :inventory_created, :inventory_updated, :products_created, :variants_created, :variants_updated, :supplier_products, :total_supplier_products, :import_settings
 
@@ -47,7 +46,7 @@ module ProductImport
         next unless supplier_id && permission_by_id?(supplier_id)
 
         products_count =
-          if importing_into_inventory?
+          if settings.importing_into_inventory?
             VariantOverride.where('variant_overrides.hub_id IN (?)', supplier_id).count
           else
             Spree::Variant.
@@ -78,7 +77,7 @@ module ProductImport
     end
 
     def strategy_factory
-      if importing_into_inventory?
+      if settings.importing_into_inventory?
         InventoryReset
       else
         ProductsReset
diff --git a/spec/models/product_import/entry_processor_spec.rb b/spec/models/product_import/entry_processor_spec.rb
index af6dbd4b17..b062b6e90a 100644
--- a/spec/models/product_import/entry_processor_spec.rb
+++ b/spec/models/product_import/entry_processor_spec.rb
@@ -99,19 +99,4 @@ describe ProductImport::EntryProcessor do
       expect(reset_absent).to have_received(:products_reset_count)
     end
   end
-
-  describe '#importing_into_inventory?' do
-    let(:settings) do
-      instance_double(ProductImport::Settings, importing_into_inventory?: true)
-    end
-
-    before do
-      allow(ProductImport::Settings).to receive(:new) { settings }
-    end
-
-    it 'delegates to Settings' do
-      entry_processor.importing_into_inventory?
-      expect(settings).to have_received(:importing_into_inventory?)
-    end
-  end
 end