From 2aade10aafa5bb11184bd556b17d7d694b3687c2 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Fri, 2 Sep 2022 16:07:25 +1000 Subject: [PATCH 1/3] Load storybook only in development The gem is not available in other environments an the app fails to boot. --- config/application.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/application.rb b/config/application.rb index e92fae3a11..0d4db42428 100644 --- a/config/application.rb +++ b/config/application.rb @@ -21,7 +21,7 @@ require "rails" end require "view_component" -require "view_component/storybook" +require "view_component/storybook" if Rails.env.development? require_relative "../lib/open_food_network/i18n_config" require_relative '../lib/spree/core/environment' From 7089bd597e0a8129231e968a6b7b992d7f8ab8b3 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Fri, 2 Sep 2022 16:08:09 +1000 Subject: [PATCH 2/3] Avoid loading view_component engine manually We load view_component in the application config and it should be automatic anyway. --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index e626686778..5e84b5cb31 100644 --- a/Gemfile +++ b/Gemfile @@ -131,7 +131,7 @@ gem 'flipper' gem 'flipper-active_record' gem 'flipper-ui' -gem "view_component", require: "view_component/engine" +gem "view_component" group :production, :staging do gem 'ddtrace' From 728eee6d3fdec16391ae1e180ff8e6e16aa2d1ab Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Fri, 2 Sep 2022 16:10:19 +1000 Subject: [PATCH 3/3] Load storybook after view_component has been loaded automatically --- config/application.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/config/application.rb b/config/application.rb index 0d4db42428..392f8a142c 100644 --- a/config/application.rb +++ b/config/application.rb @@ -20,9 +20,6 @@ require "rails" end end -require "view_component" -require "view_component/storybook" if Rails.env.development? - require_relative "../lib/open_food_network/i18n_config" require_relative '../lib/spree/core/environment' require_relative '../lib/spree/core/mail_interceptor' @@ -35,6 +32,8 @@ if defined?(Bundler) # Bundler.require(:default, :assets, Rails.env) end +require "view_component/storybook" if Rails.env.development? + module Openfoodnetwork class Application < Rails::Application config.middleware.insert_before(