diff --git a/app/assets/javascripts/admin/spree/orders/shipments.js.erb b/app/assets/javascripts/admin/spree/orders/shipments.js.erb index cf3d4d6803..75fcdcb93a 100644 --- a/app/assets/javascripts/admin/spree/orders/shipments.js.erb +++ b/app/assets/javascripts/admin/spree/orders/shipments.js.erb @@ -25,13 +25,12 @@ $(document).ready(function() { var link = $(this); var shipment_number = link.data('shipment-number'); var selected_shipping_rate_id = link.parents('tbody').find("select#selected_shipping_rate_id[data-shipment-number='" + shipment_number + "']").val(); - var unlock = link.parents('tbody').find("input[name='open_adjustment'][data-shipment-number='" + shipment_number + "']:checked").val(); var url = Spree.url( Spree.routes.orders_api + "/" + order_number + "/shipments/" + shipment_number + ".json"); $.ajax({ type: "PUT", url: url, - data: { shipment: { selected_shipping_rate_id: selected_shipping_rate_id, unlock: unlock } } + data: { shipment: { selected_shipping_rate_id: selected_shipping_rate_id } } }).done(function( msg ) { window.location.reload(); }).error(function( msg ) { diff --git a/app/controllers/api/v0/shipments_controller.rb b/app/controllers/api/v0/shipments_controller.rb index af59069627..0905abe954 100644 --- a/app/controllers/api/v0/shipments_controller.rb +++ b/app/controllers/api/v0/shipments_controller.rb @@ -28,19 +28,14 @@ module Api authorize! :read, Spree::Shipment @shipment = @order.shipments.find_by!(number: params[:id]) params[:shipment] ||= [] - unlock = params[:shipment].delete(:unlock) - if unlock == 'yes' - @shipment.fee_adjustment.fire_events(:open) - end + @shipment.fee_adjustment.fire_events(:open) if @shipment.update(shipment_params) @order.updater.update_totals_and_states end - if unlock == 'yes' - @shipment.fee_adjustment.close - end + @shipment.fee_adjustment.close render json: @shipment.reload, serializer: Api::ShipmentSerializer, status: :ok end diff --git a/spec/views/spree/admin/orders/edit.html.haml_spec.rb b/spec/views/spree/admin/orders/edit.html.haml_spec.rb index 267ab455eb..c1417cf7b2 100644 --- a/spec/views/spree/admin/orders/edit.html.haml_spec.rb +++ b/spec/views/spree/admin/orders/edit.html.haml_spec.rb @@ -62,7 +62,7 @@ describe "spree/admin/orders/edit.html.haml" do it "doesn't display closed associated adjustments" do render - + expect(rendered).to_not have_content "Associated adjustment closed" end end @@ -102,7 +102,7 @@ describe "spree/admin/orders/edit.html.haml" do it "doesn't display closed associated adjustments" do render - + expect(rendered).to_not have_content "Associated adjustment closed" end end