From 6dcc50ad151f4c3831e7897624032df8f235208c Mon Sep 17 00:00:00 2001
From: jibees <jb.bellet@gmail.com>
Date: Tue, 15 Nov 2022 10:40:22 +0100
Subject: [PATCH] Revert "Cache address JSON to avoid database queries"

---
 app/serializers/api/address_serializer.rb     |  4 +-
 .../api/address_serializer_spec.rb            | 40 -------------------
 2 files changed, 2 insertions(+), 42 deletions(-)
 delete mode 100644 spec/serializers/api/address_serializer_spec.rb

diff --git a/app/serializers/api/address_serializer.rb b/app/serializers/api/address_serializer.rb
index 4c1c3e6c3f..6edbc6adc9 100644
--- a/app/serializers/api/address_serializer.rb
+++ b/app/serializers/api/address_serializer.rb
@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
 class Api::AddressSerializer < ActiveModel::Serializer
-  cached
-  delegate :cache_key, to: :object
+  # cached
+  # delegate :cache_key, to: :object
 
   attributes :id, :zipcode, :city, :state_name, :state_id,
              :phone, :firstname, :lastname, :address1, :address2, :city, :country_id,
diff --git a/spec/serializers/api/address_serializer_spec.rb b/spec/serializers/api/address_serializer_spec.rb
deleted file mode 100644
index 9ebbfcd2d7..0000000000
--- a/spec/serializers/api/address_serializer_spec.rb
+++ /dev/null
@@ -1,40 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-describe Api::AddressSerializer do
-  subject(:serializer) { described_class.new(address) }
-  let(:address) { build(:address) }
-
-  describe "#country_name" do
-    it "provides the country's name" do
-      address.country.name = "Australia"
-      expect(serializer.country_name).to eq "Australia"
-    end
-  end
-
-  describe "#state_name" do
-    it "provides the state's abbreviation" do
-      address.state.abbr = "Vic"
-      expect(serializer.state_name).to eq "Vic"
-    end
-  end
-
-  describe "caching" do
-    it "updates with the record" do
-      expect {
-        address.update!(first_name: "Nick")
-      }.to change {
-        serializer.to_json
-      }
-    end
-
-    it "uses stored result when database wasn't changed" do
-      expect {
-        address.first_name = "Nick"
-      }.to_not change {
-        serializer.to_json
-      }
-    end
-  end
-end