From 448c0e0ce3a455fac03cd51d8e51700ea343e9cd Mon Sep 17 00:00:00 2001 From: Andy Brett Date: Sat, 27 Feb 2021 15:05:11 -0800 Subject: [PATCH] Remove duplicate specs The second of these is flaky; moreover, the OrdersController doesn't specifically have a method that they're testing. I think the ready_to_capture behaviors is adequately covered by https://github.com/openfoodfoundation/openfoodnetwork/blob/006236b8ddb90010826d7b56dc907c18f397244a/spec/serializers/api/admin/order_serializer_spec.rb#L39-L68 --- .../controllers/api/orders_controller_spec.rb | 41 ------------------- 1 file changed, 41 deletions(-) diff --git a/spec/controllers/api/orders_controller_spec.rb b/spec/controllers/api/orders_controller_spec.rb index 0b8f4b2d30..6b182578cd 100644 --- a/spec/controllers/api/orders_controller_spec.rb +++ b/spec/controllers/api/orders_controller_spec.rb @@ -157,47 +157,6 @@ module Api expect(json_response['pagination']).to eq pagination_data end end - - context "when there is a pending payment requiring authorization" do - let!(:pending_payment) do - create( - :payment, - order: order1, - state: 'pending', - amount: 123.45, - cvv_response_message: "https://stripe.com/redirect" - ) - end - - before do - allow(controller).to receive(:spree_current_user) { distributor.owner } - end - - it "returns false" do - get :index - expect(json_response['orders'].first['ready_to_capture']).to eq(false) - end - end - - context "when there is a pending payment but it does not require authorization" do - let!(:pending_payment) do - create( - :payment, - order: order1, - state: 'pending', - amount: 123.45, - ) - end - - before do - allow(controller).to receive(:spree_current_user) { distributor.owner } - end - - it "returns true" do - get :index - expect(json_response['orders'].first['ready_to_capture']).to eq(true) - end - end end describe "#show" do