From 926f196b96c2b010d0bfd5f550f5769795e448f9 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Fri, 25 Aug 2017 14:33:21 +1000 Subject: [PATCH] Re-generate rubocop_todo --- .rubocop_todo.yml | 115 ++++++++++++++++++++++------------------------ 1 file changed, 54 insertions(+), 61 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index dd05d120e6..136580b472 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 100` -# on 2017-07-12 10:36:44 +0200 using RuboCop version 0.49.1. +# on 2017-08-25 14:27:48 +1000 using RuboCop version 0.49.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -14,7 +14,7 @@ Bundler/OrderedGems: Exclude: - 'Gemfile' -# Offense count: 77 +# Offense count: 128 # Cop supports --auto-correct. Layout/AlignArray: Exclude: @@ -59,7 +59,7 @@ Layout/AlignHash: - 'spec/models/spree/shipping_method_spec.rb' - 'spec/models/spree/variant_spec.rb' -# Offense count: 42 +# Offense count: 43 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # SupportedStyles: with_first_parameter, with_fixed_indentation @@ -113,11 +113,12 @@ Layout/CaseIndentation: - 'app/models/enterprise.rb' - 'app/models/product_importer.rb' -# Offense count: 2 +# Offense count: 3 # Cop supports --auto-correct. Layout/ClosingParenthesisIndentation: Exclude: - 'app/overrides/add_capture_order_shortcut.rb' + - 'spec/serializers/variant_serializer_spec.rb' # Offense count: 8 # Cop supports --auto-correct. @@ -137,7 +138,7 @@ Layout/ElseAlignment: - 'app/serializers/api/admin/order_cycle_serializer.rb' - 'lib/open_food_network/sales_tax_report.rb' -# Offense count: 223 +# Offense count: 215 # Cop supports --auto-correct. Layout/EmptyLines: Enabled: false @@ -152,7 +153,7 @@ Layout/EmptyLinesAroundAccessModifier: - 'spec/helpers/products_helper_spec.rb' - 'spec/support/request/web_helper.rb' -# Offense count: 73 +# Offense count: 70 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: empty_lines, no_empty_lines @@ -170,7 +171,6 @@ Layout/EmptyLinesAroundBlockBody: - 'app/models/spree/calculator_decorator.rb' - 'app/models/spree/money_decorator.rb' - 'app/models/spree/option_value_decorator.rb' - - 'app/models/spree/payment_decorator.rb' - 'lib/open_food_network/group_buy_report.rb' - 'lib/spree/money_decorator.rb' - 'lib/tasks/dev.rake' @@ -188,10 +188,10 @@ Layout/EmptyLinesAroundBlockBody: - 'spec/features/admin/orders_spec.rb' - 'spec/features/admin/reports_spec.rb' - 'spec/features/admin/variant_overrides_spec.rb' + - 'spec/features/consumer/shopping/embedded_shopfronts_spec.rb' - 'spec/features/consumer/shopping/shopping_spec.rb' - 'spec/features/consumer/shopping/variant_overrides_spec.rb' - 'spec/helpers/admin/business_model_configuration_helper_spec.rb' - - 'spec/helpers/injection_helper_spec.rb' - 'spec/helpers/shared_helper_spec.rb' - 'spec/helpers/shop_helper_spec.rb' - 'spec/helpers/spree/orders_helper_spec.rb' @@ -212,8 +212,7 @@ Layout/EmptyLinesAroundBlockBody: - 'spec/models/tag_rule/filter_shipping_methods_spec.rb' - 'spec/serializers/admin/for_order_cycle/enterprise_serializer_spec.rb' - 'spec/serializers/admin/for_order_cycle/supplied_product_serializer_spec.rb' - - 'spec/serializers/order_serializer_spec.rb' - - 'spec/serializers/orders_by_distributor_serializer_spec.rb' + - 'spec/serializers/variant_serializer_spec.rb' - 'spec/support/matchers/delegate_matchers.rb' - 'spec/support/matchers/select2_matchers.rb' - 'spec/support/matchers/table_matchers.rb' @@ -270,7 +269,7 @@ Layout/EmptyLinesAroundMethodBody: - 'app/serializers/api/product_serializer.rb' - 'lib/open_food_network/orders_and_fulfillments_report.rb' -# Offense count: 13 +# Offense count: 12 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines @@ -278,7 +277,6 @@ Layout/EmptyLinesAroundModuleBody: Exclude: - 'app/helpers/add_to_cart_helper.rb' - 'app/helpers/groups_helper.rb' - - 'app/helpers/injection_helper.rb' - 'app/helpers/spree/admin/base_helper_decorator.rb' - 'lib/open_food_network/column_preference_defaults.rb' - 'lib/open_food_network/group_buy_report.rb' @@ -289,7 +287,7 @@ Layout/EmptyLinesAroundModuleBody: - 'spec/support/request/distribution_helper.rb' - 'spec/support/request/ui_component_helper.rb' -# Offense count: 54 +# Offense count: 55 # Cop supports --auto-correct. # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. Layout/ExtraSpacing: @@ -326,29 +324,28 @@ Layout/ExtraSpacing: - 'spec/models/enterprise_spec.rb' - 'spec/models/order_cycle_spec.rb' - 'spec/models/spree/adjustment_spec.rb' + - 'spec/models/spree/gateway/stripe_connect_spec.rb' - 'spec/models/spree/order_spec.rb' - 'spec/models/variant_override_spec.rb' - 'spec/serializers/admin/for_order_cycle/enterprise_serializer_spec.rb' - 'spec/serializers/admin/for_order_cycle/supplied_product_serializer_spec.rb' - 'spec/support/request/web_helper.rb' -# Offense count: 1 +# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # SupportedStyles: consistent, special_for_inner_method_call, special_for_inner_method_call_in_parentheses Layout/FirstParameterIndentation: Exclude: - 'lib/open_food_network/permissions.rb' + - 'spec/serializers/variant_serializer_spec.rb' -# Offense count: 6 +# Offense count: 4 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. +# Configuration parameters: SupportedStyles, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_brackets Layout/IndentArray: - Exclude: - - 'lib/open_food_network/users_and_enterprises_report.rb' - - 'spec/features/admin/reports_spec.rb' - - 'spec/lib/open_food_network/products_and_inventory_report_spec.rb' + EnforcedStyle: consistent # Offense count: 2 # Cop supports --auto-correct. @@ -403,7 +400,7 @@ Layout/IndentationConsistency: - 'spec/models/spree/line_item_spec.rb' - 'spec/models/spree/product_spec.rb' -# Offense count: 20 +# Offense count: 18 # Cop supports --auto-correct. # Configuration parameters: Width, IgnoredPatterns. Layout/IndentationWidth: @@ -411,13 +408,11 @@ Layout/IndentationWidth: - 'app/controllers/admin/invoice_settings_controller.rb' - 'app/controllers/admin/order_cycles_controller.rb' - 'app/controllers/api/order_cycles_controller.rb' - - 'app/controllers/spree/admin/reports_controller_decorator.rb' - 'app/models/spree/line_item_decorator.rb' - 'app/serializers/api/admin/for_order_cycle/enterprise_serializer.rb' - 'app/serializers/api/admin/for_order_cycle/supplied_product_serializer.rb' - 'app/serializers/api/admin/order_cycle_serializer.rb' - 'lib/discourse/single_sign_on.rb' - - 'lib/open_food_network/last_used_address.rb' - 'spec/features/consumer/shopping/variant_overrides_spec.rb' - 'spec/helpers/admin/business_model_configuration_helper_spec.rb' - 'spec/helpers/groups_helper_spec.rb' @@ -525,7 +520,15 @@ Layout/MultilineMethodCallBraceLayout: - 'lib/open_food_network/products_renderer.rb' - 'spec/lib/open_food_network/products_and_inventory_report_spec.rb' -# Offense count: 34 +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. +# SupportedStyles: aligned, indented, indented_relative_to_receiver +Layout/MultilineMethodCallIndentation: + Exclude: + - 'spec/serializers/variant_serializer_spec.rb' + +# Offense count: 33 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # SupportedStyles: aligned, indented @@ -538,7 +541,6 @@ Layout/MultilineOperationIndentation: - 'app/models/producer_property.rb' - 'app/models/product_importer.rb' - 'app/models/spree/ability_decorator.rb' - - 'app/models/spree/order_decorator.rb' - 'app/models/spree/product_set.rb' - 'app/models/variant_override_set.rb' - 'lib/open_food_network/accounts_and_billing_settings_validator.rb' @@ -558,20 +560,18 @@ Layout/SpaceAfterColon: - 'spec/models/variant_override_spec.rb' - 'spec/spec_helper.rb' -# Offense count: 58 +# Offense count: 53 # Cop supports --auto-correct. Layout/SpaceAfterComma: Exclude: - 'app/controllers/admin/order_cycles_controller.rb' - 'app/controllers/spree/admin/products_controller_decorator.rb' - - 'app/controllers/spree/admin/reports_controller_decorator.rb' - 'app/controllers/spree/orders_controller_decorator.rb' - 'app/models/column_preference.rb' - 'app/models/product_importer.rb' - 'lib/discourse/single_sign_on.rb' - 'lib/open_food_network/accounts_and_billing_settings_validator.rb' - 'lib/open_food_network/business_model_configuration_validator.rb' - - 'lib/open_food_network/order_and_distributor_report.rb' - 'lib/open_food_network/order_cycle_form_applicator.rb' - 'lib/open_food_network/users_and_enterprises_report.rb' - 'spec/controllers/admin/enterprises_controller_spec.rb' @@ -648,7 +648,7 @@ Layout/SpaceAroundEqualsInParameterDefault: - 'spec/support/request/distribution_helper.rb' - 'spec/support/request/web_helper.rb' -# Offense count: 58 +# Offense count: 60 # Cop supports --auto-correct. # Configuration parameters: AllowForAlignment. Layout/SpaceAroundOperators: @@ -677,6 +677,7 @@ Layout/SpaceAroundOperators: - 'spec/helpers/order_cycles_helper_spec.rb' - 'spec/jobs/update_billable_periods_spec.rb' - 'spec/lib/open_food_network/order_grouper_spec.rb' + - 'spec/lib/stripe/account_connector_spec.rb' - 'spec/models/calculator/weight_spec.rb' - 'spec/support/cancan_helper.rb' - 'spec/support/seeds.rb' @@ -715,7 +716,7 @@ Layout/SpaceInLambdaLiteral: - 'app/models/spree/product_decorator.rb' - 'app/models/spree/variant_decorator.rb' -# Offense count: 194 +# Offense count: 187 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces, SpaceBeforeBlockParameters. # SupportedStyles: space, no_space @@ -765,11 +766,9 @@ Layout/SpaceInsideBlockBraces: - 'spec/models/spree/order_spec.rb' - 'spec/models/spree/payment_spec.rb' - 'spec/models/spree/product_spec.rb' - - 'spec/models/spree/user_spec.rb' - 'spec/models/tag_rule/discount_order_spec.rb' - 'spec/serializers/admin/for_order_cycle/enterprise_serializer_spec.rb' - 'spec/serializers/admin/for_order_cycle/supplied_product_serializer_spec.rb' - - 'spec/serializers/orders_by_distributor_serializer_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/cancan_helper.rb' @@ -796,7 +795,7 @@ Layout/SpaceInsideBrackets: - 'spec/lib/open_food_network/users_and_enterprises_report_spec.rb' - 'spec/performance/orders_controller_spec.rb' -# Offense count: 729 +# Offense count: 766 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces. # SupportedStyles: space, no_space, compact @@ -823,12 +822,11 @@ Layout/Tab: - 'spec/lib/spree/product_filters_spec.rb' - 'spec/models/spree/line_item_spec.rb' -# Offense count: 32 +# Offense count: 42 # Cop supports --auto-correct. Layout/TrailingWhitespace: Exclude: - 'app/models/distributor_shipping_method.rb' - - 'app/models/product_importer.rb' - 'app/models/spree/money_decorator.rb' - 'app/serializers/api/image_serializer.rb' - 'app/serializers/api/shipping_method_serializer.rb' @@ -836,7 +834,6 @@ Layout/TrailingWhitespace: - 'app/views/json/_enterprises.rabl' - 'app/views/json/_producer.rabl' - 'app/views/json/partials/_producer.rabl' - - 'lib/open_food_network/group_buy_report.rb' - 'lib/tasks/dev.rake' - 'spec/controllers/spree/store_controller_spec.rb' - 'spec/features/admin/enterprise_user_spec.rb' @@ -844,17 +841,16 @@ Layout/TrailingWhitespace: - 'spec/lib/open_food_network/option_value_namer_spec.rb' - 'spec/lib/open_food_network/order_grouper_spec.rb' - 'spec/serializers/admin/enterprise_serializer_spec.rb' + - 'spec/serializers/variant_serializer_spec.rb' - 'spec/support/request/menu_helper.rb' - 'spec/views/json/producers.json.rabl_spec.rb' -# Offense count: 8 +# Offense count: 6 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyleAlignWith, SupportedStylesAlignWith. # SupportedStylesAlignWith: either, start_of_block, start_of_line Lint/BlockAlignment: Exclude: - - 'app/controllers/spree/admin/reports_controller_decorator.rb' - - 'lib/open_food_network/last_used_address.rb' - 'spec/lib/open_food_network/enterprise_fee_calculator_spec.rb' - 'spec/models/enterprise_spec.rb' - 'spec/models/spree/calculator/flat_percent_item_total_spec.rb' @@ -1011,7 +1007,7 @@ Lint/UselessAccessModifier: - 'lib/open_food_network/reports/bulk_coop_report.rb' - 'spec/lib/open_food_network/reports/report_spec.rb' -# Offense count: 340 +# Offense count: 341 Lint/Void: Exclude: - 'app/serializers/api/enterprise_serializer.rb' @@ -1080,7 +1076,7 @@ Lint/Void: - 'spec/serializers/enterprise_serializer_spec.rb' - 'spec/support/request/web_helper.rb' -# Offense count: 706 +# Offense count: 747 # Configuration parameters: CountComments, ExcludedMethods. Metrics/BlockLength: Max: 711 @@ -1165,7 +1161,7 @@ Rails/Delegate: - 'app/serializers/api/admin/tag_rule_serializer.rb' - 'app/serializers/api/variant_serializer.rb' -# Offense count: 6 +# Offense count: 7 Rails/FilePath: Exclude: - 'lib/tasks/karma.rake' @@ -1203,7 +1199,7 @@ Rails/HasAndBelongsToMany: - 'app/models/spree/line_item_decorator.rb' - 'app/models/spree/payment_method_decorator.rb' -# Offense count: 11 +# Offense count: 10 Rails/OutputSafety: Exclude: - 'app/controllers/spree/admin/reports_controller_decorator.rb' @@ -1211,7 +1207,6 @@ Rails/OutputSafety: - 'app/helpers/spree/reports_helper.rb' - 'app/serializers/api/product_serializer.rb' - 'lib/spree/money_decorator.rb' - - 'lib/tasks/karma.rake' # Offense count: 6 # Cop supports --auto-correct. @@ -1302,15 +1297,16 @@ Rails/Validation: - 'app/models/spree/variant_decorator.rb' - 'app/models/variant_override.rb' -# Offense count: 6 +# Offense count: 7 Style/AccessorMethodName: Exclude: - 'app/models/product_importer.rb' - 'app/models/spree/adjustment_decorator.rb' - 'app/models/spree/order_decorator.rb' - 'spec/support/request/shop_workflow.rb' + - 'spec/support/request/web_helper.rb' -# Offense count: 35 +# Offense count: 34 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: always, conditionals @@ -1326,7 +1322,6 @@ Style/AndOr: - 'app/models/product_importer.rb' - 'app/models/spreadsheet_entry.rb' - 'app/models/spree/adjustment_decorator.rb' - - 'app/models/spree/order_decorator.rb' - 'app/models/spree/product_set.rb' - 'app/views/json/partials/_enterprise.rabl' - 'lib/spree/core/controller_helpers/respond_with_decorator.rb' @@ -1340,7 +1335,7 @@ Style/BarePercentLiterals: - 'spec/features/admin/variants_spec.rb' - 'spec/support/request/web_helper.rb' -# Offense count: 209 +# Offense count: 208 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: braces, no_braces, context_dependent @@ -1410,7 +1405,6 @@ Style/BracesAroundHashParameters: - 'spec/models/spree/product_spec.rb' - 'spec/models/spree/taxon_spec.rb' - 'spec/serializers/admin/customer_serializer_spec.rb' - - 'spec/serializers/orders_by_distributor_serializer_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/cancan_helper.rb' - 'spec/support/request/authentication_workflow.rb' @@ -1422,7 +1416,7 @@ Style/CaseEquality: - 'app/helpers/angular_form_helper.rb' - 'spec/models/spree/payment_spec.rb' -# Offense count: 86 +# Offense count: 88 # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: nested, compact Style/ClassAndModuleChildren: @@ -1468,7 +1462,9 @@ Style/ClassAndModuleChildren: - 'app/serializers/api/admin/line_item_serializer.rb' - 'app/serializers/api/admin/order_cycle_serializer.rb' - 'app/serializers/api/admin/order_serializer.rb' - - 'app/serializers/api/admin/payment_method_serializer.rb' + - 'app/serializers/api/admin/payment_method/base_serializer.rb' + - 'app/serializers/api/admin/payment_method/payment_method_serializer.rb' + - 'app/serializers/api/admin/payment_method/stripe_serializer.rb' - 'app/serializers/api/admin/product_serializer.rb' - 'app/serializers/api/admin/shipping_method_serializer.rb' - 'app/serializers/api/admin/tag_rule_serializer.rb' @@ -1601,7 +1597,7 @@ Style/FileName: Style/FormatStringToken: EnforcedStyle: template -# Offense count: 88 +# Offense count: 89 # Configuration parameters: MinBodyLength. Style/GuardClause: Exclude: @@ -1655,7 +1651,7 @@ Style/GuardClause: - 'spec/support/request/distribution_helper.rb' - 'spec/support/request/shop_workflow.rb' -# Offense count: 1241 +# Offense count: 1255 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys @@ -1685,11 +1681,10 @@ Style/InverseMethods: - 'app/controllers/admin/column_preferences_controller.rb' - 'spec/support/cancan_helper.rb' -# Offense count: 9 +# Offense count: 5 # Cop supports --auto-correct. Style/LineEndConcatenation: Exclude: - - 'app/controllers/spree/admin/base_controller_decorator.rb' - 'lib/spree/core/controller_helpers/respond_with_decorator.rb' - 'spec/controllers/spree/admin/base_controller_spec.rb' @@ -1736,11 +1731,10 @@ Style/MultilineIfModifier: - 'lib/open_food_network/enterprise_issue_validator.rb' - 'lib/spree/core/controller_helpers/respond_with_decorator.rb' -# Offense count: 8 +# Offense count: 7 # Cop supports --auto-correct. Style/MutableConstant: Exclude: - - 'app/controllers/spree/admin/reports_controller_decorator.rb' - 'app/models/enterprise.rb' - 'app/models/enterprise_fee.rb' - 'app/models/spree/payment_method_decorator.rb' @@ -1798,7 +1792,7 @@ Style/NumericLiteralPrefix: Exclude: - 'spec/features/admin/order_cycles_spec.rb' -# Offense count: 16 +# Offense count: 15 # Cop supports --auto-correct. # Configuration parameters: Strict. Style/NumericLiterals: @@ -2025,7 +2019,7 @@ Style/StructInheritance: Exclude: - 'lib/open_food_network/enterprise_fee_applicator.rb' -# Offense count: 182 +# Offense count: 183 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, MinSize, SupportedStyles. # SupportedStyles: percent, brackets @@ -2069,7 +2063,7 @@ Style/SymbolArray: - 'spec/models/exchange_spec.rb' - 'spec/models/spree/ability_spec.rb' -# Offense count: 97 +# Offense count: 96 # Cop supports --auto-correct. # Configuration parameters: IgnoredMethods. # IgnoredMethods: respond_to, define_method @@ -2101,7 +2095,6 @@ Style/SymbolProc: - 'spec/features/admin/order_cycles_spec.rb' - 'spec/lib/open_food_network/group_buy_report_spec.rb' - 'spec/lib/open_food_network/order_grouper_spec.rb' - - 'spec/models/spree/user_spec.rb' # Offense count: 6 # Cop supports --auto-correct.