From e7c301da83ecbca91506b263e018c3025d991ad7 Mon Sep 17 00:00:00 2001
From: Will Marshall <will@willmarshall.me>
Date: Wed, 18 Jun 2014 13:05:44 +1000
Subject: [PATCH 1/7] Reworking the RABL templates for simplicity AND fixing up
 all the tests

---
 .../{hub.js.coffee => current_hub.js.coffee}  |  0
 .../darkswarm/services/enterprises.js.coffee  |  5 ++
 .../darkswarm/services/hubs.js.coffee         |  2 +-
 .../darkswarm/services/producers.js.coffee    |  7 --
 app/views/json/_enterprises.rabl              | 21 ++----
 app/views/json/_hubs.rabl                     | 26 +------
 app/views/json/_producers.rabl                | 22 +-----
 .../_enterprise.rabl}                         | 28 ++++----
 app/views/json/partials/_hub.rabl             | 21 ++++++
 app/views/json/partials/_producer.rabl        |  9 +++
 app/views/layouts/darkswarm.html.haml         |  1 +
 spec/javascripts/application_spec.js          |  3 +
 spec/javascripts/mock_google_maps.js.coffee   | 68 +++++++++++++++++++
 .../accordion_controller_spec.js.coffee       |  5 ++
 .../darkswarm/services/order_spec.js.coffee   | 15 +++-
 15 files changed, 146 insertions(+), 87 deletions(-)
 rename app/assets/javascripts/darkswarm/services/{hub.js.coffee => current_hub.js.coffee} (100%)
 create mode 100644 app/assets/javascripts/darkswarm/services/enterprises.js.coffee
 rename app/views/json/{_enterprises_for_map.rabl => partials/_enterprise.rabl} (51%)
 create mode 100644 app/views/json/partials/_hub.rabl
 create mode 100644 app/views/json/partials/_producer.rabl
 create mode 100644 spec/javascripts/mock_google_maps.js.coffee

diff --git a/app/assets/javascripts/darkswarm/services/hub.js.coffee b/app/assets/javascripts/darkswarm/services/current_hub.js.coffee
similarity index 100%
rename from app/assets/javascripts/darkswarm/services/hub.js.coffee
rename to app/assets/javascripts/darkswarm/services/current_hub.js.coffee
diff --git a/app/assets/javascripts/darkswarm/services/enterprises.js.coffee b/app/assets/javascripts/darkswarm/services/enterprises.js.coffee
new file mode 100644
index 0000000000..b967bdd18c
--- /dev/null
+++ b/app/assets/javascripts/darkswarm/services/enterprises.js.coffee
@@ -0,0 +1,5 @@
+Darkswarm.factory 'Enterprises', (enterprises)->
+  new class Enterprises
+    constructor: ->
+      @enterprises = enterprises
+      @dereference()
diff --git a/app/assets/javascripts/darkswarm/services/hubs.js.coffee b/app/assets/javascripts/darkswarm/services/hubs.js.coffee
index a3f2b03f23..275ce45cec 100644
--- a/app/assets/javascripts/darkswarm/services/hubs.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/hubs.js.coffee
@@ -1,4 +1,4 @@
-Darkswarm.factory 'Hubs', ($location, hubs, $filter, CurrentHub) ->
+Darkswarm.factory 'Hubs', (hubs, $filter) ->
   new class Hubs
     constructor: ->
       @hubs = $filter('orderBy')(hubs, ['-active', '+orders_close_at'])
diff --git a/app/assets/javascripts/darkswarm/services/producers.js.coffee b/app/assets/javascripts/darkswarm/services/producers.js.coffee
index 6c393660de..65e33599af 100644
--- a/app/assets/javascripts/darkswarm/services/producers.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/producers.js.coffee
@@ -2,11 +2,4 @@ Darkswarm.factory 'Producers', (producers) ->
   new class Producers
     constructor: ->
       @producers = producers
-      
-      # TODO: start adding functionality to producers like so
-      #@producers = (@extend(producer) for producer in producers)
 
-    #extend: (producer)->
-      #new class Producer
-        #constructor: ->
-          #@[k] = v for k, v of Producer
diff --git a/app/views/json/_enterprises.rabl b/app/views/json/_enterprises.rabl
index 733bf79e19..40065ff03f 100644
--- a/app/views/json/_enterprises.rabl
+++ b/app/views/json/_enterprises.rabl
@@ -1,18 +1,5 @@
-# DON'T USE DIRECTLY - for inheritance
+collection Enterprise.visible 
 attributes :name, :id, :description
-
-node :email do |enterprise|
-  enterprise.email.to_s.reverse
-end
-
-child :address do
-  extends "json/partials/address"
-end
-
-node :path do |enterprise|
-  shop_enterprise_path(enterprise) 
-end
-
-node :hash do |enterprise|
-  enterprise.to_param
-end
+extends 'json/partials/enterprise'
+extends 'json/partials/producer'
+extends 'json/partials/hub'
diff --git a/app/views/json/_hubs.rabl b/app/views/json/_hubs.rabl
index c118b4504f..8e8e36d213 100644
--- a/app/views/json/_hubs.rabl
+++ b/app/views/json/_hubs.rabl
@@ -1,26 +1,4 @@
 collection Enterprise.visible.is_distributor
-extends 'json/enterprises'
+extends 'json/partials/enterprise'
+extends 'json/partials/hub'
 
-child distributed_taxons: :taxons do
-  extends "json/taxon"
-end
-
-child suppliers: :producers do
-  extends "json/producer"
-end
-
-node :pickup do |hub|
-  not hub.shipping_methods.where(:require_ship_address => false).empty?
-end
-
-node :delivery do |hub|
-  not hub.shipping_methods.where(:require_ship_address => true).empty?
-end
-
-node :active do |hub|
-  @active_distributors.include?(hub)
-end
-
-node :orders_close_at do |hub|
-  OrderCycle.first_closing_for(hub).andand.orders_close_at
-end
diff --git a/app/views/json/_producers.rabl b/app/views/json/_producers.rabl
index 95a133a182..89839c51ea 100644
--- a/app/views/json/_producers.rabl
+++ b/app/views/json/_producers.rabl
@@ -1,21 +1,3 @@
 collection @producers
-extends 'json/enterprises'
-
-child supplied_taxons: :taxons do
-  extends 'json/taxon'
-end
-
-child distributors: :distributors do
-  attributes :name, :id
-  node :path do |distributor|
-    shop_enterprise_path(distributor) 
-  end
-end
-
-node :path do |producer|
-  producer_path(producer) 
-end
-
-node :hash do |producer|
-  producer.to_param
-end
+extends 'json/partials/enterprise'
+extends 'json/partials/producer'
diff --git a/app/views/json/_enterprises_for_map.rabl b/app/views/json/partials/_enterprise.rabl
similarity index 51%
rename from app/views/json/_enterprises_for_map.rabl
rename to app/views/json/partials/_enterprise.rabl
index a2c6eb06ac..4ebf5f7a78 100644
--- a/app/views/json/_enterprises_for_map.rabl
+++ b/app/views/json/partials/_enterprise.rabl
@@ -1,6 +1,16 @@
-collection @enterprises
-extends 'json/enterprises'
-attributes :latitude, :longitude, :long_description, :website, :instagram, :linkedin, :twitter, :facebook, :is_primary_producer?, :is_distributor?
+attributes :name, :id, :description, :latitude, :longitude, :long_description, :website, :instagram, :linkedin, :twitter, :facebook, :is_primary_producer?, :is_distributor?
+
+node :email do |enterprise|
+  enterprise.email.to_s.reverse
+end
+
+child :address do
+  extends "json/partials/address"
+end
+
+node :hash do |enterprise|
+  enterprise.to_param
+end
 
 node :logo do |enterprise|
   enterprise.logo(:medium) if enterprise.logo.exists?
@@ -10,18 +20,6 @@ node :promo_image do |enterprise|
   enterprise.promo_image(:large) if enterprise.promo_image.exists?
 end
 
-node :active do |enterprise|
-  @active_distributors.include?(enterprise)
-end
-
-child distributors: :hubs do
-  extends 'json/enterprises'
-  node :active do |hub|
-    @active_distributors.include?(hub)
-  end
-end
-
-
 node :icon do |e|
   if e.is_primary_producer? and e.is_distributor?
     image_path "map-icon-both.svg"
diff --git a/app/views/json/partials/_hub.rabl b/app/views/json/partials/_hub.rabl
new file mode 100644
index 0000000000..c1f7879268
--- /dev/null
+++ b/app/views/json/partials/_hub.rabl
@@ -0,0 +1,21 @@
+child distributed_taxons: :taxons do
+  extends "json/taxon"
+end
+child suppliers: :producers do
+  attributes :id
+end
+node :path do |enterprise|
+  shop_enterprise_path(enterprise) 
+end
+node :pickup do |hub|
+  not hub.shipping_methods.where(:require_ship_address => false).empty?
+end
+node :delivery do |hub|
+  not hub.shipping_methods.where(:require_ship_address => true).empty?
+end
+node :active do |hub|
+  @active_distributors.include?(hub)
+end
+node :orders_close_at do |hub|
+  OrderCycle.first_closing_for(hub).andand.orders_close_at
+end
diff --git a/app/views/json/partials/_producer.rabl b/app/views/json/partials/_producer.rabl
new file mode 100644
index 0000000000..a3f7975b40
--- /dev/null
+++ b/app/views/json/partials/_producer.rabl
@@ -0,0 +1,9 @@
+child supplied_taxons: :taxons do
+  extends 'json/taxon'
+end
+child distributors: :hubs do
+  attributes :id
+end
+node :path do |producer|
+  producer_path(producer) 
+end
diff --git a/app/views/layouts/darkswarm.html.haml b/app/views/layouts/darkswarm.html.haml
index 5208c3d5ef..f399756efc 100644
--- a/app/views/layouts/darkswarm.html.haml
+++ b/app/views/layouts/darkswarm.html.haml
@@ -26,6 +26,7 @@
 
 
     = inject_json "currentHub", "current_hub"
+    = inject_json "enterprises", "enterprises"
     = inject_json "currentOrder", "current_order"
     = inject_json "user", "current_user"
     = inject_json "railsFlash", "flash"
diff --git a/spec/javascripts/application_spec.js b/spec/javascripts/application_spec.js
index df629c1c81..4eacb45036 100644
--- a/spec/javascripts/application_spec.js
+++ b/spec/javascripts/application_spec.js
@@ -5,7 +5,10 @@
 //= require angular-mocks
 //= require angular-cookies
 //= require angular-backstretch.js
+//= require lodash.underscore.js
 //= require angular-flash.min.js
 //= require moment
 
 angular.module('templates', [])
+angular.module('google-maps', []);
+angular.module('duScroll', []);
diff --git a/spec/javascripts/mock_google_maps.js.coffee b/spec/javascripts/mock_google_maps.js.coffee
new file mode 100644
index 0000000000..02ef0aa81f
--- /dev/null
+++ b/spec/javascripts/mock_google_maps.js.coffee
@@ -0,0 +1,68 @@
+@google =
+  maps:
+    event:
+      addDomListener: ->
+      addDomListenerOnce: ->
+      addListener: ->
+      addListenerOnce: ->
+      bind: ->
+      clearInstanceListeners: ->
+      clearListeners: ->
+      forward: ->
+      removeListener: ->
+      trigger: ->
+      vf: ->
+
+class google.maps.LatLng
+  constructor: (lat, lng) ->
+    @latitude  = parseFloat(lat)
+    @longitude = parseFloat(lng)
+
+  lat: -> @latitude
+  lng: -> @longitude
+
+class google.maps.LatLngBounds
+  constructor: (@ne, @sw) ->
+
+  getSouthWest: -> @sw
+  getNorthEast: -> @ne
+
+class google.maps.OverlayView
+
+class google.maps.Marker
+  getAnimation: ->
+  getClickable: ->
+  getCursor: ->
+  getDraggable: ->
+  getFlat: ->
+  getIcon: ->
+  getPosition: ->
+  getShadow: ->
+  getShape: ->
+  getTitle: ->
+  getVisible: ->
+  getZIndex: ->
+  setAnimation: ->
+  setClickable: ->
+  setCursor: ->
+  setDraggable: ->
+  setFlat: ->
+  setIcon: ->
+  setPosition: ->
+  setShadow: ->
+  setShape: ->
+  setTitle: ->
+  setVisible: ->
+  setZIndex: ->
+  setMap: ->
+  getMap: ->
+
+class google.maps.MarkerImage
+
+class google.maps.Map
+
+class google.maps.Point
+
+class google.maps.Size
+
+class google.maps.InfoWindow
diff --git a/spec/javascripts/unit/darkswarm/controllers/checkout/accordion_controller_spec.js.coffee b/spec/javascripts/unit/darkswarm/controllers/checkout/accordion_controller_spec.js.coffee
index 8e59248806..9c2545b851 100644
--- a/spec/javascripts/unit/darkswarm/controllers/checkout/accordion_controller_spec.js.coffee
+++ b/spec/javascripts/unit/darkswarm/controllers/checkout/accordion_controller_spec.js.coffee
@@ -1,9 +1,14 @@
 describe "AccordionCtrl", ->
   ctrl = null
   scope = null
+  CurrentHubMock = 
+    id: 1
 
   beforeEach ->
     module "Darkswarm"
+    module ($provide)->
+      $provide.value "CurrentHub", CurrentHubMock 
+      null
     localStorage.clear()
 
   describe "loading incomplete form", ->
diff --git a/spec/javascripts/unit/darkswarm/services/order_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/order_spec.js.coffee
index f6a4112eef..58b2838ac4 100644
--- a/spec/javascripts/unit/darkswarm/services/order_spec.js.coffee
+++ b/spec/javascripts/unit/darkswarm/services/order_spec.js.coffee
@@ -6,6 +6,10 @@ describe 'Order service', ->
   flash = null
   storage = null
   scope = null
+  CurrentHubMock = 
+    id: 1
+  FlashLoaderMock = 
+    loadFlash: (arg)->
 
   beforeEach ->
     orderData =
@@ -36,6 +40,10 @@ describe 'Order service', ->
 
     angular.module('Darkswarm').value('order', orderData)
     module 'Darkswarm'
+    module ($provide)->
+      $provide.value "CurrentHub", CurrentHubMock 
+      $provide.value "RailsFlashLoader", FlashLoaderMock 
+      null
 
     inject ($injector, _$httpBackend_, _storage_, $rootScope)->
       $httpBackend = _$httpBackend_
@@ -58,13 +66,13 @@ describe 'Order service', ->
     spyOn(storage, "bind")
     Order.fieldsToBind = ["testy"]
     Order.bindFieldsToLocalStorage({})
-    prefix = "order_#{Order.order.id}#{Order.order.user_id}"
+    prefix = "order_#{Order.order.id}#{Order.order.user_id}#{CurrentHubMock.id}"
     expect(storage.bind).toHaveBeenCalledWith({}, "Order.order.testy", {storeName: "#{prefix}_testy"})
     expect(storage.bind).toHaveBeenCalledWith({}, "Order.ship_address_same_as_billing", {storeName: "#{prefix}_sameasbilling", defaultValue: true})
 
   it "binds order to local storage", ->
     Order.bindFieldsToLocalStorage(scope)
-    prefix = "order_#{Order.order.id}#{Order.order.user_id}"
+    prefix = "order_#{Order.order.id}#{Order.order.user_id}#{CurrentHubMock.id}"
     expect(localStorage.getItem("#{prefix}_email")).toMatch "test@test.com" 
 
   it "does not store secrets in local storage", ->
@@ -100,10 +108,11 @@ describe 'Order service', ->
     $httpBackend.flush()
 
   it "sends flash messages to the flash service", ->
+    spyOn(FlashLoaderMock, "loadFlash") # Stubbing out writes to window.location
     $httpBackend.expectPUT("/checkout").respond 400, {flash: {error: "frogs"}}
     Order.submit()
     $httpBackend.flush()
-    expect(flash.error).toEqual "frogs"
+    expect(FlashLoaderMock.loadFlash).toHaveBeenCalledWith {error: "frogs"}
 
   it "puts errors into the scope", ->
     $httpBackend.expectPUT("/checkout").respond 400, {errors: {error: "frogs"}}

From deb6c8a05aa1ceef33c527129024670601a23a51 Mon Sep 17 00:00:00 2001
From: Will Marshall <will@willmarshall.me>
Date: Wed, 18 Jun 2014 15:40:02 +1000
Subject: [PATCH 2/7] Refactoring the RABL injection and the
 Hubs/Producers/Enterprises services

---
 .../darkswarm/services/enterprises.js.coffee  |  4 +-
 .../darkswarm/services/hubs.js.coffee         |  9 ++++-
 .../darkswarm/services/producers.js.coffee    |  5 ++-
 app/controllers/home_controller.rb            |  1 +
 app/views/home/_hubs.html.haml                |  3 +-
 app/views/json/_hubs.rabl                     |  2 +-
 app/views/json/_producers.rabl                |  2 +-
 app/views/json/partials/_enterprise.rabl      |  8 ++++
 app/views/layouts/darkswarm.html.haml         |  1 -
 app/views/map/index.html.haml                 |  2 +-
 app/views/producers/index.haml                |  5 +--
 .../services/enterprise_spec.js.coffee        | 22 +++++++++++
 .../darkswarm/services/hubs_spec.js.coffee    | 39 +++++++++++++++++++
 .../services/producers_spec.js.coffee         | 15 +++++++
 14 files changed, 103 insertions(+), 15 deletions(-)
 create mode 100644 spec/javascripts/unit/darkswarm/services/enterprise_spec.js.coffee
 create mode 100644 spec/javascripts/unit/darkswarm/services/hubs_spec.js.coffee
 create mode 100644 spec/javascripts/unit/darkswarm/services/producers_spec.js.coffee

diff --git a/app/assets/javascripts/darkswarm/services/enterprises.js.coffee b/app/assets/javascripts/darkswarm/services/enterprises.js.coffee
index b967bdd18c..04042a2d4b 100644
--- a/app/assets/javascripts/darkswarm/services/enterprises.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/enterprises.js.coffee
@@ -1,5 +1,7 @@
 Darkswarm.factory 'Enterprises', (enterprises)->
   new class Enterprises
+    enterprises_by_id: {} # id/object pairs for lookup 
     constructor: ->
       @enterprises = enterprises
-      @dereference()
+      for enterprise in enterprises
+        @enterprises_by_id[enterprise.id] = enterprise
diff --git a/app/assets/javascripts/darkswarm/services/hubs.js.coffee b/app/assets/javascripts/darkswarm/services/hubs.js.coffee
index 275ce45cec..402b5a0603 100644
--- a/app/assets/javascripts/darkswarm/services/hubs.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/hubs.js.coffee
@@ -1,4 +1,9 @@
-Darkswarm.factory 'Hubs', (hubs, $filter) ->
+Darkswarm.factory 'Hubs', ($filter, Enterprises) ->
   new class Hubs
     constructor: ->
-      @hubs = $filter('orderBy')(hubs, ['-active', '+orders_close_at'])
+      @hubs = @filter Enterprises.enterprises.filter (hub)->
+        hub.type == "hub"
+      
+
+    filter: (hubs)->
+      $filter('orderBy')(hubs, ['-active', '+orders_close_at'])
diff --git a/app/assets/javascripts/darkswarm/services/producers.js.coffee b/app/assets/javascripts/darkswarm/services/producers.js.coffee
index 65e33599af..8ca9752d28 100644
--- a/app/assets/javascripts/darkswarm/services/producers.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/producers.js.coffee
@@ -1,5 +1,6 @@
-Darkswarm.factory 'Producers', (producers) ->
+Darkswarm.factory 'Producers', (Enterprises) ->
   new class Producers
     constructor: ->
-      @producers = producers
+      @producers = Enterprises.enterprises.filter (enterprise)->
+        enterprise.type == "producer"
 
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb
index 592388c243..54c200beff 100644
--- a/app/controllers/home_controller.rb
+++ b/app/controllers/home_controller.rb
@@ -3,6 +3,7 @@ class HomeController < BaseController
   
   def index
     @active_distributors ||= Enterprise.distributors_with_active_order_cycles
+    @enterprises = Enterprise.visible
   end
 
   def about_us
diff --git a/app/views/home/_hubs.html.haml b/app/views/home/_hubs.html.haml
index c96ec6698c..17a4cc13a5 100644
--- a/app/views/home/_hubs.html.haml
+++ b/app/views/home/_hubs.html.haml
@@ -1,6 +1,5 @@
 #hubs.hubs{"ng-controller" => "HubsCtrl"}
-  :javascript
-    angular.module('Darkswarm').value('hubs', #{render "json/hubs"})
+  = inject_json "enterprises" , "enterprises", collection: @enterprises
 
   .row
     .small-12.columns.text-center
diff --git a/app/views/json/_hubs.rabl b/app/views/json/_hubs.rabl
index 8e8e36d213..7f8c4ac7b4 100644
--- a/app/views/json/_hubs.rabl
+++ b/app/views/json/_hubs.rabl
@@ -1,4 +1,4 @@
-collection Enterprise.visible.is_distributor
+collection Enterprise.is_distributor.visible
 extends 'json/partials/enterprise'
 extends 'json/partials/hub'
 
diff --git a/app/views/json/_producers.rabl b/app/views/json/_producers.rabl
index 89839c51ea..cad5b29062 100644
--- a/app/views/json/_producers.rabl
+++ b/app/views/json/_producers.rabl
@@ -1,3 +1,3 @@
-collection @producers
+collection Enterprise.is_primary_producer.visible
 extends 'json/partials/enterprise'
 extends 'json/partials/producer'
diff --git a/app/views/json/partials/_enterprise.rabl b/app/views/json/partials/_enterprise.rabl
index 4ebf5f7a78..32c2ccf4ab 100644
--- a/app/views/json/partials/_enterprise.rabl
+++ b/app/views/json/partials/_enterprise.rabl
@@ -1,5 +1,13 @@
 attributes :name, :id, :description, :latitude, :longitude, :long_description, :website, :instagram, :linkedin, :twitter, :facebook, :is_primary_producer?, :is_distributor?
 
+node :type do |enterprise|
+  if enterprise.is_primary_producer?
+    "producer"
+  elsif enterprise.is_distributor?
+    "hub"
+  end
+end
+
 node :email do |enterprise|
   enterprise.email.to_s.reverse
 end
diff --git a/app/views/layouts/darkswarm.html.haml b/app/views/layouts/darkswarm.html.haml
index f399756efc..5208c3d5ef 100644
--- a/app/views/layouts/darkswarm.html.haml
+++ b/app/views/layouts/darkswarm.html.haml
@@ -26,7 +26,6 @@
 
 
     = inject_json "currentHub", "current_hub"
-    = inject_json "enterprises", "enterprises"
     = inject_json "currentOrder", "current_order"
     = inject_json "user", "current_user"
     = inject_json "railsFlash", "flash"
diff --git a/app/views/map/index.html.haml b/app/views/map/index.html.haml
index 277178bfdc..2c49deb4d4 100644
--- a/app/views/map/index.html.haml
+++ b/app/views/map/index.html.haml
@@ -1,4 +1,4 @@
-= inject_json "enterprisesForMap" , "enterprises_for_map", collection: @enterprises
+= inject_json "enterprisesForMap" , "enterprises", collection: @enterprises
 
 .map-container{"fill-vertical" => true}
   %map{"ng-controller" => "MapCtrl"}
diff --git a/app/views/producers/index.haml b/app/views/producers/index.haml
index 7c4b6a5b62..e30475fdd8 100644
--- a/app/views/producers/index.haml
+++ b/app/views/producers/index.haml
@@ -1,8 +1,5 @@
 .producers{"ng-controller" => "ProducersCtrl"}
-  :javascript
-    angular.module('Darkswarm').value('producers', #{render partial: "json/producers", object: @producers})
-  -#%pre
-    -#{{ Producers.producers | json }}
+  = inject_json "producers" , "producers", collection: @producers
 
   .row
     .small-12.columns.text-center.pad-top
diff --git a/spec/javascripts/unit/darkswarm/services/enterprise_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/enterprise_spec.js.coffee
new file mode 100644
index 0000000000..a2c18e879c
--- /dev/null
+++ b/spec/javascripts/unit/darkswarm/services/enterprise_spec.js.coffee
@@ -0,0 +1,22 @@
+describe "Enterprises service", ->
+  Enterprises = null
+  enterprises = [
+    {id: 1, type: "hub"},
+    {id: 2, type: "producer"}
+  ]
+  beforeEach ->
+    module 'Darkswarm'
+    angular.module('Darkswarm').value('enterprises', enterprises) 
+
+    inject ($injector)->
+      Enterprises = $injector.get("Enterprises") 
+
+  it "stores enterprises as id/object pairs", ->
+    expect(Enterprises.enterprises_by_id["1"]).toBe enterprises[0]
+    expect(Enterprises.enterprises_by_id["2"]).toBe enterprises[1]
+
+  it "stores enterprises as an array", ->
+    expect(Enterprises.enterprises).toBe enterprises
+
+  it "puts the same objects in enterprises and enterprises_by_id", ->
+    expect(Enterprises.enterprises[0]).toBe Enterprises.enterprises_by_id["1"]
diff --git a/spec/javascripts/unit/darkswarm/services/hubs_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/hubs_spec.js.coffee
new file mode 100644
index 0000000000..6247c7a713
--- /dev/null
+++ b/spec/javascripts/unit/darkswarm/services/hubs_spec.js.coffee
@@ -0,0 +1,39 @@
+describe "Hubs service", ->
+  Hubs = null
+  Enterprises = null
+  hubs = [
+    {
+      id: 2
+      active: false
+      orders_close_at: new Date()
+      type: "hub"
+    }
+    {
+      id: 3
+      active: false
+      orders_close_at: new Date()
+      type: "hub"
+    }
+    {
+      id: 1
+      active: true
+      orders_close_at: new Date()
+      type: "hub"
+    }
+  ]
+
+  
+  beforeEach ->
+    module 'Darkswarm'
+    angular.module('Darkswarm').value('enterprises', hubs) 
+    inject ($injector)->
+      Enterprises = $injector.get("Enterprises") 
+      Hubs = $injector.get("Hubs")
+
+  it "filters Enterprise.hubs into a new array", ->
+    expect(Hubs.hubs[0]).toBe Enterprises.enterprises[2]
+    # Because the $filter is a new sorted array 
+    # We check to see the objects in both arrays are still the same
+    Enterprises.enterprises[2].active = false 
+    expect(Hubs.hubs[0].active).toBe false
+
diff --git a/spec/javascripts/unit/darkswarm/services/producers_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/producers_spec.js.coffee
new file mode 100644
index 0000000000..ab2cc04cac
--- /dev/null
+++ b/spec/javascripts/unit/darkswarm/services/producers_spec.js.coffee
@@ -0,0 +1,15 @@
+describe "Producers service", ->
+  Producers = null
+  Enterprises = null
+  enterprises = [
+    {type: "producer"}
+  ]
+
+  beforeEach ->
+    module 'Darkswarm'
+    angular.module('Darkswarm').value('enterprises', enterprises) 
+    inject ($injector)->
+      Producers = $injector.get("Producers")
+
+  it "delegates producers array to Enterprises", ->
+    expect(Producers.producers[0]).toBe enterprises[0] 

From 45404f1475a12aa331b5f041c647ee5141182ca2 Mon Sep 17 00:00:00 2001
From: Will Marshall <will@willmarshall.me>
Date: Wed, 18 Jun 2014 15:48:24 +1000
Subject: [PATCH 3/7] Adding dereferencing on construct to Enterprises service
 - this is MAGIC

---
 .../darkswarm/services/enterprises.js.coffee          | 11 +++++++++++
 .../unit/darkswarm/services/enterprise_spec.js.coffee |  9 +++++++--
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/app/assets/javascripts/darkswarm/services/enterprises.js.coffee b/app/assets/javascripts/darkswarm/services/enterprises.js.coffee
index 04042a2d4b..0c73d0db1e 100644
--- a/app/assets/javascripts/darkswarm/services/enterprises.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/enterprises.js.coffee
@@ -5,3 +5,14 @@ Darkswarm.factory 'Enterprises', (enterprises)->
       @enterprises = enterprises
       for enterprise in enterprises
         @enterprises_by_id[enterprise.id] = enterprise
+      @dereference()
+    
+    dereference: ->
+      for enterprise in @enterprises
+        if enterprise.hubs
+          for hub, i in enterprise.hubs
+            enterprise.hubs[i] = @enterprises_by_id[hub.id]
+
+        if enterprise.producers
+          for producer, i in enterprise.producers
+            enterprise.producers[i] = @enterprises_by_id[producer.id]
diff --git a/spec/javascripts/unit/darkswarm/services/enterprise_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/enterprise_spec.js.coffee
index a2c18e879c..ec0475b93b 100644
--- a/spec/javascripts/unit/darkswarm/services/enterprise_spec.js.coffee
+++ b/spec/javascripts/unit/darkswarm/services/enterprise_spec.js.coffee
@@ -1,8 +1,9 @@
 describe "Enterprises service", ->
   Enterprises = null
   enterprises = [
-    {id: 1, type: "hub"},
-    {id: 2, type: "producer"}
+    {id: 1, type: "hub", producers: [{id: 2}]},
+    {id: 2, type: "producer", hubs: [{id: 1}]},
+    {id: 3, type: "producer", hubs: [{id: 1}]}
   ]
   beforeEach ->
     module 'Darkswarm'
@@ -20,3 +21,7 @@ describe "Enterprises service", ->
 
   it "puts the same objects in enterprises and enterprises_by_id", ->
     expect(Enterprises.enterprises[0]).toBe Enterprises.enterprises_by_id["1"]
+
+  it "dereferences references to other enterprises", ->
+    expect(Enterprises.enterprises_by_id["1"].producers[0]).toBe enterprises[1]
+    expect(Enterprises.enterprises_by_id["3"].hubs[0]).toBe enterprises[0]

From 224a70c11f57e3e7859be03c9ad3513acd6785b5 Mon Sep 17 00:00:00 2001
From: Will Marshall <will@willmarshall.me>
Date: Wed, 18 Jun 2014 16:43:57 +1000
Subject: [PATCH 4/7] Refactoring JSON injection a bit further

---
 .../darkswarm/services/hubs.js.coffee         |  1 -
 .../darkswarm/services/map.js.coffee          |  1 +
 app/controllers/base_controller.rb            |  8 ++++++++
 app/controllers/home_controller.rb            |  5 +++--
 app/controllers/map_controller.rb             |  5 +++--
 app/controllers/producers_controller.rb       |  3 ++-
 app/helpers/shared_helper.rb                  |  3 +++
 app/views/home/_hubs.html.haml                |  2 +-
 app/views/json/_enterprises_for_map.rabl      |  2 ++
 app/views/map/index.html.haml                 |  2 +-
 app/views/producers/index.haml                |  2 +-
 spec/controllers/base_controller_spec.rb      | 10 ++++++++++
 spec/controllers/home_controller_spec.rb      |  6 ++++++
 spec/controllers/map_controller_spec.rb       |  5 +++++
 spec/controllers/producers_controller_spec.rb | 17 ++++++++++++++---
 .../darkswarm/services/map_spec.js.coffee     | 19 +++++++++++++++++++
 16 files changed, 79 insertions(+), 12 deletions(-)
 create mode 100644 app/views/json/_enterprises_for_map.rabl
 create mode 100644 spec/javascripts/unit/darkswarm/services/map_spec.js.coffee

diff --git a/app/assets/javascripts/darkswarm/services/hubs.js.coffee b/app/assets/javascripts/darkswarm/services/hubs.js.coffee
index 402b5a0603..65940c5708 100644
--- a/app/assets/javascripts/darkswarm/services/hubs.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/hubs.js.coffee
@@ -3,7 +3,6 @@ Darkswarm.factory 'Hubs', ($filter, Enterprises) ->
     constructor: ->
       @hubs = @filter Enterprises.enterprises.filter (hub)->
         hub.type == "hub"
-      
 
     filter: (hubs)->
       $filter('orderBy')(hubs, ['-active', '+orders_close_at'])
diff --git a/app/assets/javascripts/darkswarm/services/map.js.coffee b/app/assets/javascripts/darkswarm/services/map.js.coffee
index eb1a195490..f2050a6f25 100644
--- a/app/assets/javascripts/darkswarm/services/map.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/map.js.coffee
@@ -2,6 +2,7 @@ Darkswarm.factory "OfnMap", (enterprisesForMap, MapModal)->
   new class OfnMap
     constructor: ->
       @enterprises = (@extend(enterprise) for enterprise in enterprisesForMap)
+      console.log @enterprises
 
     # Adding methods to each enterprise
     extend: (enterprise)->
diff --git a/app/controllers/base_controller.rb b/app/controllers/base_controller.rb
index ba53ff4a0f..1a4c0aac8d 100644
--- a/app/controllers/base_controller.rb
+++ b/app/controllers/base_controller.rb
@@ -11,4 +11,12 @@ class BaseController < ApplicationController
   include Spree::ProductsHelper
 
   before_filter :check_order_cycle_expiry
+  
+  def load_active_distributors
+    @active_distributors ||= Enterprise.distributors_with_active_order_cycles
+  end
+
+  def load_visible_enterprises
+    @enterprises = Enterprise.visible
+  end
 end
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb
index 54c200beff..97b386157d 100644
--- a/app/controllers/home_controller.rb
+++ b/app/controllers/home_controller.rb
@@ -1,11 +1,12 @@
 class HomeController < BaseController
   layout 'darkswarm'
+  before_filter :load_active_distributors
+  before_filter :load_visible_enterprises
   
   def index
-    @active_distributors ||= Enterprise.distributors_with_active_order_cycles
-    @enterprises = Enterprise.visible
   end
 
   def about_us
   end
 end
+
diff --git a/app/controllers/map_controller.rb b/app/controllers/map_controller.rb
index b5c9ceba83..d63d7f86a9 100644
--- a/app/controllers/map_controller.rb
+++ b/app/controllers/map_controller.rb
@@ -1,7 +1,8 @@
 class MapController < BaseController
   layout 'darkswarm'
+  before_filter :load_active_distributors
+  before_filter :load_visible_enterprises
+
   def index
-    @active_distributors ||= Enterprise.distributors_with_active_order_cycles
-    @enterprises = Enterprise.visible
   end
 end
diff --git a/app/controllers/producers_controller.rb b/app/controllers/producers_controller.rb
index c5a133a798..d7d665de90 100644
--- a/app/controllers/producers_controller.rb
+++ b/app/controllers/producers_controller.rb
@@ -1,7 +1,8 @@
 class ProducersController < BaseController
   layout 'darkswarm'
+  before_filter :load_active_distributors
+  before_filter :load_visible_enterprises
   
   def index
-    @producers = Enterprise.is_primary_producer.visible
   end
 end
diff --git a/app/helpers/shared_helper.rb b/app/helpers/shared_helper.rb
index 3dee7eefbf..f421107994 100644
--- a/app/helpers/shared_helper.rb
+++ b/app/helpers/shared_helper.rb
@@ -1,4 +1,7 @@
 module SharedHelper
+  def inject_enterprises
+    inject_json "enterprises" , "enterprises", collection: @enterprises
+  end
 
   def inject_json(name, partial, opts = {})
     render "json/injection", {name: name, partial: partial}.merge(opts)
diff --git a/app/views/home/_hubs.html.haml b/app/views/home/_hubs.html.haml
index 17a4cc13a5..55b8cc29ca 100644
--- a/app/views/home/_hubs.html.haml
+++ b/app/views/home/_hubs.html.haml
@@ -1,5 +1,5 @@
 #hubs.hubs{"ng-controller" => "HubsCtrl"}
-  = inject_json "enterprises" , "enterprises", collection: @enterprises
+  = inject_enterprises 
 
   .row
     .small-12.columns.text-center
diff --git a/app/views/json/_enterprises_for_map.rabl b/app/views/json/_enterprises_for_map.rabl
new file mode 100644
index 0000000000..641cb34a82
--- /dev/null
+++ b/app/views/json/_enterprises_for_map.rabl
@@ -0,0 +1,2 @@
+collection @enterprises
+extends 'json/partials/enterprise'
diff --git a/app/views/map/index.html.haml b/app/views/map/index.html.haml
index 2c49deb4d4..277178bfdc 100644
--- a/app/views/map/index.html.haml
+++ b/app/views/map/index.html.haml
@@ -1,4 +1,4 @@
-= inject_json "enterprisesForMap" , "enterprises", collection: @enterprises
+= inject_json "enterprisesForMap" , "enterprises_for_map", collection: @enterprises
 
 .map-container{"fill-vertical" => true}
   %map{"ng-controller" => "MapCtrl"}
diff --git a/app/views/producers/index.haml b/app/views/producers/index.haml
index e30475fdd8..2c3253a141 100644
--- a/app/views/producers/index.haml
+++ b/app/views/producers/index.haml
@@ -1,5 +1,5 @@
 .producers{"ng-controller" => "ProducersCtrl"}
-  = inject_json "producers" , "producers", collection: @producers
+  = inject_enterprises 
 
   .row
     .small-12.columns.text-center.pad-top
diff --git a/spec/controllers/base_controller_spec.rb b/spec/controllers/base_controller_spec.rb
index 8269c9374d..85afcbc7ff 100644
--- a/spec/controllers/base_controller_spec.rb
+++ b/spec/controllers/base_controller_spec.rb
@@ -18,4 +18,14 @@ describe BaseController do
     response.should redirect_to root_url
     flash[:info].should == "The order cycle you've selected has just closed. Please try again!"
   end
+
+  it "loads active_distributors" do
+    Enterprise.should_receive(:distributors_with_active_order_cycles)
+    controller.load_active_distributors
+  end
+
+  it "loads visible enterprises" do
+    Enterprise.should_receive(:visible)
+    controller.load_visible_enterprises
+  end
 end
diff --git a/spec/controllers/home_controller_spec.rb b/spec/controllers/home_controller_spec.rb
index babb1c84e6..54b6611438 100644
--- a/spec/controllers/home_controller_spec.rb
+++ b/spec/controllers/home_controller_spec.rb
@@ -7,6 +7,7 @@ describe HomeController do
 
   before do
     Enterprise.stub(:distributors_with_active_order_cycles).and_return [distributor]
+    Enterprise.stub(:visible).and_return [distributor]
   end
 
   it "sets active distributors" do
@@ -14,6 +15,11 @@ describe HomeController do
     assigns[:active_distributors].should == [distributor]
   end
 
+  it "loads visible enterprises" do
+    get :index
+    assigns[:enterprises].should == [distributor]
+  end
+
   it "does not show invisible hubs" do
     get :index
     response.body.should_not have_content invisible_distributor.name
diff --git a/spec/controllers/map_controller_spec.rb b/spec/controllers/map_controller_spec.rb
index dedb534b1b..455420380d 100644
--- a/spec/controllers/map_controller_spec.rb
+++ b/spec/controllers/map_controller_spec.rb
@@ -5,4 +5,9 @@ describe MapController do
     Enterprise.should_receive(:visible)
     get :index
   end
+
+  it "loads active distributors" do
+    Enterprise.should_receive(:distributors_with_active_order_cycles)
+    get :index
+  end
 end
diff --git a/spec/controllers/producers_controller_spec.rb b/spec/controllers/producers_controller_spec.rb
index 885b3981a1..7b399df209 100644
--- a/spec/controllers/producers_controller_spec.rb
+++ b/spec/controllers/producers_controller_spec.rb
@@ -1,9 +1,20 @@
 require 'spec_helper'
 
 describe ProducersController do
-  it "gets all active producers" do
-    Enterprise.stub_chain(:is_primary_producer, :visible)
-    Enterprise.should_receive(:is_primary_producer)
+  let!(:distributor) { create(:distributor_enterprise) }
+
+  before do
+    Enterprise.stub(:distributors_with_active_order_cycles).and_return [distributor]
+    Enterprise.stub(:visible).and_return [distributor]
+  end
+
+  it "sets active distributors" do
     get :index
+    assigns[:active_distributors].should == [distributor]
+  end
+
+  it "loads visible enterprises" do
+    get :index
+    assigns[:enterprises].should == [distributor]
   end
 end
diff --git a/spec/javascripts/unit/darkswarm/services/map_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/map_spec.js.coffee
new file mode 100644
index 0000000000..19ee666e19
--- /dev/null
+++ b/spec/javascripts/unit/darkswarm/services/map_spec.js.coffee
@@ -0,0 +1,19 @@
+describe "Hubs service", ->
+  OfnMap = null
+  enterprises = [
+    {
+      id: 2
+      active: false
+      orders_close_at: new Date()
+      type: "hub"
+    }
+  ]
+
+  beforeEach ->
+    module 'Darkswarm'
+    angular.module('Darkswarm').value('enterprises', enterprises) 
+    inject ($injector)->
+      OfnMap = $injector.get("OfnMap") 
+
+  it "builds MapMarkers from enterprises", ->
+    expect(OfnMap.enterprises[0].enterprise).toBe enterprises[0]

From c02c7cf7caee77f927f5e5ccf271c860e4d92dd7 Mon Sep 17 00:00:00 2001
From: Will Marshall <will@willmarshall.me>
Date: Wed, 18 Jun 2014 17:54:13 +1000
Subject: [PATCH 5/7] Further patches to the damned RABL system, patching
 everything up to use our new Service structure

---
 .../controllers/products_controller.js.coffee    |  5 +++--
 .../darkswarm/services/hubs.js.coffee            |  6 +++---
 .../javascripts/darkswarm/services/map.js.coffee | 16 ++++++++++------
 .../darkswarm/services/map_modal.js.coffee       |  2 +-
 .../darkswarm/services/producers.js.coffee       |  2 +-
 .../darkswarm/services/product.js.coffee         | 11 +++++------
 app/helpers/shared_helper.rb                     |  4 ++--
 app/views/json/_enterprises.rabl                 |  1 -
 app/views/json/_enterprises_for_map.rabl         |  2 +-
 app/views/json/_injection.html.haml              |  2 +-
 app/views/json/partials/_enterprise.rabl         |  4 ++--
 app/views/map/index.html.haml                    |  2 +-
 app/views/shop/products/_form.html.haml          |  4 ++--
 .../products_controller_spec.js.coffee           |  4 ++--
 .../unit/darkswarm/services/hubs_spec.js.coffee  |  6 +++---
 .../unit/darkswarm/services/map_spec.js.coffee   |  2 +-
 .../darkswarm/services/producers_spec.js.coffee  |  2 +-
 .../darkswarm/services/product_spec.js.coffee    |  2 +-
 18 files changed, 40 insertions(+), 37 deletions(-)

diff --git a/app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee b/app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee
index 323df2fc4e..3fdb58cf8e 100644
--- a/app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee
+++ b/app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee
@@ -1,11 +1,12 @@
 Darkswarm.controller "ProductsCtrl", ($scope, $rootScope, Product, OrderCycle) ->
-  $scope.data = Product.data
+  $scope.products = Product.products
+  $scope.loading = Product.loading
   $scope.limit = 3
   $scope.ordering = {order: "name"}
   $scope.order_cycle = OrderCycle.order_cycle
 
   $scope.incrementLimit = ->
-    if $scope.limit < $scope.data.products.length
+    if $scope.limit < $scope.products.length
       $scope.limit = $scope.limit + 1 
 
   $scope.searchKeypress = (e)->
diff --git a/app/assets/javascripts/darkswarm/services/hubs.js.coffee b/app/assets/javascripts/darkswarm/services/hubs.js.coffee
index 65940c5708..70df62e888 100644
--- a/app/assets/javascripts/darkswarm/services/hubs.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/hubs.js.coffee
@@ -1,8 +1,8 @@
 Darkswarm.factory 'Hubs', ($filter, Enterprises) ->
   new class Hubs
     constructor: ->
-      @hubs = @filter Enterprises.enterprises.filter (hub)->
-        hub.type == "hub"
+      @hubs = @order Enterprises.enterprises.filter (hub)->
+        hub.enterprise_type == "hub"
 
-    filter: (hubs)->
+    order: (hubs)->
       $filter('orderBy')(hubs, ['-active', '+orders_close_at'])
diff --git a/app/assets/javascripts/darkswarm/services/map.js.coffee b/app/assets/javascripts/darkswarm/services/map.js.coffee
index f2050a6f25..fd76eeff91 100644
--- a/app/assets/javascripts/darkswarm/services/map.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/map.js.coffee
@@ -1,13 +1,17 @@
-Darkswarm.factory "OfnMap", (enterprisesForMap, MapModal)->
+Darkswarm.factory "OfnMap", (Enterprises, MapModal)->
   new class OfnMap
     constructor: ->
-      @enterprises = (@extend(enterprise) for enterprise in enterprisesForMap)
-      console.log @enterprises
+      @enterprises = (@extend(enterprise) for enterprise in Enterprises.enterprises) 
+
 
     # Adding methods to each enterprise
     extend: (enterprise)->
       new class MapMarker
-        constructor: ->
-          @[k] = v for k, v of enterprise
+        # We're whitelisting attributes because Gmaps tries to crawl
+        # our data, and our data is recursive
+        latitude: enterprise.latitude
+        longitude: enterprise.longitude
+        icon: enterprise.icon
+        id: enterprise.id
         reveal: =>
-          MapModal.open @
+          MapModal.open enterprise
diff --git a/app/assets/javascripts/darkswarm/services/map_modal.js.coffee b/app/assets/javascripts/darkswarm/services/map_modal.js.coffee
index f5c8d3d065..2f1bd832b4 100644
--- a/app/assets/javascripts/darkswarm/services/map_modal.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/map_modal.js.coffee
@@ -2,7 +2,7 @@ Darkswarm.factory "MapModal", ($modal, $rootScope)->
   new class MapModal
     open: (enterprise)->
       scope = $rootScope.$new(true) # Spawn an isolate to contain the enterprise
-      if enterprise['is_primary_producer?']
+      if enterprise.enterprise_type == "producer"
         scope.producer = enterprise
         $modal.open(templateUrl: "map_modal_producer.html", scope: scope)
       else
diff --git a/app/assets/javascripts/darkswarm/services/producers.js.coffee b/app/assets/javascripts/darkswarm/services/producers.js.coffee
index 8ca9752d28..6483ef35eb 100644
--- a/app/assets/javascripts/darkswarm/services/producers.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/producers.js.coffee
@@ -2,5 +2,5 @@ Darkswarm.factory 'Producers', (Enterprises) ->
   new class Producers
     constructor: ->
       @producers = Enterprises.enterprises.filter (enterprise)->
-        enterprise.type == "producer"
+        enterprise.enterprise_type == "producer"
 
diff --git a/app/assets/javascripts/darkswarm/services/product.js.coffee b/app/assets/javascripts/darkswarm/services/product.js.coffee
index 406e122de1..5fae2314a8 100644
--- a/app/assets/javascripts/darkswarm/services/product.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/product.js.coffee
@@ -5,11 +5,10 @@ Darkswarm.factory 'Product', ($resource) ->
     
     # TODO: don't need to scope this into object
     # Already on object as far as controller scope is concerned
-    data: 
-      products: null
-      loading: true
+    products: null
+    loading: true
 
     update: =>
-      @data.products = $resource("/shop/products").query =>
-        @data.loading = false 
-      @data
+      @products = $resource("/shop/products").query =>
+        @loading = false 
+      @
diff --git a/app/helpers/shared_helper.rb b/app/helpers/shared_helper.rb
index f421107994..b552ccd554 100644
--- a/app/helpers/shared_helper.rb
+++ b/app/helpers/shared_helper.rb
@@ -1,10 +1,10 @@
 module SharedHelper
   def inject_enterprises
-    inject_json "enterprises" , "enterprises", collection: @enterprises
+    inject_json "enterprises" , "enterprises"
   end
 
   def inject_json(name, partial, opts = {})
-    render "json/injection", {name: name, partial: partial}.merge(opts)
+    render partial: "json/injection", locals: {name: name, partial: partial}.merge(opts)
   end
 
   def distributor_link_class(distributor)
diff --git a/app/views/json/_enterprises.rabl b/app/views/json/_enterprises.rabl
index 40065ff03f..9b4988b83f 100644
--- a/app/views/json/_enterprises.rabl
+++ b/app/views/json/_enterprises.rabl
@@ -1,5 +1,4 @@
 collection Enterprise.visible 
-attributes :name, :id, :description
 extends 'json/partials/enterprise'
 extends 'json/partials/producer'
 extends 'json/partials/hub'
diff --git a/app/views/json/_enterprises_for_map.rabl b/app/views/json/_enterprises_for_map.rabl
index 641cb34a82..9ce100ab65 100644
--- a/app/views/json/_enterprises_for_map.rabl
+++ b/app/views/json/_enterprises_for_map.rabl
@@ -1,2 +1,2 @@
 collection @enterprises
-extends 'json/partials/enterprise'
+extends "json/partials/enterprise"
diff --git a/app/views/json/_injection.html.haml b/app/views/json/_injection.html.haml
index 95b921406b..ca58b4a943 100644
--- a/app/views/json/_injection.html.haml
+++ b/app/views/json/_injection.html.haml
@@ -1,2 +1,2 @@
 :javascript
-  angular.module('Darkswarm').value("#{name.to_s}", #{render "json/#{partial.to_s}"})
+  angular.module('Darkswarm').value("#{name.to_s}", #{render partial: "json/#{partial.to_s}"})
diff --git a/app/views/json/partials/_enterprise.rabl b/app/views/json/partials/_enterprise.rabl
index 32c2ccf4ab..86cd9f08aa 100644
--- a/app/views/json/partials/_enterprise.rabl
+++ b/app/views/json/partials/_enterprise.rabl
@@ -1,6 +1,6 @@
-attributes :name, :id, :description, :latitude, :longitude, :long_description, :website, :instagram, :linkedin, :twitter, :facebook, :is_primary_producer?, :is_distributor?
+attributes :name, :id, :description, :latitude, :longitude, :long_description, :website, :instagram, :linkedin, :twitter, :facebook
 
-node :type do |enterprise|
+node :enterprise_type do |enterprise|
   if enterprise.is_primary_producer?
     "producer"
   elsif enterprise.is_distributor?
diff --git a/app/views/map/index.html.haml b/app/views/map/index.html.haml
index 277178bfdc..e7f6006ae4 100644
--- a/app/views/map/index.html.haml
+++ b/app/views/map/index.html.haml
@@ -1,4 +1,4 @@
-= inject_json "enterprisesForMap" , "enterprises_for_map", collection: @enterprises
+= inject_enterprises 
 
 .map-container{"fill-vertical" => true}
   %map{"ng-controller" => "MapCtrl"}
diff --git a/app/views/shop/products/_form.html.haml b/app/views/shop/products/_form.html.haml
index 95bfdac31d..d948f18f60 100644
--- a/app/views/shop/products/_form.html.haml
+++ b/app/views/shop/products/_form.html.haml
@@ -14,7 +14,7 @@
     
     %div{bindonce: true}
       %product{"ng-controller" => "ProductNodeCtrl",
-        "ng-repeat" => "product in data.products | filter:query | orderBy:ordering.order | limitTo: limit track by product.id"}
+        "ng-repeat" => "product in products | filter:query | orderBy:ordering.order | limitTo: limit track by product.id"}
         %div
           = render partial: "shop/products/summary"
           %div{"bo-if" => "hasVariants"}
@@ -22,7 +22,7 @@
         .variants.row{"bo-if" => "!hasVariants"}
           = render partial: "shop/products/master"
       
-      %product{"ng-show" => "data.loading"}
+      %product{"ng-show" => "loading"}
         .row.summary
           .small-12.columns.text-center
             Loading products
diff --git a/spec/javascripts/unit/darkswarm/controllers/products_controller_spec.js.coffee b/spec/javascripts/unit/darkswarm/controllers/products_controller_spec.js.coffee
index 685d495039..3a1b5fb399 100644
--- a/spec/javascripts/unit/darkswarm/controllers/products_controller_spec.js.coffee
+++ b/spec/javascripts/unit/darkswarm/controllers/products_controller_spec.js.coffee
@@ -9,7 +9,7 @@ describe 'ProductsCtrl', ->
     Product = 
       all: ->
       update: ->
-      data: "testy mctest"
+      products: "testy mctest"
     OrderCycle =
       order_cycle: {}
         
@@ -18,4 +18,4 @@ describe 'ProductsCtrl', ->
       ctrl = $controller 'ProductsCtrl', {$scope: scope, Product: Product, OrderCycle: OrderCycle}
 
   it 'fetches products from Product', ->
-    expect(scope.data).toEqual 'testy mctest'
+    expect(scope.products).toEqual 'testy mctest'
diff --git a/spec/javascripts/unit/darkswarm/services/hubs_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/hubs_spec.js.coffee
index 6247c7a713..9d4513af35 100644
--- a/spec/javascripts/unit/darkswarm/services/hubs_spec.js.coffee
+++ b/spec/javascripts/unit/darkswarm/services/hubs_spec.js.coffee
@@ -6,19 +6,19 @@ describe "Hubs service", ->
       id: 2
       active: false
       orders_close_at: new Date()
-      type: "hub"
+      enterprise_type: "hub"
     }
     {
       id: 3
       active: false
       orders_close_at: new Date()
-      type: "hub"
+      enterprise_type: "hub"
     }
     {
       id: 1
       active: true
       orders_close_at: new Date()
-      type: "hub"
+      enterprise_type: "hub"
     }
   ]
 
diff --git a/spec/javascripts/unit/darkswarm/services/map_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/map_spec.js.coffee
index 19ee666e19..67acef2770 100644
--- a/spec/javascripts/unit/darkswarm/services/map_spec.js.coffee
+++ b/spec/javascripts/unit/darkswarm/services/map_spec.js.coffee
@@ -16,4 +16,4 @@ describe "Hubs service", ->
       OfnMap = $injector.get("OfnMap") 
 
   it "builds MapMarkers from enterprises", ->
-    expect(OfnMap.enterprises[0].enterprise).toBe enterprises[0]
+    expect(OfnMap.enterprises[0].id).toBe enterprises[0].id
diff --git a/spec/javascripts/unit/darkswarm/services/producers_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/producers_spec.js.coffee
index ab2cc04cac..403bf186ba 100644
--- a/spec/javascripts/unit/darkswarm/services/producers_spec.js.coffee
+++ b/spec/javascripts/unit/darkswarm/services/producers_spec.js.coffee
@@ -2,7 +2,7 @@ describe "Producers service", ->
   Producers = null
   Enterprises = null
   enterprises = [
-    {type: "producer"}
+    {enterprise_type: "producer"}
   ]
 
   beforeEach ->
diff --git a/spec/javascripts/unit/darkswarm/services/product_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/product_spec.js.coffee
index 260074a981..c053573565 100644
--- a/spec/javascripts/unit/darkswarm/services/product_spec.js.coffee
+++ b/spec/javascripts/unit/darkswarm/services/product_spec.js.coffee
@@ -11,4 +11,4 @@ describe 'Product service', ->
   it "Fetches products from the backend on init", ->
     $httpBackend.expectGET("/shop/products").respond([{test : "cats"}])
     $httpBackend.flush()
-    expect(Product.data.products[0].test).toEqual "cats" 
+    expect(Product.products[0].test).toEqual "cats" 

From b9561ecf203f4600859ad21683ed089287c6c017 Mon Sep 17 00:00:00 2001
From: Will Marshall <will@willmarshall.me>
Date: Thu, 19 Jun 2014 11:41:24 +1000
Subject: [PATCH 6/7] Minor refactoring from code review with Rohan

---
 .../javascripts/darkswarm/services/hubs.js.coffee      |  2 +-
 .../javascripts/darkswarm/services/map.js.coffee       |  4 ++--
 .../javascripts/darkswarm/services/map_modal.js.coffee |  9 +++++----
 .../javascripts/darkswarm/services/producers.js.coffee |  2 +-
 app/controllers/base_controller.rb                     |  4 ----
 app/controllers/home_controller.rb                     |  1 -
 app/controllers/map_controller.rb                      |  1 -
 app/controllers/producers_controller.rb                |  1 -
 app/views/json/_enterprises.rabl                       |  3 +++
 app/views/json/_enterprises_for_map.rabl               |  2 --
 app/views/json/partials/_enterprise.rabl               | 10 +---------
 app/views/json/partials/_hub.rabl                      |  4 ++--
 spec/controllers/base_controller_spec.rb               |  5 -----
 spec/controllers/home_controller_spec.rb               |  6 ------
 spec/controllers/map_controller_spec.rb                |  5 -----
 spec/controllers/producers_controller_spec.rb          |  5 -----
 .../unit/darkswarm/services/hubs_spec.js.coffee        |  6 +++---
 .../unit/darkswarm/services/producers_spec.js.coffee   |  2 +-
 18 files changed, 19 insertions(+), 53 deletions(-)
 delete mode 100644 app/views/json/_enterprises_for_map.rabl

diff --git a/app/assets/javascripts/darkswarm/services/hubs.js.coffee b/app/assets/javascripts/darkswarm/services/hubs.js.coffee
index 70df62e888..5d55fa7de9 100644
--- a/app/assets/javascripts/darkswarm/services/hubs.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/hubs.js.coffee
@@ -2,7 +2,7 @@ Darkswarm.factory 'Hubs', ($filter, Enterprises) ->
   new class Hubs
     constructor: ->
       @hubs = @order Enterprises.enterprises.filter (hub)->
-        hub.enterprise_type == "hub"
+        hub.is_distributor
 
     order: (hubs)->
       $filter('orderBy')(hubs, ['-active', '+orders_close_at'])
diff --git a/app/assets/javascripts/darkswarm/services/map.js.coffee b/app/assets/javascripts/darkswarm/services/map.js.coffee
index fd76eeff91..ed4bc8dae4 100644
--- a/app/assets/javascripts/darkswarm/services/map.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/map.js.coffee
@@ -7,8 +7,8 @@ Darkswarm.factory "OfnMap", (Enterprises, MapModal)->
     # Adding methods to each enterprise
     extend: (enterprise)->
       new class MapMarker
-        # We're whitelisting attributes because Gmaps tries to crawl
-        # our data, and our data is recursive
+        # We're whitelisting attributes because GMaps tries to crawl
+        # our data, and our data is recursive, so it breaks
         latitude: enterprise.latitude
         longitude: enterprise.longitude
         icon: enterprise.icon
diff --git a/app/assets/javascripts/darkswarm/services/map_modal.js.coffee b/app/assets/javascripts/darkswarm/services/map_modal.js.coffee
index 2f1bd832b4..cd82edbe98 100644
--- a/app/assets/javascripts/darkswarm/services/map_modal.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/map_modal.js.coffee
@@ -2,9 +2,10 @@ Darkswarm.factory "MapModal", ($modal, $rootScope)->
   new class MapModal
     open: (enterprise)->
       scope = $rootScope.$new(true) # Spawn an isolate to contain the enterprise
-      if enterprise.enterprise_type == "producer"
-        scope.producer = enterprise
-        $modal.open(templateUrl: "map_modal_producer.html", scope: scope)
-      else
+
+      if enterprise.is_distributor
         scope.hub = enterprise
         $modal.open(templateUrl: "map_modal_hub.html", scope: scope)
+      else
+        scope.producer = enterprise
+        $modal.open(templateUrl: "map_modal_producer.html", scope: scope)
diff --git a/app/assets/javascripts/darkswarm/services/producers.js.coffee b/app/assets/javascripts/darkswarm/services/producers.js.coffee
index 6483ef35eb..ac8354c101 100644
--- a/app/assets/javascripts/darkswarm/services/producers.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/producers.js.coffee
@@ -2,5 +2,5 @@ Darkswarm.factory 'Producers', (Enterprises) ->
   new class Producers
     constructor: ->
       @producers = Enterprises.enterprises.filter (enterprise)->
-        enterprise.enterprise_type == "producer"
+        enterprise.is_primary_producer
 
diff --git a/app/controllers/base_controller.rb b/app/controllers/base_controller.rb
index 1a4c0aac8d..2ac35fa3ad 100644
--- a/app/controllers/base_controller.rb
+++ b/app/controllers/base_controller.rb
@@ -15,8 +15,4 @@ class BaseController < ApplicationController
   def load_active_distributors
     @active_distributors ||= Enterprise.distributors_with_active_order_cycles
   end
-
-  def load_visible_enterprises
-    @enterprises = Enterprise.visible
-  end
 end
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb
index 97b386157d..76e179ed22 100644
--- a/app/controllers/home_controller.rb
+++ b/app/controllers/home_controller.rb
@@ -1,7 +1,6 @@
 class HomeController < BaseController
   layout 'darkswarm'
   before_filter :load_active_distributors
-  before_filter :load_visible_enterprises
   
   def index
   end
diff --git a/app/controllers/map_controller.rb b/app/controllers/map_controller.rb
index d63d7f86a9..a980ba8f40 100644
--- a/app/controllers/map_controller.rb
+++ b/app/controllers/map_controller.rb
@@ -1,7 +1,6 @@
 class MapController < BaseController
   layout 'darkswarm'
   before_filter :load_active_distributors
-  before_filter :load_visible_enterprises
 
   def index
   end
diff --git a/app/controllers/producers_controller.rb b/app/controllers/producers_controller.rb
index d7d665de90..b101a95b7f 100644
--- a/app/controllers/producers_controller.rb
+++ b/app/controllers/producers_controller.rb
@@ -1,7 +1,6 @@
 class ProducersController < BaseController
   layout 'darkswarm'
   before_filter :load_active_distributors
-  before_filter :load_visible_enterprises
   
   def index
   end
diff --git a/app/views/json/_enterprises.rabl b/app/views/json/_enterprises.rabl
index 9b4988b83f..0f01743bfc 100644
--- a/app/views/json/_enterprises.rabl
+++ b/app/views/json/_enterprises.rabl
@@ -1,3 +1,6 @@
+# TODO: This should be moved into the controller
+# RABL is tricky to pass variables into: so we do this as a workaround for now
+# I noticed some vague comments on Rabl github about this, but haven't looked into
 collection Enterprise.visible 
 extends 'json/partials/enterprise'
 extends 'json/partials/producer'
diff --git a/app/views/json/_enterprises_for_map.rabl b/app/views/json/_enterprises_for_map.rabl
deleted file mode 100644
index 9ce100ab65..0000000000
--- a/app/views/json/_enterprises_for_map.rabl
+++ /dev/null
@@ -1,2 +0,0 @@
-collection @enterprises
-extends "json/partials/enterprise"
diff --git a/app/views/json/partials/_enterprise.rabl b/app/views/json/partials/_enterprise.rabl
index 86cd9f08aa..20c7ff2332 100644
--- a/app/views/json/partials/_enterprise.rabl
+++ b/app/views/json/partials/_enterprise.rabl
@@ -1,12 +1,4 @@
-attributes :name, :id, :description, :latitude, :longitude, :long_description, :website, :instagram, :linkedin, :twitter, :facebook
-
-node :enterprise_type do |enterprise|
-  if enterprise.is_primary_producer?
-    "producer"
-  elsif enterprise.is_distributor?
-    "hub"
-  end
-end
+attributes :name, :id, :description, :latitude, :longitude, :long_description, :website, :instagram, :linkedin, :twitter, :facebook, :is_primary_producer, :is_distributor
 
 node :email do |enterprise|
   enterprise.email.to_s.reverse
diff --git a/app/views/json/partials/_hub.rabl b/app/views/json/partials/_hub.rabl
index c1f7879268..1c11b23005 100644
--- a/app/views/json/partials/_hub.rabl
+++ b/app/views/json/partials/_hub.rabl
@@ -8,10 +8,10 @@ node :path do |enterprise|
   shop_enterprise_path(enterprise) 
 end
 node :pickup do |hub|
-  not hub.shipping_methods.where(:require_ship_address => false).empty?
+  hub.shipping_methods.where(:require_ship_address => false).present?
 end
 node :delivery do |hub|
-  not hub.shipping_methods.where(:require_ship_address => true).empty?
+  hub.shipping_methods.where(:require_ship_address => true).present?
 end
 node :active do |hub|
   @active_distributors.include?(hub)
diff --git a/spec/controllers/base_controller_spec.rb b/spec/controllers/base_controller_spec.rb
index 85afcbc7ff..e431f14e3f 100644
--- a/spec/controllers/base_controller_spec.rb
+++ b/spec/controllers/base_controller_spec.rb
@@ -23,9 +23,4 @@ describe BaseController do
     Enterprise.should_receive(:distributors_with_active_order_cycles)
     controller.load_active_distributors
   end
-
-  it "loads visible enterprises" do
-    Enterprise.should_receive(:visible)
-    controller.load_visible_enterprises
-  end
 end
diff --git a/spec/controllers/home_controller_spec.rb b/spec/controllers/home_controller_spec.rb
index 54b6611438..babb1c84e6 100644
--- a/spec/controllers/home_controller_spec.rb
+++ b/spec/controllers/home_controller_spec.rb
@@ -7,7 +7,6 @@ describe HomeController do
 
   before do
     Enterprise.stub(:distributors_with_active_order_cycles).and_return [distributor]
-    Enterprise.stub(:visible).and_return [distributor]
   end
 
   it "sets active distributors" do
@@ -15,11 +14,6 @@ describe HomeController do
     assigns[:active_distributors].should == [distributor]
   end
 
-  it "loads visible enterprises" do
-    get :index
-    assigns[:enterprises].should == [distributor]
-  end
-
   it "does not show invisible hubs" do
     get :index
     response.body.should_not have_content invisible_distributor.name
diff --git a/spec/controllers/map_controller_spec.rb b/spec/controllers/map_controller_spec.rb
index 455420380d..f3d56853f9 100644
--- a/spec/controllers/map_controller_spec.rb
+++ b/spec/controllers/map_controller_spec.rb
@@ -1,11 +1,6 @@
 require 'spec_helper'
 
 describe MapController do
-  it "loads all visible enterprises" do
-    Enterprise.should_receive(:visible)
-    get :index
-  end
-
   it "loads active distributors" do
     Enterprise.should_receive(:distributors_with_active_order_cycles)
     get :index
diff --git a/spec/controllers/producers_controller_spec.rb b/spec/controllers/producers_controller_spec.rb
index 7b399df209..d5a90a77d3 100644
--- a/spec/controllers/producers_controller_spec.rb
+++ b/spec/controllers/producers_controller_spec.rb
@@ -12,9 +12,4 @@ describe ProducersController do
     get :index
     assigns[:active_distributors].should == [distributor]
   end
-
-  it "loads visible enterprises" do
-    get :index
-    assigns[:enterprises].should == [distributor]
-  end
 end
diff --git a/spec/javascripts/unit/darkswarm/services/hubs_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/hubs_spec.js.coffee
index 9d4513af35..41828242a8 100644
--- a/spec/javascripts/unit/darkswarm/services/hubs_spec.js.coffee
+++ b/spec/javascripts/unit/darkswarm/services/hubs_spec.js.coffee
@@ -6,19 +6,19 @@ describe "Hubs service", ->
       id: 2
       active: false
       orders_close_at: new Date()
-      enterprise_type: "hub"
+      is_distributor: true
     }
     {
       id: 3
       active: false
       orders_close_at: new Date()
-      enterprise_type: "hub"
+      is_distributor: true
     }
     {
       id: 1
       active: true
       orders_close_at: new Date()
-      enterprise_type: "hub"
+      is_distributor: true
     }
   ]
 
diff --git a/spec/javascripts/unit/darkswarm/services/producers_spec.js.coffee b/spec/javascripts/unit/darkswarm/services/producers_spec.js.coffee
index 403bf186ba..282e4725de 100644
--- a/spec/javascripts/unit/darkswarm/services/producers_spec.js.coffee
+++ b/spec/javascripts/unit/darkswarm/services/producers_spec.js.coffee
@@ -2,7 +2,7 @@ describe "Producers service", ->
   Producers = null
   Enterprises = null
   enterprises = [
-    {enterprise_type: "producer"}
+    {is_primary_producer: true}
   ]
 
   beforeEach ->

From 8905b453334c36239869631a9774c927369bde7a Mon Sep 17 00:00:00 2001
From: Will Marshall <will@willmarshall.me>
Date: Thu, 19 Jun 2014 12:10:05 +1000
Subject: [PATCH 7/7] Fixing a minor regression

---
 .../darkswarm/controllers/products_controller.js.coffee     | 5 ++---
 app/assets/javascripts/darkswarm/services/product.js.coffee | 1 +
 app/views/shop/products/_form.html.haml                     | 6 ++----
 spec/features/consumer/shopping/shopping_spec.rb            | 1 -
 .../controllers/products_controller_spec.js.coffee          | 2 +-
 5 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee b/app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee
index 3fdb58cf8e..3860a2d56e 100644
--- a/app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee
+++ b/app/assets/javascripts/darkswarm/controllers/products_controller.js.coffee
@@ -1,12 +1,11 @@
 Darkswarm.controller "ProductsCtrl", ($scope, $rootScope, Product, OrderCycle) ->
-  $scope.products = Product.products
-  $scope.loading = Product.loading
+  $scope.Product = Product
   $scope.limit = 3
   $scope.ordering = {order: "name"}
   $scope.order_cycle = OrderCycle.order_cycle
 
   $scope.incrementLimit = ->
-    if $scope.limit < $scope.products.length
+    if $scope.limit < $scope.Product.products.length
       $scope.limit = $scope.limit + 1 
 
   $scope.searchKeypress = (e)->
diff --git a/app/assets/javascripts/darkswarm/services/product.js.coffee b/app/assets/javascripts/darkswarm/services/product.js.coffee
index 5fae2314a8..21c0921e41 100644
--- a/app/assets/javascripts/darkswarm/services/product.js.coffee
+++ b/app/assets/javascripts/darkswarm/services/product.js.coffee
@@ -9,6 +9,7 @@ Darkswarm.factory 'Product', ($resource) ->
     loading: true
 
     update: =>
+      @loading = true 
       @products = $resource("/shop/products").query =>
         @loading = false 
       @
diff --git a/app/views/shop/products/_form.html.haml b/app/views/shop/products/_form.html.haml
index d948f18f60..724ec7b249 100644
--- a/app/views/shop/products/_form.html.haml
+++ b/app/views/shop/products/_form.html.haml
@@ -14,7 +14,7 @@
     
     %div{bindonce: true}
       %product{"ng-controller" => "ProductNodeCtrl",
-        "ng-repeat" => "product in products | filter:query | orderBy:ordering.order | limitTo: limit track by product.id"}
+        "ng-repeat" => "product in Product.products | filter:query | orderBy:ordering.order | limitTo: limit track by product.id"}
         %div
           = render partial: "shop/products/summary"
           %div{"bo-if" => "hasVariants"}
@@ -22,12 +22,10 @@
         .variants.row{"bo-if" => "!hasVariants"}
           = render partial: "shop/products/master"
       
-      %product{"ng-show" => "loading"}
+      %product{"ng-show" => "Product.loading"}
         .row.summary
           .small-12.columns.text-center
             Loading products
-            
-    
     .row
       .small-12.columns
         %input.button.primary.right.add_to_cart{type: :submit, value: "Add to Cart"}
diff --git a/spec/features/consumer/shopping/shopping_spec.rb b/spec/features/consumer/shopping/shopping_spec.rb
index 304eff7d23..e219e970a2 100644
--- a/spec/features/consumer/shopping/shopping_spec.rb
+++ b/spec/features/consumer/shopping/shopping_spec.rb
@@ -77,7 +77,6 @@ feature "As a consumer I want to shop with a distributor", js: true do
           page.should have_content "Next order closing in 2 days" 
           Spree::Order.last.order_cycle.should == oc1
           page.should have_content product.name 
-          save_screenshot "/Users/willmarshall/Desktop/shop.png"
           page.should have_content product.master.display_name
           page.should have_content product.master.display_as
         end
diff --git a/spec/javascripts/unit/darkswarm/controllers/products_controller_spec.js.coffee b/spec/javascripts/unit/darkswarm/controllers/products_controller_spec.js.coffee
index 3a1b5fb399..47ad0ccbd4 100644
--- a/spec/javascripts/unit/darkswarm/controllers/products_controller_spec.js.coffee
+++ b/spec/javascripts/unit/darkswarm/controllers/products_controller_spec.js.coffee
@@ -18,4 +18,4 @@ describe 'ProductsCtrl', ->
       ctrl = $controller 'ProductsCtrl', {$scope: scope, Product: Product, OrderCycle: OrderCycle}
 
   it 'fetches products from Product', ->
-    expect(scope.products).toEqual 'testy mctest'
+    expect(scope.Product.products).toEqual 'testy mctest'