From 642938afe08c449e1cc1de581987a88d3c041949 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Bellet Date: Wed, 19 Oct 2022 11:28:31 +0200 Subject: [PATCH 1/5] Upgrade "actions/checkout" to non-deprecated version --- .github/workflows/brakeman-analysis.yml | 2 +- .github/workflows/build.yml | 4 ++-- .github/workflows/linters.yml | 2 +- .github/workflows/mapi.yml | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/brakeman-analysis.yml b/.github/workflows/brakeman-analysis.yml index 97882628ea..934120590d 100644 --- a/.github/workflows/brakeman-analysis.yml +++ b/.github/workflows/brakeman-analysis.yml @@ -23,7 +23,7 @@ jobs: steps: # Checkout the repository to the GitHub Actions runner - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v3 # Customize the ruby version depending on your needs - name: Setup Ruby diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5da8c4c05d..2c66d8567f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -45,7 +45,7 @@ jobs: - "engines/*/spec" fail-fast: false steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up Ruby uses: ruby/setup-ruby@v1 @@ -92,7 +92,7 @@ jobs: POSTGRES_USER: ofn POSTGRES_PASSWORD: f00d steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up Ruby uses: ruby/setup-ruby@v1 diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml index adabb59404..a5f6a5d866 100644 --- a/.github/workflows/linters.yml +++ b/.github/workflows/linters.yml @@ -23,7 +23,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out code - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: prettier uses: EPMatt/reviewdog-action-prettier@v1 with: diff --git a/.github/workflows/mapi.yml b/.github/workflows/mapi.yml index bc4c43b6dc..db4fe5cd36 100644 --- a/.github/workflows/mapi.yml +++ b/.github/workflows/mapi.yml @@ -12,7 +12,7 @@ jobs: strategy: fail-fast: true steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - run: docker/build - run: docker-compose up --detach - run: until curl -f -s http://localhost:3000; do echo "waiting for api server"; sleep 1; done From 2fcbe437f2124a67c571c5f33ad8ba3eec431d30 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Bellet Date: Wed, 19 Oct 2022 11:31:47 +0200 Subject: [PATCH 2/5] Upgrade "actions/setup-node" to non-deprecated version --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2c66d8567f..00029e700a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -52,7 +52,7 @@ jobs: with: bundler-cache: true # runs 'bundle install' and caches installed gems automatically - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v3 with: node-version: '14.15.5' @@ -99,7 +99,7 @@ jobs: with: bundler-cache: true # runs 'bundle install' and caches installed gems automatically - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v3 with: node-version: '14.15.5' From 7ffd4669be0d380e460df439d84b9ecaeda24655 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Bellet Date: Thu, 20 Oct 2022 10:20:09 +0200 Subject: [PATCH 3/5] Change node version to use the latest LTS We probably need to modify our `ofn-install` build to also use the latest LTS --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 00029e700a..6e945de957 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -54,7 +54,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: '14.15.5' + node-version: 16 - name: Install JS dependencies run: yarn install --frozen-lockfile @@ -101,7 +101,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: '14.15.5' + node-version: 16 - name: Install JS dependencies run: yarn install --frozen-lockfile From 053af8416bbe4033a23334c31707e4998b099765 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Bellet Date: Thu, 20 Oct 2022 16:14:14 +0200 Subject: [PATCH 4/5] Previous `setup-ruby` action was deprecated. Use `ruby/setup-ruby@v1` --- .github/workflows/brakeman-analysis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/brakeman-analysis.yml b/.github/workflows/brakeman-analysis.yml index 934120590d..27200af876 100644 --- a/.github/workflows/brakeman-analysis.yml +++ b/.github/workflows/brakeman-analysis.yml @@ -27,7 +27,7 @@ jobs: # Customize the ruby version depending on your needs - name: Setup Ruby - uses: actions/setup-ruby@v1 + uses: ruby/setup-ruby@v1 with: ruby-version: '2.7' From 87ed23211eee76a2d2fa0132c5e52801ff100810 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Bellet Date: Thu, 20 Oct 2022 17:42:22 +0200 Subject: [PATCH 5/5] Use the last version of `github/codeql-action/upload-sarif` --- .github/workflows/brakeman-analysis.yml | 2 +- .github/workflows/mapi.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/brakeman-analysis.yml b/.github/workflows/brakeman-analysis.yml index 27200af876..76b28c52e5 100644 --- a/.github/workflows/brakeman-analysis.yml +++ b/.github/workflows/brakeman-analysis.yml @@ -45,6 +45,6 @@ jobs: # Upload the SARIF file generated in the previous step - name: Upload SARIF - uses: github/codeql-action/upload-sarif@v1 + uses: github/codeql-action/upload-sarif@v2 with: sarif_file: output.sarif.json diff --git a/.github/workflows/mapi.yml b/.github/workflows/mapi.yml index db4fe5cd36..8aaf1d1f62 100644 --- a/.github/workflows/mapi.yml +++ b/.github/workflows/mapi.yml @@ -46,6 +46,6 @@ jobs: # Upload SARIF file (only available on public repos or github enterprise) - name: Upload SARIF file - uses: github/codeql-action/upload-sarif@v1 + uses: github/codeql-action/upload-sarif@v2 with: sarif_file: mapi.sarif