From 8a062b05eb3248755571d202def61d28712f411d Mon Sep 17 00:00:00 2001
From: Maikel Linke <maikel@email.org.au>
Date: Fri, 9 Apr 2021 16:54:35 +1000
Subject: [PATCH] Clarify test users in feature toggle spec

---
 spec/lib/open_food_network/feature_toggle_spec.rb | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/spec/lib/open_food_network/feature_toggle_spec.rb b/spec/lib/open_food_network/feature_toggle_spec.rb
index 60f23933cf..4d60fd060d 100644
--- a/spec/lib/open_food_network/feature_toggle_spec.rb
+++ b/spec/lib/open_food_network/feature_toggle_spec.rb
@@ -41,7 +41,8 @@ module OpenFoodNetwork
     end
 
     context 'when specifying users' do
-      let(:user) { build(:user) }
+      let(:insider) { build(:user) }
+      let(:outsider) { build(:user, email: "different") }
 
       context 'and the block does not specify arguments' do
         before do
@@ -49,20 +50,20 @@ module OpenFoodNetwork
         end
 
         it "returns the block's return value" do
-          expect(FeatureToggle.enabled?(:foo, user)).to eq('return value')
+          expect(FeatureToggle.enabled?(:foo, insider)).to eq('return value')
         end
       end
 
       context 'and the block specifies arguments' do
-        let(:users) { [user.email] }
+        let(:users) { [insider.email] }
 
         before do
           FeatureToggle.enable(:foo) { |user| users.include?(user&.email) }
         end
 
         it "returns the block's return value" do
-          expect(FeatureToggle.enabled?(:foo, user)).to eq(true)
-          expect(FeatureToggle.enabled?(:foo, OpenStruct.new(email: "different"))).to eq(false)
+          expect(FeatureToggle.enabled?(:foo, insider)).to eq(true)
+          expect(FeatureToggle.enabled?(:foo, outsider)).to eq(false)
           expect(FeatureToggle.enabled?(:foo, nil)).to eq(false)
         end
       end