diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index a5c489dc1b..bd2b7c9b67 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 1400 --no-auto-gen-timestamp` -# using RuboCop version 1.57.2. +# using RuboCop version 1.59.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -116,13 +116,28 @@ Lint/RedundantSafeNavigation: Exclude: - 'app/models/spree/payment.rb' +# Offense count: 1 +Lint/SelfAssignment: + Exclude: + - 'app/models/spree/order/checkout.rb' + +# Offense count: 9 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: strict, consistent +Lint/SymbolConversion: + Exclude: + - 'app/models/spree/preferences/preferable_class_methods.rb' + - 'app/services/sets/product_set.rb' + - 'lib/spree/core/environment_extension.rb' + # Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). Lint/UselessMethodDefinition: Exclude: - 'app/models/spree/gateway.rb' -# Offense count: 27 +# Offense count: 26 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max. Metrics/AbcSize: Exclude: @@ -520,7 +535,7 @@ Rails/NegateInclude: - 'lib/spree/localized_number.rb' - 'spec/support/matchers/table_matchers.rb' -# Offense count: 31 +# Offense count: 32 # This cop supports unsafe autocorrection (--autocorrect-all). Rails/Pluck: Exclude: @@ -539,6 +554,7 @@ Rails/Pluck: - 'spec/lib/reports/lettuce_share_report_spec.rb' - 'spec/lib/reports/users_and_enterprises_report_spec.rb' - 'spec/serializers/api/admin/for_order_cycle/supplied_product_serializer_spec.rb' + - 'spec/support/api_helper.rb' # Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). @@ -606,13 +622,12 @@ Rails/ResponseParsedBody: - 'spec/controllers/spree/credit_cards_controller_spec.rb' - 'spec/controllers/user_registrations_controller_spec.rb' -# Offense count: 3 +# Offense count: 2 # This cop supports unsafe autocorrection (--autocorrect-all). Rails/RootPathnameMethods: Exclude: - 'spec/lib/reports/orders_and_fulfillment/order_cycle_customer_totals_report_spec.rb' - 'spec/models/terms_of_service_file_spec.rb' - - 'spec/system/admin/configuration/terms_of_service_files_spec.rb' # Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). @@ -827,6 +842,22 @@ Style/HashConversion: - 'spec/controllers/admin/inventory_items_controller_spec.rb' - 'spec/controllers/admin/variant_overrides_controller_spec.rb' +# Offense count: 13 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowedReceivers. +# AllowedReceivers: Thread.current +Style/HashEachMethods: + Exclude: + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/spree/admin/shipping_methods_controller.rb' + - 'app/forms/enterprise_fees_bulk_update.rb' + - 'app/models/product_import/entry_processor.rb' + - 'app/models/spree/preferences/configuration.rb' + - 'app/services/sets/model_set.rb' + - 'lib/reporting/reports/sales_tax/sales_tax_totals_by_producer.rb' + - 'spec/models/product_importer_spec.rb' + - 'spec/support/cancan_helper.rb' + # Offense count: 1 # Configuration parameters: MinBranchesCount. Style/HashLikeCase: @@ -923,6 +954,26 @@ Style/RedundantInterpolation: - 'lib/tasks/karma.rake' - 'spec/base_spec_helper.rb' +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantLineContinuation: + Exclude: + - 'app/helpers/shop_helper.rb' + - 'spec/system/admin/configuration/content_spec.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantParentheses: + Exclude: + - 'app/models/spree/app_configuration.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowMultipleReturnValues. +Style/RedundantReturn: + Exclude: + - 'app/models/spree/product.rb' + # Offense count: 19 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowedMethods, AllowedPatterns.