From 8926a3f08d7c2f5dfda09397e899bb20dc098475 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Bellet Date: Wed, 1 Feb 2023 10:19:04 +0100 Subject: [PATCH] Having a cleaner syntax a prefer using `map()` instead of `forEach()` --- app/webpacker/controllers/bulk_actions_controller.js | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/app/webpacker/controllers/bulk_actions_controller.js b/app/webpacker/controllers/bulk_actions_controller.js index 78401aa047..a413222b65 100644 --- a/app/webpacker/controllers/bulk_actions_controller.js +++ b/app/webpacker/controllers/bulk_actions_controller.js @@ -12,12 +12,9 @@ export default class extends ApplicationController { // private getOrdersIds() { - const order_ids = []; - document - .querySelectorAll("#listing_orders input[name='order_ids[]']:checked") - .forEach((checkbox) => { - order_ids.push(checkbox.value); - }); - return order_ids; + const checkboxes = document.querySelectorAll( + "#listing_orders input[name='order_ids[]']:checked" + ); + return Array.from(checkboxes).map((checkbox) => checkbox.value); } }