From 85fef7ac4b4f4253a4e5f8924c7930362ce23e4c Mon Sep 17 00:00:00 2001
From: Neal Chambers <macanudo@yahoo.com>
Date: Fri, 17 Nov 2023 08:59:27 +0900
Subject: [PATCH] Safely autocorrect Style/RedundantRegexpArgument

Inspecting 1513 files
...........................................................................................................................................................................................................................................................................................................................................................C....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Offenses:

app/models/spree/shipping_method.rb:69:25: C: [Corrected] Style/RedundantRegexpArgument: Use string ":tracking" as argument instead of regexp /:tracking/.
      tracking_url.gsub(/:tracking/, tracking) unless tracking.blank? || tracking_url.blank?
                        ^^^^^^^^^^^
lib/spree/i18n.rb:36:17: C: [Corrected] Style/RedundantRegexpArgument: Use string "spree" as argument instead of regexp /spree/.
      path.gsub(/spree/, '')
                ^^^^^^^

1513 files inspected, 2 offenses detected, 2 offenses corrected
---
 .rubocop_todo.yml                   | 7 -------
 app/models/spree/shipping_method.rb | 2 +-
 lib/spree/i18n.rb                   | 2 +-
 3 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 44eff7c575..7bb5fa3079 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -937,13 +937,6 @@ Style/RedundantInterpolation:
     - 'lib/tasks/karma.rake'
     - 'spec/base_spec_helper.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantRegexpArgument:
-  Exclude:
-    - 'app/models/spree/shipping_method.rb'
-    - 'lib/spree/i18n.rb'
-
 # Offense count: 5
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowMultipleReturnValues.
diff --git a/app/models/spree/shipping_method.rb b/app/models/spree/shipping_method.rb
index 42ab253ef7..1f726a5d2a 100644
--- a/app/models/spree/shipping_method.rb
+++ b/app/models/spree/shipping_method.rb
@@ -66,7 +66,7 @@ module Spree
     end
 
     def build_tracking_url(tracking)
-      tracking_url.gsub(/:tracking/, tracking) unless tracking.blank? || tracking_url.blank?
+      tracking_url.gsub(":tracking", tracking) unless tracking.blank? || tracking_url.blank?
     end
 
     # Some shipping methods are only meant to be set via backend
diff --git a/lib/spree/i18n.rb b/lib/spree/i18n.rb
index 69242c3d07..38fbd40b00 100644
--- a/lib/spree/i18n.rb
+++ b/lib/spree/i18n.rb
@@ -33,7 +33,7 @@ module Spree
 
       return unless path
 
-      path.gsub(/spree/, '')
+      path.gsub("spree", '')
     end
   end
 end