diff --git a/spec/lib/open_food_network/orders_and_fulfillments_report_spec.rb b/spec/lib/open_food_network/orders_and_fulfillments_report_spec.rb index ec9fd9bc15..b6d810758f 100644 --- a/spec/lib/open_food_network/orders_and_fulfillments_report_spec.rb +++ b/spec/lib/open_food_network/orders_and_fulfillments_report_spec.rb @@ -20,13 +20,13 @@ module OpenFoodNetwork it "fetches completed orders" do o2 = create(:order) o2.line_items << build(:line_item) - subject.table_items.should == [line_item] + expect(subject.table_items).to eq([line_item]) end it "does not show cancelled orders" do o2 = create(:order, state: "canceled", completed_at: 1.day.ago) o2.line_items << build(:line_item) - subject.table_items.should == [line_item] + expect(subject.table_items).to eq([line_item]) end end @@ -49,8 +49,8 @@ module OpenFoodNetwork end it "shows line items supplied by my producers, with names hidden" do - subject.table_items.should == [li2] - subject.table_items.first.order.bill_address.firstname.should == "HIDDEN" + expect(subject.table_items).to eq([li2]) + expect(subject.table_items.first.order.bill_address.firstname).to eq("HIDDEN") end end @@ -63,7 +63,7 @@ module OpenFoodNetwork end it "shows line items supplied by my producers, with names hidden" do - subject.table_items.should == [] + expect(subject.table_items).to eq([]) end end end @@ -80,15 +80,15 @@ module OpenFoodNetwork d2.enterprise_roles.create!(user: create(:user)) o2 = create(:order, distributor: d2, completed_at: 1.day.ago) o2.line_items << build(:line_item) - subject.table_items.should == [line_item] + expect(subject.table_items).to eq([line_item]) end it "only shows the selected order cycle" do oc2 = create(:simple_order_cycle) o2 = create(:order, distributor: distributor, order_cycle: oc2) o2.line_items << build(:line_item) - subject.stub(:params).and_return(order_cycle_id_in: order_cycle.id) - subject.table_items.should == [line_item] + allow(subject).to receive(:params).and_return(order_cycle_id_in: order_cycle.id) + expect(subject.table_items).to eq([line_item]) end end end @@ -99,7 +99,7 @@ module OpenFoodNetwork report_types.each do |report_type| report = OrdersAndFulfillmentsReport.new admin_user, report_type: report_type - report.header.size.should == report.columns.size + expect(report.header.size).to eq(report.columns.size) end end end