From 83acc3faacca2b7cdab88137456125af0bd43651 Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Sat, 20 Mar 2021 00:37:54 +0000 Subject: [PATCH] Improve test setup where checking ineligible payment fee adjustments --- spec/controllers/spree/admin/orders_controller_spec.rb | 3 ++- spec/services/paypal_items_builder_spec.rb | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/spec/controllers/spree/admin/orders_controller_spec.rb b/spec/controllers/spree/admin/orders_controller_spec.rb index 3c332122c8..567e01807e 100644 --- a/spec/controllers/spree/admin/orders_controller_spec.rb +++ b/spec/controllers/spree/admin/orders_controller_spec.rb @@ -19,10 +19,11 @@ describe Spree::Admin::OrdersController, type: :controller do describe "view" do render_views - it "shows only eligible adjustments" do + it "does not show ineligible payment adjustments" do adjustment = create( :adjustment, adjustable: order, + originator_type: "Spree::PaymentMethod", label: "invalid adjustment", eligible: false, order: order, diff --git a/spec/services/paypal_items_builder_spec.rb b/spec/services/paypal_items_builder_spec.rb index 13c6c16c0b..168089c0d1 100644 --- a/spec/services/paypal_items_builder_spec.rb +++ b/spec/services/paypal_items_builder_spec.rb @@ -25,7 +25,8 @@ describe PaypalItemsBuilder do } let!(:ineligible_adjustment) { create(:adjustment, label: "Ineligible Adjustment", order: order, adjustable: order, - amount: 34, eligible: false, state: "closed") + amount: 34, eligible: false, state: "closed", + originator_type: "Spree::PaymentMethod") } let!(:zone) { create(:zone_with_member) } let!(:included_tax_rate) {