From 8084ad00689e3eddb34bdc90b20a886d96d75e69 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Tue, 15 Feb 2022 12:17:08 +0000
Subject: [PATCH] Extract a comment-method so the code conveys it's purpose

---
 app/models/spree/payment.rb | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/app/models/spree/payment.rb b/app/models/spree/payment.rb
index 6da10ab81c..8d66fc2757 100644
--- a/app/models/spree/payment.rb
+++ b/app/models/spree/payment.rb
@@ -147,7 +147,7 @@ module Spree
         adjustment.originator = payment_method
         adjustment.label = adjustment_label
         adjustment.save
-      elsif amount.positive? && payment_method.present?
+      elsif !processing_refund? && payment_method.present?
         payment_method.create_adjustment(adjustment_label, self, true)
         adjustment.reload
       end
@@ -163,6 +163,10 @@ module Spree
 
     private
 
+    def processing_refund?
+      amount.negative?
+    end
+
     # Don't charge fees for invalid or failed payments.
     # This is called twice for failed payments, because the persistence of the 'failed'
     # state is acheived through some trickery using an after_rollback callback on the