diff --git a/engines/dfc_provider/app/controllers/dfc_provider/api/base_controller.rb b/engines/dfc_provider/app/controllers/dfc_provider/api/base_controller.rb index 922f48c307..edc8e3adaa 100644 --- a/engines/dfc_provider/app/controllers/dfc_provider/api/base_controller.rb +++ b/engines/dfc_provider/app/controllers/dfc_provider/api/base_controller.rb @@ -32,10 +32,13 @@ module DfcProvider def current_enterprise @current_enterprise ||= - if params[enterprise_id_param_name] == 'default' - current_user.enterprises.first! + case params[enterprise_id_param_name] + when 'default' + return current_user.enterprises.first! + when nil + return nil else - current_user.enterprises.find(params[enterprise_id_param_name]) + return current_user.enterprises.find(params[enterprise_id_param_name]) end end diff --git a/engines/dfc_provider/spec/controllers/dfc_provider/api/catalog_items_controller_spec.rb b/engines/dfc_provider/spec/controllers/dfc_provider/api/catalog_items_controller_spec.rb index 4dfa947ef1..88581ed555 100644 --- a/engines/dfc_provider/spec/controllers/dfc_provider/api/catalog_items_controller_spec.rb +++ b/engines/dfc_provider/spec/controllers/dfc_provider/api/catalog_items_controller_spec.rb @@ -29,7 +29,7 @@ describe DfcProvider::Api::CatalogItemsController, type: :controller do before { api_get :index, enterprise_id: 'default' } it 'is successful' do - expect(response.status).to eq 200 + expect(response).to be_success end it 'renders the required content' do @@ -47,7 +47,7 @@ describe DfcProvider::Api::CatalogItemsController, type: :controller do it 'returns not_found head' do api_get :index, enterprise_id: enterprise.id - expect(response.status).to eq 404 + expect(response).to be_not_found end end end @@ -75,7 +75,7 @@ describe DfcProvider::Api::CatalogItemsController, type: :controller do it 'is not found' do api_get :index, enterprise_id: 'default' - expect(response.status).to eq 404 + expect(response).to be_not_found end end end @@ -87,7 +87,7 @@ describe DfcProvider::Api::CatalogItemsController, type: :controller do .and_return(nil) api_get :index, enterprise_id: 'default' - expect(response.status).to eq 401 + expect(response.response_code).to eq(401) end end end @@ -95,7 +95,7 @@ describe DfcProvider::Api::CatalogItemsController, type: :controller do context 'without an authorization token' do it 'returns unprocessable_entity head' do api_get :index, enterprise_id: enterprise.id - expect(response.status).to eq 422 + expect(response).to be_unprocessable end end end @@ -120,7 +120,7 @@ describe DfcProvider::Api::CatalogItemsController, type: :controller do end it 'is successful' do - expect(response.status).to eq 200 + expect(response).to be_success end it 'renders the required content' do @@ -137,7 +137,7 @@ describe DfcProvider::Api::CatalogItemsController, type: :controller do end it 'is not found' do - expect(response.status).to eq 404 + expect(response).to be_not_found end end end diff --git a/engines/dfc_provider/spec/controllers/dfc_provider/api/enterprises_spec.rb b/engines/dfc_provider/spec/controllers/dfc_provider/api/enterprises_spec.rb index ff5d92fbf2..89444c2de4 100644 --- a/engines/dfc_provider/spec/controllers/dfc_provider/api/enterprises_spec.rb +++ b/engines/dfc_provider/spec/controllers/dfc_provider/api/enterprises_spec.rb @@ -27,7 +27,7 @@ describe DfcProvider::Api::EnterprisesController, type: :controller do before { api_get :show, id: 'default' } it 'is successful' do - expect(response.status).to eq 200 + expect(response).to be_success end it 'renders the required content' do @@ -44,7 +44,7 @@ describe DfcProvider::Api::EnterprisesController, type: :controller do before { api_get :show, id: 999 } it 'is not found' do - expect(response.status).to eq 404 + expect(response).to be_not_found end end end diff --git a/engines/dfc_provider/spec/controllers/dfc_provider/api/persons_controller_spec.rb b/engines/dfc_provider/spec/controllers/dfc_provider/api/persons_controller_spec.rb index f8d147ed79..d461f1394f 100644 --- a/engines/dfc_provider/spec/controllers/dfc_provider/api/persons_controller_spec.rb +++ b/engines/dfc_provider/spec/controllers/dfc_provider/api/persons_controller_spec.rb @@ -24,7 +24,7 @@ describe DfcProvider::Api::PersonsController, type: :controller do before { api_get :show, id: user.id } it 'is successful' do - expect(response.status).to eq 200 + expect(response).to be_success end it 'renders the required content' do @@ -36,7 +36,7 @@ describe DfcProvider::Api::PersonsController, type: :controller do before { api_get :show, id: create(:user).id } it 'is not found' do - expect(response.status).to eq 404 + expect(response).to be_not_found end end end diff --git a/engines/dfc_provider/spec/controllers/dfc_provider/api/supplied_products_controller_spec.rb b/engines/dfc_provider/spec/controllers/dfc_provider/api/supplied_products_controller_spec.rb index 1053174a3b..e0cc386b14 100644 --- a/engines/dfc_provider/spec/controllers/dfc_provider/api/supplied_products_controller_spec.rb +++ b/engines/dfc_provider/spec/controllers/dfc_provider/api/supplied_products_controller_spec.rb @@ -30,7 +30,7 @@ describe DfcProvider::Api::SuppliedProductsController, type: :controller do end it 'is successful' do - expect(response.status).to eq 200 + expect(response).to be_success end it 'renders the required content' do @@ -39,10 +39,10 @@ describe DfcProvider::Api::SuppliedProductsController, type: :controller do end context 'given with a wrong id' do - before { api_get :show, id: 999 } + before { api_get :show, enterprise_id: 'default', id: 999 } it 'is not found' do - expect(response.status).to eq 404 + expect(response).to be_not_found end end end