From 7f1797de5833e7ee241c503b7a912e618cc0d9d9 Mon Sep 17 00:00:00 2001 From: Luis Ramos Date: Sat, 27 Jun 2020 17:43:57 +0100 Subject: [PATCH] Adapt specs to the move of unauthorized route from the spree routes to the main app routes --- .../admin/bulk_line_items_controller_spec.rb | 6 +++--- .../admin/customers_controller_spec.rb | 4 ++-- .../admin/enterprises_controller_spec.rb | 4 ++-- .../admin/inventory_items_controller_spec.rb | 8 ++++---- .../admin/proxy_orders_controller_spec.rb | 8 ++++---- .../admin/schedules_controller_spec.rb | 2 +- .../admin/stripe_accounts_controller_spec.rb | 4 ++-- ...stripe_connect_settings_controller_spec.rb | 4 ++-- .../admin/subscriptions_controller_spec.rb | 20 +++++++++---------- .../admin/tag_rules_controller_spec.rb | 2 +- .../variant_overrides_controller_spec.rb | 10 +++++----- .../spree/admin/orders_controller_spec.rb | 10 +++++----- .../spree/admin/products_controller_spec.rb | 2 +- .../spree/credit_cards_controller_spec.rb | 4 ++-- .../stripe/callbacks_controller_spec.rb | 2 +- 15 files changed, 45 insertions(+), 45 deletions(-) diff --git a/spec/controllers/admin/bulk_line_items_controller_spec.rb b/spec/controllers/admin/bulk_line_items_controller_spec.rb index 941b44eb0c..553e796558 100644 --- a/spec/controllers/admin/bulk_line_items_controller_spec.rb +++ b/spec/controllers/admin/bulk_line_items_controller_spec.rb @@ -21,7 +21,7 @@ describe Admin::BulkLineItemsController, type: :controller do it "should deny me access to the index action" do spree_get :index, format: :json - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -94,7 +94,7 @@ describe Admin::BulkLineItemsController, type: :controller do end it "does not display line items for which my enterprise is a supplier" do - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -172,7 +172,7 @@ describe Admin::BulkLineItemsController, type: :controller do end it "does not allow access" do - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end diff --git a/spec/controllers/admin/customers_controller_spec.rb b/spec/controllers/admin/customers_controller_spec.rb index b1503d89f7..8e344879a2 100644 --- a/spec/controllers/admin/customers_controller_spec.rb +++ b/spec/controllers/admin/customers_controller_spec.rb @@ -90,7 +90,7 @@ describe Admin::CustomersController, type: :controller do it "prevents me from updating the customer" do spree_put :update, format: :json, id: customer.id, customer: { email: 'new.email@gmail.com' } - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path expect(assigns(:customer)).to eq nil expect(customer.email).to_not eq 'new.email@gmail.com' end @@ -166,7 +166,7 @@ describe Admin::CustomersController, type: :controller do it "prevents me from updating the customer" do spree_get :show, format: :json, id: customer.id - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end end diff --git a/spec/controllers/admin/enterprises_controller_spec.rb b/spec/controllers/admin/enterprises_controller_spec.rb index 78678e03e2..c8a0a9ac29 100644 --- a/spec/controllers/admin/enterprises_controller_spec.rb +++ b/spec/controllers/admin/enterprises_controller_spec.rb @@ -294,7 +294,7 @@ describe Admin::EnterprisesController, type: :controller do it "does not allow access" do spree_post :register, id: enterprise.id, sells: 'none' - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -306,7 +306,7 @@ describe Admin::EnterprisesController, type: :controller do it "does not allow access" do spree_post :register, id: enterprise.id, sells: 'none' - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end diff --git a/spec/controllers/admin/inventory_items_controller_spec.rb b/spec/controllers/admin/inventory_items_controller_spec.rb index 741f329663..9fce5711a6 100644 --- a/spec/controllers/admin/inventory_items_controller_spec.rb +++ b/spec/controllers/admin/inventory_items_controller_spec.rb @@ -21,7 +21,7 @@ describe Admin::InventoryItemsController, type: :controller do it "redirects to unauthorized" do spree_post :create, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -33,7 +33,7 @@ describe Admin::InventoryItemsController, type: :controller do context "but the producer has not granted VO permission" do it "redirects to unauthorized" do spree_post :create, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -84,7 +84,7 @@ describe Admin::InventoryItemsController, type: :controller do it "redirects to unauthorized" do spree_put :update, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -96,7 +96,7 @@ describe Admin::InventoryItemsController, type: :controller do context "but the producer has not granted VO permission" do it "redirects to unauthorized" do spree_put :update, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end diff --git a/spec/controllers/admin/proxy_orders_controller_spec.rb b/spec/controllers/admin/proxy_orders_controller_spec.rb index 1d612e2c57..0bc63e3cb8 100644 --- a/spec/controllers/admin/proxy_orders_controller_spec.rb +++ b/spec/controllers/admin/proxy_orders_controller_spec.rb @@ -20,7 +20,7 @@ describe Admin::ProxyOrdersController, type: :controller do context 'as a regular user' do it 'redirects to unauthorized' do spree_put :cancel, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -31,7 +31,7 @@ describe Admin::ProxyOrdersController, type: :controller do it 'redirects to unauthorized' do spree_put :cancel, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -89,7 +89,7 @@ describe Admin::ProxyOrdersController, type: :controller do context 'as a regular user' do it 'redirects to unauthorized' do spree_put :resume, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -100,7 +100,7 @@ describe Admin::ProxyOrdersController, type: :controller do it 'redirects to unauthorized' do spree_put :resume, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end diff --git a/spec/controllers/admin/schedules_controller_spec.rb b/spec/controllers/admin/schedules_controller_spec.rb index 99b73f4e03..8a0ac86c78 100644 --- a/spec/controllers/admin/schedules_controller_spec.rb +++ b/spec/controllers/admin/schedules_controller_spec.rb @@ -106,7 +106,7 @@ describe Admin::SchedulesController, type: :controller do it "prevents me from updating the schedule" do spree_put :update, format: :json, id: coordinated_schedule.id, schedule: { name: "my awesome schedule" } - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path expect(assigns(:schedule)).to eq nil expect(coordinated_schedule.name).to_not eq "my awesome schedule" end diff --git a/spec/controllers/admin/stripe_accounts_controller_spec.rb b/spec/controllers/admin/stripe_accounts_controller_spec.rb index 9a6854ae85..c1b0890316 100644 --- a/spec/controllers/admin/stripe_accounts_controller_spec.rb +++ b/spec/controllers/admin/stripe_accounts_controller_spec.rb @@ -46,7 +46,7 @@ describe Admin::StripeAccountsController, type: :controller do it "redirects to unauthorized" do spree_delete :destroy, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -93,7 +93,7 @@ describe Admin::StripeAccountsController, type: :controller do it "redirects to unauthorized" do spree_get :status, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end diff --git a/spec/controllers/admin/stripe_connect_settings_controller_spec.rb b/spec/controllers/admin/stripe_connect_settings_controller_spec.rb index 11cebea66e..73331a151a 100644 --- a/spec/controllers/admin/stripe_connect_settings_controller_spec.rb +++ b/spec/controllers/admin/stripe_connect_settings_controller_spec.rb @@ -14,7 +14,7 @@ describe Admin::StripeConnectSettingsController, type: :controller do it "does not allow access" do spree_get :edit - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -76,7 +76,7 @@ describe Admin::StripeConnectSettingsController, type: :controller do it "does not allow access" do spree_get :update, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end diff --git a/spec/controllers/admin/subscriptions_controller_spec.rb b/spec/controllers/admin/subscriptions_controller_spec.rb index c7f0e207a4..7eb11807bf 100644 --- a/spec/controllers/admin/subscriptions_controller_spec.rb +++ b/spec/controllers/admin/subscriptions_controller_spec.rb @@ -18,7 +18,7 @@ describe Admin::SubscriptionsController, type: :controller do context 'as a regular user' do it 'redirects to unauthorized' do spree_get :index, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -55,7 +55,7 @@ describe Admin::SubscriptionsController, type: :controller do context 'as a regular user' do it 'redirects to unauthorized' do spree_get :index, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -120,7 +120,7 @@ describe Admin::SubscriptionsController, type: :controller do it 'redirects to unauthorized' do spree_post :create, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -272,7 +272,7 @@ describe Admin::SubscriptionsController, type: :controller do it 'redirects to unauthorized' do spree_post :update, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -390,7 +390,7 @@ describe Admin::SubscriptionsController, type: :controller do context 'as a regular user' do it 'redirects to unauthorized' do spree_put :cancel, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -401,7 +401,7 @@ describe Admin::SubscriptionsController, type: :controller do it 'redirects to unauthorized' do spree_put :cancel, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -489,7 +489,7 @@ describe Admin::SubscriptionsController, type: :controller do context 'as a regular user' do it 'redirects to unauthorized' do spree_put :pause, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -500,7 +500,7 @@ describe Admin::SubscriptionsController, type: :controller do it 'redirects to unauthorized' do spree_put :pause, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -588,7 +588,7 @@ describe Admin::SubscriptionsController, type: :controller do context 'as a regular user' do it 'redirects to unauthorized' do spree_put :unpause, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -599,7 +599,7 @@ describe Admin::SubscriptionsController, type: :controller do it 'redirects to unauthorized' do spree_put :unpause, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end diff --git a/spec/controllers/admin/tag_rules_controller_spec.rb b/spec/controllers/admin/tag_rules_controller_spec.rb index b4da011923..5d654958a4 100644 --- a/spec/controllers/admin/tag_rules_controller_spec.rb +++ b/spec/controllers/admin/tag_rules_controller_spec.rb @@ -19,7 +19,7 @@ describe Admin::TagRulesController, type: :controller do it "redirects to unauthorized" do spree_delete :destroy, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end diff --git a/spec/controllers/admin/variant_overrides_controller_spec.rb b/spec/controllers/admin/variant_overrides_controller_spec.rb index c75a265cd1..4690dba35b 100644 --- a/spec/controllers/admin/variant_overrides_controller_spec.rb +++ b/spec/controllers/admin/variant_overrides_controller_spec.rb @@ -22,7 +22,7 @@ describe Admin::VariantOverridesController, type: :controller do it "redirects to unauthorized" do spree_put :bulk_update, format: format, variant_overrides: variant_override_params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -34,7 +34,7 @@ describe Admin::VariantOverridesController, type: :controller do context "but the producer has not granted VO permission" do it "redirects to unauthorized" do spree_put :bulk_update, format: format, variant_overrides: variant_override_params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -78,7 +78,7 @@ describe Admin::VariantOverridesController, type: :controller do it "allows to update other variant overrides" do spree_put :bulk_update, format: format, variant_overrides: variant_override_params - expect(response).to_not redirect_to spree.unauthorized_path + expect(response).to_not redirect_to unauthorized_path variant_override.reload expect(variant_override.price).to eq 123.45 end @@ -111,7 +111,7 @@ describe Admin::VariantOverridesController, type: :controller do it "redirects to unauthorized" do spree_put :bulk_reset, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -123,7 +123,7 @@ describe Admin::VariantOverridesController, type: :controller do context "where the producer has not granted create_variant_overrides permission to the hub" do it "restricts access" do spree_put :bulk_reset, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end diff --git a/spec/controllers/spree/admin/orders_controller_spec.rb b/spec/controllers/spree/admin/orders_controller_spec.rb index 8ab20c385a..5d0401c6cc 100644 --- a/spec/controllers/spree/admin/orders_controller_spec.rb +++ b/spec/controllers/spree/admin/orders_controller_spec.rb @@ -113,7 +113,7 @@ describe Spree::Admin::OrdersController, type: :controller do it "should deny me access to the index action" do spree_get :index - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -140,7 +140,7 @@ describe Spree::Admin::OrdersController, type: :controller do it "should prevent me from sending order invoices" do spree_get :invoice, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -150,7 +150,7 @@ describe Spree::Admin::OrdersController, type: :controller do it "should prevent me from sending order invoices" do spree_get :invoice, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -198,7 +198,7 @@ describe Spree::Admin::OrdersController, type: :controller do it "should prevent me from sending order invoices" do spree_get :print, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -207,7 +207,7 @@ describe Spree::Admin::OrdersController, type: :controller do before { allow(controller).to receive(:spree_current_user) { user } } it "should prevent me from sending order invoices" do spree_get :print, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end diff --git a/spec/controllers/spree/admin/products_controller_spec.rb b/spec/controllers/spree/admin/products_controller_spec.rb index e8ae658e9e..efc6ce9b5b 100644 --- a/spec/controllers/spree/admin/products_controller_spec.rb +++ b/spec/controllers/spree/admin/products_controller_spec.rb @@ -16,7 +16,7 @@ describe Spree::Admin::ProductsController, type: :controller do end it "denies access" do - expect(response).to redirect_to spree.unauthorized_url + expect(response).to redirect_to unauthorized_path end it "does not update any product" do diff --git a/spec/controllers/spree/credit_cards_controller_spec.rb b/spec/controllers/spree/credit_cards_controller_spec.rb index e8996433f3..2c4f6a3a15 100644 --- a/spec/controllers/spree/credit_cards_controller_spec.rb +++ b/spec/controllers/spree/credit_cards_controller_spec.rb @@ -88,7 +88,7 @@ describe Spree::CreditCardsController, type: :controller do context "but the card is not owned by the user" do it "redirects to unauthorized" do spree_put :update, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end @@ -135,7 +135,7 @@ describe Spree::CreditCardsController, type: :controller do context "but the card is not owned by the user" do it "redirects to unauthorized" do spree_delete :destroy, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end diff --git a/spec/controllers/stripe/callbacks_controller_spec.rb b/spec/controllers/stripe/callbacks_controller_spec.rb index 33f7bd5b76..50c5433767 100644 --- a/spec/controllers/stripe/callbacks_controller_spec.rb +++ b/spec/controllers/stripe/callbacks_controller_spec.rb @@ -30,7 +30,7 @@ describe Stripe::CallbacksController, type: :controller do it "redirects to unauthorized" do spree_get :index, params - expect(response).to redirect_to spree.unauthorized_path + expect(response).to redirect_to unauthorized_path end end