From 7e2fcede61e8c8cfbc0f6e81c322efad834a6184 Mon Sep 17 00:00:00 2001
From: Maikel Linke <maikel@email.org.au>
Date: Tue, 16 Apr 2024 15:43:59 +1000
Subject: [PATCH] Further simplify mail options logic

We were always adding this option anyway, so why not declare it to start
with?
---
 lib/spree/core/mail_settings.rb | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/lib/spree/core/mail_settings.rb b/lib/spree/core/mail_settings.rb
index 0373f7fac7..ebd62fc4c0 100644
--- a/lib/spree/core/mail_settings.rb
+++ b/lib/spree/core/mail_settings.rb
@@ -20,9 +20,7 @@ module Spree
       private
 
       def mail_server_settings
-        settings = basic_settings.merge(user_credentials)
-
-        settings.merge(enable_starttls_auto: secure_connection?)
+        basic_settings.merge(user_credentials)
       end
 
       def user_credentials
@@ -31,10 +29,13 @@ module Spree
       end
 
       def basic_settings
-        { address: Config.mail_host,
+        {
+          address: Config.mail_host,
           domain: Config.mail_domain,
           port: Config.mail_port,
-          authentication: }
+          authentication:,
+          enable_starttls_auto: secure_connection?,
+        }
       end
 
       def authentication