From 7dfe62a1c7633aace257e5ef268bd4ca916fc535 Mon Sep 17 00:00:00 2001 From: Ahmed Ejaz Date: Tue, 24 Mar 2026 03:46:17 +0500 Subject: [PATCH] Add comment for outgroing exchange variants --- .../services/order_management/subscriptions/variants_list.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/engines/order_management/app/services/order_management/subscriptions/variants_list.rb b/engines/order_management/app/services/order_management/subscriptions/variants_list.rb index 771a231d7f..4a119598e1 100644 --- a/engines/order_management/app/services/order_management/subscriptions/variants_list.rb +++ b/engines/order_management/app/services/order_management/subscriptions/variants_list.rb @@ -32,14 +32,14 @@ module OrderManagement .merge(Enterprise.is_primary_producer) .select(:parent_id) - # Append to the potentially gigantic array instead of using union, which creates a new array - # The db IN statement won't care if there's a duplicate. Enterprise.where(id: distributor.id) .select(:id) .or(Enterprise.where(id: other_permitted_producer_ids)) end def self.outgoing_exchange_variant_ids(distributor) + # DISTINCT is not required here since this subquery is used within an IN clause, + # where duplicate values do not impact the result. ExchangeVariant.joins(:exchange) .where(exchanges: { incoming: false, receiver_id: distributor.id }) .select(:variant_id)