From 6dc54fbd2225d516f8ef33eda933095614412fac Mon Sep 17 00:00:00 2001 From: David Cook Date: Fri, 20 Jan 2023 12:02:48 +1100 Subject: [PATCH 1/2] Add required webpack package Webpack won't run and tells me I need to install the new package: > The command moved into a separate package: @webpack-cli/serve But the latest version depends on webpack 5, so should we install an older version? I couldn't get that working either. --- package.json | 1 + yarn.lock | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/package.json b/package.json index 1f85a44af1..de52f8045f 100644 --- a/package.json +++ b/package.json @@ -42,6 +42,7 @@ "webpack-cli": "~3" }, "devDependencies": { + "@webpack-cli/serve": "*", "husky": "^8.0.0", "jasmine-core": "~2.4.1", "jest": "^27.4.7", diff --git a/yarn.lock b/yarn.lock index c692d9dd54..f05cde08ea 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2027,6 +2027,11 @@ "@webassemblyjs/wast-parser" "1.9.0" "@xtuc/long" "4.2.2" +"@webpack-cli/serve@*": + version "2.0.1" + resolved "https://registry.yarnpkg.com/@webpack-cli/serve/-/serve-2.0.1.tgz#34bdc31727a1889198855913db2f270ace6d7bf8" + integrity sha512-0G7tNyS+yW8TdgHwZKlDWYXFA6OJQnoLCQvYKkQP0Q2X205PSQ6RNUj0M+1OB/9gRQaUZ/ccYfaxd0nhaWKfjw== + "@xtuc/ieee754@^1.2.0": version "1.2.0" resolved "https://registry.yarnpkg.com/@xtuc/ieee754/-/ieee754-1.2.0.tgz#eef014a3145ae477a1cbc00cd1e552336dceb790" From 14189aef5c447013cac314623b72bc3614063eda Mon Sep 17 00:00:00 2001 From: David Cook Date: Thu, 2 Feb 2023 11:51:13 +1100 Subject: [PATCH 2/2] Use yarn to install dependencies reviewdoc-action-prettier is automatically running npm, but that fails. We use yarn so maybe if we call it first, npm won't get called? Worth a try. --- .github/workflows/linters.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml index a5f6a5d866..21219f9a2f 100644 --- a/.github/workflows/linters.yml +++ b/.github/workflows/linters.yml @@ -24,6 +24,14 @@ jobs: steps: - name: Check out code uses: actions/checkout@v3 + + - uses: actions/setup-node@v3 + with: + node-version: 16 + + - name: Install JS dependencies + run: yarn install --frozen-lockfile + - name: prettier uses: EPMatt/reviewdog-action-prettier@v1 with: