From 7cc4cb0181e2cef70db04969fe09df94da493fdd Mon Sep 17 00:00:00 2001 From: cyrillefr Date: Fri, 16 May 2025 14:31:15 +0200 Subject: [PATCH] Fixes RSpecRailsInferredSpecType cop in engines --- .rubocop_todo.yml | 12 +----------- engines/dfc_provider/spec/requests/addresses_spec.rb | 2 +- .../dfc_provider/spec/requests/catalog_items_spec.rb | 2 +- .../requests/enterprise_groups/affiliated_by_spec.rb | 2 +- .../spec/requests/enterprise_groups_spec.rb | 2 +- .../dfc_provider/spec/requests/enterprises_spec.rb | 2 +- engines/dfc_provider/spec/requests/offers_spec.rb | 2 +- engines/dfc_provider/spec/requests/persons_spec.rb | 2 +- .../dfc_provider/spec/requests/social_medias_spec.rb | 2 +- .../spec/requests/supplied_products_spec.rb | 2 +- .../web/spec/helpers/cookies_policy_helper_spec.rb | 2 +- 11 files changed, 11 insertions(+), 21 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index c6aa3ff1ca..342b5a58f9 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -221,21 +221,11 @@ Metrics/PerceivedComplexity: - 'app/models/spree/ability.rb' - 'app/models/spree/order/checkout.rb' -# Offense count: 144 +# Offense count: 134 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Inferences. RSpecRails/InferredSpecType: Exclude: - - 'engines/dfc_provider/spec/requests/addresses_spec.rb' - - 'engines/dfc_provider/spec/requests/catalog_items_spec.rb' - - 'engines/dfc_provider/spec/requests/enterprise_groups/affiliated_by_spec.rb' - - 'engines/dfc_provider/spec/requests/enterprise_groups_spec.rb' - - 'engines/dfc_provider/spec/requests/enterprises_spec.rb' - - 'engines/dfc_provider/spec/requests/offers_spec.rb' - - 'engines/dfc_provider/spec/requests/persons_spec.rb' - - 'engines/dfc_provider/spec/requests/social_medias_spec.rb' - - 'engines/dfc_provider/spec/requests/supplied_products_spec.rb' - - 'engines/web/spec/helpers/cookies_policy_helper_spec.rb' - 'spec/controllers/admin/bulk_line_items_controller_spec.rb' - 'spec/controllers/admin/column_preferences_controller_spec.rb' - 'spec/controllers/admin/customers_controller_spec.rb' diff --git a/engines/dfc_provider/spec/requests/addresses_spec.rb b/engines/dfc_provider/spec/requests/addresses_spec.rb index 7c06914078..56eb1f4eed 100644 --- a/engines/dfc_provider/spec/requests/addresses_spec.rb +++ b/engines/dfc_provider/spec/requests/addresses_spec.rb @@ -2,7 +2,7 @@ require_relative "../swagger_helper" -RSpec.describe "Addresses", type: :request, swagger_doc: "dfc.yaml" do +RSpec.describe "Addresses", swagger_doc: "dfc.yaml" do let(:user) { create(:oidc_user) } let(:address) { create(:address, id: 40_000) } let(:result) { json_response } diff --git a/engines/dfc_provider/spec/requests/catalog_items_spec.rb b/engines/dfc_provider/spec/requests/catalog_items_spec.rb index a48f6c0eba..ac8b091c9a 100644 --- a/engines/dfc_provider/spec/requests/catalog_items_spec.rb +++ b/engines/dfc_provider/spec/requests/catalog_items_spec.rb @@ -2,7 +2,7 @@ require_relative "../swagger_helper" -RSpec.describe "CatalogItems", type: :request, swagger_doc: "dfc.yaml" do +RSpec.describe "CatalogItems", swagger_doc: "dfc.yaml" do let(:user) { create(:oidc_user, id: 12_345) } let(:enterprise) { create( diff --git a/engines/dfc_provider/spec/requests/enterprise_groups/affiliated_by_spec.rb b/engines/dfc_provider/spec/requests/enterprise_groups/affiliated_by_spec.rb index e6ef549213..0b82bb647f 100644 --- a/engines/dfc_provider/spec/requests/enterprise_groups/affiliated_by_spec.rb +++ b/engines/dfc_provider/spec/requests/enterprise_groups/affiliated_by_spec.rb @@ -2,7 +2,7 @@ require_relative "../../swagger_helper" -RSpec.describe "EnterpriseGroups::AffiliatedBy", type: :request, swagger_doc: "dfc.yaml" do +RSpec.describe "EnterpriseGroups::AffiliatedBy", swagger_doc: "dfc.yaml" do let(:user) { create(:oidc_user, id: 12_345) } let(:group) { create( diff --git a/engines/dfc_provider/spec/requests/enterprise_groups_spec.rb b/engines/dfc_provider/spec/requests/enterprise_groups_spec.rb index 4836a689f5..44385d3878 100644 --- a/engines/dfc_provider/spec/requests/enterprise_groups_spec.rb +++ b/engines/dfc_provider/spec/requests/enterprise_groups_spec.rb @@ -2,7 +2,7 @@ require_relative "../swagger_helper" -RSpec.describe "EnterpriseGroups", type: :request, swagger_doc: "dfc.yaml" do +RSpec.describe "EnterpriseGroups", swagger_doc: "dfc.yaml" do let(:user) { create(:oidc_user, id: 12_345) } let(:group) { create( diff --git a/engines/dfc_provider/spec/requests/enterprises_spec.rb b/engines/dfc_provider/spec/requests/enterprises_spec.rb index 254d04fc11..331626e46e 100644 --- a/engines/dfc_provider/spec/requests/enterprises_spec.rb +++ b/engines/dfc_provider/spec/requests/enterprises_spec.rb @@ -2,7 +2,7 @@ require_relative "../swagger_helper" -RSpec.describe "Enterprises", type: :request, swagger_doc: "dfc.yaml" do +RSpec.describe "Enterprises", swagger_doc: "dfc.yaml" do let!(:user) { create(:oidc_user) } let!(:enterprise) do create( diff --git a/engines/dfc_provider/spec/requests/offers_spec.rb b/engines/dfc_provider/spec/requests/offers_spec.rb index 8e3ffe8dab..9f223b41f3 100644 --- a/engines/dfc_provider/spec/requests/offers_spec.rb +++ b/engines/dfc_provider/spec/requests/offers_spec.rb @@ -2,7 +2,7 @@ require_relative "../swagger_helper" -RSpec.describe "Offers", type: :request, swagger_doc: "dfc.yaml" do +RSpec.describe "Offers", swagger_doc: "dfc.yaml" do let!(:user) { create(:oidc_user) } let!(:enterprise) { create(:distributor_enterprise, id: 10_000, owner: user) } let!(:product) { diff --git a/engines/dfc_provider/spec/requests/persons_spec.rb b/engines/dfc_provider/spec/requests/persons_spec.rb index c6379affd7..31a35f47af 100644 --- a/engines/dfc_provider/spec/requests/persons_spec.rb +++ b/engines/dfc_provider/spec/requests/persons_spec.rb @@ -2,7 +2,7 @@ require_relative "../swagger_helper" -RSpec.describe "Persons", type: :request, swagger_doc: "dfc.yaml" do +RSpec.describe "Persons", swagger_doc: "dfc.yaml" do let(:user) { create(:oidc_user, id: 10_000) } let(:other_user) { create(:oidc_user) } diff --git a/engines/dfc_provider/spec/requests/social_medias_spec.rb b/engines/dfc_provider/spec/requests/social_medias_spec.rb index 32c479f593..adfd902c39 100644 --- a/engines/dfc_provider/spec/requests/social_medias_spec.rb +++ b/engines/dfc_provider/spec/requests/social_medias_spec.rb @@ -2,7 +2,7 @@ require_relative "../swagger_helper" -RSpec.describe "SocialMedias", type: :request, swagger_doc: "dfc.yaml" do +RSpec.describe "SocialMedias", swagger_doc: "dfc.yaml" do let(:user) { create(:oidc_user) } let(:enterprise) do create( diff --git a/engines/dfc_provider/spec/requests/supplied_products_spec.rb b/engines/dfc_provider/spec/requests/supplied_products_spec.rb index a5f7d857ab..a316154159 100644 --- a/engines/dfc_provider/spec/requests/supplied_products_spec.rb +++ b/engines/dfc_provider/spec/requests/supplied_products_spec.rb @@ -2,7 +2,7 @@ require_relative "../swagger_helper" -RSpec.describe "SuppliedProducts", type: :request, swagger_doc: "dfc.yaml" do +RSpec.describe "SuppliedProducts", swagger_doc: "dfc.yaml" do let!(:user) { create(:oidc_user) } let!(:enterprise) { create(:distributor_enterprise, id: 10_000, owner: user) } let!(:product) { diff --git a/engines/web/spec/helpers/cookies_policy_helper_spec.rb b/engines/web/spec/helpers/cookies_policy_helper_spec.rb index 81a779c7dd..81607dbc1b 100644 --- a/engines/web/spec/helpers/cookies_policy_helper_spec.rb +++ b/engines/web/spec/helpers/cookies_policy_helper_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' module Web - RSpec.describe CookiesPolicyHelper, type: :helper do + RSpec.describe CookiesPolicyHelper do # keeps global state unchanged around do |example| original_locale = I18n.locale