From 7c72969792652e5d491cdd394cf19fd4f654253f Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Mon, 5 Jun 2023 20:03:11 +0100 Subject: [PATCH] Move Order #state_changed method out into Checkout concern (alongside order states logic) --- app/models/spree/order.rb | 13 ------------- app/models/spree/order/checkout.rb | 13 +++++++++++++ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/app/models/spree/order.rb b/app/models/spree/order.rb index 6b3b463b7f..7f8d69474c 100644 --- a/app/models/spree/order.rb +++ b/app/models/spree/order.rb @@ -426,19 +426,6 @@ module Spree restart_checkout_flow if state.in?(["payment", "confirmation"]) end - def state_changed(name) - state = "#{name}_state" - return unless persisted? - - old_state = __send__("#{state}_was") - state_changes.create( - previous_state: old_state, - next_state: __send__(state), - name: name, - user_id: user_id - ) - end - def shipped? %w(partial shipped).include?(shipment_state) end diff --git a/app/models/spree/order/checkout.rb b/app/models/spree/order/checkout.rb index 01997e676c..23606d52cf 100644 --- a/app/models/spree/order/checkout.rb +++ b/app/models/spree/order/checkout.rb @@ -136,6 +136,19 @@ module Spree ) end + def state_changed(name) + state = "#{name}_state" + return unless persisted? + + old_state = __send__("#{state}_was") + state_changes.create( + previous_state: old_state, + next_state: __send__(state), + name: name, + user_id: user_id + ) + end + private def validate_payment_method!