From 7abe455899337ee43b105eff8dd7be99cb5c722e Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Fri, 15 Mar 2024 12:52:09 +1100 Subject: [PATCH] Exclude false Style/RedundantLineContinuation file The current Rubocop version flags good code as bad. Regenerating the todo file added it there and when the issue is fixed it will disappear from our generated todo list as well. --- .rubocop_todo.yml | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 250bf7c60f..00b861c123 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 1400 --no-auto-gen-timestamp` -# using RuboCop version 1.60.2. +# using RuboCop version 1.62.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -113,6 +113,7 @@ Lint/SelfAssignment: # Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AutoCorrect. Lint/UselessMethodDefinition: Exclude: - 'app/models/spree/gateway.rb' @@ -602,14 +603,6 @@ Rails/SkipsModelValidations: - 'app/models/variant_override.rb' - 'spec/models/spree/line_item_spec.rb' -# Offense count: 3 -# This cop supports unsafe autocorrection (--autocorrect-all). -Rails/SquishedSQLHeredocs: - Exclude: - - 'app/queries/customers_with_balance.rb' - - 'app/queries/outstanding_balance.rb' - - 'spec/queries/outstanding_balance_spec.rb' - # Offense count: 7 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. @@ -656,7 +649,7 @@ Rails/UnusedRenderContent: - 'app/controllers/api/v0/taxons_controller.rb' - 'app/controllers/api/v0/variants_controller.rb' -# Offense count: 55 +# Offense count: 54 # This cop supports unsafe autocorrection (--autocorrect-all). Rails/WhereEquals: Exclude: @@ -678,7 +671,6 @@ Rails/WhereEquals: - 'app/models/spree/shipping_method.rb' - 'app/models/spree/variant.rb' - 'app/models/subscription.rb' - - 'app/queries/payments_requiring_action.rb' - 'app/serializers/api/enterprise_shopfront_serializer.rb' - 'app/serializers/api/order_serializer.rb' - 'lib/open_food_network/enterprise_fee_calculator.rb' @@ -883,7 +875,7 @@ Style/PreferredHashMethods: Exclude: - 'app/controllers/api/v0/shipments_controller.rb' -# Offense count: 3 +# Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Methods. Style/RedundantArgument: @@ -898,7 +890,7 @@ Style/RedundantAssignment: # Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: AllowComments. +# Configuration parameters: AutoCorrect, AllowComments. Style/RedundantInitialize: Exclude: - 'spec/models/spree/gateway_spec.rb' @@ -910,6 +902,12 @@ Style/RedundantInterpolation: - 'lib/tasks/karma.rake' - 'spec/base_spec_helper.rb' +# Offense count: 8 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantLineContinuation: + Exclude: + - 'lib/reporting/reports/enterprise_fee_summary/scope.rb' + # Offense count: 19 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowedMethods, AllowedPatterns.