From 79aebed40e2bc3a179b503a8f16acbf6f815f800 Mon Sep 17 00:00:00 2001
From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com>
Date: Wed, 12 May 2021 10:23:22 +0100
Subject: [PATCH] Bring OrderContents#update_cart tests from upstream and tidy
 up

---
 spec/models/spree/order_contents_spec.rb | 56 ++++++++++++++++++++----
 1 file changed, 47 insertions(+), 9 deletions(-)

diff --git a/spec/models/spree/order_contents_spec.rb b/spec/models/spree/order_contents_spec.rb
index 7a333521ee..e63318cf5b 100644
--- a/spec/models/spree/order_contents_spec.rb
+++ b/spec/models/spree/order_contents_spec.rb
@@ -3,12 +3,11 @@
 require 'spec_helper'
 
 describe Spree::OrderContents do
-  let(:order) { Spree::Order.create }
+  let!(:order) { create(:order) }
+  let!(:variant) { create(:variant) }
   subject { described_class.new(order) }
 
   context "#add" do
-    let(:variant) { create(:variant) }
-
     context 'given quantity is not explicitly provided' do
       it 'should add one line item' do
         line_item = subject.add(variant)
@@ -42,8 +41,6 @@ describe Spree::OrderContents do
   end
 
   context "#remove" do
-    let(:variant) { create(:variant) }
-
     context "given an invalid variant" do
       it "raises an exception" do
         expect {
@@ -53,11 +50,12 @@ describe Spree::OrderContents do
     end
 
     context 'given quantity is not explicitly provided' do
-      it 'should remove one line item' do
-        line_item = subject.add(variant, 3)
-        subject.remove(variant)
+      it 'should remove line item' do
+        subject.add(variant, 3)
 
-        expect(line_item.reload.quantity).to eq 2
+        expect{
+          subject.remove(variant)
+        }.to change(Spree::LineItem, :count).by -1
       end
     end
 
@@ -89,4 +87,44 @@ describe Spree::OrderContents do
       expect(order.total.to_f).to eq 19.99
     end
   end
+
+  context "#update_cart" do
+    let!(:line_item) { subject.add variant, 1 }
+
+    let(:params) do
+      { line_items_attributes: {
+        "0" => { id: line_item.id, quantity: 3 }
+      } }
+    end
+
+    it "changes item quantity" do
+      subject.update_cart params
+      expect(line_item.reload.quantity).to eq 3
+    end
+
+    it "updates order totals" do
+      expect {
+        subject.update_cart params
+      }.to change { subject.order.total }
+    end
+
+    context "submits item quantity 0" do
+      let(:params) do
+        { line_items_attributes: {
+          "0" => { id: line_item.id, quantity: 0 }
+        } }
+      end
+
+      it "removes item from order" do
+        expect {
+          subject.update_cart params
+        }.to change { order.line_items.count }
+      end
+    end
+
+    it "ensures updated shipments" do
+      expect(subject.order).to receive(:ensure_updated_shipments)
+      subject.update_cart params
+    end
+  end
 end