From 78d6d129e85656e50188fe8277b8ad3e9b3d2857 Mon Sep 17 00:00:00 2001
From: Maikel Linke <maikel@email.org.au>
Date: Wed, 28 Jun 2023 14:08:10 +1000
Subject: [PATCH] Simplify with extracted helper method

---
 engines/dfc_provider/spec/requests/catalog_items_spec.rb  | 2 +-
 .../dfc_provider/spec/requests/supplied_products_spec.rb  | 4 +---
 engines/dfc_provider/spec/support/example_json.rb         | 8 ++++++++
 3 files changed, 10 insertions(+), 4 deletions(-)
 create mode 100644 engines/dfc_provider/spec/support/example_json.rb

diff --git a/engines/dfc_provider/spec/requests/catalog_items_spec.rb b/engines/dfc_provider/spec/requests/catalog_items_spec.rb
index 959bb2b0e4..8d4170e8ca 100644
--- a/engines/dfc_provider/spec/requests/catalog_items_spec.rb
+++ b/engines/dfc_provider/spec/requests/catalog_items_spec.rb
@@ -103,7 +103,7 @@ describe "CatalogItems", type: :request, swagger_doc: "dfc-v1.7/swagger.yaml",
       consumes "application/json"
 
       parameter name: :catalog_item, in: :body, schema: {
-        example: JSON.parse(DfcProvider::Engine.root.join("spec/support/patch_catalog_item.json").read)
+        example: ExampleJson.read("patch_catalog_item")
       }
 
       before { product }
diff --git a/engines/dfc_provider/spec/requests/supplied_products_spec.rb b/engines/dfc_provider/spec/requests/supplied_products_spec.rb
index 192d3e72c5..c2dec83b2f 100644
--- a/engines/dfc_provider/spec/requests/supplied_products_spec.rb
+++ b/engines/dfc_provider/spec/requests/supplied_products_spec.rb
@@ -103,9 +103,7 @@ describe "SuppliedProducts", type: :request, swagger_doc: "dfc-v1.7/swagger.yaml
       parameter name: :supplied_product, in: :body, schema: {}
 
       let(:id) { variant.id }
-      let(:supplied_product) do
-        JSON.parse(DfcProvider::Engine.root.join("spec/support/patch_supplied_product.json").read)
-      end
+      let(:supplied_product) { ExampleJson.read("patch_supplied_product") }
 
       response "401", "unauthorized" do
         before { login_as nil }
diff --git a/engines/dfc_provider/spec/support/example_json.rb b/engines/dfc_provider/spec/support/example_json.rb
new file mode 100644
index 0000000000..3bd8341af0
--- /dev/null
+++ b/engines/dfc_provider/spec/support/example_json.rb
@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+module ExampleJson
+  def self.read(name)
+    pathname = DfcProvider::Engine.root.join("spec/support/#{name}.json")
+    JSON.parse(pathname.read)
+  end
+end