From ed06edda3f1f16466018b54cfb69250ab364d5c7 Mon Sep 17 00:00:00 2001 From: Neal Chambers Date: Wed, 13 Sep 2023 16:45:00 +0900 Subject: [PATCH 1/2] Fix Style/HashSyntax --- app/models/spree/adjustment.rb | 4 ++-- app/models/spree/credit_card.rb | 12 +++++------ app/models/spree/gateway/pay_pal_express.rb | 2 +- app/models/spree/gateway/stripe_sca.rb | 4 ++-- app/models/spree/inventory_unit.rb | 2 +- app/models/spree/item_adjustments.rb | 6 +++--- app/models/spree/line_item.rb | 10 +++++----- app/models/spree/order.rb | 20 +++++++++---------- app/models/spree/order/checkout.rb | 4 ++-- app/models/spree/order_contents.rb | 2 +- app/models/spree/payment.rb | 6 +++--- app/models/spree/payment/processing.rb | 12 +++++------ app/models/spree/preferences/store.rb | 4 ++-- app/models/spree/price.rb | 2 +- app/models/spree/product.rb | 2 +- app/models/spree/product_property.rb | 4 ++-- app/models/spree/return_authorization.rb | 4 ++-- app/models/spree/shipment.rb | 14 ++++++------- app/models/spree/shipping_rate.rb | 2 +- app/models/spree/stock_location.rb | 4 ++-- app/models/spree/tax_rate.rb | 6 +++--- app/models/spree/taxonomy.rb | 4 ++-- app/models/spree/user.rb | 8 ++++---- app/models/spree/variant.rb | 2 +- app/models/stripe_account.rb | 6 +++--- app/models/voucher.rb | 4 ++-- app/reflexes/admin/orders_reflex.rb | 4 ++-- app/reflexes/invite_manager_reflex.rb | 6 +++--- app/reflexes/white_label_reflex.rb | 2 +- .../api/admin/enterprise_serializer.rb | 2 +- 30 files changed, 82 insertions(+), 82 deletions(-) diff --git a/app/models/spree/adjustment.rb b/app/models/spree/adjustment.rb index 8c8bfb848e..ee8b3dcc7d 100644 --- a/app/models/spree/adjustment.rb +++ b/app/models/spree/adjustment.rb @@ -109,7 +109,7 @@ module Spree if originator.present? amount = originator.compute_amount(calculable || adjustable) update_columns( - amount: amount, + amount:, updated_at: Time.zone.now, ) end @@ -122,7 +122,7 @@ module Spree end def display_amount - Spree::Money.new(amount, currency: currency) + Spree::Money.new(amount, currency:) end def admin? diff --git a/app/models/spree/credit_card.rb b/app/models/spree/credit_card.rb index fa3f9ecc9e..529f657014 100644 --- a/app/models/spree/credit_card.rb +++ b/app/models/spree/credit_card.rb @@ -102,12 +102,12 @@ module Spree def to_active_merchant ActiveMerchant::Billing::CreditCard.new( - number: number, - month: month, - year: year, - verification_value: verification_value, - first_name: first_name, - last_name: last_name + number:, + month:, + year:, + verification_value:, + first_name:, + last_name: ) end diff --git a/app/models/spree/gateway/pay_pal_express.rb b/app/models/spree/gateway/pay_pal_express.rb index 7d4903a275..d4c669097f 100644 --- a/app/models/spree/gateway/pay_pal_express.rb +++ b/app/models/spree/gateway/pay_pal_express.rb @@ -100,7 +100,7 @@ module Spree refunded_at: Time.now, refund_transaction_id: refund_transaction_response.RefundTransactionID, state: "refunded", - refund_type: refund_type + refund_type: ) payment.class.create!( diff --git a/app/models/spree/gateway/stripe_sca.rb b/app/models/spree/gateway/stripe_sca.rb index c6a19f91d7..b4a3ea95b4 100644 --- a/app/models/spree/gateway/stripe_sca.rb +++ b/app/models/spree/gateway/stripe_sca.rb @@ -69,7 +69,7 @@ module Spree customer, payment_method = Stripe::CreditCardCloner.new(creditcard, stripe_account_id).find_or_clone - options = basic_options(gateway_options).merge(customer: customer, off_session: true) + options = basic_options(gateway_options).merge(customer:, off_session: true) provider.purchase(money, payment_method, options) rescue Stripe::StripeError => e failed_activemerchant_billing_response(e.message) @@ -164,7 +164,7 @@ module Spree state = payment_intent_response.status return if state == 'requires_capture' - raise Stripe::StripeError, I18n.t(:invalid_payment_state, state: state) + raise Stripe::StripeError, I18n.t(:invalid_payment_state, state:) end def fetch_payment(creditcard, gateway_options) diff --git a/app/models/spree/inventory_unit.rb b/app/models/spree/inventory_unit.rb index 44a5c4acf9..f5f0219919 100644 --- a/app/models/spree/inventory_unit.rb +++ b/app/models/spree/inventory_unit.rb @@ -58,7 +58,7 @@ module Spree def find_stock_item Spree::StockItem.find_by(stock_location_id: shipment.stock_location_id, - variant_id: variant_id) + variant_id:) end private diff --git a/app/models/spree/item_adjustments.rb b/app/models/spree/item_adjustments.rb index bbcc063ac0..1465e5ad97 100644 --- a/app/models/spree/item_adjustments.rb +++ b/app/models/spree/item_adjustments.rb @@ -22,9 +22,9 @@ module Spree additional_tax_total = tax_adjustments.additional.reload.map(&:update_adjustment!).compact.sum item.update_columns( - included_tax_total: included_tax_total, - additional_tax_total: additional_tax_total, - adjustment_total: adjustment_total, + included_tax_total:, + additional_tax_total:, + adjustment_total:, updated_at: Time.zone.now ) end diff --git a/app/models/spree/line_item.rb b/app/models/spree/line_item.rb index 846b88ba3c..6de3fe9601 100644 --- a/app/models/spree/line_item.rb +++ b/app/models/spree/line_item.rb @@ -142,12 +142,12 @@ module Spree alias total amount def single_money - Spree::Money.new(price, currency: currency) + Spree::Money.new(price, currency:) end alias single_display_amount single_money def money - Spree::Money.new(amount, currency: currency) + Spree::Money.new(amount, currency:) end alias display_total money alias display_amount money @@ -209,7 +209,7 @@ module Spree end def single_display_amount_with_adjustments - Spree::Money.new(price_with_adjustments, currency: currency) + Spree::Money.new(price_with_adjustments, currency:) end def amount_with_adjustments @@ -219,11 +219,11 @@ module Spree end def display_amount_with_adjustments - Spree::Money.new(amount_with_adjustments, currency: currency) + Spree::Money.new(amount_with_adjustments, currency:) end def display_included_tax - Spree::Money.new(included_tax, currency: currency) + Spree::Money.new(included_tax, currency:) end def unit_value diff --git a/app/models/spree/order.rb b/app/models/spree/order.rb index 6798e9596b..64c5aa60c0 100644 --- a/app/models/spree/order.rb +++ b/app/models/spree/order.rb @@ -168,8 +168,8 @@ module Spree scope :finalized, -> { where(state: FINALIZED_STATES) } scope :complete, -> { where.not(completed_at: nil) } scope :incomplete, -> { where(completed_at: nil) } - scope :by_state, lambda { |state| where(state: state) } - scope :not_state, lambda { |state| where.not(state: state) } + scope :by_state, lambda { |state| where(state:) } + scope :not_state, lambda { |state| where.not(state:) } def initialize(*_args) @checkout_processing = nil @@ -193,15 +193,15 @@ module Spree end def display_item_total - Spree::Money.new(item_total, currency: currency) + Spree::Money.new(item_total, currency:) end def display_adjustment_total - Spree::Money.new(adjustment_total, currency: currency) + Spree::Money.new(adjustment_total, currency:) end def display_total - Spree::Money.new(total, currency: currency) + Spree::Money.new(total, currency:) end def to_param @@ -312,9 +312,9 @@ module Spree # Persist the changes we just made, # but don't use save since we might have an invalid address associated - self.class.unscoped.where(id: id).update_all(email: user.email, - user_id: user.id, - created_by_id: created_by_id) + self.class.unscoped.where(id:).update_all(email: user.email, + user_id: user.id, + created_by_id:) end def generate_order_number @@ -393,7 +393,7 @@ module Spree previous_state: 'cart', next_state: 'complete', name: 'order', - user_id: user_id + user_id: ) end @@ -673,7 +673,7 @@ module Spree end def registered_email? - Spree::User.exists?(email: email) + Spree::User.exists?(email:) end def adjustments_fetcher diff --git a/app/models/spree/order/checkout.rb b/app/models/spree/order/checkout.rb index 8d5ec88b5c..e76cc248c2 100644 --- a/app/models/spree/order/checkout.rb +++ b/app/models/spree/order/checkout.rb @@ -145,8 +145,8 @@ module Spree state_changes.create( previous_state: old_state, next_state: __send__(state), - name: name, - user_id: user_id + name:, + user_id: ) end diff --git a/app/models/spree/order_contents.rb b/app/models/spree/order_contents.rb index 8ffbd33827..6c8e150e02 100644 --- a/app/models/spree/order_contents.rb +++ b/app/models/spree/order_contents.rb @@ -88,7 +88,7 @@ module Spree line_item.target_shipment = shipment line_item.quantity += quantity.to_i else - line_item = order.line_items.new(quantity: quantity, variant: variant) + line_item = order.line_items.new(quantity:, variant:) line_item.target_shipment = shipment line_item.price = variant.price end diff --git a/app/models/spree/payment.rb b/app/models/spree/payment.rb index c7f7ec54d0..51d19d72ad 100644 --- a/app/models/spree/payment.rb +++ b/app/models/spree/payment.rb @@ -102,7 +102,7 @@ module Spree end def money - Spree::Money.new(amount, currency: currency) + Spree::Money.new(amount, currency:) end alias display_amount money @@ -220,7 +220,7 @@ module Spree # Makes newly entered payments invalidate previously entered payments so the most recent payment # is used by the gateway. def invalidate_old_payments - order.payments.incomplete.where.not(id: id).each do |payment| + order.payments.incomplete.where.not(id:).each do |payment| # Using update_column skips validations and so it skips validate_source. As we are just # invalidating past payments here, we don't want to validate all of them at this stage. payment.update_columns( @@ -245,7 +245,7 @@ module Spree # and this is it. Related to #1998. # See https://github.com/spree/spree/issues/1998#issuecomment-12869105 def set_unique_identifier - self.identifier = generate_identifier while self.class.exists?(identifier: identifier) + self.identifier = generate_identifier while self.class.exists?(identifier:) end def generate_identifier diff --git a/app/models/spree/payment/processing.rb b/app/models/spree/payment/processing.rb index cace1f17e1..17918078de 100644 --- a/app/models/spree/payment/processing.rb +++ b/app/models/spree/payment/processing.rb @@ -22,7 +22,7 @@ module Spree def authorize!(return_url = nil) started_processing! - gateway_action(source, :authorize, :pend, return_url: return_url) + gateway_action(source, :authorize, :pend, return_url:) end def purchase! @@ -100,9 +100,9 @@ module Spree if response.success? self.class.create!( - order: order, + order:, source: self, - payment_method: payment_method, + payment_method:, amount: credit_amount.abs * -1, response_code: response.authorization, state: 'completed', @@ -139,9 +139,9 @@ module Spree if response.success? self.class.create!( - order: order, + order:, source: self, - payment_method: payment_method, + payment_method:, amount: refund_amount.abs * -1, response_code: response.authorization, state: 'completed', @@ -174,7 +174,7 @@ module Spree tax: order.additional_tax_total * 100, subtotal: order.item_total * 100, discount: 0, - currency: currency) + currency:) options.merge!({ billing_address: order.bill_address.try(:active_merchant_hash), shipping_address: order.ship_address.try(:active_merchant_hash) }) diff --git a/app/models/spree/preferences/store.rb b/app/models/spree/preferences/store.rb index 8ede8e3901..f952b94e33 100644 --- a/app/models/spree/preferences/store.rb +++ b/app/models/spree/preferences/store.rb @@ -25,7 +25,7 @@ module Spree def exist?(key) @cache.exist?(key) || - (should_persist? && Spree::Preference.where(key: key).exists?) + (should_persist? && Spree::Preference.where(key:).exists?) end def get(key, fallback = nil) @@ -39,7 +39,7 @@ module Spree # If it's not in the cache, maybe it's in the database, but has been cleared from the cache # does it exist in the database? if should_persist? && Spree::Preference.table_exists? - preference = Spree::Preference.find_by(key: key) + preference = Spree::Preference.find_by(key:) if preference # it does exist, so let's put it back into the cache @cache.write(preference.key, preference.value) diff --git a/app/models/spree/price.rb b/app/models/spree/price.rb index 34344f62f0..68d5caf306 100644 --- a/app/models/spree/price.rb +++ b/app/models/spree/price.rb @@ -17,7 +17,7 @@ module Spree alias :display_price :display_amount def money - Spree::Money.new(amount || 0, currency: currency) + Spree::Money.new(amount || 0, currency:) end def price diff --git a/app/models/spree/product.rb b/app/models/spree/product.rb index 652e9214e1..e7bf67a3d3 100755 --- a/app/models/spree/product.rb +++ b/app/models/spree/product.rb @@ -220,7 +220,7 @@ module Spree ActiveRecord::Base.transaction do property = Property.where(name: property_name).first_or_create!(presentation: property_name) product_property = ProductProperty.where(product: self, - property: property).first_or_initialize + property:).first_or_initialize product_property.value = property_value product_property.save! end diff --git a/app/models/spree/product_property.rb b/app/models/spree/product_property.rb index 6e7f46bdd8..653c446464 100644 --- a/app/models/spree/product_property.rb +++ b/app/models/spree/product_property.rb @@ -20,8 +20,8 @@ module Spree def property_name=(name) return if name.blank? - unless property = Property.find_by(name: name) - property = Property.create(name: name, presentation: name) + unless property = Property.find_by(name:) + property = Property.create(name:, presentation: name) end self.property = property end diff --git a/app/models/spree/return_authorization.rb b/app/models/spree/return_authorization.rb index 42b9349e6d..61a9e219ae 100644 --- a/app/models/spree/return_authorization.rb +++ b/app/models/spree/return_authorization.rb @@ -33,7 +33,7 @@ module Spree end def display_amount - Spree::Money.new(amount, currency: currency) + Spree::Money.new(amount, currency:) end def add_variant(variant_id, quantity) @@ -101,7 +101,7 @@ module Spree Adjustment.create( amount: -amount.abs, label: I18n.t('spree.rma_credit'), - order: order, + order:, adjustable: order, originator: self ) diff --git a/app/models/spree/shipment.rb b/app/models/spree/shipment.rb index f7428f2341..1f528bc4a8 100644 --- a/app/models/spree/shipment.rb +++ b/app/models/spree/shipment.rb @@ -92,7 +92,7 @@ module Spree end def add_shipping_method(shipping_method, selected = false) - shipping_rates.create(shipping_method: shipping_method, selected: selected) + shipping_rates.create(shipping_method:, selected:) end def selected_shipping_rate @@ -127,7 +127,7 @@ module Spree .exclude?(original_shipping_method_id) cost = estimator.calculate_cost(shipping_method, to_package) unless cost.nil? - original_shipping_rate = shipping_method.shipping_rates.new(cost: cost) + original_shipping_rate = shipping_method.shipping_rates.new(cost:) self.shipping_rates = distributor_shipping_rates + [original_shipping_rate] self.selected_shipping_rate_id = original_shipping_rate.id end @@ -167,7 +167,7 @@ module Spree end def display_cost - Spree::Money.new(cost, currency: currency) + Spree::Money.new(cost, currency:) end alias_method :display_amount, :display_cost @@ -177,7 +177,7 @@ module Spree end def display_item_cost - Spree::Money.new(item_cost, currency: currency) + Spree::Money.new(item_cost, currency:) end def update_amounts @@ -195,7 +195,7 @@ module Spree states = {} units.group_by(&:state).each { |state, iu| states[state] = iu.count } scoper.scope(variant) - OpenStruct.new(variant: variant, quantity: units.length, states: states) + OpenStruct.new(variant:, quantity: units.length, states:) end end @@ -268,7 +268,7 @@ module Spree end def set_up_inventory(state, variant, order) - inventory_units.create(variant_id: variant.id, state: state, order_id: order.id) + inventory_units.create(variant_id: variant.id, state:, order_id: order.id) end def fee_adjustment @@ -361,7 +361,7 @@ module Spree def send_shipped_email delivery = !!shipping_method.require_ship_address - ShipmentMailer.shipped_email(id, delivery: delivery).deliver_later + ShipmentMailer.shipped_email(id, delivery:).deliver_later end def update_adjustments diff --git a/app/models/spree/shipping_rate.rb b/app/models/spree/shipping_rate.rb index aef9a91b20..39f39af305 100644 --- a/app/models/spree/shipping_rate.rb +++ b/app/models/spree/shipping_rate.rb @@ -19,7 +19,7 @@ module Spree delegate :name, to: :shipping_method def display_price - Spree::Money.new(cost, { currency: currency }) + Spree::Money.new(cost, { currency: }) end alias_method :display_cost, :display_price diff --git a/app/models/spree/stock_location.rb b/app/models/spree/stock_location.rb index a3e7d588bf..e20cbd17ce 100644 --- a/app/models/spree/stock_location.rb +++ b/app/models/spree/stock_location.rb @@ -18,7 +18,7 @@ module Spree # Wrapper for creating a new stock item respecting the backorderable config def propagate_variant(variant) - stock_items.create!(variant: variant, backorderable: backorderable_default) + stock_items.create!(variant:, backorderable: backorderable_default) end def stock_item(variant) @@ -26,7 +26,7 @@ module Spree end def stock_item_or_create(variant) - stock_item(variant) || stock_items.create(variant: variant) + stock_item(variant) || stock_items.create(variant:) end def count_on_hand(variant) diff --git a/app/models/spree/tax_rate.rb b/app/models/spree/tax_rate.rb index f603db2c02..62dade25b1 100644 --- a/app/models/spree/tax_rate.rb +++ b/app/models/spree/tax_rate.rb @@ -95,10 +95,10 @@ module Spree adjustments.create!( adjustable: item, - amount: amount, - order: order, + amount:, + order:, label: create_label(amount), - included: included + included: ) end diff --git a/app/models/spree/taxonomy.rb b/app/models/spree/taxonomy.rb index 11364fda0c..50778e37cf 100644 --- a/app/models/spree/taxonomy.rb +++ b/app/models/spree/taxonomy.rb @@ -16,11 +16,11 @@ module Spree def set_name if root root.update_columns( - name: name, + name:, updated_at: Time.zone.now ) else - self.root = Taxon.create!(taxonomy_id: id, name: name) + self.root = Taxon.create!(taxonomy_id: id, name:) end end end diff --git a/app/models/spree/user.rb b/app/models/spree/user.rb index f1d929332e..6326dcd7d3 100644 --- a/app/models/spree/user.rb +++ b/app/models/spree/user.rb @@ -106,7 +106,7 @@ module Spree def build_enterprise_roles Enterprise.all.find_each do |enterprise| unless enterprise_roles.find_by enterprise_id: enterprise.id - enterprise_roles.build(enterprise: enterprise) + enterprise_roles.build(enterprise:) end end end @@ -130,7 +130,7 @@ module Spree end def associate_customers - self.customers = Customer.where(email: email) + self.customers = Customer.where(email:) end def associate_orders @@ -190,8 +190,8 @@ module Spree return unless owned_enterprises.size > enterprise_limit errors.add(:owned_enterprises, I18n.t(:spree_user_enterprise_limit_error, - email: email, - enterprise_limit: enterprise_limit)) + email:, + enterprise_limit:)) end def remove_payments_in_checkout(enterprises) diff --git a/app/models/spree/variant.rb b/app/models/spree/variant.rb index d8c52c1cbd..5e706c801e 100644 --- a/app/models/spree/variant.rb +++ b/app/models/spree/variant.rb @@ -193,7 +193,7 @@ module Spree def price_in(currency) prices.select{ |price| price.currency == currency }.first || - Spree::Price.new(variant_id: id, currency: currency) + Spree::Price.new(variant_id: id, currency:) end def amount_in(currency) diff --git a/app/models/stripe_account.rb b/app/models/stripe_account.rb index 76a4487dfd..a18d37b8ac 100644 --- a/app/models/stripe_account.rb +++ b/app/models/stripe_account.rb @@ -8,17 +8,17 @@ class StripeAccount < ApplicationRecord validates :enterprise_id, uniqueness: true def deauthorize_and_destroy - accounts = StripeAccount.where(stripe_user_id: stripe_user_id) + accounts = StripeAccount.where(stripe_user_id:) # Only deauthorize the user if it is not linked to multiple accounts return destroy if accounts.count > 1 - destroy && Stripe::OAuth.deauthorize(stripe_user_id: stripe_user_id) + destroy && Stripe::OAuth.deauthorize(stripe_user_id:) rescue Stripe::OAuth::OAuthError Bugsnag.notify( RuntimeError.new("StripeDeauthorizeFailure"), stripe_account: stripe_user_id, - enterprise_id: enterprise_id + enterprise_id: ) true end diff --git a/app/models/voucher.rb b/app/models/voucher.rb index 9ba6a95c3b..8b678efd33 100644 --- a/app/models/voucher.rb +++ b/app/models/voucher.rb @@ -30,8 +30,8 @@ class Voucher < ApplicationRecord adjustment_attributes = { amount: 0, originator: self, - order: order, - label: label, + order:, + label:, mandatory: false, state: "open", tax_category: nil diff --git a/app/reflexes/admin/orders_reflex.rb b/app/reflexes/admin/orders_reflex.rb index 311cab117f..0a9640147d 100644 --- a/app/reflexes/admin/orders_reflex.rb +++ b/app/reflexes/admin/orders_reflex.rb @@ -51,7 +51,7 @@ module Admin cancelled_orders.each do |order| cable_ready.replace( selector: dom_id(order), - html: render(partial: "spree/admin/orders/table_row", locals: { order: order }) + html: render(partial: "spree/admin/orders/table_row", locals: { order: }) ) end @@ -89,7 +89,7 @@ module Admin end def success(i18n_key, count) - flash[:success] = with_locale { I18n.t(i18n_key, count: count) } + flash[:success] = with_locale { I18n.t(i18n_key, count:) } cable_ready.dispatch_event(name: "modal:close") morph_admin_flashes end diff --git a/app/reflexes/invite_manager_reflex.rb b/app/reflexes/invite_manager_reflex.rb index b1bd4d04a2..2d7463cf3a 100644 --- a/app/reflexes/invite_manager_reflex.rb +++ b/app/reflexes/invite_manager_reflex.rb @@ -9,9 +9,9 @@ class InviteManagerReflex < ApplicationReflex authorize! :edit, enterprise - existing_user = Spree::User.find_by(email: email) + existing_user = Spree::User.find_by(email:) - locals = { error: nil, success: nil, email: email, enterprise: enterprise } + locals = { error: nil, success: nil, email:, enterprise: } if existing_user locals[:error] = I18n.t('admin.enterprises.invite_manager.user_already_exists') @@ -36,7 +36,7 @@ class InviteManagerReflex < ApplicationReflex def return_morph(locals) morph "#add_manager_modal", with_locale { - render(partial: "admin/enterprises/form/add_new_unregistered_manager", locals: locals) + render(partial: "admin/enterprises/form/add_new_unregistered_manager", locals:) } end end diff --git a/app/reflexes/white_label_reflex.rb b/app/reflexes/white_label_reflex.rb index 140079add6..44462c8449 100644 --- a/app/reflexes/white_label_reflex.rb +++ b/app/reflexes/white_label_reflex.rb @@ -13,7 +13,7 @@ class WhiteLabelReflex < ApplicationReflex html = with_locale { render(partial: "admin/enterprises/form/white_label", - locals: { f: f, enterprise: @enterprise }) + locals: { f:, enterprise: @enterprise }) } morph "#white_label_panel", html diff --git a/app/serializers/api/admin/enterprise_serializer.rb b/app/serializers/api/admin/enterprise_serializer.rb index 30c3d2045b..f189e57fd0 100644 --- a/app/serializers/api/admin/enterprise_serializer.rb +++ b/app/serializers/api/admin/enterprise_serializer.rb @@ -75,7 +75,7 @@ module Api return tag_group if tag_group[:tags].length == tags.length && (tag_group[:tags] & tags) == tag_group[:tags] end - { tags: tags, rules: [] } + { tags:, rules: [] } end private From 1fa0dc99fe89b51c64e290f7b27b455b3a891aca Mon Sep 17 00:00:00 2001 From: Neal Chambers Date: Wed, 13 Sep 2023 16:34:01 +0900 Subject: [PATCH 2/2] Update .rubocop_todo.yml --- .rubocop_todo.yml | 36 +++--------------------------------- 1 file changed, 3 insertions(+), 33 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 326b9fe003..f98d116826 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 1400 --no-auto-gen-timestamp` -# using RuboCop version 1.56.2. +# using RuboCop version 1.56.3. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -770,7 +770,7 @@ Security/Open: Exclude: - 'app/services/image_importer.rb' -# Offense count: 11 +# Offense count: 9 # This cop supports unsafe autocorrection (--autocorrect-all). Style/ArrayIntersect: Exclude: @@ -873,43 +873,13 @@ Style/HashLikeCase: Exclude: - 'app/models/enterprise.rb' -# Offense count: 1715 +# Offense count: 1563 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys # SupportedShorthandSyntax: always, never, either, consistent Style/HashSyntax: Exclude: - - 'app/models/spree/adjustment.rb' - - 'app/models/spree/credit_card.rb' - - 'app/models/spree/gateway/pay_pal_express.rb' - - 'app/models/spree/gateway/stripe_sca.rb' - - 'app/models/spree/inventory_unit.rb' - - 'app/models/spree/item_adjustments.rb' - - 'app/models/spree/line_item.rb' - - 'app/models/spree/order.rb' - - 'app/models/spree/order/checkout.rb' - - 'app/models/spree/order_contents.rb' - - 'app/models/spree/payment.rb' - - 'app/models/spree/payment/processing.rb' - - 'app/models/spree/preferences/store.rb' - - 'app/models/spree/price.rb' - - 'app/models/spree/product.rb' - - 'app/models/spree/product_property.rb' - - 'app/models/spree/return_authorization.rb' - - 'app/models/spree/shipment.rb' - - 'app/models/spree/shipping_rate.rb' - - 'app/models/spree/stock_location.rb' - - 'app/models/spree/tax_rate.rb' - - 'app/models/spree/taxonomy.rb' - - 'app/models/spree/user.rb' - - 'app/models/spree/variant.rb' - - 'app/models/stripe_account.rb' - - 'app/models/voucher.rb' - - 'app/reflexes/admin/orders_reflex.rb' - - 'app/reflexes/invite_manager_reflex.rb' - - 'app/reflexes/white_label_reflex.rb' - - 'app/serializers/api/admin/enterprise_serializer.rb' - 'app/services/address_geocoder.rb' - 'app/services/customer_syncer.rb' - 'app/services/exchange_variant_bulk_updater.rb'