From 64d25b2999ec23a3e3a729446ae565169292bb1a Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Mon, 6 Dec 2021 16:31:30 +1100 Subject: [PATCH 1/4] Remove dead code highlighted by Rubocop The assignments here didn't actually do anything and `number` was restricted to numbers only already. No whitespace to remove. --- app/models/spree/credit_card.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/models/spree/credit_card.rb b/app/models/spree/credit_card.rb index 1145cb06d2..2afd96891b 100644 --- a/app/models/spree/credit_card.rb +++ b/app/models/spree/credit_card.rb @@ -56,8 +56,6 @@ module Spree end def set_last_digits - number = @number.to_s.gsub(/\s/, '') - verification_value = verification_value.to_s.gsub(/\s/, '') self.last_digits ||= number.to_s.length <= 4 ? number : number.to_s.slice(-4..-1) end From 207cc8908a47eff6b85a740ddbba8f0e5a485b4d Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Mon, 6 Dec 2021 16:36:38 +1100 Subject: [PATCH 2/4] Remove useless assignments Rubocop highlighted this. The todo list actually contains these files but somehow the cop still runs and reports these as violations. --- app/models/spree/taxon.rb | 2 +- lib/spree/core/controller_helpers/common.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/spree/taxon.rb b/app/models/spree/taxon.rb index f17bb48f97..81b9f8e824 100644 --- a/app/models/spree/taxon.rb +++ b/app/models/spree/taxon.rb @@ -56,7 +56,7 @@ module Spree def pretty_name ancestor_chain = ancestors.inject("") do |name, ancestor| - name += "#{ancestor.name} -> " + name + "#{ancestor.name} -> " end ancestor_chain + name.to_s end diff --git a/lib/spree/core/controller_helpers/common.rb b/lib/spree/core/controller_helpers/common.rb index 27684873b4..28090659b6 100644 --- a/lib/spree/core/controller_helpers/common.rb +++ b/lib/spree/core/controller_helpers/common.rb @@ -66,7 +66,7 @@ module Spree # The layout to render can be set inside Spree configuration with the +:layout+ option. # Default layout is: +app/views/spree/layouts/spree_application+ def get_layout - layout ||= Spree::Config[:layout] + Spree::Config[:layout] end end end From faf0a3ab844332c61f6b986470ca99a31280c357 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Mon, 6 Dec 2021 16:39:11 +1100 Subject: [PATCH 3/4] Remove unnecessary disabling of cop --- .../orders_and_fulfillments_report/customer_totals_report.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/open_food_network/orders_and_fulfillments_report/customer_totals_report.rb b/lib/open_food_network/orders_and_fulfillments_report/customer_totals_report.rb index 256c21c27d..f012c25cd9 100644 --- a/lib/open_food_network/orders_and_fulfillments_report/customer_totals_report.rb +++ b/lib/open_food_network/orders_and_fulfillments_report/customer_totals_report.rb @@ -119,7 +119,6 @@ module OpenFoodNetwork # rubocop:enable Metrics/MethodLength # rubocop:disable Metrics/AbcSize - # rubocop:disable Metrics/CyclomaticComplexity # rubocop:disable Metrics/MethodLength # rubocop:disable Metrics/PerceivedComplexity def columns @@ -199,7 +198,6 @@ module OpenFoodNetwork ] end # rubocop:enable Metrics/AbcSize - # rubocop:enable Metrics/CyclomaticComplexity # rubocop:enable Metrics/MethodLength # rubocop:enable Metrics/PerceivedComplexity From 67aa3447da6984f263bc09dcdc4ccf55a2be7123 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Mon, 6 Dec 2021 11:58:22 +1100 Subject: [PATCH 4/4] Automatically regenerate style todo list We used to keep a manual file for metrics violations because the automatic file didn't exclude on a file-by-file basis. But Rubocop has an additional option these days so that we can generate that automatically in the normal todo list. The todo list was also out of date. --- .rubocop.yml | 3 - .rubocop_manual_todo.yml | 776 ----------------------------- .rubocop_todo.yml | 1008 +++++++++++++++++++++++++++++++++++--- 3 files changed, 950 insertions(+), 837 deletions(-) delete mode 100644 .rubocop_manual_todo.yml diff --git a/.rubocop.yml b/.rubocop.yml index f779f8efde..2d06208942 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -16,6 +16,3 @@ inherit_from: # bundle exec rubocop -c .rubocop_styleguide.yml # - .rubocop_styleguide.yml - - # A manually compiled todo list to ignore metrics violations on a file-by-file basis. - - .rubocop_manual_todo.yml diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml deleted file mode 100644 index 6e2e25cc86..0000000000 --- a/.rubocop_manual_todo.yml +++ /dev/null @@ -1,776 +0,0 @@ -# A manually compiled todo list to ignore metrics violations on a file-by-file basis. -# -# The file .rubocop_todo.yml is generated automatically and contains a -# configuration to make all files pass. For a lot of cops it just lists -# the offending files. But for metrics cops it sets a different metric. -# -# Since we don't want these lax metrics, we override them in our config -# file .rubocop.yml which results in a lot of offences again. This file -# lists all offending files for each cop to make rubocop pass. We can -# improve the code over time and remove items from the list. -# -# This file was manually created by using the following tools: -# -# rubocop > rubo.log -# # inspect log file to see which cops are failing -# # copy cop configurations and add Exclude parameter -# grep ExampleCop rubo.log | cut -d ":" -f 1 | sort -u | while read f; do echo " - $f"; done >> .rubocop.yml -# -# This process probably doesn't need repeating. Otherwise there is plenty -# of room for improvements and automation. - -Layout/LineLength: - Max: 100 - Exclude: - - app/controllers/admin/bulk_line_items_controller.rb - - app/controllers/admin/enterprise_fees_controller.rb - - app/controllers/admin/enterprise_relationships_controller.rb - - app/controllers/admin/enterprises_controller.rb - - app/controllers/admin/product_import_controller.rb - - app/controllers/admin/schedules_controller.rb - - app/controllers/admin/subscriptions_controller.rb - - app/controllers/api/v0/order_cycles_controller.rb - - app/controllers/spree/paypal_controller.rb - - app/helpers/angular_form_builder.rb - - app/helpers/angular_form_helper.rb - - app/helpers/enterprises_helper.rb - - app/helpers/order_cycles_helper.rb - - app/helpers/spree/orders_helper.rb - - app/jobs/subscription_confirm_job.rb - - app/mailers/subscription_mailer.rb - - app/models/column_preference.rb - - app/models/concerns/order_shipment.rb - - app/models/concerns/product_stock.rb - - app/models/concerns/variant_stock.rb - - app/models/customer.rb - - app/models/enterprise_group.rb - - app/models/product_import/entry_processor.rb - - app/models/product_import/spreadsheet_entry.rb - - app/models/product_import/unit_converter.rb - - app/models/proxy_order.rb - - app/models/schedule.rb - - app/models/spree/app_configuration.rb - - app/models/spree/image.rb - - app/models/spree/line_item.rb - - app/models/spree/order.rb - - app/models/spree/payment_method.rb - - app/models/spree/preferences/store.rb - - app/models/subscription.rb - - app/models/variant_override.rb - - app/serializers/api/admin/subscription_line_item_serializer.rb - - app/serializers/api/admin/subscription_serializer.rb - - app/services/cart_service.rb - - app/services/checkout/post_checkout_actions.rb - - app/services/embedded_page_service.rb - - app/services/order_cycle_form.rb - - app/services/order_syncer.rb - - app/services/variant_units/variant_and_line_item_naming.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - - engines/order_management/app/services/order_management/subscriptions/validator.rb - - engines/order_management/spec/services/order_management/order/stripe_sca_payment_authorize_spec.rb - - engines/order_management/spec/services/order_management/order/updater_spec.rb - - engines/web/app/helpers/web/cookies_policy_helper.rb - - engines/web/spec/features/consumer/cookies_spec.rb - - lib/discourse/single_sign_on.rb - - lib/open_food_network/enterprise_fee_applicator.rb - - lib/open_food_network/enterprise_fee_calculator.rb - - lib/open_food_network/enterprise_issue_validator.rb - - lib/open_food_network/lettuce_share_report.rb - - lib/open_food_network/order_cycle_form_applicator.rb - - lib/open_food_network/order_cycle_management_report.rb - - lib/open_food_network/order_cycle_permissions.rb - - lib/open_food_network/payments_report.rb - - lib/open_food_network/reports/line_items.rb - - lib/open_food_network/sales_tax_report.rb - - lib/open_food_network/scope_variants_for_search.rb - - lib/open_food_network/xero_invoices_report.rb - - lib/spree/core/calculated_adjustments.rb - - lib/spree/localized_number.rb - - lib/tasks/data.rake - - lib/tasks/enterprises.rake - - spec/controllers/admin/bulk_line_items_controller_spec.rb - - spec/controllers/admin/column_preferences_controller_spec.rb - - spec/controllers/admin/enterprises_controller_spec.rb - - spec/controllers/admin/manager_invitations_controller_spec.rb - - spec/controllers/admin/order_cycles_controller_spec.rb - - spec/controllers/admin/schedules_controller_spec.rb - - spec/controllers/admin/stripe_accounts_controller_spec.rb - - spec/controllers/admin/stripe_connect_settings_controller_spec.rb - - spec/controllers/admin/subscription_line_items_controller_spec.rb - - spec/controllers/admin/subscriptions_controller_spec.rb - - spec/controllers/admin/variant_overrides_controller_spec.rb - - spec/controllers/api/v0/base_controller_spec.rb - - spec/controllers/api/v0/enterprises_controller_spec.rb - - spec/controllers/api/v0/exchange_products_controller_spec.rb - - spec/controllers/api/v0/logos_controller_spec.rb - - spec/controllers/api/v0/order_cycles_controller_spec.rb - - spec/controllers/api/v0/orders_controller_spec.rb - - spec/controllers/api/v0/product_images_controller_spec.rb - - spec/controllers/api/v0/products_controller_spec.rb - - spec/controllers/api/v0/promo_images_controller_spec.rb - - spec/controllers/api/v0/terms_and_conditions_controller_spec.rb - - spec/controllers/cart_controller_spec.rb - - spec/controllers/checkout_controller_spec.rb - - spec/controllers/enterprises_controller_spec.rb - - spec/controllers/line_items_controller_spec.rb - - spec/controllers/shops_controller_spec.rb - - spec/controllers/spree/admin/adjustments_controller_spec.rb - - spec/controllers/spree/admin/orders_controller_spec.rb - - spec/controllers/spree/admin/orders/customer_details_controller_spec.rb - - spec/controllers/spree/admin/orders/invoices_spec.rb - - spec/controllers/spree/admin/payment_methods_controller_spec.rb - - spec/controllers/spree/admin/reports_controller_spec.rb - - spec/controllers/spree/admin/variants_controller_spec.rb - - spec/controllers/spree/credit_cards_controller_spec.rb - - spec/controllers/spree/orders_controller_spec.rb - - spec/controllers/stripe/callbacks_controller_spec.rb - - spec/controllers/stripe/webhooks_controller_spec.rb - - spec/controllers/user_confirmations_controller_spec.rb - - spec/factories/stock_location_factory.rb - - spec/features/admin/adjustments_spec.rb - - spec/features/admin/bulk_order_management_spec.rb - - spec/features/admin/bulk_product_update_spec.rb - - spec/features/admin/configuration/content_spec.rb - - spec/features/admin/customers_spec.rb - - spec/features/admin/enterprise_fees_spec.rb - - spec/features/admin/enterprise_relationships_spec.rb - - spec/features/admin/enterprises/images_spec.rb - - spec/features/admin/enterprises/index_spec.rb - - spec/features/admin/enterprises_spec.rb - - spec/features/admin/multilingual_spec.rb - - spec/features/admin/order_cycles/complex_editing_multiple_product_pages_spec.rb - - spec/features/admin/order_cycles/complex_editing_spec.rb - - spec/features/admin/order_cycles/complex_updating_specific_time_spec.rb - - spec/features/admin/order_cycles/list_spec.rb - - spec/features/admin/order_cycles/simple_spec.rb - - spec/features/admin/order_spec.rb - - spec/features/admin/overview_spec.rb - - spec/features/admin/payment_method_spec.rb - - spec/features/admin/payments_stripe_spec.rb - - spec/features/admin/product_import_spec.rb - - spec/features/admin/products_spec.rb - - spec/features/admin/reports_spec.rb - - spec/features/admin/schedules_spec.rb - - spec/features/admin/shipping_methods_spec.rb - - spec/features/admin/subscriptions_spec.rb - - spec/features/admin/tag_rules_spec.rb - - spec/features/admin/users_spec.rb - - spec/features/admin/variant_overrides_spec.rb - - spec/features/consumer/authentication_spec.rb - - spec/features/consumer/caching/shops_caching_spec.rb - - spec/features/consumer/multilingual_spec.rb - - spec/features/consumer/shopping/cart_spec.rb - - spec/features/consumer/shopping/checkout_auth_spec.rb - - spec/features/consumer/shopping/checkout_spec.rb - - spec/features/consumer/shopping/checkout_stripe_spec.rb - - spec/features/consumer/shopping/embedded_shopfronts_spec.rb - - spec/features/consumer/shopping/products_spec.rb - - spec/features/consumer/shopping/shopping_spec.rb - - spec/features/consumer/shopping/unit_price_spec.rb - - spec/features/consumer/shopping/variant_overrides_spec.rb - - spec/features/consumer/shops_spec.rb - - spec/helpers/enterprises_helper_spec.rb - - spec/helpers/injection_helper_spec.rb - - spec/helpers/order_cycles_helper_spec.rb - - spec/helpers/spree/admin/base_helper_spec.rb - - spec/jobs/subscription_confirm_job_spec.rb - - spec/jobs/subscription_placement_job_spec.rb - - spec/lib/open_food_network/customers_report_spec.rb - - spec/lib/open_food_network/enterprise_fee_calculator_spec.rb - - spec/lib/open_food_network/group_buy_report_spec.rb - - spec/lib/open_food_network/order_cycle_form_applicator_spec.rb - - spec/lib/open_food_network/order_cycle_management_report_spec.rb - - spec/lib/open_food_network/order_cycle_permissions_spec.rb - - spec/lib/open_food_network/order_grouper_spec.rb - - spec/lib/open_food_network/permissions_spec.rb - - spec/lib/open_food_network/products_and_inventory_report_spec.rb - - spec/lib/open_food_network/scope_variant_to_hub_spec.rb - - spec/lib/open_food_network/tag_rule_applicator_spec.rb - - spec/lib/open_food_network/users_and_enterprises_report_spec.rb - - spec/lib/spree/core/calculated_adjustments_spec.rb - - spec/lib/stripe/authorize_response_patcher_spec.rb - - spec/mailers/order_mailer_spec.rb - - spec/mailers/subscription_mailer_spec.rb - - spec/models/concerns/order_shipment_spec.rb - - spec/models/concerns/product_stock_spec.rb - - spec/models/enterprise_group_spec.rb - - spec/models/enterprise_relationship_spec.rb - - spec/models/enterprise_spec.rb - - spec/models/exchange_spec.rb - - spec/models/order_cycle_spec.rb - - spec/models/product_importer_spec.rb - - spec/models/spree/ability_spec.rb - - spec/models/spree/address_spec.rb - - spec/models/spree/adjustment_spec.rb - - spec/models/spree/classification_spec.rb - - spec/models/spree/gateway/stripe_connect_spec.rb - - spec/models/spree/inventory_unit_spec.rb - - spec/models/spree/line_item_spec.rb - - spec/models/spree/order/checkout_spec.rb - - spec/models/spree/order_inventory_spec.rb - - spec/models/spree/order_spec.rb - - spec/models/spree/payment_method_spec.rb - - spec/models/spree/payment_spec.rb - - spec/models/spree/product_spec.rb - - spec/models/spree/shipping_method_spec.rb - - spec/models/spree/tax_rate_spec.rb - - spec/models/spree/user_spec.rb - - spec/models/spree/variant_spec.rb - - spec/models/tag_rule/filter_order_cycles_spec.rb - - spec/models/tag_rule/filter_payment_methods_spec.rb - - spec/models/tag_rule/filter_products_spec.rb - - spec/models/tag_rule/filter_shipping_methods_spec.rb - - spec/models/terms_of_service_file_spec.rb - - spec/models/variant_override_spec.rb - - spec/requests/api/orders_spec.rb - - spec/requests/checkout/failed_checkout_spec.rb - - spec/requests/embedded_shopfronts_headers_spec.rb - - spec/serializers/api/admin/exchange_serializer_spec.rb - - spec/serializers/api/admin/order_cycle_serializer_spec.rb - - spec/services/address_geocoder_spec.rb - - spec/services/cart_service_spec.rb - - spec/services/checkout/form_data_adapter_spec.rb - - spec/services/checkout/post_checkout_actions_spec.rb - - spec/services/content_sanitizer_spec.rb - - spec/services/embedded_page_service_spec.rb - - spec/services/exchange_products_renderer_spec.rb - - spec/services/order_cycle_distributed_variants_spec.rb - - spec/services/order_syncer_spec.rb - - spec/services/paypal_items_builder_spec.rb - - spec/services/permissions/order_spec.rb - - spec/services/permitted_attributes/order_cycle_spec.rb - - spec/services/products_renderer_spec.rb - - spec/services/product_tag_rules_filterer_spec.rb - - spec/support/cancan_helper.rb - - spec/support/features/datepicker_helper.rb - - spec/support/matchers/select2_matchers.rb - - spec/support/matchers/table_matchers.rb - - spec/support/request/stripe_stubs.rb - - spec/support/request/web_helper.rb - - spec/swagger_helper.rb - - spec/views/spree/admin/payment_methods/index.html.haml_spec.rb - -Metrics/AbcSize: - Max: 15 - Exclude: - - app/controllers/admin/bulk_line_items_controller.rb - - app/controllers/admin/customers_controller.rb - - app/controllers/admin/enterprise_fees_controller.rb - - app/controllers/admin/enterprises_controller.rb - - app/controllers/admin/order_cycles_controller.rb - - app/controllers/admin/product_import_controller.rb - - app/controllers/admin/resource_controller.rb - - app/controllers/admin/schedules_controller.rb - - app/controllers/admin/stripe_accounts_controller.rb - - app/controllers/admin/subscription_line_items_controller.rb - - app/controllers/admin/subscriptions_controller.rb - - app/controllers/api/v0/enterprises_controller.rb - - app/controllers/api/v0/product_images_controller.rb - - app/controllers/api/v0/products_controller.rb - - app/controllers/api/v0/shipments_controller.rb - - app/controllers/api/v0/taxons_controller.rb - - app/controllers/api/v0/variants_controller.rb - - app/controllers/checkout_controller.rb - - app/controllers/discourse_sso_controller.rb - - app/controllers/enterprises_controller.rb - - app/controllers/spree/admin/adjustments_controller.rb - - app/controllers/spree/admin/general_settings_controller.rb - - app/controllers/spree/admin/images_controller.rb - - app/controllers/spree/admin/mail_methods_controller.rb - - app/controllers/spree/admin/orders_controller.rb - - app/controllers/spree/admin/orders/customer_details_controller.rb - - app/controllers/spree/admin/overview_controller.rb - - app/controllers/spree/admin/payment_methods_controller.rb - - app/controllers/spree/admin/payments_controller.rb - - app/controllers/spree/admin/products_controller.rb - - app/controllers/spree/admin/reports_controller.rb - - app/controllers/spree/admin/search_controller.rb - - app/controllers/spree/admin/shipping_methods_controller.rb - - app/controllers/spree/admin/taxons_controller.rb - - app/controllers/spree/admin/users_controller.rb - - app/controllers/spree/admin/variants_controller.rb - - app/controllers/spree/credit_cards_controller.rb - - app/controllers/spree/orders_controller.rb - - app/controllers/spree/paypal_controller.rb - - app/controllers/spree/user_passwords_controller.rb - - app/controllers/spree/users_controller.rb - - app/controllers/spree/user_sessions_controller.rb - - app/controllers/stripe/callbacks_controller.rb - - app/controllers/user_confirmations_controller.rb - - app/controllers/user_passwords_controller.rb - - app/controllers/user_registrations_controller.rb - - app/helpers/checkout_helper.rb - - app/helpers/order_cycles_helper.rb - - app/helpers/spree/admin/base_helper.rb - - app/helpers/spree/admin/navigation_helper.rb - - app/helpers/spree/admin/zones_helper.rb - - app/helpers/spree/base_helper.rb - - app/helpers/spree/orders_helper.rb - - app/mailers/spree/order_mailer.rb - - app/models/calculator/flat_percent_per_item.rb - - app/models/column_preference.rb - - app/models/enterprise_group.rb - - app/models/enterprise.rb - - app/models/enterprise_relationship.rb - - app/models/order_cycle.rb - - app/models/product_import/entry_processor.rb - - app/models/product_import/entry_validator.rb - - app/models/product_import/product_importer.rb - - app/models/product_import/unit_converter.rb - - app/models/proxy_order.rb - - app/models/spree/ability.rb - - app/models/spree/address.rb - - app/models/spree/gateway/pay_pal_express.rb - - app/models/spree/item_adjustments.rb - - app/models/spree/line_item.rb - - app/models/spree/order/checkout.rb - - app/models/spree/order_inventory.rb - - app/models/spree/order.rb - - app/models/spree/payment/processing.rb - - app/models/spree/payment.rb - - app/models/spree/preference.rb - - app/models/spree/preferences/preferable_class_methods.rb - - app/models/spree/preferences/preferable.rb - - app/models/spree/product.rb - - app/models/spree/return_authorization.rb - - app/models/spree/shipment.rb - - app/models/spree/taxon.rb - - app/models/spree/tax_rate.rb - - app/models/spree/variant.rb - - app/models/spree/zone.rb - - app/serializers/api/admin/enterprise_serializer.rb - - app/serializers/api/variant_serializer.rb - - app/services/cap_quantity.rb - - app/services/cart_service.rb - - app/services/create_order_cycle.rb - - app/services/order_cycle_form.rb - - app/services/order_factory.rb - - app/services/order_syncer.rb - - app/services/place_proxy_order.rb - - app/services/process_payment_intent.rb - - app/services/sets/model_set.rb - - app/services/variants_stock_levels.rb - - app/services/variant_units/option_value_namer.rb - - app/services/variant_units/variant_and_line_item_naming.rb - - engines/order_management/app/services/order_management/order/updater.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - - engines/order_management/app/services/order_management/stock/estimator.rb - - engines/order_management/app/services/order_management/stock/package.rb - - engines/order_management/app/services/order_management/stock/packer.rb - - engines/order_management/app/services/order_management/subscriptions/form.rb - - engines/order_management/app/services/order_management/subscriptions/validator.rb - - lib/active_merchant/billing/gateways/stripe_payment_intents.rb - - lib/discourse/single_sign_on.rb - - lib/open_food_network/customers_report.rb - - lib/open_food_network/enterprise_fee_calculator.rb - - lib/open_food_network/enterprise_issue_validator.rb - - lib/open_food_network/group_buy_report.rb - - lib/open_food_network/lettuce_share_report.rb - - lib/open_food_network/order_and_distributor_report.rb - - lib/open_food_network/order_cycle_form_applicator.rb - - lib/open_food_network/order_cycle_management_report.rb - - lib/open_food_network/order_cycle_permissions.rb - - lib/open_food_network/order_grouper.rb - - lib/open_food_network/orders_and_fulfillments_report/supplier_totals_report.rb - - lib/open_food_network/packing_report.rb - - lib/open_food_network/payments_report.rb - - lib/open_food_network/permissions.rb - - lib/open_food_network/products_and_inventory_report.rb - - lib/open_food_network/reports/line_items.rb - - lib/open_food_network/sales_tax_report.rb - - lib/open_food_network/users_and_enterprises_report.rb - - lib/open_food_network/xero_invoices_report.rb - - lib/spree/api/controller_setup.rb - - lib/spree/core/calculated_adjustments.rb - - lib/spree/core/controller_helpers/auth.rb - - lib/spree/core/controller_helpers/common.rb - - lib/spree/core/controller_helpers/order.rb - - lib/spree/core/controller_helpers/respond_with.rb - - lib/spree/core/delegate_belongs_to.rb - - lib/spree/core/permalinks.rb - - lib/spree/core/product_duplicator.rb - - lib/spree/core/s3_support.rb - - lib/spree/localized_number.rb - - lib/stripe/account_connector.rb - - lib/stripe/authorize_response_patcher.rb - - lib/stripe/profile_storer.rb - - lib/tasks/enterprises.rake - - lib/tasks/sample_data/order_factory.rb - - lib/tasks/sample_data/product_factory.rb - - spec/features/admin/product_import_spec.rb - - spec/features/admin/reports_spec.rb - - spec/features/admin/subscriptions_spec.rb - - spec/features/consumer/shopping/shopping_spec.rb - - spec/features/consumer/shopping/variant_overrides_spec.rb - - spec/models/enterprise_spec.rb - - spec/models/product_importer_spec.rb - - spec/services/order_checkout_restart_spec.rb - - spec/support/i18n_translations_checker.rb - - spec/support/performance_helper.rb - - spec/support/request/web_helper.rb - -Metrics/BlockLength: - Max: 25 - IgnoredMethods: [ - "class_eval", - "collection", - "context", - "describe", - "feature", - "it", - "member", - "namespace", - "resource", - "resources", - "scenario" - ] - Exclude: - - app/models/spree/order/checkout.rb - - app/models/spree/payment/processing.rb - - app/models/spree/payment.rb - - app/models/spree/shipment.rb - - lib/spree/core/controller_helpers/common.rb - - lib/tasks/data.rake - - spec/factories/address_factory.rb - - spec/factories/enterprise_factory.rb - - spec/factories/line_item_factory.rb - - spec/factories/order_cycle_factory.rb - - spec/factories/order_factory.rb - - spec/factories/payment_method_factory.rb - - spec/factories/product_factory.rb - - spec/factories.rb - - spec/factories/shipment_factory.rb - - spec/factories/shipping_method_factory.rb - - spec/factories/subscription_factory.rb - - spec/factories/user_factory.rb - - spec/factories/variant_factory.rb - - spec/features/admin/order_cycles/complex_updating_specific_time_spec.rb - - spec/features/consumer/shopping/checkout_spec.rb - - spec/features/consumer/shopping/embedded_shopfronts_spec.rb - - spec/lib/open_food_network/group_buy_report_spec.rb - - spec/requests/api/orders_spec.rb - - spec/spec_helper.rb - - spec/support/cancan_helper.rb - - spec/support/matchers/select2_matchers.rb - - spec/support/matchers/table_matchers.rb - - spec/swagger_helper.rb - -Metrics/CyclomaticComplexity: - Max: 6 - Exclude: - - app/controllers/admin/enterprise_fees_controller.rb - - app/controllers/admin/enterprises_controller.rb - - app/controllers/spree/admin/orders_controller.rb - - app/controllers/spree/admin/payment_methods_controller.rb - - app/controllers/spree/admin/payments_controller.rb - - app/controllers/spree/admin/products_controller.rb - - app/controllers/spree/admin/taxons_controller.rb - - app/controllers/spree/admin/users_controller.rb - - app/controllers/spree/orders_controller.rb - - app/helpers/checkout_helper.rb - - app/helpers/order_cycles_helper.rb - - app/helpers/spree/admin/base_helper.rb - - app/helpers/spree/admin/navigation_helper.rb - - app/models/enterprise.rb - - app/models/enterprise_relationship.rb - - app/models/product_import/entry_validator.rb - - app/models/spree/ability.rb - - app/models/spree/address.rb - - app/models/spree/order/checkout.rb - - app/models/spree/order_inventory.rb - - app/models/spree/payment.rb - - app/models/spree/preference.rb - - app/models/spree/preferences/preferable_class_methods.rb - - app/models/spree/preferences/preferable.rb - - app/models/spree/product.rb - - app/models/spree/return_authorization.rb - - app/models/spree/shipment.rb - - app/models/spree/tax_rate.rb - - app/models/spree/variant.rb - - app/models/spree/zone.rb - - app/services/cart_service.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - - engines/order_management/app/services/order_management/reports/enterprise_fee_summary/parameters.rb - - engines/order_management/app/services/order_management/stock/estimator.rb - - lib/active_merchant/billing/gateways/stripe_payment_intents.rb - - lib/discourse/single_sign_on.rb - - lib/open_food_network/enterprise_issue_validator.rb - - lib/open_food_network/group_buy_report.rb - - lib/open_food_network/order_cycle_form_applicator.rb - - lib/open_food_network/order_cycle_permissions.rb - - lib/open_food_network/payments_report.rb - - lib/spree/core/calculated_adjustments.rb - - lib/spree/core/controller_helpers/common.rb - - lib/spree/core/controller_helpers/order.rb - - lib/spree/core/controller_helpers/respond_with.rb - - lib/spree/localized_number.rb - - lib/stripe/authorize_response_patcher.rb - - lib/stripe/credit_card_clone_destroyer.rb - - spec/models/product_importer_spec.rb - - spec/support/i18n_translations_checker.rb - -Metrics/PerceivedComplexity: - Max: 7 - Exclude: - - app/controllers/admin/enterprises_controller.rb - - app/controllers/api/v0/variants_controller.rb - - app/controllers/spree/admin/orders_controller.rb - - app/controllers/spree/admin/payment_methods_controller.rb - - app/controllers/spree/admin/payments_controller.rb - - app/controllers/spree/admin/taxons_controller.rb - - app/controllers/spree/admin/users_controller.rb - - app/controllers/spree/orders_controller.rb - - app/helpers/checkout_helper.rb - - app/helpers/order_cycles_helper.rb - - app/helpers/spree/admin/navigation_helper.rb - - app/models/enterprise_relationship.rb - - app/models/product_import/entry_validator.rb - - app/models/spree/ability.rb - - app/models/spree/address.rb - - app/models/spree/order/checkout.rb - - app/models/spree/order_inventory.rb - - app/models/spree/preferences/preferable_class_methods.rb - - app/models/spree/preferences/preferable.rb - - app/models/spree/product.rb - - app/models/spree/return_authorization.rb - - app/models/spree/tax_rate.rb - - app/models/spree/variant.rb - - app/models/spree/zone.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - - engines/order_management/app/services/order_management/stock/estimator.rb - - lib/active_merchant/billing/gateways/stripe_payment_intents.rb - - lib/discourse/single_sign_on.rb - - lib/open_food_network/enterprise_issue_validator.rb - - lib/open_food_network/group_buy_report.rb - - lib/open_food_network/order_cycle_form_applicator.rb - - lib/open_food_network/order_cycle_permissions.rb - - lib/open_food_network/payments_report.rb - - lib/spree/core/calculated_adjustments.rb - - lib/spree/core/controller_helpers/order.rb - - lib/spree/core/controller_helpers/respond_with.rb - - lib/spree/localized_number.rb - - spec/models/product_importer_spec.rb - -Metrics/MethodLength: - Max: 10 - Exclude: - - app/controllers/admin/bulk_line_items_controller.rb - - app/controllers/admin/contents_controller.rb - - app/controllers/admin/customers_controller.rb - - app/controllers/admin/enterprise_fees_controller.rb - - app/controllers/admin/enterprises_controller.rb - - app/controllers/admin/manager_invitations_controller.rb - - app/controllers/admin/order_cycles_controller.rb - - app/controllers/admin/resource_controller.rb - - app/controllers/admin/stripe_accounts_controller.rb - - app/controllers/admin/subscriptions_controller.rb - - app/controllers/api/v0/product_images_controller.rb - - app/controllers/api/v0/products_controller.rb - - app/controllers/api/v0/shipments_controller.rb - - app/controllers/api/v0/taxons_controller.rb - - app/controllers/api/v0/variants_controller.rb - - app/controllers/shop_controller.rb - - app/controllers/spree/admin/orders_controller.rb - - app/controllers/spree/admin/orders/customer_details_controller.rb - - app/controllers/spree/admin/payment_methods_controller.rb - - app/controllers/spree/admin/payments_controller.rb - - app/controllers/spree/admin/products_controller.rb - - app/controllers/spree/admin/reports_controller.rb - - app/controllers/spree/admin/tax_categories_controller.rb - - app/controllers/spree/admin/taxons_controller.rb - - app/controllers/spree/admin/users_controller.rb - - app/controllers/spree/admin/variants_controller.rb - - app/controllers/spree/credit_cards_controller.rb - - app/controllers/spree/orders_controller.rb - - app/controllers/spree/paypal_controller.rb - - app/controllers/spree/user_sessions_controller.rb - - app/controllers/stripe/callbacks_controller.rb - - app/controllers/user_confirmations_controller.rb - - app/controllers/user_passwords_controller.rb - - app/controllers/user_registrations_controller.rb - - app/helpers/checkout_helper.rb - - app/helpers/order_cycles_helper.rb - - app/helpers/spree/admin/base_helper.rb - - app/helpers/spree/admin/navigation_helper.rb - - app/mailers/producer_mailer.rb - - app/models/calculator/default_tax.rb - - app/models/column_preference.rb - - app/models/enterprise.rb - - app/models/enterprise_relationship.rb - - app/models/preference_sections/footer_and_external_links_section.rb - - app/models/preference_sections/main_links_section.rb - - app/models/product_import/entry_processor.rb - - app/models/product_import/entry_validator.rb - - app/models/product_import/product_importer.rb - - app/models/spree/ability.rb - - app/models/spree/address.rb - - app/models/spree/credit_card.rb - - app/models/spree/gateway/pay_pal_express.rb - - app/models/spree/order/checkout.rb - - app/models/spree/order_contents.rb - - app/models/spree/order_inventory.rb - - app/models/spree/order.rb - - app/models/spree/payment/processing.rb - - app/models/spree/preference.rb - - app/models/spree/preferences/preferable_class_methods.rb - - app/models/spree/preferences/preferable.rb - - app/models/spree/preferences/store.rb - - app/models/spree/product.rb - - app/models/spree/return_authorization.rb - - app/models/spree/shipment.rb - - app/models/spree/taxon.rb - - app/models/spree/tax_rate.rb - - app/models/spree/zone.rb - - app/serializers/api/admin/order_cycle_serializer.rb - - app/serializers/api/cached_enterprise_serializer.rb - - app/services/cart_service.rb - - app/services/mail_configuration.rb - - app/services/order_cycle_form.rb - - app/services/permitted_attributes/checkout.rb - - app/services/place_proxy_order.rb - - app/services/process_payment_intent.rb - - app/services/variant_units/option_value_namer.rb - - engines/order_management/app/services/order_management/order/updater.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_allocation_report.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_supplier_report.rb - - engines/order_management/app/services/order_management/reports/enterprise_fee_summary/scope.rb - - engines/order_management/app/services/order_management/stock/estimator.rb - - engines/order_management/app/services/order_management/stock/package.rb - - lib/active_merchant/billing/gateways/stripe_payment_intents.rb - - lib/discourse/single_sign_on.rb - - lib/open_food_network/column_preference_defaults.rb - - lib/open_food_network/customers_report.rb - - lib/open_food_network/enterprise_fee_calculator.rb - - lib/open_food_network/enterprise_issue_validator.rb - - lib/open_food_network/group_buy_report.rb - - lib/open_food_network/lettuce_share_report.rb - - lib/open_food_network/order_and_distributor_report.rb - - lib/open_food_network/order_cycle_form_applicator.rb - - lib/open_food_network/order_cycle_management_report.rb - - lib/open_food_network/order_cycle_permissions.rb - - lib/open_food_network/order_grouper.rb - - lib/open_food_network/packing_report.rb - - lib/open_food_network/payments_report.rb - - lib/open_food_network/permissions.rb - - lib/open_food_network/products_and_inventory_report.rb - - lib/open_food_network/reports/line_items.rb - - lib/open_food_network/sales_tax_report.rb - - lib/open_food_network/users_and_enterprises_report.rb - - lib/open_food_network/xero_invoices_report.rb - - lib/spree/api/controller_setup.rb - - lib/spree/core/calculated_adjustments.rb - - lib/spree/core/controller_helpers/order.rb - - lib/spree/core/controller_helpers/respond_with.rb - - lib/spree/core/delegate_belongs_to.rb - - lib/spree/core/permalinks.rb - - lib/spree/core/s3_support.rb - - lib/spree/localized_number.rb - - lib/spree/responder.rb - - lib/stripe/credit_card_clone_finder.rb - - lib/stripe/profile_storer.rb - - lib/tasks/sample_data/group_factory.rb - - lib/tasks/sample_data/order_factory.rb - - lib/tasks/sample_data/product_factory.rb - - spec/features/consumer/shopping/variant_overrides_spec.rb - - spec/models/product_importer_spec.rb - - spec/support/i18n_translations_checker.rb - -Metrics/ClassLength: - Max: 100 - Exclude: - - app/controllers/admin/customers_controller.rb - - app/controllers/admin/enterprises_controller.rb - - app/controllers/admin/order_cycles_controller.rb - - app/controllers/admin/resource_controller.rb - - app/controllers/admin/schedules_controller.rb - - app/controllers/admin/subscriptions_controller.rb - - app/controllers/api/v0/products_controller.rb - - app/controllers/application_controller.rb - - app/controllers/checkout_controller.rb - - app/controllers/spree/admin/orders_controller.rb - - app/controllers/spree/admin/payment_methods_controller.rb - - app/controllers/spree/admin/payments_controller.rb - - app/controllers/spree/admin/products_controller.rb - - app/controllers/spree/admin/reports_controller.rb - - app/controllers/spree/admin/users_controller.rb - - app/controllers/spree/orders_controller.rb - - app/controllers/spree/paypal_controller.rb - - app/models/enterprise.rb - - app/models/order_cycle.rb - - app/models/product_import/entry_processor.rb - - app/models/product_import/entry_validator.rb - - app/models/product_import/product_importer.rb - - app/models/spree/ability.rb - - app/models/spree/address.rb - - app/models/spree/credit_card.rb - - app/models/spree/gateway/stripe_sca.rb - - app/models/spree/line_item.rb - - app/models/spree/order.rb - - app/models/spree/payment.rb - - app/models/spree/product.rb - - app/models/spree/shipment.rb - - app/models/spree/tax_rate.rb - - app/models/spree/user.rb - - app/models/spree/variant.rb - - app/models/spree/zone.rb - - app/serializers/api/cached_enterprise_serializer.rb - - app/serializers/api/enterprise_shopfront_serializer.rb - - app/services/cart_service.rb - - app/services/order_syncer.rb - - engines/order_management/app/services/order_management/order/updater.rb - - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb - - engines/order_management/app/services/order_management/reports/enterprise_fee_summary/scope.rb - - lib/active_merchant/billing/gateways/stripe_payment_intents.rb - - lib/open_food_network/enterprise_fee_calculator.rb - - lib/open_food_network/order_cycle_form_applicator.rb - - lib/open_food_network/order_cycle_management_report.rb - - lib/open_food_network/order_cycle_permissions.rb - - lib/open_food_network/packing_report.rb - - lib/open_food_network/payments_report.rb - - lib/open_food_network/permissions.rb - - lib/open_food_network/users_and_enterprises_report.rb - - lib/open_food_network/xero_invoices_report.rb - -Metrics/ModuleLength: - Max: 100 - Exclude: - - app/helpers/admin/injection_helper.rb - - app/helpers/injection_helper.rb - - app/helpers/spree/admin/base_helper.rb - - app/helpers/spree/admin/navigation_helper.rb - - app/helpers/spree/admin/orders_helper.rb - - app/models/spree/order/checkout.rb - - app/models/spree/payment/processing.rb - - engines/order_management/spec/services/order_management/subscriptions/proxy_order_syncer_spec.rb - - engines/order_management/spec/services/order_management/subscriptions/validator_spec.rb - - lib/open_food_network/column_preference_defaults.rb - - spec/controllers/admin/order_cycles_controller_spec.rb - - spec/lib/open_food_network/order_cycle_form_applicator_spec.rb - - spec/lib/open_food_network/order_cycle_permissions_spec.rb - - spec/models/spree/adjustment_spec.rb - - spec/models/spree/line_item_spec.rb - - spec/models/spree/product_spec.rb - - spec/models/spree/tax_rate_spec.rb - - spec/models/spree/variant_spec.rb - -Metrics/ParameterLists: - Max: 5 - Exclude: - - app/helpers/angular_form_builder.rb - - app/models/product_import/entry_processor.rb - - lib/open_food_network/xero_invoices_report.rb - - spec/features/admin/reports_spec.rb - - spec/support/controller_requests_helper.rb - -Lint/UselessAssignment: - Exclude: - - 'spec/**/*' - - app/models/spree/credit_card.rb - - app/models/spree/taxon.rb - - lib/spree/core/controller_helpers/common.rb - -Metrics/BlockNesting: - Max: 3 - Exclude: - - app/models/spree/payment/processing.rb diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index a643372650..1b4d51f6e1 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by -# `rubocop --auto-gen-config --exclude-limit 1400` -# on 2021-07-13 21:27:42 UTC using RuboCop version 1.18.0. +# `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 1400` +# on 2021-12-09 22:28:37 UTC using RuboCop version 1.22.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -16,20 +16,313 @@ Gemspec/RequiredRubyVersion: - 'engines/order_management/order_management.gemspec' - 'engines/web/web.gemspec' +# Offense count: 1 +# Cop supports --auto-correct. +Layout/ClosingParenthesisIndentation: + Exclude: + - 'lib/reporting/queries/joins.rb' + # Offense count: 2 # Cop supports --auto-correct. +# Configuration parameters: EmptyLineBetweenMethodDefs, EmptyLineBetweenClassDefs, EmptyLineBetweenModuleDefs, AllowAdjacentOneLineDefs, NumberOfEmptyLines. +Layout/EmptyLineBetweenDefs: + Exclude: + - 'spec/lib/reports/report_loader_spec.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: empty_lines, no_empty_lines +Layout/EmptyLinesAroundBlockBody: + Exclude: + - 'spec/requests/checkout/concurrency_spec.rb' + - 'spec/system/admin/order_cycles/list_spec.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment. +Layout/LeadingCommentSpace: + Exclude: + - 'spec/system/admin/enterprises_spec.rb' + +# Offense count: 814 +# Cop supports --auto-correct. +# Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Exclude: + - 'app/controllers/admin/bulk_line_items_controller.rb' + - 'app/controllers/admin/enterprise_fees_controller.rb' + - 'app/controllers/admin/enterprise_relationships_controller.rb' + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/admin/product_import_controller.rb' + - 'app/controllers/admin/schedules_controller.rb' + - 'app/controllers/admin/subscriptions_controller.rb' + - 'app/controllers/api/v0/order_cycles_controller.rb' + - 'app/controllers/checkout_controller.rb' + - 'app/controllers/spree/admin/reports_controller.rb' + - 'app/controllers/spree/paypal_controller.rb' + - 'app/helpers/angular_form_builder.rb' + - 'app/helpers/angular_form_helper.rb' + - 'app/helpers/enterprises_helper.rb' + - 'app/helpers/order_cycles_helper.rb' + - 'app/helpers/spree/orders_helper.rb' + - 'app/jobs/subscription_confirm_job.rb' + - 'app/mailers/subscription_mailer.rb' + - 'app/models/column_preference.rb' + - 'app/models/concerns/order_shipment.rb' + - 'app/models/concerns/product_stock.rb' + - 'app/models/concerns/variant_stock.rb' + - 'app/models/customer.rb' + - 'app/models/enterprise.rb' + - 'app/models/enterprise_group.rb' + - 'app/models/product_import/entry_processor.rb' + - 'app/models/product_import/spreadsheet_entry.rb' + - 'app/models/product_import/unit_converter.rb' + - 'app/models/proxy_order.rb' + - 'app/models/schedule.rb' + - 'app/models/spree/app_configuration.rb' + - 'app/models/spree/gateway/stripe_sca.rb' + - 'app/models/spree/image.rb' + - 'app/models/spree/line_item.rb' + - 'app/models/spree/order.rb' + - 'app/models/spree/payment_method.rb' + - 'app/models/spree/preferences/store.rb' + - 'app/models/subscription.rb' + - 'app/models/variant_override.rb' + - 'app/serializers/api/admin/subscription_line_item_serializer.rb' + - 'app/serializers/api/admin/subscription_serializer.rb' + - 'app/services/cart_service.rb' + - 'app/services/checkout/post_checkout_actions.rb' + - 'app/services/embedded_page_service.rb' + - 'app/services/order_cycle_form.rb' + - 'app/services/order_syncer.rb' + - 'app/services/products_renderer.rb' + - 'app/services/variant_units/variant_and_line_item_naming.rb' + - 'engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb' + - 'engines/order_management/app/services/order_management/subscriptions/validator.rb' + - 'engines/order_management/spec/services/order_management/order/stripe_sca_payment_authorize_spec.rb' + - 'engines/order_management/spec/services/order_management/order/updater_spec.rb' + - 'engines/web/app/helpers/web/cookies_policy_helper.rb' + - 'engines/web/spec/features/consumer/cookies_spec.rb' + - 'lib/discourse/single_sign_on.rb' + - 'lib/open_food_network/enterprise_fee_applicator.rb' + - 'lib/open_food_network/enterprise_fee_calculator.rb' + - 'lib/open_food_network/enterprise_issue_validator.rb' + - 'lib/open_food_network/lettuce_share_report.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/order_cycle_management_report.rb' + - 'lib/open_food_network/order_cycle_permissions.rb' + - 'lib/open_food_network/payments_report.rb' + - 'lib/open_food_network/reports/line_items.rb' + - 'lib/open_food_network/sales_tax_report.rb' + - 'lib/open_food_network/scope_variants_for_search.rb' + - 'lib/open_food_network/xero_invoices_report.rb' + - 'lib/spree/localized_number.rb' + - 'lib/tasks/data.rake' + - 'lib/tasks/enterprises.rake' + - 'lib/tasks/import_product_images.rake' + - 'spec/controllers/admin/bulk_line_items_controller_spec.rb' + - 'spec/controllers/admin/column_preferences_controller_spec.rb' + - 'spec/controllers/admin/enterprises_controller_spec.rb' + - 'spec/controllers/admin/manager_invitations_controller_spec.rb' + - 'spec/controllers/admin/order_cycles_controller_spec.rb' + - 'spec/controllers/admin/schedules_controller_spec.rb' + - 'spec/controllers/admin/stripe_accounts_controller_spec.rb' + - 'spec/controllers/admin/stripe_connect_settings_controller_spec.rb' + - 'spec/controllers/admin/subscription_line_items_controller_spec.rb' + - 'spec/controllers/admin/subscriptions_controller_spec.rb' + - 'spec/controllers/admin/variant_overrides_controller_spec.rb' + - 'spec/controllers/api/v0/base_controller_spec.rb' + - 'spec/controllers/api/v0/enterprises_controller_spec.rb' + - 'spec/controllers/api/v0/exchange_products_controller_spec.rb' + - 'spec/controllers/api/v0/logos_controller_spec.rb' + - 'spec/controllers/api/v0/order_cycles_controller_spec.rb' + - 'spec/controllers/api/v0/orders_controller_spec.rb' + - 'spec/controllers/api/v0/product_images_controller_spec.rb' + - 'spec/controllers/api/v0/products_controller_spec.rb' + - 'spec/controllers/api/v0/promo_images_controller_spec.rb' + - 'spec/controllers/api/v0/terms_and_conditions_controller_spec.rb' + - 'spec/controllers/cart_controller_spec.rb' + - 'spec/controllers/checkout_controller_spec.rb' + - 'spec/controllers/enterprises_controller_spec.rb' + - 'spec/controllers/line_items_controller_spec.rb' + - 'spec/controllers/shops_controller_spec.rb' + - 'spec/controllers/spree/admin/orders/customer_details_controller_spec.rb' + - 'spec/controllers/spree/admin/orders/invoices_spec.rb' + - 'spec/controllers/spree/admin/orders_controller_spec.rb' + - 'spec/controllers/spree/admin/payment_methods_controller_spec.rb' + - 'spec/controllers/spree/admin/reports_controller_spec.rb' + - 'spec/controllers/spree/admin/variants_controller_spec.rb' + - 'spec/controllers/spree/credit_cards_controller_spec.rb' + - 'spec/controllers/spree/orders_controller_spec.rb' + - 'spec/controllers/stripe/callbacks_controller_spec.rb' + - 'spec/controllers/stripe/webhooks_controller_spec.rb' + - 'spec/controllers/user_confirmations_controller_spec.rb' + - 'spec/factories/stock_location_factory.rb' + - 'spec/features/consumer/multilingual_spec.rb' + - 'spec/features/consumer/shops_spec.rb' + - 'spec/helpers/enterprises_helper_spec.rb' + - 'spec/helpers/injection_helper_spec.rb' + - 'spec/helpers/order_cycles_helper_spec.rb' + - 'spec/helpers/spree/admin/base_helper_spec.rb' + - 'spec/jobs/subscription_confirm_job_spec.rb' + - 'spec/jobs/subscription_placement_job_spec.rb' + - 'spec/lib/open_food_network/customers_report_spec.rb' + - 'spec/lib/open_food_network/enterprise_fee_calculator_spec.rb' + - 'spec/lib/open_food_network/group_buy_report_spec.rb' + - 'spec/lib/open_food_network/order_cycle_form_applicator_spec.rb' + - 'spec/lib/open_food_network/order_cycle_management_report_spec.rb' + - 'spec/lib/open_food_network/order_cycle_permissions_spec.rb' + - 'spec/lib/open_food_network/order_grouper_spec.rb' + - 'spec/lib/open_food_network/permissions_spec.rb' + - 'spec/lib/open_food_network/products_and_inventory_report_spec.rb' + - 'spec/lib/open_food_network/scope_variant_to_hub_spec.rb' + - 'spec/lib/open_food_network/tag_rule_applicator_spec.rb' + - 'spec/lib/open_food_network/users_and_enterprises_report_spec.rb' + - 'spec/lib/reports/packing/packing_report_spec.rb' + - 'spec/lib/stripe/authorize_response_patcher_spec.rb' + - 'spec/mailers/order_mailer_spec.rb' + - 'spec/mailers/producer_mailer_spec.rb' + - 'spec/mailers/subscription_mailer_spec.rb' + - 'spec/migrations/migrate_customer_names_spec.rb' + - 'spec/models/concerns/calculated_adjustments_spec.rb' + - 'spec/models/concerns/order_shipment_spec.rb' + - 'spec/models/concerns/product_stock_spec.rb' + - 'spec/models/enterprise_group_spec.rb' + - 'spec/models/enterprise_relationship_spec.rb' + - 'spec/models/enterprise_spec.rb' + - 'spec/models/exchange_spec.rb' + - 'spec/models/order_cycle_spec.rb' + - 'spec/models/product_importer_spec.rb' + - 'spec/models/spree/ability_spec.rb' + - 'spec/models/spree/address_spec.rb' + - 'spec/models/spree/adjustment_spec.rb' + - 'spec/models/spree/classification_spec.rb' + - 'spec/models/spree/gateway/stripe_connect_spec.rb' + - 'spec/models/spree/inventory_unit_spec.rb' + - 'spec/models/spree/line_item_spec.rb' + - 'spec/models/spree/order/checkout_spec.rb' + - 'spec/models/spree/order_inventory_spec.rb' + - 'spec/models/spree/order_spec.rb' + - 'spec/models/spree/payment_method_spec.rb' + - 'spec/models/spree/payment_spec.rb' + - 'spec/models/spree/product_spec.rb' + - 'spec/models/spree/shipping_method_spec.rb' + - 'spec/models/spree/tax_rate_spec.rb' + - 'spec/models/spree/user_spec.rb' + - 'spec/models/spree/variant_spec.rb' + - 'spec/models/tag_rule/filter_order_cycles_spec.rb' + - 'spec/models/tag_rule/filter_payment_methods_spec.rb' + - 'spec/models/tag_rule/filter_products_spec.rb' + - 'spec/models/tag_rule/filter_shipping_methods_spec.rb' + - 'spec/models/terms_of_service_file_spec.rb' + - 'spec/models/variant_override_spec.rb' + - 'spec/requests/api/orders_spec.rb' + - 'spec/requests/checkout/failed_checkout_spec.rb' + - 'spec/requests/embedded_shopfronts_headers_spec.rb' + - 'spec/serializers/api/admin/exchange_serializer_spec.rb' + - 'spec/serializers/api/admin/order_cycle_serializer_spec.rb' + - 'spec/services/address_geocoder_spec.rb' + - 'spec/services/cart_service_spec.rb' + - 'spec/services/checkout/form_data_adapter_spec.rb' + - 'spec/services/checkout/post_checkout_actions_spec.rb' + - 'spec/services/content_sanitizer_spec.rb' + - 'spec/services/embedded_page_service_spec.rb' + - 'spec/services/exchange_products_renderer_spec.rb' + - 'spec/services/order_cycle_distributed_variants_spec.rb' + - 'spec/services/order_syncer_spec.rb' + - 'spec/services/paypal_items_builder_spec.rb' + - 'spec/services/permissions/order_spec.rb' + - 'spec/services/permitted_attributes/order_cycle_spec.rb' + - 'spec/services/product_tag_rules_filterer_spec.rb' + - 'spec/services/products_renderer_spec.rb' + - 'spec/support/cancan_helper.rb' + - 'spec/support/features/datepicker_helper.rb' + - 'spec/support/matchers/select2_matchers.rb' + - 'spec/support/matchers/table_matchers.rb' + - 'spec/support/request/stripe_stubs.rb' + - 'spec/support/request/web_helper.rb' + - 'spec/swagger_helper.rb' + - 'spec/system/admin/adjustments_spec.rb' + - 'spec/system/admin/bulk_order_management_spec.rb' + - 'spec/system/admin/bulk_product_update_spec.rb' + - 'spec/system/admin/configuration/content_spec.rb' + - 'spec/system/admin/customers_spec.rb' + - 'spec/system/admin/enterprise_fees_spec.rb' + - 'spec/system/admin/enterprise_relationships_spec.rb' + - 'spec/system/admin/enterprises/business_address_form_spec.rb' + - 'spec/system/admin/enterprises/images_spec.rb' + - 'spec/system/admin/enterprises/index_spec.rb' + - 'spec/system/admin/enterprises_spec.rb' + - 'spec/system/admin/multilingual_spec.rb' + - 'spec/system/admin/order_cycles/complex_editing_multiple_product_pages_spec.rb' + - 'spec/system/admin/order_cycles/complex_editing_spec.rb' + - 'spec/system/admin/order_cycles/complex_updating_specific_time_spec.rb' + - 'spec/system/admin/order_cycles/list_spec.rb' + - 'spec/system/admin/order_cycles/simple_spec.rb' + - 'spec/system/admin/order_spec.rb' + - 'spec/system/admin/orders_spec.rb' + - 'spec/system/admin/overview_spec.rb' + - 'spec/system/admin/payment_method_spec.rb' + - 'spec/system/admin/payments_stripe_spec.rb' + - 'spec/system/admin/product_import_spec.rb' + - 'spec/system/admin/products_spec.rb' + - 'spec/system/admin/reports/packing_report_spec.rb' + - 'spec/system/admin/schedules_spec.rb' + - 'spec/system/admin/shipping_methods_spec.rb' + - 'spec/system/admin/subscriptions_spec.rb' + - 'spec/system/admin/tag_rules_spec.rb' + - 'spec/system/admin/users_spec.rb' + - 'spec/system/admin/variant_overrides_spec.rb' + - 'spec/system/consumer/authentication_spec.rb' + - 'spec/system/consumer/caching/shops_caching_spec.rb' + - 'spec/system/consumer/shopping/cart_spec.rb' + - 'spec/system/consumer/shopping/checkout_auth_spec.rb' + - 'spec/system/consumer/shopping/checkout_spec.rb' + - 'spec/system/consumer/shopping/checkout_stripe_spec.rb' + - 'spec/system/consumer/shopping/embedded_shopfronts_spec.rb' + - 'spec/system/consumer/shopping/products_spec.rb' + - 'spec/system/consumer/shopping/shopping_spec.rb' + - 'spec/system/consumer/shopping/unit_price_spec.rb' + - 'spec/system/consumer/shopping/variant_overrides_spec.rb' + - 'spec/system/consumer/split_checkout_spec.rb' + - 'spec/system/support/precompile_assets.rb' + - 'spec/views/spree/admin/payment_methods/index.html.haml_spec.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Layout/MultilineBlockLayout: + Exclude: + - 'spec/lib/reports/report_renderer_spec.rb' + +# Offense count: 1 +# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineMethodCallBraceLayout: Exclude: - - 'spec/features/consumer/account/payments_spec.rb' - - 'spec/queries/payments_requiring_action_spec.rb' + - 'lib/reporting/queries/joins.rb' # Offense count: 15 +# Cop supports --auto-correct. +# Configuration parameters: AllowInHeredoc. +Layout/TrailingWhitespace: + Exclude: + - 'app/controllers/spree/admin/shipping_methods_controller.rb' + - 'spec/controllers/spree/admin/shipping_methods_controller_spec.rb' + - 'spec/system/admin/enterprises_spec.rb' + - 'spec/system/admin/order_spec.rb' + - 'spec/system/admin/shipping_methods_spec.rb' + - 'spec/system/flatpickr_spec.rb' + +# Offense count: 17 # Configuration parameters: AllowedMethods. # AllowedMethods: enums Lint/ConstantDefinitionInBlock: Exclude: + - 'lib/active_merchant/billing/gateways/stripe_payment_intents_decorator.rb' + - 'lib/tasks/import_product_images.rake' - 'lib/tasks/users.rake' - 'spec/controllers/spree/admin/base_controller_spec.rb' - 'spec/helpers/serializer_helper_spec.rb' @@ -77,10 +370,20 @@ Lint/RedundantSafeNavigation: Exclude: - 'app/models/spree/payment.rb' -# Offense count: 1 -Lint/UselessAssignment: +# Offense count: 2 +# Configuration parameters: AllowedMethods. +# AllowedMethods: present?, blank?, presence, try, try!, in? +Lint/SafeNavigationChain: Exclude: - - 'app/models/spree/credit_card.rb' + - 'app/models/spree/line_item.rb' + - 'app/models/spree/stock/availability_validator.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. +Lint/UnusedMethodArgument: + Exclude: + - 'lib/reporting/queries/query_interface.rb' # Offense count: 5 # Cop supports --auto-correct. @@ -90,11 +393,558 @@ Lint/UselessMethodDefinition: - 'app/controllers/spree/user_registrations_controller.rb' - 'app/models/spree/gateway.rb' +# Offense count: 262 +# Configuration parameters: IgnoredMethods, CountRepeatedAttributes, Max. +Metrics/AbcSize: + Exclude: + - 'app/controllers/admin/bulk_line_items_controller.rb' + - 'app/controllers/admin/customers_controller.rb' + - 'app/controllers/admin/enterprise_fees_controller.rb' + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/admin/order_cycles_controller.rb' + - 'app/controllers/admin/product_import_controller.rb' + - 'app/controllers/admin/resource_controller.rb' + - 'app/controllers/admin/schedules_controller.rb' + - 'app/controllers/admin/stripe_accounts_controller.rb' + - 'app/controllers/admin/subscription_line_items_controller.rb' + - 'app/controllers/admin/subscriptions_controller.rb' + - 'app/controllers/api/v0/enterprises_controller.rb' + - 'app/controllers/api/v0/product_images_controller.rb' + - 'app/controllers/api/v0/products_controller.rb' + - 'app/controllers/api/v0/shipments_controller.rb' + - 'app/controllers/api/v0/taxons_controller.rb' + - 'app/controllers/api/v0/variants_controller.rb' + - 'app/controllers/checkout_controller.rb' + - 'app/controllers/discourse_sso_controller.rb' + - 'app/controllers/enterprises_controller.rb' + - 'app/controllers/split_checkout_controller.rb' + - 'app/controllers/spree/admin/adjustments_controller.rb' + - 'app/controllers/spree/admin/general_settings_controller.rb' + - 'app/controllers/spree/admin/images_controller.rb' + - 'app/controllers/spree/admin/mail_methods_controller.rb' + - 'app/controllers/spree/admin/orders/customer_details_controller.rb' + - 'app/controllers/spree/admin/orders_controller.rb' + - 'app/controllers/spree/admin/overview_controller.rb' + - 'app/controllers/spree/admin/payment_methods_controller.rb' + - 'app/controllers/spree/admin/payments_controller.rb' + - 'app/controllers/spree/admin/products_controller.rb' + - 'app/controllers/spree/admin/reports_controller.rb' + - 'app/controllers/spree/admin/search_controller.rb' + - 'app/controllers/spree/admin/shipping_methods_controller.rb' + - 'app/controllers/spree/admin/taxons_controller.rb' + - 'app/controllers/spree/admin/users_controller.rb' + - 'app/controllers/spree/admin/variants_controller.rb' + - 'app/controllers/spree/credit_cards_controller.rb' + - 'app/controllers/spree/orders_controller.rb' + - 'app/controllers/spree/paypal_controller.rb' + - 'app/controllers/spree/user_passwords_controller.rb' + - 'app/controllers/spree/user_sessions_controller.rb' + - 'app/controllers/spree/users_controller.rb' + - 'app/controllers/stripe/callbacks_controller.rb' + - 'app/controllers/user_confirmations_controller.rb' + - 'app/controllers/user_passwords_controller.rb' + - 'app/controllers/user_registrations_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/checkout_helper.rb' + - 'app/helpers/order_cycles_helper.rb' + - 'app/helpers/spree/admin/base_helper.rb' + - 'app/helpers/spree/admin/navigation_helper.rb' + - 'app/helpers/spree/admin/zones_helper.rb' + - 'app/helpers/spree/base_helper.rb' + - 'app/helpers/spree/orders_helper.rb' + - 'app/helpers/tax_helper.rb' + - 'app/mailers/producer_mailer.rb' + - 'app/mailers/spree/order_mailer.rb' + - 'app/models/calculator/flat_percent_per_item.rb' + - 'app/models/column_preference.rb' + - 'app/models/enterprise.rb' + - 'app/models/enterprise_group.rb' + - 'app/models/enterprise_relationship.rb' + - 'app/models/order_cycle.rb' + - 'app/models/product_import/entry_processor.rb' + - 'app/models/product_import/entry_validator.rb' + - 'app/models/product_import/product_importer.rb' + - 'app/models/product_import/unit_converter.rb' + - 'app/models/proxy_order.rb' + - 'app/models/spree/ability.rb' + - 'app/models/spree/address.rb' + - 'app/models/spree/adjustment.rb' + - 'app/models/spree/gateway/pay_pal_express.rb' + - 'app/models/spree/image.rb' + - 'app/models/spree/item_adjustments.rb' + - 'app/models/spree/line_item.rb' + - 'app/models/spree/order.rb' + - 'app/models/spree/order/checkout.rb' + - 'app/models/spree/order_inventory.rb' + - 'app/models/spree/payment.rb' + - 'app/models/spree/payment/processing.rb' + - 'app/models/spree/preference.rb' + - 'app/models/spree/preferences/preferable.rb' + - 'app/models/spree/preferences/preferable_class_methods.rb' + - 'app/models/spree/product.rb' + - 'app/models/spree/return_authorization.rb' + - 'app/models/spree/shipment.rb' + - 'app/models/spree/tax_rate.rb' + - 'app/models/spree/taxon.rb' + - 'app/models/spree/variant.rb' + - 'app/models/spree/zone.rb' + - 'app/serializers/api/admin/enterprise_serializer.rb' + - 'app/serializers/api/variant_serializer.rb' + - 'app/services/cap_quantity.rb' + - 'app/services/cart_service.rb' + - 'app/services/create_order_cycle.rb' + - 'app/services/order_cycle_form.rb' + - 'app/services/order_factory.rb' + - 'app/services/order_syncer.rb' + - 'app/services/place_proxy_order.rb' + - 'app/services/process_payment_intent.rb' + - 'app/services/products_renderer.rb' + - 'app/services/search_orders.rb' + - 'app/services/sets/model_set.rb' + - 'app/services/variant_units/option_value_namer.rb' + - 'app/services/variant_units/variant_and_line_item_naming.rb' + - 'app/services/variants_stock_levels.rb' + - 'engines/order_management/app/services/order_management/order/updater.rb' + - 'engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb' + - 'engines/order_management/app/services/order_management/stock/estimator.rb' + - 'engines/order_management/app/services/order_management/stock/package.rb' + - 'engines/order_management/app/services/order_management/stock/packer.rb' + - 'engines/order_management/app/services/order_management/subscriptions/form.rb' + - 'engines/order_management/app/services/order_management/subscriptions/validator.rb' + - 'lib/active_merchant/billing/gateways/stripe_payment_intents_decorator.rb' + - 'lib/discourse/single_sign_on.rb' + - 'lib/open_food_network/customers_report.rb' + - 'lib/open_food_network/enterprise_fee_calculator.rb' + - 'lib/open_food_network/enterprise_issue_validator.rb' + - 'lib/open_food_network/group_buy_report.rb' + - 'lib/open_food_network/lettuce_share_report.rb' + - 'lib/open_food_network/order_and_distributor_report.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/order_cycle_management_report.rb' + - 'lib/open_food_network/order_cycle_permissions.rb' + - 'lib/open_food_network/order_grouper.rb' + - 'lib/open_food_network/orders_and_fulfillments_report/supplier_totals_report.rb' + - 'lib/open_food_network/payments_report.rb' + - 'lib/open_food_network/permissions.rb' + - 'lib/open_food_network/products_and_inventory_report.rb' + - 'lib/open_food_network/reports/line_items.rb' + - 'lib/open_food_network/sales_tax_report.rb' + - 'lib/open_food_network/users_and_enterprises_report.rb' + - 'lib/open_food_network/xero_invoices_report.rb' + - 'lib/reporting/queries/query_builder.rb' + - 'lib/reporting/reports/packing/base.rb' + - 'lib/reporting/reports/packing/customer.rb' + - 'lib/reporting/reports/packing/supplier.rb' + - 'lib/session_cookie_upgrader.rb' + - 'lib/spree/api/controller_setup.rb' + - 'lib/spree/core/controller_helpers/auth.rb' + - 'lib/spree/core/controller_helpers/common.rb' + - 'lib/spree/core/controller_helpers/order.rb' + - 'lib/spree/core/controller_helpers/respond_with.rb' + - 'lib/spree/core/delegate_belongs_to.rb' + - 'lib/spree/core/permalinks.rb' + - 'lib/spree/core/product_duplicator.rb' + - 'lib/spree/core/s3_support.rb' + - 'lib/spree/localized_number.rb' + - 'lib/stripe/account_connector.rb' + - 'lib/stripe/authorize_response_patcher.rb' + - 'lib/stripe/profile_storer.rb' + - 'lib/tasks/enterprises.rake' + - 'lib/tasks/sample_data/order_factory.rb' + - 'lib/tasks/sample_data/product_factory.rb' + - 'spec/controllers/api/v0/reports/packing_report_spec.rb' + - 'spec/models/enterprise_spec.rb' + - 'spec/models/product_importer_spec.rb' + - 'spec/services/order_checkout_restart_spec.rb' + - 'spec/support/i18n_translations_checker.rb' + - 'spec/support/performance_helper.rb' + - 'spec/support/request/web_helper.rb' + - 'spec/system/admin/product_import_spec.rb' + - 'spec/system/admin/reports_spec.rb' + - 'spec/system/admin/subscriptions_spec.rb' + - 'spec/system/consumer/shopping/shopping_spec.rb' + - 'spec/system/consumer/shopping/variant_overrides_spec.rb' + +# Offense count: 48 +# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, IgnoredMethods. +# IgnoredMethods: refine +Metrics/BlockLength: + Exclude: + - 'app/models/spree/order/checkout.rb' + - 'app/models/spree/payment.rb' + - 'app/models/spree/payment/processing.rb' + - 'app/models/spree/shipment.rb' + - 'lib/spree/core/controller_helpers/common.rb' + - 'lib/tasks/data.rake' + - 'spec/base_spec_helper.rb' + - 'spec/factories.rb' + - 'spec/factories/address_factory.rb' + - 'spec/factories/enterprise_factory.rb' + - 'spec/factories/line_item_factory.rb' + - 'spec/factories/order_cycle_factory.rb' + - 'spec/factories/order_factory.rb' + - 'spec/factories/payment_method_factory.rb' + - 'spec/factories/product_factory.rb' + - 'spec/factories/shipment_factory.rb' + - 'spec/factories/shipping_method_factory.rb' + - 'spec/factories/subscription_factory.rb' + - 'spec/factories/user_factory.rb' + - 'spec/factories/variant_factory.rb' + - 'spec/lib/open_food_network/group_buy_report_spec.rb' + - 'spec/requests/api/orders_spec.rb' + - 'spec/spec_helper.rb' + - 'spec/support/cancan_helper.rb' + - 'spec/support/matchers/select2_matchers.rb' + - 'spec/support/matchers/table_matchers.rb' + - 'spec/swagger_helper.rb' + - 'spec/system/admin/order_cycles/complex_updating_specific_time_spec.rb' + - 'spec/system/consumer/shopping/checkout_spec.rb' + - 'spec/system/consumer/shopping/embedded_shopfronts_spec.rb' + +# Offense count: 1 +# Configuration parameters: CountBlocks, Max. +Metrics/BlockNesting: + Exclude: + - 'app/models/spree/payment/processing.rb' + +# Offense count: 49 +# Configuration parameters: CountComments, Max, CountAsOne. +Metrics/ClassLength: + Exclude: + - 'app/controllers/admin/customers_controller.rb' + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/admin/order_cycles_controller.rb' + - 'app/controllers/admin/resource_controller.rb' + - 'app/controllers/admin/schedules_controller.rb' + - 'app/controllers/admin/subscriptions_controller.rb' + - 'app/controllers/api/v0/products_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/controllers/checkout_controller.rb' + - 'app/controllers/spree/admin/orders_controller.rb' + - 'app/controllers/spree/admin/payment_methods_controller.rb' + - 'app/controllers/spree/admin/payments_controller.rb' + - 'app/controllers/spree/admin/products_controller.rb' + - 'app/controllers/spree/admin/reports_controller.rb' + - 'app/controllers/spree/admin/users_controller.rb' + - 'app/controllers/spree/orders_controller.rb' + - 'app/controllers/spree/paypal_controller.rb' + - 'app/models/enterprise.rb' + - 'app/models/order_cycle.rb' + - 'app/models/product_import/entry_processor.rb' + - 'app/models/product_import/entry_validator.rb' + - 'app/models/product_import/product_importer.rb' + - 'app/models/spree/ability.rb' + - 'app/models/spree/address.rb' + - 'app/models/spree/credit_card.rb' + - 'app/models/spree/gateway/stripe_sca.rb' + - 'app/models/spree/line_item.rb' + - 'app/models/spree/order.rb' + - 'app/models/spree/payment.rb' + - 'app/models/spree/product.rb' + - 'app/models/spree/shipment.rb' + - 'app/models/spree/user.rb' + - 'app/models/spree/variant.rb' + - 'app/models/spree/zone.rb' + - 'app/serializers/api/cached_enterprise_serializer.rb' + - 'app/serializers/api/enterprise_shopfront_serializer.rb' + - 'app/services/cart_service.rb' + - 'app/services/order_syncer.rb' + - 'engines/order_management/app/services/order_management/order/updater.rb' + - 'engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb' + - 'engines/order_management/app/services/order_management/reports/enterprise_fee_summary/scope.rb' + - 'lib/open_food_network/enterprise_fee_calculator.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/order_cycle_management_report.rb' + - 'lib/open_food_network/order_cycle_permissions.rb' + - 'lib/open_food_network/payments_report.rb' + - 'lib/open_food_network/permissions.rb' + - 'lib/open_food_network/users_and_enterprises_report.rb' + - 'lib/open_food_network/xero_invoices_report.rb' + +# Offense count: 72 +# Configuration parameters: IgnoredMethods, Max. +Metrics/CyclomaticComplexity: + Exclude: + - 'app/controllers/admin/enterprise_fees_controller.rb' + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/checkout_controller.rb' + - 'app/controllers/spree/admin/orders_controller.rb' + - 'app/controllers/spree/admin/payment_methods_controller.rb' + - 'app/controllers/spree/admin/payments_controller.rb' + - 'app/controllers/spree/admin/taxons_controller.rb' + - 'app/controllers/spree/admin/users_controller.rb' + - 'app/controllers/spree/orders_controller.rb' + - 'app/helpers/checkout_helper.rb' + - 'app/helpers/order_cycles_helper.rb' + - 'app/helpers/spree/admin/base_helper.rb' + - 'app/helpers/spree/admin/navigation_helper.rb' + - 'app/helpers/spree/admin/orders_helper.rb' + - 'app/models/enterprise.rb' + - 'app/models/enterprise_relationship.rb' + - 'app/models/product_import/entry_validator.rb' + - 'app/models/spree/ability.rb' + - 'app/models/spree/address.rb' + - 'app/models/spree/adjustment.rb' + - 'app/models/spree/order/checkout.rb' + - 'app/models/spree/order_inventory.rb' + - 'app/models/spree/payment.rb' + - 'app/models/spree/preference.rb' + - 'app/models/spree/preferences/preferable.rb' + - 'app/models/spree/preferences/preferable_class_methods.rb' + - 'app/models/spree/product.rb' + - 'app/models/spree/return_authorization.rb' + - 'app/models/spree/shipment.rb' + - 'app/models/spree/tax_rate.rb' + - 'app/models/spree/variant.rb' + - 'app/models/spree/zone.rb' + - 'app/services/cart_service.rb' + - 'app/services/products_renderer.rb' + - 'app/services/sets/model_set.rb' + - 'engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb' + - 'engines/order_management/app/services/order_management/reports/enterprise_fee_summary/parameters.rb' + - 'engines/order_management/app/services/order_management/stock/estimator.rb' + - 'engines/order_management/app/services/order_management/subscriptions/validator.rb' + - 'lib/active_merchant/billing/gateways/stripe_payment_intents_decorator.rb' + - 'lib/discourse/single_sign_on.rb' + - 'lib/open_food_network/customers_report.rb' + - 'lib/open_food_network/enterprise_issue_validator.rb' + - 'lib/open_food_network/group_buy_report.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/order_cycle_permissions.rb' + - 'lib/open_food_network/orders_and_fulfillments_report/customer_totals_report.rb' + - 'lib/open_food_network/payments_report.rb' + - 'lib/open_food_network/sales_tax_report.rb' + - 'lib/open_food_network/xero_invoices_report.rb' + - 'lib/spree/core/controller_helpers/common.rb' + - 'lib/spree/core/controller_helpers/order.rb' + - 'lib/spree/core/controller_helpers/respond_with.rb' + - 'lib/spree/localized_number.rb' + - 'lib/stripe/authorize_response_patcher.rb' + - 'lib/stripe/credit_card_clone_destroyer.rb' + - 'spec/models/product_importer_spec.rb' + - 'spec/support/i18n_translations_checker.rb' + +# Offense count: 254 +# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods, IgnoredMethods. +Metrics/MethodLength: + Exclude: + - 'app/controllers/admin/bulk_line_items_controller.rb' + - 'app/controllers/admin/contents_controller.rb' + - 'app/controllers/admin/customers_controller.rb' + - 'app/controllers/admin/enterprise_fees_controller.rb' + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/admin/manager_invitations_controller.rb' + - 'app/controllers/admin/order_cycles_controller.rb' + - 'app/controllers/admin/resource_controller.rb' + - 'app/controllers/admin/stripe_accounts_controller.rb' + - 'app/controllers/admin/subscriptions_controller.rb' + - 'app/controllers/api/v0/exchange_products_controller.rb' + - 'app/controllers/api/v0/product_images_controller.rb' + - 'app/controllers/api/v0/products_controller.rb' + - 'app/controllers/api/v0/shipments_controller.rb' + - 'app/controllers/api/v0/taxons_controller.rb' + - 'app/controllers/api/v0/variants_controller.rb' + - 'app/controllers/shop_controller.rb' + - 'app/controllers/split_checkout_controller.rb' + - 'app/controllers/spree/admin/orders/customer_details_controller.rb' + - 'app/controllers/spree/admin/orders_controller.rb' + - 'app/controllers/spree/admin/payment_methods_controller.rb' + - 'app/controllers/spree/admin/payments_controller.rb' + - 'app/controllers/spree/admin/products_controller.rb' + - 'app/controllers/spree/admin/reports_controller.rb' + - 'app/controllers/spree/admin/tax_categories_controller.rb' + - 'app/controllers/spree/admin/taxons_controller.rb' + - 'app/controllers/spree/admin/users_controller.rb' + - 'app/controllers/spree/admin/variants_controller.rb' + - 'app/controllers/spree/credit_cards_controller.rb' + - 'app/controllers/spree/orders_controller.rb' + - 'app/controllers/spree/paypal_controller.rb' + - 'app/controllers/spree/user_sessions_controller.rb' + - 'app/controllers/stripe/callbacks_controller.rb' + - 'app/controllers/user_confirmations_controller.rb' + - 'app/controllers/user_passwords_controller.rb' + - 'app/controllers/user_registrations_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/checkout_helper.rb' + - 'app/helpers/order_cycles_helper.rb' + - 'app/helpers/spree/admin/base_helper.rb' + - 'app/helpers/spree/admin/navigation_helper.rb' + - 'app/mailers/producer_mailer.rb' + - 'app/models/calculator/default_tax.rb' + - 'app/models/column_preference.rb' + - 'app/models/concerns/calculated_adjustments.rb' + - 'app/models/enterprise.rb' + - 'app/models/enterprise_relationship.rb' + - 'app/models/preference_sections/footer_and_external_links_section.rb' + - 'app/models/preference_sections/main_links_section.rb' + - 'app/models/product_import/entry_processor.rb' + - 'app/models/product_import/entry_validator.rb' + - 'app/models/product_import/product_importer.rb' + - 'app/models/spree/ability.rb' + - 'app/models/spree/address.rb' + - 'app/models/spree/adjustment.rb' + - 'app/models/spree/credit_card.rb' + - 'app/models/spree/gateway/pay_pal_express.rb' + - 'app/models/spree/order.rb' + - 'app/models/spree/order/checkout.rb' + - 'app/models/spree/order_contents.rb' + - 'app/models/spree/order_inventory.rb' + - 'app/models/spree/payment/processing.rb' + - 'app/models/spree/preference.rb' + - 'app/models/spree/preferences/preferable.rb' + - 'app/models/spree/preferences/preferable_class_methods.rb' + - 'app/models/spree/preferences/store.rb' + - 'app/models/spree/product.rb' + - 'app/models/spree/return_authorization.rb' + - 'app/models/spree/shipment.rb' + - 'app/models/spree/tax_rate.rb' + - 'app/models/spree/taxon.rb' + - 'app/models/spree/zone.rb' + - 'app/serializers/api/admin/order_cycle_serializer.rb' + - 'app/serializers/api/cached_enterprise_serializer.rb' + - 'app/services/cart_service.rb' + - 'app/services/mail_configuration.rb' + - 'app/services/order_cycle_form.rb' + - 'app/services/permitted_attributes/checkout.rb' + - 'app/services/permitted_attributes/enterprise.rb' + - 'app/services/place_proxy_order.rb' + - 'app/services/process_payment_intent.rb' + - 'app/services/products_renderer.rb' + - 'app/services/variant_units/option_value_namer.rb' + - 'engines/order_management/app/services/order_management/order/updater.rb' + - 'engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_allocation_report.rb' + - 'engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb' + - 'engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_supplier_report.rb' + - 'engines/order_management/app/services/order_management/reports/enterprise_fee_summary/scope.rb' + - 'engines/order_management/app/services/order_management/stock/estimator.rb' + - 'engines/order_management/app/services/order_management/stock/package.rb' + - 'lib/active_merchant/billing/gateways/stripe_payment_intents_decorator.rb' + - 'lib/discourse/single_sign_on.rb' + - 'lib/open_food_network/column_preference_defaults.rb' + - 'lib/open_food_network/customers_report.rb' + - 'lib/open_food_network/enterprise_fee_calculator.rb' + - 'lib/open_food_network/enterprise_issue_validator.rb' + - 'lib/open_food_network/group_buy_report.rb' + - 'lib/open_food_network/lettuce_share_report.rb' + - 'lib/open_food_network/order_and_distributor_report.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/order_cycle_management_report.rb' + - 'lib/open_food_network/order_cycle_permissions.rb' + - 'lib/open_food_network/order_grouper.rb' + - 'lib/open_food_network/payments_report.rb' + - 'lib/open_food_network/permissions.rb' + - 'lib/open_food_network/products_and_inventory_report.rb' + - 'lib/open_food_network/reports/line_items.rb' + - 'lib/open_food_network/sales_tax_report.rb' + - 'lib/open_food_network/users_and_enterprises_report.rb' + - 'lib/open_food_network/xero_invoices_report.rb' + - 'lib/reporting/reports/packing/base.rb' + - 'lib/reporting/reports/packing/customer.rb' + - 'lib/reporting/reports/packing/supplier.rb' + - 'lib/session_cookie_upgrader.rb' + - 'lib/spree/api/controller_setup.rb' + - 'lib/spree/core/controller_helpers/order.rb' + - 'lib/spree/core/controller_helpers/respond_with.rb' + - 'lib/spree/core/delegate_belongs_to.rb' + - 'lib/spree/core/permalinks.rb' + - 'lib/spree/core/s3_support.rb' + - 'lib/spree/localized_number.rb' + - 'lib/spree/responder.rb' + - 'lib/stripe/credit_card_clone_finder.rb' + - 'lib/stripe/profile_storer.rb' + - 'lib/tasks/sample_data/group_factory.rb' + - 'lib/tasks/sample_data/order_factory.rb' + - 'lib/tasks/sample_data/product_factory.rb' + - 'spec/controllers/api/v0/reports/packing_report_spec.rb' + - 'spec/models/product_importer_spec.rb' + - 'spec/support/i18n_translations_checker.rb' + - 'spec/support/request/checkout_request_helper.rb' + - 'spec/system/admin/reports_spec.rb' + - 'spec/system/consumer/shopping/variant_overrides_spec.rb' + +# Offense count: 19 +# Configuration parameters: CountComments, Max, CountAsOne. +Metrics/ModuleLength: + Exclude: + - 'app/helpers/admin/injection_helper.rb' + - 'app/helpers/checkout_helper.rb' + - 'app/helpers/injection_helper.rb' + - 'app/helpers/spree/admin/base_helper.rb' + - 'app/helpers/spree/admin/navigation_helper.rb' + - 'app/helpers/spree/admin/orders_helper.rb' + - 'app/models/spree/order/checkout.rb' + - 'app/models/spree/payment/processing.rb' + - 'engines/order_management/spec/services/order_management/subscriptions/proxy_order_syncer_spec.rb' + - 'engines/order_management/spec/services/order_management/subscriptions/validator_spec.rb' + - 'lib/open_food_network/column_preference_defaults.rb' + - 'spec/controllers/admin/order_cycles_controller_spec.rb' + - 'spec/lib/open_food_network/order_cycle_form_applicator_spec.rb' + - 'spec/lib/open_food_network/order_cycle_permissions_spec.rb' + - 'spec/models/spree/adjustment_spec.rb' + - 'spec/models/spree/line_item_spec.rb' + - 'spec/models/spree/product_spec.rb' + - 'spec/models/spree/tax_rate_spec.rb' + - 'spec/models/spree/variant_spec.rb' + +# Offense count: 7 +# Configuration parameters: Max, CountKeywordArgs, MaxOptionalParameters. +Metrics/ParameterLists: + Exclude: + - 'app/helpers/angular_form_builder.rb' + - 'app/models/product_import/entry_processor.rb' + - 'lib/open_food_network/xero_invoices_report.rb' + - 'spec/support/controller_requests_helper.rb' + - 'spec/system/admin/reports_spec.rb' + +# Offense count: 46 +# Configuration parameters: IgnoredMethods, Max. +Metrics/PerceivedComplexity: + Exclude: + - 'app/controllers/admin/enterprises_controller.rb' + - 'app/controllers/api/v0/variants_controller.rb' + - 'app/controllers/spree/admin/orders_controller.rb' + - 'app/controllers/spree/admin/payment_methods_controller.rb' + - 'app/controllers/spree/admin/payments_controller.rb' + - 'app/controllers/spree/admin/taxons_controller.rb' + - 'app/controllers/spree/admin/users_controller.rb' + - 'app/controllers/spree/orders_controller.rb' + - 'app/helpers/checkout_helper.rb' + - 'app/helpers/order_cycles_helper.rb' + - 'app/helpers/spree/admin/navigation_helper.rb' + - 'app/models/enterprise_relationship.rb' + - 'app/models/product_import/entry_validator.rb' + - 'app/models/spree/ability.rb' + - 'app/models/spree/address.rb' + - 'app/models/spree/order/checkout.rb' + - 'app/models/spree/order_inventory.rb' + - 'app/models/spree/preferences/preferable.rb' + - 'app/models/spree/preferences/preferable_class_methods.rb' + - 'app/models/spree/product.rb' + - 'app/models/spree/return_authorization.rb' + - 'app/models/spree/tax_rate.rb' + - 'app/models/spree/variant.rb' + - 'app/models/spree/zone.rb' + - 'app/services/products_renderer.rb' + - 'app/services/sets/model_set.rb' + - 'engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb' + - 'lib/discourse/single_sign_on.rb' + - 'lib/open_food_network/customers_report.rb' + - 'lib/open_food_network/enterprise_issue_validator.rb' + - 'lib/open_food_network/group_buy_report.rb' + - 'lib/open_food_network/order_cycle_form_applicator.rb' + - 'lib/open_food_network/order_cycle_permissions.rb' + - 'lib/open_food_network/payments_report.rb' + - 'lib/open_food_network/xero_invoices_report.rb' + - 'lib/spree/core/controller_helpers/order.rb' + - 'lib/spree/core/controller_helpers/respond_with.rb' + - 'lib/spree/localized_number.rb' + - 'spec/models/product_importer_spec.rb' + # Offense count: 9 Naming/AccessorMethodName: Exclude: - 'app/controllers/spree/admin/taxonomies_controller.rb' - - 'app/models/spree/adjustment.rb' + - 'app/mailers/producer_mailer.rb' - 'app/models/spree/order.rb' - 'app/services/checkout/post_checkout_actions.rb' - 'lib/spree/core/controller_helpers/common.rb' @@ -108,11 +958,12 @@ Naming/HeredocDelimiterNaming: Exclude: - 'app/models/content_configuration.rb' -# Offense count: 5 +# Offense count: 6 # Configuration parameters: EnforcedStyleForLeadingUnderscores. # SupportedStylesForLeadingUnderscores: disallowed, required, optional Naming/MemoizedInstanceVariableName: Exclude: + - 'app/constraints/split_checkout_constraint.rb' - 'app/mailers/producer_mailer.rb' - 'app/models/concerns/balance.rb' - 'lib/open_food_network/address_finder.rb' @@ -124,7 +975,7 @@ Naming/MethodParameterName: Exclude: - 'app/services/process_payment_intent.rb' -# Offense count: 34 +# Offense count: 30 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers. # SupportedStyles: snake_case, normalcase, non_integer # AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339 @@ -137,7 +988,6 @@ Naming/VariableNumber: - 'lib/spree/core/controller_helpers/common.rb' - 'spec/controllers/spree/admin/search_controller_spec.rb' - 'spec/factories/stock_location_factory.rb' - - 'spec/features/admin/reports_spec.rb' - 'spec/models/spree/stock_item_spec.rb' - 'spec/models/spree/tax_rate_spec.rb' - 'spec/requests/api/orders_spec.rb' @@ -187,6 +1037,13 @@ Rails/Blank: - 'engines/order_management/app/services/order_management/stock/package.rb' - 'lib/stripe/authorize_response_patcher.rb' +# Offense count: 1 +# Configuration parameters: EnforcedStyle, AllowToTime. +# SupportedStyles: strict, flexible +Rails/Date: + Exclude: + - 'spec/system/flatpickr_spec.rb' + # Offense count: 15 # Configuration parameters: EnforcedStyle. # SupportedStyles: slashes, arguments @@ -199,10 +1056,10 @@ Rails/FilePath: - 'spec/controllers/api/v0/promo_images_controller_spec.rb' - 'spec/controllers/api/v0/terms_and_conditions_controller_spec.rb' - 'spec/factories/product_factory.rb' - - 'spec/features/admin/enterprises/images_spec.rb' - 'spec/models/content_configuration_spec.rb' - 'spec/serializers/api/admin/enterprise_serializer_spec.rb' - 'spec/support/downloads_helper.rb' + - 'spec/system/admin/enterprises/images_spec.rb' # Offense count: 11 # Configuration parameters: Include. @@ -220,7 +1077,7 @@ Rails/HasAndBelongsToMany: - 'app/models/spree/variant.rb' - 'app/models/spree/zone.rb' -# Offense count: 42 +# Offense count: 47 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/HasManyOrHasOneDependent: @@ -230,9 +1087,12 @@ Rails/HasManyOrHasOneDependent: - 'app/models/order_cycle.rb' - 'app/models/spree/address.rb' - 'app/models/spree/adjustment.rb' + - 'app/models/spree/country.rb' - 'app/models/spree/credit_card.rb' - 'app/models/spree/order.rb' + - 'app/models/spree/payment.rb' - 'app/models/spree/payment_method.rb' + - 'app/models/spree/product.rb' - 'app/models/spree/property.rb' - 'app/models/spree/return_authorization.rb' - 'app/models/spree/shipment.rb' @@ -245,7 +1105,7 @@ Rails/HasManyOrHasOneDependent: - 'app/models/spree/variant.rb' - 'app/models/subscription.rb' -# Offense count: 58 +# Offense count: 59 # Configuration parameters: Include. # Include: app/helpers/**/*.rb Rails/HelperInstanceVariable: @@ -259,11 +1119,12 @@ Rails/HelperInstanceVariable: - 'app/helpers/spree/admin/orders_helper.rb' - 'app/helpers/spree/orders_helper.rb' -# Offense count: 35 +# Offense count: 36 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/InverseOf: Exclude: + - 'app/models/concerns/calculated_adjustments.rb' - 'app/models/enterprise.rb' - 'app/models/order_cycle.rb' - 'app/models/spree/adjustment.rb' @@ -295,6 +1156,7 @@ Rails/LexicallyScopedActionFilter: - 'app/controllers/admin/product_import_controller.rb' - 'app/controllers/admin/schedules_controller.rb' - 'app/controllers/admin/subscriptions_controller.rb' + - 'app/controllers/concerns/checkout_callbacks.rb' - 'app/controllers/registration_controller.rb' - 'app/controllers/spree/admin/adjustments_controller.rb' - 'app/controllers/spree/admin/payment_methods_controller.rb' @@ -308,19 +1170,22 @@ Rails/LexicallyScopedActionFilter: - 'app/controllers/spree/users_controller.rb' - 'app/controllers/user_passwords_controller.rb' -# Offense count: 13 +# Offense count: 18 Rails/OutputSafety: Exclude: - 'app/controllers/spree/admin/reports_controller.rb' - 'app/helpers/angular_form_helper.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/reports_helper.rb' - 'app/helpers/spree/admin/base_helper.rb' - 'app/helpers/spree/admin/navigation_helper.rb' - 'app/helpers/spree/admin/orders_helper.rb' - 'app/helpers/spree/admin/zones_helper.rb' - - 'app/helpers/spree/reports_helper.rb' - 'app/serializers/api/product_serializer.rb' + - 'lib/reporting/queries/query_builder.rb' + - 'lib/reporting/queries/query_interface.rb' - 'lib/spree/money.rb' - - 'spec/features/admin/order_print_ticket_spec.rb' + - 'spec/system/admin/order_print_ticket_spec.rb' # Offense count: 1 # Cop supports --auto-correct. @@ -329,12 +1194,13 @@ Rails/RelativeDateConstant: Exclude: - 'lib/tasks/data/remove_transient_data.rb' -# Offense count: 301 +# Offense count: 297 # Configuration parameters: ForbiddenMethods, AllowedMethods. # ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all Rails/SkipsModelValidations: Exclude: - 'app/controllers/admin/resource_controller.rb' + - 'app/controllers/checkout_controller.rb' - 'app/controllers/spree/admin/payment_methods_controller.rb' - 'app/controllers/spree/admin/shipping_methods_controller.rb' - 'app/controllers/spree/admin/taxons_controller.rb' @@ -392,29 +1258,17 @@ Rails/SkipsModelValidations: - 'spec/factories.rb' - 'spec/factories/order_factory.rb' - 'spec/factories/shipment_factory.rb' - - 'spec/features/admin/bulk_order_management_spec.rb' - - 'spec/features/admin/bulk_product_update_spec.rb' - - 'spec/features/admin/configuration/tax_rates_spec.rb' - - 'spec/features/admin/order_cycles/complex_editing_spec.rb' - - 'spec/features/admin/order_cycles/simple_spec.rb' - - 'spec/features/admin/order_spec.rb' - - 'spec/features/admin/payments_spec.rb' - - 'spec/features/admin/reports_spec.rb' - - 'spec/features/consumer/caching/shops_caching_spec.rb' - - 'spec/features/consumer/shopping/checkout_spec.rb' - - 'spec/features/consumer/shopping/products_spec.rb' - - 'spec/features/consumer/shopping/shopping_spec.rb' - - 'spec/features/consumer/shopping/unit_price_spec.rb' - 'spec/helpers/enterprises_helper_spec.rb' - 'spec/helpers/order_cycles_helper_spec.rb' - 'spec/lib/open_food_network/address_finder_spec.rb' - 'spec/lib/open_food_network/enterprise_fee_calculator_spec.rb' + - 'spec/lib/open_food_network/orders_and_fulfillments_report_spec.rb' - 'spec/lib/open_food_network/permissions_spec.rb' - 'spec/lib/open_food_network/products_and_inventory_report_spec.rb' - 'spec/lib/open_food_network/scope_variant_to_hub_spec.rb' + - 'spec/lib/reports/packing/packing_report_spec.rb' - 'spec/lib/stripe/credit_card_cloner_spec.rb' - 'spec/lib/tasks/data/remove_transient_data_spec.rb' - - 'spec/migrations/migrate_enterprise_fee_tax_amounts_spec.rb' - 'spec/models/concerns/variant_stock_spec.rb' - 'spec/models/enterprise_relationship_spec.rb' - 'spec/models/exchange_spec.rb' @@ -441,9 +1295,21 @@ Rails/SkipsModelValidations: - 'spec/services/product_tag_rules_filterer_spec.rb' - 'spec/services/products_renderer_spec.rb' - 'spec/support/request/shop_workflow.rb' + - 'spec/system/admin/bulk_order_management_spec.rb' + - 'spec/system/admin/bulk_product_update_spec.rb' + - 'spec/system/admin/configuration/tax_rates_spec.rb' + - 'spec/system/admin/order_cycles/complex_editing_spec.rb' + - 'spec/system/admin/order_cycles/simple_spec.rb' + - 'spec/system/admin/order_spec.rb' + - 'spec/system/admin/payments_spec.rb' + - 'spec/system/consumer/caching/shops_caching_spec.rb' + - 'spec/system/consumer/shopping/checkout_spec.rb' + - 'spec/system/consumer/shopping/products_spec.rb' + - 'spec/system/consumer/shopping/shopping_spec.rb' + - 'spec/system/consumer/shopping/unit_price_spec.rb' - 'spec/views/spree/shared/_order_details.html.haml_spec.rb' -# Offense count: 11 +# Offense count: 5 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible @@ -451,10 +1317,9 @@ Rails/TimeZone: Exclude: - 'app/models/spree/gateway/pay_pal_express.rb' - 'spec/controllers/spree/credit_cards_controller_spec.rb' - - 'spec/features/admin/order_cycles/complex_creating_specific_time_spec.rb' - - 'spec/features/admin/order_cycles/simple_spec.rb' - 'spec/models/spree/tax_rate_spec.rb' - 'spec/services/customer_order_cancellation_spec.rb' + - 'spec/system/admin/order_cycles/list_spec.rb' # Offense count: 5 # Configuration parameters: Include. @@ -475,6 +1340,17 @@ Rails/UnknownEnv: - 'app/controllers/spree/admin/payment_methods_controller.rb' - 'app/models/spree/app_configuration.rb' +# Offense count: 1 +Security/Open: + Exclude: + - 'app/services/image_importer.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Style/BlockComments: + Exclude: + - 'spec/system/admin/tag_rules_spec.rb' + # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: AllowOnConstant. @@ -482,14 +1358,13 @@ Style/CaseEquality: Exclude: - 'spec/models/spree/payment_spec.rb' -# Offense count: 4 +# Offense count: 3 # Cop supports --auto-correct. Style/CaseLikeIf: Exclude: - 'app/controllers/admin/order_cycles_controller.rb' - 'app/models/calculator/weight.rb' - 'app/models/spree/payment/processing.rb' - - 'lib/active_merchant/billing/gateways/stripe_payment_intents.rb' # Offense count: 25 # Cop supports --auto-correct. @@ -550,7 +1425,7 @@ Style/GlobalStdStream: - 'lib/tasks/subscriptions/debug.rake' - 'lib/tasks/subscriptions/test.rake' -# Offense count: 38 +# Offense count: 41 # Configuration parameters: MinBodyLength. Style/GuardClause: Exclude: @@ -560,6 +1435,7 @@ Style/GuardClause: - 'app/controllers/api/v0/shipments_controller.rb' - 'app/controllers/application_controller.rb' - 'app/controllers/home_controller.rb' + - 'app/controllers/spree/admin/shipping_methods_controller.rb' - 'app/controllers/spree/orders_controller.rb' - 'app/models/enterprise.rb' - 'app/models/enterprise_group.rb' @@ -575,6 +1451,7 @@ Style/GuardClause: - 'lib/spree/core/controller_helpers/respond_with.rb' - 'spec/support/request/distribution_helper.rb' - 'spec/support/request/shop_workflow.rb' + - 'spec/system/support/precompile_assets.rb' # Offense count: 1 # Configuration parameters: MinBranchesCount. @@ -582,6 +1459,13 @@ Style/HashLikeCase: Exclude: - 'app/models/enterprise.rb' +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: IgnoredMethods. +Style/MethodCallWithoutArgsParentheses: + Exclude: + - 'spec/system/flatpickr_spec.rb' + # Offense count: 3 Style/MissingRespondToMissing: Exclude: @@ -589,11 +1473,19 @@ Style/MissingRespondToMissing: - 'app/models/spree/gateway.rb' - 'app/models/spree/preferences/configuration.rb' -# Offense count: 2 +# Offense count: 1 Style/MixinUsage: Exclude: - 'lib/open_food_network/orders_and_fulfillments_report.rb' - - 'spec/lib/open_food_network/packing_report_spec.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: literals, strict +Style/MutableConstant: + Exclude: + - 'lib/reporting/report_template.rb' + - 'lib/reporting/reports/packing/base.rb' # Offense count: 22 # Cop supports --auto-correct. @@ -604,25 +1496,23 @@ Style/NestedModifier: - 'spec/controllers/spree/admin/orders_controller_spec.rb' - 'spec/controllers/spree/orders_controller_spec.rb' - 'spec/factories/order_factory.rb' - - 'spec/features/admin/payments_stripe_spec.rb' - - 'spec/features/admin/reports_spec.rb' - 'spec/models/proxy_order_spec.rb' - 'spec/models/spree/line_item_spec.rb' - 'spec/services/place_proxy_order_spec.rb' + - 'spec/system/admin/payments_stripe_spec.rb' + - 'spec/system/admin/reports_spec.rb' -# Offense count: 34 +# Offense count: 31 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IgnoredMethods. # SupportedStyles: predicate, comparison Style/NumericPredicate: Exclude: - - 'app/controllers/spree/admin/payment_methods_controller.rb' - 'app/controllers/spree/orders_controller.rb' - 'app/helpers/checkout_helper.rb' - 'app/helpers/shared_helper.rb' - 'app/models/product_import/product_importer.rb' - 'app/models/product_import/spreadsheet_entry.rb' - - 'app/models/spree/gateway/stripe_connect.rb' - 'app/models/spree/line_item.rb' - 'app/models/spree/order.rb' - 'app/models/spree/order_contents.rb' @@ -636,7 +1526,7 @@ Style/NumericPredicate: - 'lib/open_food_network/sales_tax_report.rb' - 'lib/tasks/sample_data.rake' -# Offense count: 26 +# Offense count: 25 # Configuration parameters: AllowedMethods. # AllowedMethods: respond_to_missing? Style/OptionalBooleanParameter: @@ -644,6 +1534,7 @@ Style/OptionalBooleanParameter: - 'app/controllers/admin/subscriptions_controller.rb' - 'app/mailers/spree/order_mailer.rb' - 'app/mailers/spree/shipment_mailer.rb' + - 'app/models/concerns/calculated_adjustments.rb' - 'app/models/enterprise_relationship.rb' - 'app/models/product_import/entry_processor.rb' - 'app/models/spree/order_contents.rb' @@ -655,12 +1546,10 @@ Style/OptionalBooleanParameter: - 'lib/open_food_network/order_and_distributor_report.rb' - 'lib/open_food_network/order_cycle_management_report.rb' - 'lib/open_food_network/orders_and_fulfillments_report.rb' - - 'lib/open_food_network/packing_report.rb' - 'lib/open_food_network/payments_report.rb' - 'lib/open_food_network/products_and_inventory_report_base.rb' - 'lib/open_food_network/users_and_enterprises_report.rb' - 'lib/open_food_network/xero_invoices_report.rb' - - 'lib/spree/core/calculated_adjustments.rb' - 'lib/spree/core/controller_helpers/order.rb' - 'lib/spree/core/delegate_belongs_to.rb' - 'spec/support/request/web_helper.rb' @@ -673,9 +1562,17 @@ Style/PreferredHashMethods: Exclude: - 'app/controllers/api/v0/shipments_controller.rb' -# Offense count: 223 +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: AllowMultipleReturnValues. +Style/RedundantReturn: + Exclude: + - 'app/controllers/spree/admin/shipping_methods_controller.rb' + +# Offense count: 220 Style/Send: Exclude: + - 'app/controllers/split_checkout_controller.rb' - 'engines/order_management/spec/services/order_management/reports/bulk_coop/bulk_coop_report_spec.rb' - 'spec/controllers/admin/subscriptions_controller_spec.rb' - 'spec/controllers/checkout_controller_spec.rb' @@ -703,7 +1600,6 @@ Style/Send: - 'spec/models/spree/order_spec.rb' - 'spec/models/spree/payment_spec.rb' - 'spec/models/spree/return_authorization_spec.rb' - - 'spec/models/spree/tax_rate_spec.rb' - 'spec/models/tag_rule/filter_order_cycles_spec.rb' - 'spec/models/tag_rule/filter_payment_methods_spec.rb' - 'spec/models/tag_rule/filter_products_spec.rb' @@ -714,12 +1610,11 @@ Style/Send: - 'spec/spec_helper.rb' - 'spec/support/localized_number_helper.rb' -# Offense count: 2 +# Offense count: 1 # Cop supports --auto-correct. Style/SingleArgumentDig: Exclude: - 'app/services/checkout/form_data_adapter.rb' - - 'lib/active_merchant/billing/gateways/stripe_payment_intents.rb' # Offense count: 5 # Cop supports --auto-correct. @@ -731,7 +1626,7 @@ Style/SlicingWithRange: - 'lib/discourse/single_sign_on.rb' - 'spec/lib/open_food_network/order_grouper_spec.rb' -# Offense count: 43 +# Offense count: 41 # Cop supports --auto-correct. # Configuration parameters: Mode. Style/StringConcatenation: @@ -753,11 +1648,7 @@ Style/StringConcatenation: - 'lib/spree/api/controller_setup.rb' - 'lib/spree/core/environment_extension.rb' - 'spec/controllers/user_confirmations_controller_spec.rb' - - 'spec/features/admin/bulk_order_management_spec.rb' - - 'spec/features/admin/products_spec.rb' - 'spec/features/consumer/account_spec.rb' - - 'spec/features/consumer/authentication_spec.rb' - - 'spec/features/consumer/shopping/shopping_spec.rb' - 'spec/lib/open_food_network/order_grouper_spec.rb' - 'spec/models/spree/line_item_spec.rb' - 'spec/models/spree/product_spec.rb' @@ -766,3 +1657,4 @@ Style/StringConcatenation: - 'spec/services/embedded_page_service_spec.rb' - 'spec/support/api_helper.rb' - 'spec/support/features/datepicker_helper.rb' + - 'spec/system/admin/products_spec.rb'