From 73ee14cc7c58e52cc0ec881a95e6558d1e06f541 Mon Sep 17 00:00:00 2001 From: luisramos0 Date: Sun, 10 Nov 2019 19:21:08 +0000 Subject: [PATCH] Fix long line in injection helper --- .rubocop_manual_todo.yml | 1 - app/helpers/admin/injection_helper.rb | 139 ++++++++++++++++++++------ 2 files changed, 111 insertions(+), 29 deletions(-) diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index d0f81abb78..c050bda9de 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -50,7 +50,6 @@ Metrics/LineLength: - app/controllers/spree/credit_cards_controller.rb - app/controllers/spree/paypal_controller_decorator.rb - app/controllers/stripe/callbacks_controller.rb - - app/helpers/admin/injection_helper.rb - app/helpers/angular_form_builder.rb - app/helpers/angular_form_helper.rb - app/helpers/checkout_helper.rb diff --git a/app/helpers/admin/injection_helper.rb b/app/helpers/admin/injection_helper.rb index bb04020f04..6b57512676 100644 --- a/app/helpers/admin/injection_helper.rb +++ b/app/helpers/admin/injection_helper.rb @@ -1,70 +1,118 @@ module Admin module InjectionHelper def admin_inject_enterprise - admin_inject_json_ams "admin.enterprises", "enterprise", @enterprise, Api::Admin::EnterpriseSerializer + admin_inject_json_ams "admin.enterprises", + "enterprise", + @enterprise, + Api::Admin::EnterpriseSerializer end def admin_inject_enterprises - admin_inject_json_ams_array("ofn.admin", "my_enterprises", @my_enterprises, Api::Admin::BasicEnterpriseSerializer) + - admin_inject_json_ams_array("ofn.admin", "all_enterprises", @all_enterprises, Api::Admin::BasicEnterpriseSerializer) + admin_inject_json_ams_array("ofn.admin", + "my_enterprises", + @my_enterprises, + Api::Admin::BasicEnterpriseSerializer) + + admin_inject_json_ams_array("ofn.admin", + "all_enterprises", + @all_enterprises, + Api::Admin::BasicEnterpriseSerializer) end def admin_inject_enterprise_relationships - admin_inject_json_ams_array "ofn.admin", "enterprise_relationships", @enterprise_relationships, Api::Admin::EnterpriseRelationshipSerializer + admin_inject_json_ams_array "ofn.admin", + "enterprise_relationships", + @enterprise_relationships, + Api::Admin::EnterpriseRelationshipSerializer end def admin_inject_enterprise_roles - admin_inject_json_ams_array "ofn.admin", "enterpriseRoles", @enterprise_roles, Api::Admin::EnterpriseRoleSerializer + admin_inject_json_ams_array "ofn.admin", + "enterpriseRoles", + @enterprise_roles, + Api::Admin::EnterpriseRoleSerializer end def admin_inject_payment_methods - admin_inject_json_ams_array "admin.paymentMethods", "paymentMethods", @payment_methods, Api::Admin::IdNameSerializer + admin_inject_json_ams_array "admin.paymentMethods", + "paymentMethods", + @payment_methods, + Api::Admin::IdNameSerializer end def admin_inject_payment_method - admin_inject_json_ams "admin.paymentMethods", "paymentMethod", @payment_method, Api::Admin::PaymentMethodSerializer + admin_inject_json_ams "admin.paymentMethods", + "paymentMethod", + @payment_method, + Api::Admin::PaymentMethodSerializer end def admin_inject_shipping_methods - admin_inject_json_ams_array "admin.shippingMethods", "shippingMethods", @shipping_methods, Api::Admin::IdNameSerializer + admin_inject_json_ams_array "admin.shippingMethods", + "shippingMethods", + @shipping_methods, + Api::Admin::IdNameSerializer end def admin_inject_shipping_method - admin_inject_json_ams "admin.shippingMethods", "shippingMethod", @shipping_method, Api::Admin::ShippingMethodSerializer + admin_inject_json_ams "admin.shippingMethods", + "shippingMethod", + @shipping_method, + Api::Admin::ShippingMethodSerializer end def admin_inject_shops(opts = {}) opts.reverse_merge!(module: 'admin.customers') - admin_inject_json_ams_array opts[:module], "shops", @shops, Api::Admin::IdNameSerializer + admin_inject_json_ams_array opts[:module], + "shops", + @shops, + Api::Admin::IdNameSerializer end def admin_inject_available_countries(opts = {}) opts.reverse_merge!(module: 'admin.customers') - admin_inject_json_ams_array opts[:module], 'availableCountries', available_countries, Api::CountrySerializer + admin_inject_json_ams_array opts[:module], + 'availableCountries', + available_countries, + Api::CountrySerializer end def admin_inject_hubs(opts = {}) opts.reverse_merge!(module: 'ofn.admin') - admin_inject_json_ams_array opts[:module], "hubs", @hubs, Api::Admin::IdNameSerializer + admin_inject_json_ams_array opts[:module], + "hubs", + @hubs, + Api::Admin::IdNameSerializer end def admin_inject_producers(opts = {}) opts.reverse_merge!(module: 'ofn.admin') - admin_inject_json_ams_array opts[:module], "producers", @producers, Api::Admin::IdNameSerializer + admin_inject_json_ams_array opts[:module], + "producers", + @producers, + Api::Admin::IdNameSerializer end def admin_inject_inventory_items(opts = { module: 'ofn.admin' }) - admin_inject_json_ams_array opts[:module], "inventoryItems", @inventory_items, Api::Admin::InventoryItemSerializer + admin_inject_json_ams_array opts[:module], + "inventoryItems", + @inventory_items, + Api::Admin::InventoryItemSerializer end def admin_inject_column_preferences(opts = {}) opts.reverse_merge!(module: 'ofn.admin', action: "#{controller_name}_#{action_name}") column_preferences = ColumnPreference.for(spree_current_user, opts[:action]) - admin_inject_json_ams_array opts[:module], "columns", column_preferences, Api::Admin::ColumnPreferenceSerializer + admin_inject_json_ams_array opts[:module], + "columns", + column_preferences, + Api::Admin::ColumnPreferenceSerializer end def admin_inject_currency_config - admin_inject_json_ams 'admin.utils', "currencyConfig", {}, Api::CurrencyConfigSerializer + admin_inject_json_ams 'admin.utils', + "currencyConfig", + {}, + Api::CurrencyConfigSerializer end def admin_inject_enterprise_permissions @@ -77,7 +125,9 @@ module Admin end def admin_inject_hub_permissions - render partial: "admin/json/injection_ams", locals: { ngModule: "admin.variantOverrides", name: "hubPermissions", json: @hub_permissions.to_json } + render partial: "admin/json/injection_ams", locals: { ngModule: "admin.variantOverrides", + name: "hubPermissions", + json: @hub_permissions.to_json } end def admin_inject_products @@ -85,46 +135,79 @@ module Admin end def admin_inject_tax_categories(opts = { module: 'ofn.admin' }) - admin_inject_json_ams_array opts[:module], "tax_categories", @tax_categories, Api::Admin::TaxCategorySerializer + admin_inject_json_ams_array opts[:module], + "tax_categories", + @tax_categories, + Api::Admin::TaxCategorySerializer end def admin_inject_taxons - admin_inject_json_ams_array "admin.taxons", "taxons", @taxons, Api::Admin::TaxonSerializer + admin_inject_json_ams_array "admin.taxons", + "taxons", + @taxons, + Api::Admin::TaxonSerializer end def admin_inject_users - admin_inject_json_ams_array "ofn.admin", "users", @users, Api::Admin::UserSerializer + admin_inject_json_ams_array "ofn.admin", + "users", + @users, + Api::Admin::UserSerializer end def admin_inject_variant_overrides - admin_inject_json_ams_array "admin.variantOverrides", "variantOverrides", @variant_overrides, Api::Admin::VariantOverrideSerializer + admin_inject_json_ams_array "admin.variantOverrides", + "variantOverrides", + @variant_overrides, + Api::Admin::VariantOverrideSerializer end def admin_inject_order_cycle_instance - render partial: "admin/json/injection_ams", locals: { ngModule: 'admin.orderCycles', name: 'ocInstance', json: "{coordinator_id: '#{@order_cycle.coordinator.id}'}" } + render partial: "admin/json/injection_ams", + locals: { ngModule: 'admin.orderCycles', + name: 'ocInstance', + json: "{coordinator_id: '#{@order_cycle.coordinator.id}'}" } end def admin_inject_order_cycles - admin_inject_json_ams_array "admin.orders", "orderCycles", @order_cycles, Api::Admin::BasicOrderCycleSerializer, current_user: spree_current_user + admin_inject_json_ams_array "admin.orders", + "orderCycles", + @order_cycles, + Api::Admin::BasicOrderCycleSerializer, + current_user: spree_current_user end def admin_inject_spree_api_key - render partial: "admin/json/injection_ams", locals: { ngModule: 'admin.indexUtils', name: 'SpreeApiKey', json: "'#{@spree_api_key}'" } + render partial: "admin/json/injection_ams", + locals: { ngModule: 'admin.indexUtils', + name: 'SpreeApiKey', + json: "'#{@spree_api_key}'" } end def admin_inject_json(ng_module, name, data) json = data.to_json - render partial: "admin/json/injection_ams", locals: { ngModule: ng_module, name: name, json: json } + render partial: "admin/json/injection_ams", + locals: { ngModule: ng_module, + name: name, + json: json } end def admin_inject_json_ams(ng_module, name, data, serializer, opts = {}) json = serializer.new(data, { scope: spree_current_user }.merge(opts)).to_json - render partial: "admin/json/injection_ams", locals: { ngModule: ng_module, name: name, json: json } + render partial: "admin/json/injection_ams", + locals: { ngModule: ng_module, + name: name, + json: json } end def admin_inject_json_ams_array(ng_module, name, data, serializer, opts = {}) - json = ActiveModel::ArraySerializer.new(data, { each_serializer: serializer, scope: spree_current_user }.merge(opts)).to_json - render partial: "admin/json/injection_ams", locals: { ngModule: ng_module, name: name, json: json } + json = ActiveModel::ArraySerializer. + new(data, { each_serializer: serializer, scope: spree_current_user }.merge(opts)).to_json + + render partial: "admin/json/injection_ams", + locals: { ngModule: ng_module, + name: name, + json: json } end end end