From 73e5fd3f5b906a64fd38bb18359dde9586f34659 Mon Sep 17 00:00:00 2001
From: Andy Brett <andy@andybrett.com>
Date: Wed, 28 Apr 2021 10:21:35 -0700
Subject: [PATCH] use method to clarify intent on payment intents

---
 app/models/spree/payment/processing.rb | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/app/models/spree/payment/processing.rb b/app/models/spree/payment/processing.rb
index e9e3048023..b59f3663ff 100644
--- a/app/models/spree/payment/processing.rb
+++ b/app/models/spree/payment/processing.rb
@@ -6,18 +6,14 @@ module Spree
       def process!
         return unless validate!
 
-        if response_code
-          capture!
-        else
-          purchase!
-        end
+        purchase!
       end
 
       def process_offline!
         return unless validate!
         return if authorization_action_required?
 
-        if response_code
+        if preauthorized?
           capture!
         else
           charge_offline!
@@ -192,6 +188,10 @@ module Spree
 
       private
 
+      def preauthorized?
+        response_code.presence&.match("pi_")
+      end
+
       def validate!
         return false unless payment_method&.source_required?