From 73b2d37224ec256e4ddf81d25d2fef222132646d Mon Sep 17 00:00:00 2001 From: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com> Date: Tue, 13 Jun 2023 15:12:13 +0100 Subject: [PATCH] Don't try to load orders if the number of line_items with the current filters applied is zero This ends up sending a request to the orders endpoint with no filters and no search params, which then tries to load every order in the entire database if the user is superadmin, which blows up. --- .../line_items/controllers/line_items_controller.js.coffee | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/assets/javascripts/admin/line_items/controllers/line_items_controller.js.coffee b/app/assets/javascripts/admin/line_items/controllers/line_items_controller.js.coffee index 4fd6656a27..88d6fd6ab9 100644 --- a/app/assets/javascripts/admin/line_items/controllers/line_items_controller.js.coffee +++ b/app/assets/javascripts/admin/line_items/controllers/line_items_controller.js.coffee @@ -62,6 +62,8 @@ angular.module("admin.lineItems").controller 'LineItemsCtrl', ($scope, $timeout, $scope.dereferenceLoadedData() $scope.loadOrders = -> + return $scope.orders = [] unless $scope.line_items.length + RequestMonitor.load $scope.orders = Orders.index( "q[id_in][]": $scope.line_items.map((line_item) -> line_item.order.id) )