From 72640cfc2ac2d047e8dc657acc2b610b8b5e35ab Mon Sep 17 00:00:00 2001 From: Ahmed Ejaz Date: Mon, 24 Jun 2024 14:43:17 +0500 Subject: [PATCH] 12346: refactor orders_controller spec --- spec/controllers/api/v0/orders_controller_spec.rb | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/spec/controllers/api/v0/orders_controller_spec.rb b/spec/controllers/api/v0/orders_controller_spec.rb index 55ccf415e9..6755ae0678 100644 --- a/spec/controllers/api/v0/orders_controller_spec.rb +++ b/spec/controllers/api/v0/orders_controller_spec.rb @@ -155,23 +155,22 @@ module Api create(:order_with_line_items, billing_address: nil, order_cycle:, distributor:) } + let(:expected_order_ids) { + serialized_orders([order2, order3, order1, order4, order7]).pluck('id') + } it 'can show orders without bill address' do get :index, params: { q: {} }, as: :json - expect(json_response['orders'] - .pluck('id')).to match_array serialized_orders([order2, order3, order1, order4, - order7]) - .pluck('id') + expect(json_response[:orders].pluck(:id)).to match_array(expected_order_ids) end it 'can sort orders by bill_address.lastname' do get :index, params: { q: { s: 'bill_address_lastname ASC' } }, as: :json - expect(json_response['orders'] - .pluck('id')).to eq serialized_orders([order2, order3, order1, order4, order7]) - .pluck('id') + + expect(json_response[:orders].pluck(:id)).to eq expected_order_ids end end end