From 70b7143e7b7dfba31b6106ecfcaca911470195aa Mon Sep 17 00:00:00 2001 From: Andy Brett Date: Wed, 17 Mar 2021 11:33:27 -0700 Subject: [PATCH] reload line items and recalculate fees after removing line item --- app/jobs/subscription_placement_job.rb | 7 ++++++- app/models/spree/order_inventory.rb | 3 +-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/app/jobs/subscription_placement_job.rb b/app/jobs/subscription_placement_job.rb index 432ddc021a..4cd02392a4 100644 --- a/app/jobs/subscription_placement_job.rb +++ b/app/jobs/subscription_placement_job.rb @@ -62,7 +62,12 @@ class SubscriptionPlacementJob < ActiveJob::Base unavailable_stock_lines_for(order).each do |line_item| changes[line_item.id] = changes[line_item.id] || line_item.quantity line_item.update(quantity: 0) - Spree::OrderInventory.new(order).verify(line_item) + + Spree::OrderInventory.new(order).verify(line_item, order.shipment) + end + if changes.present? + order.line_items.reload + order.update_order_fees! end changes end diff --git a/app/models/spree/order_inventory.rb b/app/models/spree/order_inventory.rb index 8416bb4755..44ff226609 100644 --- a/app/models/spree/order_inventory.rb +++ b/app/models/spree/order_inventory.rb @@ -98,8 +98,7 @@ module Spree inventory_unit.destroy removed_quantity += 1 end - - shipment.destroy if shipment.inventory_units.count == 0 + shipment.destroy if shipment.inventory_units.reload.count == 0 # removing this from shipment, and adding to stock_location if order.completed?