From 705295049e8d602effc481286cc0d6effde6a545 Mon Sep 17 00:00:00 2001
From: Duende13 <susana.r.cunado@gmail.com>
Date: Mon, 26 Jun 2017 23:11:45 +1000
Subject: [PATCH] Improved test for variant serializer

---
 spec/serializers/variant_serializer_spec.rb | 24 ++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/spec/serializers/variant_serializer_spec.rb b/spec/serializers/variant_serializer_spec.rb
index 852645c160..4ddc0f75fb 100644
--- a/spec/serializers/variant_serializer_spec.rb
+++ b/spec/serializers/variant_serializer_spec.rb
@@ -1,13 +1,27 @@
 require 'spec_helper'
 
 describe Api::VariantSerializer do
-  let(:serializer) { Api::VariantSerializer.new variant }
+  
+  subject { Api::VariantSerializer.new variant }
   let(:variant) { create(:variant) }
 
-
-  it "serializes a variant" do
-    expect(serializer.to_json).to match variant.id.to_s
+  it "includes the expected attributes " do 
+    expect(subject.attributes.keys).
+    to include(
+        :id,
+        :name_to_display, 
+        :is_master, 
+        :count_on_hand, 
+        :name_to_display, 
+        :unit_to_display, 
+        :unit_value,
+        :options_text, 
+        :on_demand, 
+        :price, 
+        :fees, 
+        :price_with_fees, 
+        :product_name
+      )
   end
 
-
 end