From 6fae80bb04387f40bded4eec9d2686eafb644272 Mon Sep 17 00:00:00 2001 From: Pau Perez Date: Mon, 15 Mar 2021 12:24:54 +0100 Subject: [PATCH] Fix deprecation warning related to #reload This fixes: ``` DEPRECATION WARNING: Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload` on the result collection proxy instead. (called from can_own_more_enterprises? at /usr/src/app/app/models/spree/user.rb:112) ``` This method in particular gets called a lot of times so it'll have it's cost in performance. --- app/models/spree/user.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/spree/user.rb b/app/models/spree/user.rb index 8d6f4add10..ab1ef6ddfc 100644 --- a/app/models/spree/user.rb +++ b/app/models/spree/user.rb @@ -109,7 +109,7 @@ module Spree end def can_own_more_enterprises? - owned_enterprises(:reload).size < enterprise_limit + owned_enterprises.reload.size < enterprise_limit end def default_card