From 6c9e12b4ea9ce0daf044cfbb8a2fa14252d48704 Mon Sep 17 00:00:00 2001 From: Luis Ramos Date: Thu, 5 Nov 2020 11:31:51 +0000 Subject: [PATCH] Update rubocop exceptions file after bye bye spree --- .rubocop_todo.yml | 40 +++++++++++++++------------------------- 1 file changed, 15 insertions(+), 25 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index ea841b8a8b..342484d5ad 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 1400` -# on 2020-10-30 17:18:53 +0000 using RuboCop version 0.81.0. +# on 2020-11-05 11:27:59 +0000 using RuboCop version 0.81.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -27,13 +27,6 @@ Lint/UselessAccessModifier: - 'app/services/mail_configuration.rb' - 'lib/open_food_network/feature_toggle.rb' -# Offense count: 2 -Lint/UselessAssignment: - Exclude: - - 'spec/**/*' - - 'app/models/spree/taxon.rb' - - 'lib/spree/core/controller_helpers/common.rb' - # Offense count: 10 Naming/AccessorMethodName: Exclude: @@ -60,7 +53,7 @@ Naming/MemoizedInstanceVariableName: - 'app/mailers/producer_mailer.rb' - 'lib/open_food_network/address_finder.rb' -# Offense count: 24 +# Offense count: 25 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ # ForbiddenPrefixes: is_, has_, have_ @@ -72,6 +65,7 @@ Naming/PredicateName: - 'app/models/enterprise.rb' - 'app/models/enterprise_relationship.rb' - 'app/models/order_cycle.rb' + - 'app/models/spree/ability.rb' - 'app/models/spree/adjustment.rb' - 'app/models/spree/credit_card.rb' - 'app/models/spree/line_item.rb' @@ -125,7 +119,7 @@ Rails/Delegate: - 'app/models/spree/line_item.rb' - 'engines/order_management/app/services/order_management/reports/bulk_coop/renderers/html_renderer.rb' -# Offense count: 16 +# Offense count: 15 # Configuration parameters: EnforcedStyle. # SupportedStyles: slashes, arguments Rails/FilePath: @@ -139,7 +133,6 @@ Rails/FilePath: - 'spec/factories/product_factory.rb' - 'spec/features/admin/enterprises/images_spec.rb' - 'spec/models/content_configuration_spec.rb' - - 'spec/models/spree/variant_spec.rb' - 'spec/serializers/api/admin/enterprise_serializer_spec.rb' - 'spec/support/downloads_helper.rb' @@ -163,7 +156,7 @@ Rails/FindEach: Exclude: - 'app/models/spree/shipment.rb' -# Offense count: 9 +# Offense count: 11 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/HasAndBelongsToMany: @@ -172,12 +165,14 @@ Rails/HasAndBelongsToMany: - 'app/models/enterprise.rb' - 'app/models/enterprise_group.rb' - 'app/models/spree/line_item.rb' + - 'app/models/spree/option_value.rb' - 'app/models/spree/role.rb' - 'app/models/spree/shipping_method.rb' - 'app/models/spree/user.rb' + - 'app/models/spree/variant.rb' - 'app/models/spree/zone.rb' -# Offense count: 38 +# Offense count: 41 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/HasManyOrHasOneDependent: @@ -197,7 +192,7 @@ Rails/HasManyOrHasOneDependent: - 'app/models/spree/shipping_method.rb' - 'app/models/spree/taxonomy.rb' - 'app/models/spree/user.rb' - - 'app/models/spree/variant_decorator.rb' + - 'app/models/spree/variant.rb' - 'app/models/subscription.rb' # Offense count: 84 @@ -272,7 +267,7 @@ Rails/ReflectionClassName: - 'app/models/spree/order.rb' - 'app/models/subscription.rb' -# Offense count: 247 +# Offense count: 250 # Configuration parameters: Blacklist, Whitelist. # Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters Rails/SkipsModelValidations: @@ -294,10 +289,12 @@ Rails/SkipsModelValidations: - 'app/models/spree/inventory_unit.rb' - 'app/models/spree/order.rb' - 'app/models/spree/payment.rb' + - 'app/models/spree/product.rb' - 'app/models/spree/shipment.rb' - 'app/models/spree/shipping_method.rb' - 'app/models/spree/tax_category.rb' - 'app/models/spree/taxonomy.rb' + - 'app/models/spree/variant.rb' - 'app/models/spree/zone.rb' - 'app/models/subscription.rb' - 'app/models/variant_override.rb' @@ -440,7 +437,7 @@ Style/FormatStringToken: - 'lib/open_food_network/sales_tax_report.rb' - 'spec/features/admin/bulk_order_management_spec.rb' -# Offense count: 765 +# Offense count: 760 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never @@ -635,16 +632,10 @@ Style/FrozenStringLiteralComment: - 'app/models/spree/gateway/migs.rb' - 'app/models/spree/gateway/pin.rb' - 'app/models/spree/gateway/stripe_connect.rb' - - 'app/models/spree/option_type_decorator.rb' - 'app/models/spree/preferences/file_configuration.rb' - - 'app/models/spree/price_decorator.rb' - - 'app/models/spree/product_decorator.rb' - - 'app/models/spree/product_option_type_decorator.rb' - - 'app/models/spree/product_property_decorator.rb' - 'app/models/spree/product_set.rb' - 'app/models/spree/property.rb' - 'app/models/spree/user.rb' - - 'app/models/spree/variant_decorator.rb' - 'app/models/stripe_account.rb' - 'app/models/subscription.rb' - 'app/models/subscription_line_item.rb' @@ -920,6 +911,7 @@ Style/FrozenStringLiteralComment: - 'spec/factories/enterprise_factory.rb' - 'spec/factories/order_cycle_factory.rb' - 'spec/factories/order_factory.rb' + - 'spec/factories/price_factory.rb' - 'spec/factories/product_factory.rb' - 'spec/factories/return_authorization_factory.rb' - 'spec/factories/shipment_factory.rb' @@ -1212,7 +1204,7 @@ Style/FrozenStringLiteralComment: - 'spec/views/spree/admin/payment_methods/index.html.haml_spec.rb' - 'spec/views/spree/admin/shared/_order_links.html.haml_spec.rb' -# Offense count: 44 +# Offense count: 39 # Configuration parameters: MinBodyLength. Style/GuardClause: Exclude: @@ -1229,8 +1221,6 @@ Style/GuardClause: - 'app/models/enterprise_group.rb' - 'app/models/producer_property.rb' - 'app/models/spree/preferences/preferable_class_methods.rb' - - 'app/models/spree/price_decorator.rb' - - 'app/models/spree/product_decorator.rb' - 'app/services/order_syncer.rb' - 'app/services/variant_units/variant_and_line_item_naming.rb' - 'lib/discourse/single_sign_on.rb'