From 6ad0749ce8fbc31fda4adedd4d571d0d5fa8e733 Mon Sep 17 00:00:00 2001 From: binarygit Date: Tue, 12 Jul 2022 14:11:53 +0545 Subject: [PATCH] Refactor: create parent_node var to find child elements --- .../admin/spree/orders/variant_autocomplete.js.erb | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/app/assets/javascripts/admin/spree/orders/variant_autocomplete.js.erb b/app/assets/javascripts/admin/spree/orders/variant_autocomplete.js.erb index 84c973c803..bc3dd5738c 100644 --- a/app/assets/javascripts/admin/spree/orders/variant_autocomplete.js.erb +++ b/app/assets/javascripts/admin/spree/orders/variant_autocomplete.js.erb @@ -141,24 +141,26 @@ doAdjustItems = function(shipment_number, variant_id, quantity, inventory_units, toggleTrackingEdit = function(){ var link = $(this); - let input = link.parents('tbody').find('#tracking')[0] - link.parents('tbody').find('tr.edit-tracking').toggle(); + var parent_node = link.parents('tbody') + let input = parent_node.find('#tracking')[0] + parent_node.find('tr.edit-tracking').toggle(); // Set focus on input and // put cursor at it's end input.focus() input.setSelectionRange(-1, -1) - link.parents('tbody').find('tr.show-tracking').toggle(); + parent_node.find('tr.show-tracking').toggle(); } toggleNoteEdit = function(){ var link = $(this); - let input = link.parents('tbody').find('#note')[0] - link.parents('tbody').find('tr.edit-note').toggle(); + var parent_node = link.parents('tbody') + let input = parent_node.find('#note')[0] + parent_node.find('tr.edit-note').toggle(); // Set focus on input and // put cursor at it's end input.focus() input.setSelectionRange(-1, -1) - link.parents('tbody').find('tr.show-note').toggle(); + parent_node.find('tr.show-note').toggle(); } toggleMethodEdit = function(){