From 5892eab4e30721ac35602828ec91127b4833339f Mon Sep 17 00:00:00 2001
From: filipefurtad0 <filipefurtado@gmail.com>
Date: Wed, 15 Jun 2022 16:36:13 +0100
Subject: [PATCH 1/8] Removes spree namespace; adds pending on failing examples
 - enterprise_fee_r

---
 .../reports/enterprise_fee_summaries_spec.rb  | 62 ++++++++++---------
 1 file changed, 34 insertions(+), 28 deletions(-)

diff --git a/spec/system/admin/reports/enterprise_fee_summaries_spec.rb b/spec/system/admin/reports/enterprise_fee_summaries_spec.rb
index 51bf9b41f2..b558a3ae64 100644
--- a/spec/system/admin/reports/enterprise_fee_summaries_spec.rb
+++ b/spec/system/admin/reports/enterprise_fee_summaries_spec.rb
@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require "spec_helper"
+require "system_helper"
 
-feature "enterprise fee summaries", js: true do
+describe "enterprise fee summaries" do
   include AuthenticationHelper
   include WebHelper
 
@@ -15,36 +15,40 @@ feature "enterprise fee summaries", js: true do
   before do
     login_as current_user
   end
-
-  describe "navigation" do
-    context "when accessing the report as an superadmin" do
-      let(:current_user) { create(:admin_user) }
-
-      it "shows link and allows access to the report" do
-        visit spree.admin_reports_path
-        click_on I18n.t("admin.reports.enterprise_fee_summary.name")
-        expect(page).to have_button("Go")
-      end
+  
+  describe "visiting the reports page" do
+        
+    before do
+      visit admin_reports_path
     end
+  
+    describe "navigation" do
+      context "when accessing the report as an superadmin" do
+        let(:current_user) { create(:admin_user) }
 
-    context "when accessing the report as an admin" do
-      let(:current_user) { distributor.owner }
-
-      it "shows link and allows access to the report" do
-        visit spree.admin_reports_path
-        click_on I18n.t("admin.reports.enterprise_fee_summary.name")
-        expect(page).to have_button("Go")
+        it "shows link and allows access to the report" do
+          click_on I18n.t("admin.reports.enterprise_fee_summary.name")
+          expect(page).to have_button("Go")
+        end
       end
-    end
 
-    context "when accessing the report as an enterprise user without sufficient permissions" do
-      let(:current_user) { create(:user) }
+      context "when accessing the report as an admin" do
+        let(:current_user) { distributor.owner }
 
-      it "does not allow access to the report" do
-        visit spree.admin_reports_path
-        expect(page).to have_no_link(I18n.t("admin.reports.enterprise_fee_summary.name"))
-        visit main_app.admin_report_path(report_type: 'enterprise_fee_summary')
-        expect(page).to have_content(I18n.t("unauthorized"))
+        it "shows link and allows access to the report" do
+          click_on I18n.t("admin.reports.enterprise_fee_summary.name")
+          expect(page).to have_button("Go")
+        end
+      end
+
+      context "when accessing the report as an enterprise user without sufficient permissions" do
+        let(:current_user) { create(:user) }
+
+        it "does not allow access to the report" do
+          expect(page).to have_no_link(I18n.t("admin.reports.enterprise_fee_summary.name"))
+          visit main_app.admin_report_path(report_type: 'enterprise_fee_summary')
+          expect(page).to have_content(I18n.t("unauthorized"))
+        end
       end
     end
   end
@@ -91,8 +95,8 @@ feature "enterprise fee summaries", js: true do
                                              distributor: distributor)
         end
         let(:current_user) { create(:admin_user) }
-
         it "generates file with data for all enterprises" do
+          pending "reports overhaul spec update"
           check I18n.t("filters.report_format_csv", scope: i18n_scope)
           click_on "Go"
 
@@ -113,6 +117,7 @@ feature "enterprise fee summaries", js: true do
         let(:current_user) { distributor.owner }
 
         it "generates file with data for the enterprise" do
+          pending "reports overhaul spec update"
           check I18n.t("filters.report_format_csv", scope: i18n_scope)
           click_on "Go"
 
@@ -144,6 +149,7 @@ feature "enterprise fee summaries", js: true do
       end
 
       it "generates file with data for selected order cycle" do
+        pending "reports overhaul spec update"
         select order_cycle.name, from: "report_order_cycle_ids"
         check I18n.t("filters.report_format_csv", scope: i18n_scope)
         click_on "Go"

From 32e247bf7590b6cb04de53a39f5b6a1fc2332d51 Mon Sep 17 00:00:00 2001
From: filipefurtad0 <filipefurtado@gmail.com>
Date: Wed, 15 Jun 2022 16:52:24 +0100
Subject: [PATCH 2/8] Removes spree namespace; adds pending on failing examples
 - packing_r

---
 .../admin/reports/enterprise_fee_summaries_spec.rb     |  5 ++---
 spec/system/admin/reports/packing_report_spec.rb       | 10 +++++++---
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/spec/system/admin/reports/enterprise_fee_summaries_spec.rb b/spec/system/admin/reports/enterprise_fee_summaries_spec.rb
index b558a3ae64..dab77cc93e 100644
--- a/spec/system/admin/reports/enterprise_fee_summaries_spec.rb
+++ b/spec/system/admin/reports/enterprise_fee_summaries_spec.rb
@@ -15,13 +15,12 @@ describe "enterprise fee summaries" do
   before do
     login_as current_user
   end
-  
+
   describe "visiting the reports page" do
-        
     before do
       visit admin_reports_path
     end
-  
+
     describe "navigation" do
       context "when accessing the report as an superadmin" do
         let(:current_user) { create(:admin_user) }
diff --git a/spec/system/admin/reports/packing_report_spec.rb b/spec/system/admin/reports/packing_report_spec.rb
index efe64b1901..850f66910d 100644
--- a/spec/system/admin/reports/packing_report_spec.rb
+++ b/spec/system/admin/reports/packing_report_spec.rb
@@ -2,14 +2,14 @@
 
 require "system_helper"
 
-describe "Packing Reports", js: true do
+describe "Packing Reports" do
   include AuthenticationHelper
   include WebHelper
 
   describe "Packing reports" do
     before do
       login_as_admin
-      visit spree.admin_reports_path
+      visit admin_reports_path
     end
 
     let(:bill_address1) { create(:address, lastname: "MULLER") }
@@ -43,6 +43,7 @@ describe "Packing Reports", js: true do
 
     describe "Pack By Customer" do
       it "displays the report" do
+        pending "reports overhaul spec update"
         click_link "Pack By Customer"
         fill_in 'q_completed_at_gt', with: '2013-04-25 13:00:00'
         fill_in 'q_completed_at_lt', with: '2013-04-25 16:00:00'
@@ -58,6 +59,7 @@ describe "Packing Reports", js: true do
       end
 
       it "sorts alphabetically" do
+        pending "reports overhaul spec update"
         click_link "Pack By Customer"
         click_button 'Go'
 
@@ -76,6 +78,7 @@ describe "Packing Reports", js: true do
 
     describe "Pack By Supplier" do
       it "displays the report" do
+        pending "reports overhaul spec update"
         click_link "Pack By Supplier"
         fill_in 'q_completed_at_gt', with: '2013-04-25 13:00:00'
         fill_in 'q_completed_at_lt', with: '2013-04-25 16:00:00'
@@ -112,9 +115,10 @@ describe "Packing Reports", js: true do
     describe "viewing a report" do
       context "when an associated variant has been soft-deleted" do
         it "shows line items" do
+          pending "reports overhaul spec update"
           li1.variant.delete
 
-          visit spree.admin_reports_path
+          visit admin_reports_path
 
           click_on I18n.t("admin.reports.packing.name")
           select oc.name, from: "q_order_cycle_id_in"

From 54bcd75f3f5ed72bd2f7786be8c3ef242a83158b Mon Sep 17 00:00:00 2001
From: filipefurtad0 <filipefurtado@gmail.com>
Date: Wed, 15 Jun 2022 18:32:35 +0100
Subject: [PATCH 3/8] Corrects namespace; adds pending on failing examples -
 payment_r

---
 spec/system/admin/reports/payments_report_spec.rb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/spec/system/admin/reports/payments_report_spec.rb b/spec/system/admin/reports/payments_report_spec.rb
index d2e4396466..641a5a8570 100644
--- a/spec/system/admin/reports/payments_report_spec.rb
+++ b/spec/system/admin/reports/payments_report_spec.rb
@@ -31,11 +31,12 @@ describe "Payments Reports" do
     create(:line_item_with_shipment, order: other_order, product: product)
 
     login_as_admin
+    visit main_app.admin_report_path(report_type: 'payments')
   end
 
   context "when choosing itemised payments report type" do
     it "shows orders with payment state, their balance and totals" do
-      visit spree.payments_admin_reports_path
+      pending "reports overhaul spec update"
 
       select I18n.t(:report_itemised_payment), from: "report_subtype"
       find("[type='submit']").click
@@ -72,7 +73,7 @@ describe "Payments Reports" do
     }
 
     it 'shows orders with payment state, their balance and and payment totals' do
-      visit spree.payments_admin_reports_path
+      pending "reports overhaul spec update"
 
       select I18n.t(:report_payment_totals), from: "report_subtype"
       find("[type='submit']").click

From b0d29c6dbc12929f0aea78a519d972e9a16fd0f9 Mon Sep 17 00:00:00 2001
From: filipefurtad0 <filipefurtado@gmail.com>
Date: Thu, 16 Jun 2022 15:15:01 +0100
Subject: [PATCH 4/8] Updates spec settings to address timeout error

---
 spec/support/downloads_helper.rb     | 10 ++--------
 spec/system/support/cuprite_setup.rb |  1 +
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/spec/support/downloads_helper.rb b/spec/support/downloads_helper.rb
index a85bcca55b..a9cf3cf60d 100644
--- a/spec/support/downloads_helper.rb
+++ b/spec/support/downloads_helper.rb
@@ -4,7 +4,7 @@ module DownloadsHelper
   TIMEOUT = 10
 
   def self.path
-    Rails.root.join("tmp", "downloads")
+    Rails.root.join("tmp", "capybara")
   end
 
   def downloaded_filename
@@ -17,16 +17,10 @@ module DownloadsHelper
     File.read(downloaded_filename)
   end
 
-  def with_empty_downloads_folder
-    remove_downloaded_files
-    yield
-    remove_downloaded_files
-  end
-
   private
 
   def downloaded_filenames
-    Dir[DownloadsHelper.path.join("*")]
+    Dir[DownloadsHelper.path.join("*")].select { |f| File.file?(f) }
   end
 
   def wait_for_download
diff --git a/spec/system/support/cuprite_setup.rb b/spec/system/support/cuprite_setup.rb
index 07a42e7039..18ae445ede 100644
--- a/spec/system/support/cuprite_setup.rb
+++ b/spec/system/support/cuprite_setup.rb
@@ -38,5 +38,6 @@ RSpec.configure do |config|
       "#{Capybara.current_session.server.host}:#{Capybara.current_session.server.port}"
     example.run
     Rails.application.default_url_options[:host] = original_host
+    remove_downloaded_files
   end
 end

From db8eb523597a043ce8c8873729c75b3b487cd3af Mon Sep 17 00:00:00 2001
From: filipefurtad0 <filipefurtado@gmail.com>
Date: Thu, 16 Jun 2022 16:11:13 +0100
Subject: [PATCH 5/8] Updates enterprise_summary_fee spec

---
 .../reports/enterprise_fee_summaries_spec.rb  | 44 +++++++++----------
 1 file changed, 21 insertions(+), 23 deletions(-)

diff --git a/spec/system/admin/reports/enterprise_fee_summaries_spec.rb b/spec/system/admin/reports/enterprise_fee_summaries_spec.rb
index dab77cc93e..ffc9cc4d98 100644
--- a/spec/system/admin/reports/enterprise_fee_summaries_spec.rb
+++ b/spec/system/admin/reports/enterprise_fee_summaries_spec.rb
@@ -79,26 +79,21 @@ describe "enterprise fee summaries" do
   end
 
   describe "csv downloads" do
-    around do |example|
-      with_empty_downloads_folder { example.run }
-    end
-
     describe "smoke test for generation of report based on permissions" do
-      before do
-        visit main_app.admin_report_path(report_type: 'enterprise_fee_summary')
-      end
-
       context "when logged in as admin" do
         let!(:order) do
           create(:completed_order_with_fees, order_cycle: order_cycle,
                                              distributor: distributor)
         end
         let(:current_user) { create(:admin_user) }
-        it "generates file with data for all enterprises" do
-          pending "reports overhaul spec update"
-          check I18n.t("filters.report_format_csv", scope: i18n_scope)
-          click_on "Go"
 
+        before do
+          visit main_app.admin_report_path(report_type: 'enterprise_fee_summary')
+        end
+
+        it "generates file with data for all enterprises" do
+          select "CSV"
+          click_on "Go"
           expect(downloaded_filename).to include ".csv"
           expect(downloaded_content).to have_content(distributor.name)
         end
@@ -115,15 +110,17 @@ describe "enterprise fee summaries" do
         end
         let(:current_user) { distributor.owner }
 
+        before do
+          visit main_app.admin_report_path(report_type: 'enterprise_fee_summary')
+        end
+
         it "generates file with data for the enterprise" do
-          pending "reports overhaul spec update"
-          check I18n.t("filters.report_format_csv", scope: i18n_scope)
+          select "CSV"
           click_on "Go"
 
           expect(downloaded_filename).to include ".csv"
-          csv_content = downloaded_content
-          expect(csv_content).to have_content(distributor.name)
-          expect(csv_content).not_to have_content(other_distributor.name)
+          expect(downloaded_content).to have_content(distributor.name)
+          expect(downloaded_content).not_to have_content(other_distributor.name)
         end
       end
     end
@@ -148,15 +145,16 @@ describe "enterprise fee summaries" do
       end
 
       it "generates file with data for selected order cycle" do
-        pending "reports overhaul spec update"
-        select order_cycle.name, from: "report_order_cycle_ids"
-        check I18n.t("filters.report_format_csv", scope: i18n_scope)
+        find("#s2id_q_order_cycle_ids").click
+        select order_cycle.name
+
+        find("#report_format").click
+        select "CSV"
         click_on "Go"
 
         expect(downloaded_filename).to include ".csv"
-        csv_content = downloaded_content
-        expect(csv_content).to have_content(distributor.name)
-        expect(csv_content).not_to have_content(second_distributor.name)
+        expect(downloaded_content).to have_content(distributor.name)
+        expect(downloaded_content).not_to have_content(second_distributor.name)
       end
     end
   end

From 98eecb1b3e39533382faf2ed34caa91d349751c1 Mon Sep 17 00:00:00 2001
From: filipefurtad0 <filipefurtado@gmail.com>
Date: Thu, 16 Jun 2022 17:38:12 +0100
Subject: [PATCH 6/8] Updates packing report spec

---
 .../admin/reports/packing_report_spec.rb      | 63 +++++++++++--------
 1 file changed, 38 insertions(+), 25 deletions(-)

diff --git a/spec/system/admin/reports/packing_report_spec.rb b/spec/system/admin/reports/packing_report_spec.rb
index 850f66910d..0d3e6d9489 100644
--- a/spec/system/admin/reports/packing_report_spec.rb
+++ b/spec/system/admin/reports/packing_report_spec.rb
@@ -12,8 +12,8 @@ describe "Packing Reports" do
       visit admin_reports_path
     end
 
-    let(:bill_address1) { create(:address, lastname: "MULLER") }
-    let(:bill_address2) { create(:address, lastname: "Mistery") }
+    let(:bill_address1) { create(:address, lastname: "ABRA") }
+    let(:bill_address2) { create(:address, lastname: "KADABRA") }
     let(:distributor_address) {
       create(:address, address1: "distributor address", city: 'The Shire', zipcode: "1234")
     }
@@ -33,8 +33,8 @@ describe "Packing Reports" do
     let(:product2) { create(:simple_product, name: "Product 2", supplier: supplier) }
 
     before do
-      Timecop.travel(Time.zone.local(2013, 4, 25, 14, 0, 0)) { order1.finalize! }
-      Timecop.travel(Time.zone.local(2013, 4, 25, 15, 0, 0)) { order2.finalize! }
+      Timecop.travel(Time.zone.local(2022, 4, 25, 14, 0, 0)) { order1.finalize! }
+      Timecop.travel(Time.zone.local(2022, 4, 25, 15, 0, 0)) { order2.finalize! }
 
       create(:line_item_with_shipment, variant: variant1, quantity: 1, order: order1)
       create(:line_item_with_shipment, variant: variant2, quantity: 3, order: order1)
@@ -43,34 +43,42 @@ describe "Packing Reports" do
 
     describe "Pack By Customer" do
       it "displays the report" do
-        pending "reports overhaul spec update"
         click_link "Pack By Customer"
-        fill_in 'q_completed_at_gt', with: '2013-04-25 13:00:00'
-        fill_in 'q_completed_at_lt', with: '2013-04-25 16:00:00'
+
+        find('#q_order_completed_at_gt').click
+        select_date_from_datepicker Time.zone.at(order1.completed_at - 1.day)
+
+        find('#q_order_completed_at_lt').click
+        select_date_from_datepicker Time.zone.at(order1.completed_at + 1.day)
+
         click_button 'Go'
 
         rows = find("table.report__table").all("thead tr")
         table = rows.map { |r| r.all("th").map { |c| c.text.strip } }
         expect(table).to eq([
-                              ["Hub", "Code", "First Name", "Last Name", "Supplier",
+                              ["Hub", "Customer Code", "First Name", "Last Name", "Supplier",
                                "Product", "Variant", "Quantity", "TempControlled?"].map(&:upcase)
                             ])
         expect(page).to have_selector 'table.report__table tbody tr', count: 5 # Totals row per order
       end
 
       it "sorts alphabetically" do
-        pending "reports overhaul spec update"
         click_link "Pack By Customer"
-        click_button 'Go'
 
+        find('#q_order_completed_at_gt').click
+        select_date_from_datepicker Time.zone.at(order1.completed_at - 1.day)
+
+        find('#q_order_completed_at_lt').click
+        select_date_from_datepicker Time.zone.at(order1.completed_at + 1.day)
+        click_button 'Go'
         rows = find("table.report__table").all("tr")
         table = rows.map { |r| r.all("th,td").map { |c| c.text.strip }[3] }
         expect(table).to eq([
                               "LAST NAME",
-                              order2.bill_address.lastname,
+                              order1.bill_address.lastname,
+                              order1.bill_address.lastname,
                               "",
-                              order1.bill_address.lastname,
-                              order1.bill_address.lastname,
+                              order2.bill_address.lastname,
                               ""
                             ])
       end
@@ -78,19 +86,25 @@ describe "Packing Reports" do
 
     describe "Pack By Supplier" do
       it "displays the report" do
-        pending "reports overhaul spec update"
         click_link "Pack By Supplier"
-        fill_in 'q_completed_at_gt', with: '2013-04-25 13:00:00'
-        fill_in 'q_completed_at_lt', with: '2013-04-25 16:00:00'
+        find('#q_order_completed_at_gt').click
+        select_date_from_datepicker Time.zone.at(order1.completed_at - 1.day)
+
+        find('#q_order_completed_at_lt').click
+        select_date_from_datepicker Time.zone.at(order1.completed_at + 1.day)
+
+        find(:css, "#display_summary_row").set(false) # does not include summary rows
+
         click_button 'Go'
 
         rows = find("table.report__table").all("thead tr")
         table = rows.map { |r| r.all("th").map { |c| c.text.strip } }
         expect(table).to eq([
-                              ["Hub", "Supplier", "Code", "First Name", "Last Name",
+                              ["Hub", "Supplier", "Customer Code", "First Name", "Last Name",
                                "Product", "Variant", "Quantity", "TempControlled?"].map(&:upcase)
                             ])
-        expect(all('table.report__table tbody tr').count).to eq(4) # Totals row per supplier
+
+        expect(all('table.report__table tbody tr').count).to eq(3) # Totals row per supplier
       end
     end
   end
@@ -99,7 +113,7 @@ describe "Packing Reports" do
     let(:distributor) { create(:distributor_enterprise) }
     let(:oc) { create(:simple_order_cycle) }
     let(:order) {
-      create(:completed_order_with_totals, line_items_count: 0, completed_at: 1.day.ago,
+      create(:completed_order_with_totals, line_items_count: 0,
                                            order_cycle: oc, distributor: distributor)
     }
     let(:li1) { build(:line_item_with_shipment) }
@@ -108,14 +122,13 @@ describe "Packing Reports" do
     before do
       order.line_items << li1
       order.line_items << li2
-      order.finalize!
+      Timecop.travel(Time.zone.local(2022, 4, 25, 14, 0, 0)) { order.finalize! }
       login_as_admin
     end
 
     describe "viewing a report" do
       context "when an associated variant has been soft-deleted" do
         it "shows line items" do
-          pending "reports overhaul spec update"
           li1.variant.delete
 
           visit admin_reports_path
@@ -123,11 +136,11 @@ describe "Packing Reports" do
           click_on I18n.t("admin.reports.packing.name")
           select oc.name, from: "q_order_cycle_id_in"
 
-          find('#q_completed_at_gt').click
-          select_date(Time.zone.today - 1.day)
+          find('#q_order_completed_at_gt').click
+          select_date_from_datepicker Time.zone.at(order.completed_at - 1.day)
 
-          find('#q_completed_at_lt').click
-          select_date(Time.zone.today)
+          find('#q_order_completed_at_lt').click
+          select_date_from_datepicker Time.zone.at(order.completed_at + 1.day)
 
           find("button[type='submit']").click
 

From be7d44a603a6def1a2671ae1ef379aca3f06e0a2 Mon Sep 17 00:00:00 2001
From: filipefurtad0 <filipefurtado@gmail.com>
Date: Thu, 16 Jun 2022 18:48:03 +0100
Subject: [PATCH 7/8] Updates payments_report_spec.rb

---
 spec/base_spec_helper.rb                          |  1 +
 spec/system/admin/reports/payments_report_spec.rb | 15 ++++++---------
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/spec/base_spec_helper.rb b/spec/base_spec_helper.rb
index 5b865822de..832c4da714 100644
--- a/spec/base_spec_helper.rb
+++ b/spec/base_spec_helper.rb
@@ -140,6 +140,7 @@ RSpec.configure do |config|
   config.include ActionView::Helpers::DateHelper
   config.include OpenFoodNetwork::PerformanceHelper
   config.include ActiveJob::TestHelper
+  config.include ReportsHelper
 
   config.include Features::DatepickerHelper, type: :system
   config.include DownloadsHelper, type: :system
diff --git a/spec/system/admin/reports/payments_report_spec.rb b/spec/system/admin/reports/payments_report_spec.rb
index 641a5a8570..b09a05952e 100644
--- a/spec/system/admin/reports/payments_report_spec.rb
+++ b/spec/system/admin/reports/payments_report_spec.rb
@@ -36,8 +36,6 @@ describe "Payments Reports" do
 
   context "when choosing itemised payments report type" do
     it "shows orders with payment state, their balance and totals" do
-      pending "reports overhaul spec update"
-
       select I18n.t(:report_itemised_payment), from: "report_subtype"
       find("[type='submit']").click
 
@@ -53,10 +51,10 @@ describe "Payments Reports" do
       expect(page.find("table.report__table tbody tr").text).to have_content([
         order.payment_state,
         order.distributor.name,
-        order.item_total.to_f + other_order.item_total.to_f,
-        order.ship_total.to_f + other_order.ship_total.to_f,
-        order.outstanding_balance.to_f + other_order.outstanding_balance.to_f,
-        order.total.to_f + other_order.total.to_f
+        with_currency(order.item_total.to_f + other_order.item_total.to_f),
+        with_currency(order.ship_total.to_f + other_order.ship_total.to_f),
+        with_currency(order.outstanding_balance.to_f + other_order.outstanding_balance.to_f),
+        with_currency(order.total.to_f + other_order.total.to_f)
       ].compact.join(" "))
     end
   end
@@ -73,8 +71,6 @@ describe "Payments Reports" do
     }
 
     it 'shows orders with payment state, their balance and and payment totals' do
-      pending "reports overhaul spec update"
-
       select I18n.t(:report_payment_totals), from: "report_subtype"
       find("[type='submit']").click
 
@@ -89,6 +85,7 @@ describe "Payments Reports" do
         I18n.t(:report_header_outstanding_balance_price, currency: currency_symbol),
       ].join(" ").upcase)
 
+      pending "PR #9229 which will remove currency from the figures below"
       expect(page.find("table.report__table tbody tr").text).to have_content([
         order.payment_state,
         order.distributor.name,
@@ -97,7 +94,7 @@ describe "Payments Reports" do
         order.total.to_f + other_order.total.to_f,
         eft_payment.amount.to_f,
         paypal_payment.amount.to_f,
-        order.outstanding_balance.to_f + other_order.outstanding_balance.to_f,
+        with_currency(order.outstanding_balance + other_order.outstanding_balance),
       ].join(" "))
     end
   end

From d63aca31298ec788fbead572d821db1d79a625a4 Mon Sep 17 00:00:00 2001
From: filipefurtad0 <filipefurtado@gmail.com>
Date: Thu, 23 Jun 2022 10:40:11 +0100
Subject: [PATCH 8/8] Removes 'pending' after #9229 merge

---
 spec/system/admin/reports/payments_report_spec.rb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/spec/system/admin/reports/payments_report_spec.rb b/spec/system/admin/reports/payments_report_spec.rb
index b09a05952e..984b1bcbdd 100644
--- a/spec/system/admin/reports/payments_report_spec.rb
+++ b/spec/system/admin/reports/payments_report_spec.rb
@@ -85,7 +85,6 @@ describe "Payments Reports" do
         I18n.t(:report_header_outstanding_balance_price, currency: currency_symbol),
       ].join(" ").upcase)
 
-      pending "PR #9229 which will remove currency from the figures below"
       expect(page.find("table.report__table tbody tr").text).to have_content([
         order.payment_state,
         order.distributor.name,
@@ -94,7 +93,7 @@ describe "Payments Reports" do
         order.total.to_f + other_order.total.to_f,
         eft_payment.amount.to_f,
         paypal_payment.amount.to_f,
-        with_currency(order.outstanding_balance + other_order.outstanding_balance),
+        order.outstanding_balance + other_order.outstanding_balance,
       ].join(" "))
     end
   end