From 69a5527e24f76e2221fcae0a44de43de7b15621f Mon Sep 17 00:00:00 2001 From: luisramos0 Date: Tue, 23 Jul 2019 14:14:37 +0100 Subject: [PATCH] Update/regenarate .rubocop_todo.yml --- .rubocop_todo.yml | 111 +++++++++++++++++++++++++++++++++------------- 1 file changed, 81 insertions(+), 30 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 3e44970301..712ceee1da 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 1400` -# on 2019-05-28 16:29:07 +0100 using RuboCop version 0.57.2. +# on 2019-07-23 14:09:18 +0100 using RuboCop version 0.57.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -32,15 +32,6 @@ Layout/EndAlignment: Layout/IndentHash: EnforcedStyle: consistent -# Offense count: 7 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: aligned, indented, indented_relative_to_receiver -Layout/MultilineMethodCallIndentation: - Exclude: - - 'app/models/spree/line_item_decorator.rb' - - 'app/models/spree/product_decorator.rb' - # Offense count: 4 Lint/AmbiguousOperator: Exclude: @@ -55,7 +46,7 @@ Lint/DuplicateMethods: - 'lib/discourse/single_sign_on.rb' - 'lib/open_food_network/subscription_summary.rb' -# Offense count: 15 +# Offense count: 8 Lint/IneffectiveAccessModifier: Exclude: - 'app/models/column_preference.rb' @@ -79,7 +70,13 @@ Lint/UnderscorePrefixedVariableName: Exclude: - 'spec/support/cancan_helper.rb' -# Offense count: 6 +# Offense count: 1 +# Cop supports --auto-correct. +Lint/UnneededCopDisableDirective: + Exclude: + - 'app/models/product_import/entry_validator.rb' + +# Offense count: 5 # Configuration parameters: ContextCreatingMethods, MethodCreatingMethods. Lint/UselessAccessModifier: Exclude: @@ -89,28 +86,47 @@ Lint/UselessAccessModifier: - 'lib/open_food_network/reports/bulk_coop_report.rb' - 'spec/lib/open_food_network/reports/report_spec.rb' -# Offense count: 91 +# Offense count: 8 # Configuration parameters: CheckForMethodsWithNoSideEffects. Lint/Void: Exclude: - 'app/serializers/api/enterprise_serializer.rb' - 'spec/features/admin/bulk_product_update_spec.rb' - - 'spec/features/admin/enterprise_groups_spec.rb' - - 'spec/features/admin/enterprises/index_spec.rb' - - 'spec/features/admin/enterprises_spec.rb' - - 'spec/features/admin/order_cycles_spec.rb' - - 'spec/features/admin/payment_method_spec.rb' - - 'spec/features/admin/products_spec.rb' - - 'spec/features/admin/variant_overrides_spec.rb' - - 'spec/features/admin/variants_spec.rb' - 'spec/features/consumer/shopping/checkout_spec.rb' - 'spec/features/consumer/shopping/shopping_spec.rb' - 'spec/features/consumer/shopping/variant_overrides_spec.rb' -# Offense count: 109 +# Offense count: 15 +Metrics/AbcSize: + Max: 36 + +# Offense count: 13 # Configuration parameters: CountComments, ExcludedMethods. Metrics/BlockLength: - Max: 774 + Max: 115 + +# Offense count: 2 +# Configuration parameters: CountComments. +Metrics/ClassLength: + Max: 169 + +# Offense count: 1 +Metrics/CyclomaticComplexity: + Max: 8 + +# Offense count: 8 +# Configuration parameters: CountComments. +Metrics/MethodLength: + Max: 31 + +# Offense count: 2 +# Configuration parameters: CountComments. +Metrics/ModuleLength: + Max: 208 + +# Offense count: 2 +Metrics/PerceivedComplexity: + Max: 11 # Offense count: 7 Naming/AccessorMethodName: @@ -160,7 +176,7 @@ Naming/PredicateName: - 'lib/open_food_network/packing_report.rb' - 'lib/tasks/data.rake' -# Offense count: 12 +# Offense count: 11 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. # AllowedNames: io, id, to, by, on, in, at Naming/UncommunicativeMethodParamName: @@ -288,13 +304,12 @@ Style/CaseEquality: - 'app/helpers/angular_form_helper.rb' - 'spec/models/spree/payment_spec.rb' -# Offense count: 79 +# Offense count: 78 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, EnforcedStyle. # SupportedStyles: nested, compact Style/ClassAndModuleChildren: Exclude: - - 'app/controllers/spree/store_controller_decorator.rb' - 'app/helpers/angular_form_helper.rb' - 'app/models/calculator/flat_percent_per_item.rb' - 'app/models/spree/concerns/payment_method_distributors.rb' @@ -379,11 +394,27 @@ Style/CommentedKeyword: Exclude: - 'app/controllers/application_controller.rb' +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions. +# SupportedStyles: assign_to_condition, assign_inside_condition +Style/ConditionalAssignment: + Exclude: + - 'app/controllers/spree/api/products_controller.rb' + - 'app/controllers/spree/api/taxons_controller.rb' + - 'app/controllers/spree/api/variants_controller.rb' + # Offense count: 2 Style/DateTime: Exclude: - 'lib/open_food_network/users_and_enterprises_report.rb' +# Offense count: 1 +# Cop supports --auto-correct. +Style/EachWithObject: + Exclude: + - 'app/controllers/spree/api/base_controller.rb' + # Offense count: 5 # Configuration parameters: EnforcedStyle. # SupportedStyles: annotated, template, unannotated @@ -393,7 +424,7 @@ Style/FormatStringToken: - 'lib/open_food_network/sales_tax_report.rb' - 'spec/models/enterprise_spec.rb' -# Offense count: 69 +# Offense count: 68 # Configuration parameters: MinBodyLength. Style/GuardClause: Exclude: @@ -410,7 +441,9 @@ Style/GuardClause: - 'app/controllers/spree/admin/products_controller_decorator.rb' - 'app/controllers/spree/admin/resource_controller_decorator.rb' - 'app/controllers/spree/admin/variants_controller_decorator.rb' - - 'app/controllers/spree/orders_controller_decorator.rb' + - 'app/controllers/spree/api/base_controller.rb' + - 'app/controllers/spree/checkout_controller.rb' + - 'app/controllers/spree/orders_controller.rb' - 'app/controllers/spree/paypal_controller_decorator.rb' - 'app/jobs/products_cache_integrity_checker_job.rb' - 'app/models/enterprise.rb' @@ -434,12 +467,23 @@ Style/GuardClause: - 'spec/support/request/distribution_helper.rb' - 'spec/support/request/shop_workflow.rb' -# Offense count: 3 +# Offense count: 6 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. +# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys +Style/HashSyntax: + Exclude: + - 'app/controllers/spree/api/base_controller.rb' + - 'app/controllers/spree/checkout_controller.rb' + - 'app/controllers/spree/orders_controller.rb' + +# Offense count: 4 Style/IfInsideElse: Exclude: - 'app/controllers/admin/column_preferences_controller.rb' - 'app/controllers/admin/variant_overrides_controller.rb' - 'app/controllers/spree/admin/products_controller_decorator.rb' + - 'app/controllers/spree/api/taxons_controller.rb' # Offense count: 1 Style/MissingRespondToMissing: @@ -492,9 +536,10 @@ Style/RegexpLiteral: - 'spec/mailers/subscription_mailer_spec.rb' - 'spec/models/content_configuration_spec.rb' -# Offense count: 243 +# Offense count: 244 Style/Send: Exclude: + - 'app/controllers/spree/checkout_controller.rb' - 'app/models/spree/shipping_method_decorator.rb' - 'spec/controllers/admin/subscriptions_controller_spec.rb' - 'spec/controllers/checkout_controller_spec.rb' @@ -541,3 +586,9 @@ Style/Send: Style/StructInheritance: Exclude: - 'lib/open_food_network/enterprise_fee_applicator.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Style/UnlessElse: + Exclude: + - 'app/controllers/spree/api/variants_controller.rb'