From 65fea6291e1fc0c80b5e4ce9562a96f132dfc7a7 Mon Sep 17 00:00:00 2001 From: Hugo Daniel Date: Tue, 6 Feb 2018 12:49:03 +0100 Subject: [PATCH] CodeClimate requested changes --- app/controllers/spree/admin/reports_controller_decorator.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/controllers/spree/admin/reports_controller_decorator.rb b/app/controllers/spree/admin/reports_controller_decorator.rb index 0aec336b9c..9d00949b6c 100644 --- a/app/controllers/spree/admin/reports_controller_decorator.rb +++ b/app/controllers/spree/admin/reports_controller_decorator.rb @@ -338,10 +338,9 @@ Spree::Admin::ReportsController.class_eval do # Avoids duplicates OrderCycle.active_or_complete.involving_managed_producers_of(spree_current_user).each do |order_cycle| - @order_cycles << order_cycle unless @order_cycles.include?(order_cycle) + @order_cycles << order_cycle unless @order_cycles.include?(order_cycle) end - @order_cycles.sort_by! {|order_cycle| order_cycle.orders_close_at} - return @order_cycles + @order_cycles.sort_by!(&:orders_close_at) end end