raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-11 03:40:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Orders::WorkflowService#complete! and #advance_to_payment in specs to replace code causing Style/NestedModifier rubocop offenses

Browse Source 
Rewrite the loop "break unless a = order.next! while !order.delivery?" to correct the offenses. Not adding a helper because the change was only needed in a couple of places.
This commit is contained in:
Carlos Chitty
2025-06-04 10:37:09 -04:00
parent 00aa60c8a3
commit 63d284e81a
11 changed files with 27 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/controllers/admin/subscriptions_controller_spec.rb
View File

@@ -458,7 +458,7 @@ RSpec.describe Admin::SubscriptionsController do
}
let!(:order) { proxy_order.initialise_order! }
before { break unless order.next! while !order.completed? }
before { Orders::WorkflowService.new(order).complete! }
context "when no 'open_orders' directive has been provided" do
it "renders an error, asking what to do" do
@@ -562,7 +562,7 @@ RSpec.describe Admin::SubscriptionsController do
}
let!(:order) { proxy_order.initialise_order! }
before { break unless order.next! while !order.completed? }
before { Orders::WorkflowService.new(order).complete! }
context "when no 'open_orders' directive has been provided" do
it "renders an error, asking what to do" do
@@ -668,7 +668,7 @@ RSpec.describe Admin::SubscriptionsController do
}
let!(:order) { proxy_order.initialise_order! }
before { break unless order.next! while !order.completed? }
before { Orders::WorkflowService.new(order).complete! }
context "when no associated orders are 'canceled'" do
it 'renders the unpaused subscription as json, leaves the order untouched' do