From 63a9765feaec7a4dd3ad7daaeaea3878caea35c4 Mon Sep 17 00:00:00 2001 From: Maikel Linke Date: Thu, 13 Aug 2020 16:33:47 +1000 Subject: [PATCH] Update rubocop todo lists --- .rubocop_manual_todo.yml | 37 +++++ .rubocop_todo.yml | 312 ++++++++++++++++++++++++++++----------- 2 files changed, 261 insertions(+), 88 deletions(-) diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index 286b945692..96493448e2 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -321,6 +321,15 @@ Layout/LineLength: - spec/support/request/shop_workflow.rb - spec/support/request/web_helper.rb - spec/support/seeds.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb + - spec/controllers/base_controller2_spec.rb + - spec/features/consumer/caching/darkswarm_caching_spec.rb + - spec/models/calculator/flexi_rate_spec.rb + - spec/models/calculator/price_sack_spec.rb + - spec/models/spree/stock_item_spec.rb + - spec/requests/api/orders_spec.rb + - spec/swagger_helper.rb + - spec/views/spree/admin/payment_methods/index.html.haml_spec.rb Metrics/AbcSize: Max: 15 @@ -444,6 +453,11 @@ Metrics/AbcSize: - spec/models/product_importer_spec.rb - spec/services/order_checkout_restart_spec.rb - spec/support/performance_helper.rb + - app/controllers/application_controller.rb + - app/models/spree/order/checkout.rb + - app/models/spree/payment/processing.rb + - app/models/spree/payment.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb Metrics/BlockLength: Max: 25 @@ -482,6 +496,10 @@ Metrics/BlockLength: - spec/support/delayed_job_helper.rb - spec/support/matchers/select2_matchers.rb - spec/support/matchers/table_matchers.rb + - app/models/spree/order/checkout.rb + - app/models/spree/payment/processing.rb + - spec/requests/api/orders_spec.rb + - spec/swagger_helper.rb Metrics/CyclomaticComplexity: Max: 6 @@ -513,6 +531,9 @@ Metrics/CyclomaticComplexity: - lib/spree/core/controller_helpers/ssl.rb - lib/spree/localized_number.rb - spec/models/product_importer_spec.rb + - app/models/spree/order/checkout.rb + - app/models/spree/payment.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb Metrics/PerceivedComplexity: Max: 7 @@ -539,6 +560,8 @@ Metrics/PerceivedComplexity: - lib/spree/core/controller_helpers/ssl.rb - lib/spree/localized_number.rb - spec/models/product_importer_spec.rb + - app/models/spree/order/checkout.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb Metrics/MethodLength: Max: 10 @@ -645,6 +668,11 @@ Metrics/MethodLength: - spec/features/consumer/shopping/variant_overrides_spec.rb - spec/models/product_importer_spec.rb - spec/support/request/authentication_helper.rb + - app/models/spree/order/checkout.rb + - app/models/spree/payment/processing.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_allocation_report.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_supplier_report.rb Metrics/ClassLength: Max: 100 @@ -686,6 +714,8 @@ Metrics/ClassLength: - lib/open_food_network/permissions.rb - lib/open_food_network/users_and_enterprises_report.rb - lib/open_food_network/xero_invoices_report.rb + - app/models/spree/payment.rb + - engines/order_management/app/services/order_management/reports/bulk_coop/bulk_coop_report.rb Metrics/ModuleLength: Max: 100 @@ -728,6 +758,8 @@ Metrics/ModuleLength: - spec/models/spree/variant_spec.rb - spec/services/permissions/order_spec.rb - spec/support/request/web_helper.rb + - app/models/spree/order/checkout.rb + - app/models/spree/payment/processing.rb Metrics/ParameterLists: Max: 5 @@ -736,3 +768,8 @@ Metrics/ParameterLists: - app/models/product_import/entry_processor.rb - lib/open_food_network/xero_invoices_report.rb - spec/features/admin/reports_spec.rb + +Lint/UselessAssignment: + Exclude: + - 'spec/**/*' + - 'lib/spree/core/controller_helpers/common.rb' diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index c88c48b817..e95d9e89c6 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,79 +1,214 @@ # This configuration was generated by # `rubocop --auto-gen-config --exclude-limit 1400` -# on 2020-06-22 13:28:10 +0100 using RuboCop version 0.81.0. +# on 2020-08-13 16:05:53 +1000 using RuboCop version 0.81.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 139 +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, IndentationWidth. +# SupportedStyles: with_first_argument, with_fixed_indentation +Layout/ArgumentAlignment: + Exclude: + - 'spec/models/spree/order/checkout_spec.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyleAlignWith. +# SupportedStylesAlignWith: either, start_of_block, start_of_line +Layout/BlockAlignment: + Exclude: + - 'spec/models/spree/order/checkout_spec.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +Layout/EmptyLines: + Exclude: + - 'spec/models/spree/payment_spec.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: empty_lines, no_empty_lines +Layout/EmptyLinesAroundBlockBody: + Exclude: + - 'spec/models/spree/payment_spec.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment. +Layout/ExtraSpacing: + Exclude: + - 'spec/models/spree/payment_spec.rb' + - 'spec/requests/api/orders_spec.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, IndentationWidth. +# SupportedStyles: special_inside_parentheses, consistent, align_brackets +Layout/FirstArrayElementIndentation: + Exclude: + - 'spec/views/spree/admin/payment_methods/index.html.haml_spec.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, IndentationWidth. +# SupportedStyles: special_inside_parentheses, consistent, align_braces +Layout/FirstHashElementIndentation: + Exclude: + - 'spec/models/spree/payment_spec.rb' + - 'spec/swagger_helper.rb' + +# Offense count: 5 +# Cop supports --auto-correct. +# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle. +# SupportedHashRocketStyles: key, separator, table +# SupportedColonStyles: key, separator, table +# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit +Layout/HashAlignment: + Exclude: + - 'spec/models/spree/payment_spec.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: normal, indented_internal_methods +Layout/IndentationConsistency: + Exclude: + - 'spec/models/spree/order/checkout_spec.rb' + +# Offense count: 26 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Layout/LineLength: - Max: 268 + Max: 409 + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: symmetrical, new_line, same_line +Layout/MultilineHashBraceLayout: + Exclude: + - 'spec/models/spree/payment_spec.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator. +# SupportedStylesForExponentOperator: space, no_space +Layout/SpaceAroundOperators: + Exclude: + - 'spec/models/spree/payment_spec.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. +# SupportedStyles: space, no_space +# SupportedStylesForEmptyBraces: space, no_space +Layout/SpaceInsideBlockBraces: + Exclude: + - 'spec/models/spree/payment_spec.rb' + +# Offense count: 11 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. +# SupportedStyles: space, no_space, compact +# SupportedStylesForEmptyBraces: space, no_space +Layout/SpaceInsideHashLiteralBraces: + Exclude: + - 'spec/models/spree/payment_spec.rb' + - 'spec/requests/api/orders_spec.rb' + - 'spec/services/checkout/form_data_adapter_spec.rb' + - 'spec/services/user_locale_setter_spec.rb' + +# Offense count: 6 +# Cop supports --auto-correct. +# Configuration parameters: AllowInHeredoc. +Layout/TrailingWhitespace: + Exclude: + - 'spec/controllers/base_controller2_spec.rb' + - 'spec/features/consumer/shopping/shopping_spec.rb' + - 'spec/requests/api/orders_spec.rb' # Offense count: 2 Lint/DuplicateMethods: Exclude: - 'lib/discourse/single_sign_on.rb' -# Offense count: 9 +# Offense count: 8 Lint/IneffectiveAccessModifier: Exclude: - 'app/models/column_preference.rb' - 'app/models/spree/user.rb' - 'app/services/mail_configuration.rb' - 'lib/open_food_network/feature_toggle.rb' - - 'spec/lib/open_food_network/reports/report_spec.rb' -# Offense count: 5 +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. +Lint/UnusedMethodArgument: + Exclude: + - 'spec/views/spree/admin/payment_methods/index.html.haml_spec.rb' + +# Offense count: 3 # Configuration parameters: ContextCreatingMethods, MethodCreatingMethods. Lint/UselessAccessModifier: Exclude: - 'app/models/column_preference.rb' - 'app/services/mail_configuration.rb' - 'lib/open_food_network/feature_toggle.rb' - - 'lib/open_food_network/reports/bulk_coop_report.rb' - - 'spec/lib/open_food_network/reports/report_spec.rb' - -# Offense count: 6 -# Configuration parameters: IgnoredMethods. -Metrics/AbcSize: - Max: 37 # Offense count: 1 +Lint/UselessAssignment: + Exclude: + - 'spec/**/*' + - 'lib/spree/core/controller_helpers/common.rb' + +# Offense count: 19 +# Configuration parameters: IgnoredMethods. +Metrics/AbcSize: + Max: 126 + +# Offense count: 7 # Configuration parameters: CountComments, ExcludedMethods. # ExcludedMethods: refine Metrics/BlockLength: - Max: 27 + Max: 102 -# Offense count: 1 +# Offense count: 2 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 101 + Max: 231 -# Offense count: 1 +# Offense count: 3 # Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 7 + Max: 23 -# Offense count: 6 +# Offense count: 19 # Configuration parameters: CountComments, ExcludedMethods. Metrics/MethodLength: - Max: 20 + Max: 140 -# Offense count: 1 +# Offense count: 2 # Configuration parameters: CountComments. Metrics/ModuleLength: - Max: 121 + Max: 208 -# Offense count: 8 +# Offense count: 2 +# Configuration parameters: IgnoredMethods. +Metrics/PerceivedComplexity: + Max: 24 + +# Offense count: 9 Naming/AccessorMethodName: Exclude: - 'app/controllers/spree/admin/taxonomies_controller.rb' - 'app/models/spree/adjustment_decorator.rb' - 'app/models/spree/order_decorator.rb' + - 'lib/spree/core/controller_helpers/common.rb' - 'spec/support/request/shop_workflow.rb' - 'spec/support/request/web_helper.rb' @@ -117,6 +252,15 @@ Naming/PredicateName: - 'lib/open_food_network/packing_report.rb' - 'lib/tasks/data.rake' +# Offense count: 7 +# Cop supports --auto-correct. +Rails/ActiveRecordAliases: + Exclude: + - 'spec/controllers/line_items_controller_spec.rb' + - 'spec/controllers/spree/orders_controller_spec.rb' + - 'spec/features/consumer/shopping/orders_spec.rb' + - 'spec/requests/api/orders_spec.rb' + # Offense count: 1 # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible @@ -124,6 +268,13 @@ Rails/Date: Exclude: - 'app/models/order_cycle.rb' +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforceForPrefixed. +Rails/Delegate: + Exclude: + - 'engines/order_management/app/services/order_management/reports/bulk_coop/renderers/html_renderer.rb' + # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: Whitelist. @@ -150,7 +301,7 @@ Rails/FilePath: - 'spec/serializers/api/admin/enterprise_serializer_spec.rb' - 'spec/support/downloads_helper.rb' -# Offense count: 7 +# Offense count: 9 # Cop supports --auto-correct. # Configuration parameters: Include. # Include: app/models/**/*.rb @@ -160,15 +311,17 @@ Rails/FindBy: - 'app/models/product_import/entry_processor.rb' - 'app/models/product_import/entry_validator.rb' - 'app/models/product_import/spreadsheet_data.rb' + - 'app/models/spree/shipment.rb' - 'app/models/spree/user.rb' -# Offense count: 1 +# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/FindEach: Exclude: - 'app/models/spree/order_decorator.rb' + - 'app/models/spree/shipment.rb' # Offense count: 5 # Configuration parameters: Include. @@ -180,7 +333,7 @@ Rails/HasAndBelongsToMany: - 'app/models/spree/concerns/payment_method_distributors.rb' - 'app/models/spree/line_item_decorator.rb' -# Offense count: 25 +# Offense count: 26 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/HasManyOrHasOneDependent: @@ -192,6 +345,7 @@ Rails/HasManyOrHasOneDependent: - 'app/models/spree/order_decorator.rb' - 'app/models/spree/payment_method_decorator.rb' - 'app/models/spree/property.rb' + - 'app/models/spree/shipment.rb' - 'app/models/spree/shipping_method_decorator.rb' - 'app/models/spree/user.rb' - 'app/models/spree/variant_decorator.rb' @@ -268,7 +422,7 @@ Rails/ReflectionClassName: - 'app/models/enterprise_role.rb' - 'app/models/subscription.rb' -# Offense count: 227 +# Offense count: 233 # Configuration parameters: Blacklist, Whitelist. # Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters Rails/SkipsModelValidations: @@ -287,7 +441,8 @@ Rails/SkipsModelValidations: - 'app/models/spree/address_decorator.rb' - 'app/models/spree/credit_card_decorator.rb' - 'app/models/spree/order_decorator.rb' - - 'app/models/spree/payment_decorator.rb' + - 'app/models/spree/payment.rb' + - 'app/models/spree/shipment.rb' - 'app/models/spree/shipping_method_decorator.rb' - 'app/models/subscription.rb' - 'app/models/variant_override.rb' @@ -355,27 +510,22 @@ Rails/SkipsModelValidations: - 'spec/support/request/shop_workflow.rb' - 'spec/views/spree/shared/_order_details.html.haml_spec.rb' -# Offense count: 2 +# Offense count: 3 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/UniqueValidationWithoutIndex: Exclude: - 'app/models/customer.rb' - 'app/models/exchange.rb' - -# Offense count: 2 -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/UniqueValidationWithoutIndex: - Exclude: - 'app/models/spree/stock_item.rb' -# Offense count: 1 +# Offense count: 2 # Configuration parameters: Environments. # Environments: development, test, production Rails/UnknownEnv: Exclude: - 'app/models/spree/app_configuration_decorator.rb' + - 'lib/spree/core/controller_helpers/ssl.rb' # Offense count: 2 Style/CaseEquality: @@ -383,7 +533,7 @@ Style/CaseEquality: - 'app/helpers/angular_form_helper.rb' - 'spec/models/spree/payment_spec.rb' -# Offense count: 75 +# Offense count: 71 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, EnforcedStyle. # SupportedStyles: nested, compact @@ -447,13 +597,9 @@ Style/ClassAndModuleChildren: - 'app/serializers/api/property_serializer.rb' - 'app/serializers/api/shipping_method_serializer.rb' - 'app/serializers/api/state_serializer.rb' - - 'app/serializers/api/taxon_image_serializer.rb' - 'app/serializers/api/taxon_serializer.rb' - 'app/serializers/api/variant_serializer.rb' - 'lib/open_food_network/locking.rb' - - 'lib/open_food_network/reports/bulk_coop_allocation_report.rb' - - 'lib/open_food_network/reports/bulk_coop_report.rb' - - 'lib/open_food_network/reports/bulk_coop_supplier_report.rb' - 'lib/open_food_network/reports/report.rb' - 'lib/open_food_network/reports/row.rb' - 'lib/open_food_network/reports/rule.rb' @@ -475,7 +621,7 @@ Style/FormatStringToken: - 'lib/open_food_network/sales_tax_report.rb' - 'spec/features/admin/bulk_order_management_spec.rb' -# Offense count: 874 +# Offense count: 847 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never @@ -569,7 +715,6 @@ Style/FrozenStringLiteralComment: - 'app/controllers/spree/admin/variants_controller.rb' - 'app/controllers/spree/admin/zones_controller.rb' - 'app/controllers/spree/credit_cards_controller.rb' - - 'app/controllers/spree/home_controller.rb' - 'app/controllers/spree/orders_controller.rb' - 'app/controllers/spree/store_controller.rb' - 'app/controllers/spree/user_passwords_controller.rb' @@ -624,8 +769,6 @@ Style/FrozenStringLiteralComment: - 'app/jobs/subscription_placement_job.rb' - 'app/jobs/welcome_enterprise_job.rb' - 'app/mailers/enterprise_mailer.rb' - - 'app/mailers/spree/base_mailer_decorator.rb' - - 'app/mailers/spree/order_mailer_decorator.rb' - 'app/mailers/spree/user_mailer.rb' - 'app/mailers/subscription_mailer.rb' - 'app/models/adjustment_metadata.rb' @@ -684,12 +827,6 @@ Style/FrozenStringLiteralComment: - 'app/models/spree/address_decorator.rb' - 'app/models/spree/adjustment_decorator.rb' - 'app/models/spree/app_configuration_decorator.rb' - - 'app/models/spree/calculator/default_tax_decorator.rb' - - 'app/models/spree/calculator/flat_percent_item_total_decorator.rb' - - 'app/models/spree/calculator/flat_rate_decorator.rb' - - 'app/models/spree/calculator/flexi_rate_decorator.rb' - - 'app/models/spree/calculator/per_item_decorator.rb' - - 'app/models/spree/calculator/price_sack_decorator.rb' - 'app/models/spree/calculator_decorator.rb' - 'app/models/spree/classification_decorator.rb' - 'app/models/spree/concerns/payment_method_distributors.rb' @@ -702,7 +839,6 @@ Style/FrozenStringLiteralComment: - 'app/models/spree/line_item_decorator.rb' - 'app/models/spree/option_type_decorator.rb' - 'app/models/spree/order_decorator.rb' - - 'app/models/spree/payment_decorator.rb' - 'app/models/spree/payment_method_decorator.rb' - 'app/models/spree/preferences/file_configuration.rb' - 'app/models/spree/price_decorator.rb' @@ -711,15 +847,12 @@ Style/FrozenStringLiteralComment: - 'app/models/spree/product_property_decorator.rb' - 'app/models/spree/product_set.rb' - 'app/models/spree/property.rb' - - 'app/models/spree/shipment_decorator.rb' - 'app/models/spree/shipping_method_decorator.rb' - - 'app/models/spree/stock/availability_validator_decorator.rb' - 'app/models/spree/stock_location_decorator.rb' - 'app/models/spree/tax_rate_decorator.rb' - 'app/models/spree/taxon_decorator.rb' - 'app/models/spree/user.rb' - 'app/models/spree/variant_decorator.rb' - - 'app/models/stock/package.rb' - 'app/models/stripe_account.rb' - 'app/models/subscription.rb' - 'app/models/subscription_line_item.rb' @@ -803,7 +936,6 @@ Style/FrozenStringLiteralComment: - 'app/serializers/api/shipping_method_serializer.rb' - 'app/serializers/api/shop_for_orders_serializer.rb' - 'app/serializers/api/state_serializer.rb' - - 'app/serializers/api/taxon_image_serializer.rb' - 'app/serializers/api/taxon_jstree_attribute_serializer.rb' - 'app/serializers/api/taxon_jstree_serializer.rb' - 'app/serializers/api/taxon_serializer.rb' @@ -811,7 +943,6 @@ Style/FrozenStringLiteralComment: - 'app/serializers/api/user_serializer.rb' - 'app/serializers/api/variant_serializer.rb' - 'app/services/action_callbacks.rb' - - 'app/services/advance_order_service.rb' - 'app/services/bulk_invoice_service.rb' - 'app/services/cart_service.rb' - 'app/services/create_order_cycle.rb' @@ -831,6 +962,7 @@ Style/FrozenStringLiteralComment: - 'app/services/order_factory.rb' - 'app/services/order_syncer.rb' - 'app/services/order_update_issues.rb' + - 'app/services/order_workflow.rb' - 'app/services/permissions/order.rb' - 'app/services/product_tag_rules_filterer.rb' - 'app/services/products_renderer.rb' @@ -893,7 +1025,6 @@ Style/FrozenStringLiteralComment: - 'lib/discourse/single_sign_on.rb' - 'lib/open_food_network/address_finder.rb' - 'lib/open_food_network/available_payment_method_filter.rb' - - 'lib/open_food_network/bulk_coop_report.rb' - 'lib/open_food_network/column_preference_defaults.rb' - 'lib/open_food_network/customers_report.rb' - 'lib/open_food_network/enterprise_fee_applicator.rb' @@ -928,9 +1059,6 @@ Style/FrozenStringLiteralComment: - 'lib/open_food_network/property_merge.rb' - 'lib/open_food_network/rack_request_blocker.rb' - 'lib/open_food_network/referer_parser.rb' - - 'lib/open_food_network/reports/bulk_coop_allocation_report.rb' - - 'lib/open_food_network/reports/bulk_coop_report.rb' - - 'lib/open_food_network/reports/bulk_coop_supplier_report.rb' - 'lib/open_food_network/reports/line_items.rb' - 'lib/open_food_network/reports/list.rb' - 'lib/open_food_network/reports/report.rb' @@ -949,9 +1077,6 @@ Style/FrozenStringLiteralComment: - 'lib/spree/api/controller_setup.rb' - 'lib/spree/api/testing_support/setup.rb' - 'lib/spree/authentication_helpers.rb' - - 'lib/spree/core/controller_helpers/auth_decorator.rb' - - 'lib/spree/core/controller_helpers/order_decorator.rb' - - 'lib/spree/core/controller_helpers/respond_with_decorator.rb' - 'lib/spree/localized_number.rb' - 'lib/spree/money_decorator.rb' - 'lib/spree/product_filters.rb' @@ -980,7 +1105,6 @@ Style/FrozenStringLiteralComment: - 'lib/tasks/sample_data/user_factory.rb' - 'lib/tasks/specs.rake' - 'lib/tasks/users.rake' - - 'spec/config/application_spec.rb' - 'spec/controllers/admin/bulk_line_items_controller_spec.rb' - 'spec/controllers/admin/column_preferences_controller_spec.rb' - 'spec/controllers/admin/customers_controller_spec.rb' @@ -1011,9 +1135,9 @@ Style/FrozenStringLiteralComment: - 'spec/controllers/api/taxonomies_controller_spec.rb' - 'spec/controllers/api/taxons_controller_spec.rb' - 'spec/controllers/api/variants_controller_spec.rb' + - 'spec/controllers/base_controller2_spec.rb' - 'spec/controllers/base_controller_spec.rb' - 'spec/controllers/cart_controller_spec.rb' - - 'spec/controllers/checkout_controller_concurrency_spec.rb' - 'spec/controllers/checkout_controller_spec.rb' - 'spec/controllers/enterprises_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' @@ -1030,7 +1154,6 @@ Style/FrozenStringLiteralComment: - 'spec/controllers/spree/admin/orders_controller_spec.rb' - 'spec/controllers/spree/admin/overview_controller_spec.rb' - 'spec/controllers/spree/admin/payment_methods_controller_spec.rb' - - 'spec/controllers/spree/admin/payments_controller_spec.rb' - 'spec/controllers/spree/admin/products_controller_spec.rb' - 'spec/controllers/spree/admin/reports_controller_spec.rb' - 'spec/controllers/spree/admin/search_controller_spec.rb' @@ -1039,7 +1162,6 @@ Style/FrozenStringLiteralComment: - 'spec/controllers/spree/admin/variants_controller_spec.rb' - 'spec/controllers/spree/credit_cards_controller_spec.rb' - 'spec/controllers/spree/orders_controller_spec.rb' - - 'spec/controllers/spree/store_controller_spec.rb' - 'spec/controllers/spree/user_sessions_controller_spec.rb' - 'spec/controllers/spree/users_controller_spec.rb' - 'spec/controllers/stripe/callbacks_controller_spec.rb' @@ -1147,7 +1269,6 @@ Style/FrozenStringLiteralComment: - 'spec/jobs/subscription_placement_job_spec.rb' - 'spec/jobs/welcome_enterprise_job_spec.rb' - 'spec/lib/open_food_network/address_finder_spec.rb' - - 'spec/lib/open_food_network/bulk_coop_report_spec.rb' - 'spec/lib/open_food_network/customers_report_spec.rb' - 'spec/lib/open_food_network/enterprise_fee_applicator_spec.rb' - 'spec/lib/open_food_network/enterprise_fee_calculator_spec.rb' @@ -1190,12 +1311,16 @@ Style/FrozenStringLiteralComment: - 'spec/lib/tasks/enterprises_rake_spec.rb' - 'spec/lib/tasks/users_rake_spec.rb' - 'spec/mailers/enterprise_mailer_spec.rb' - - 'spec/mailers/order_mailer_spec.rb' - 'spec/mailers/producer_mailer_spec.rb' - 'spec/mailers/subscription_mailer_spec.rb' - 'spec/mailers/user_mailer_spec.rb' - 'spec/models/adjustment_metadata_spec.rb' + - 'spec/models/calculator/flat_percent_item_total_spec.rb' - 'spec/models/calculator/flat_percent_per_item_spec.rb' + - 'spec/models/calculator/flat_rate_spec.rb' + - 'spec/models/calculator/flexi_rate_spec.rb' + - 'spec/models/calculator/per_item_spec.rb' + - 'spec/models/calculator/price_sack_spec.rb' - 'spec/models/calculator/weight_spec.rb' - 'spec/models/column_preference_spec.rb' - 'spec/models/concerns/order_shipment_spec.rb' @@ -1221,11 +1346,6 @@ Style/FrozenStringLiteralComment: - 'spec/models/spree/ability_spec.rb' - 'spec/models/spree/addresses_spec.rb' - 'spec/models/spree/adjustment_spec.rb' - - 'spec/models/spree/calculator/flat_percent_item_total_spec.rb' - - 'spec/models/spree/calculator/flat_rate_spec.rb' - - 'spec/models/spree/calculator/flexi_rate_spec.rb' - - 'spec/models/spree/calculator/per_item_spec.rb' - - 'spec/models/spree/calculator/price_sack_spec.rb' - 'spec/models/spree/calculator_spec.rb' - 'spec/models/spree/classification_spec.rb' - 'spec/models/spree/credit_card_spec.rb' @@ -1240,14 +1360,12 @@ Style/FrozenStringLiteralComment: - 'spec/models/spree/price_spec.rb' - 'spec/models/spree/product_set_spec.rb' - 'spec/models/spree/product_spec.rb' - - 'spec/models/spree/shipment_spec.rb' - 'spec/models/spree/shipping_method_spec.rb' - 'spec/models/spree/stock/availability_validator_spec.rb' - 'spec/models/spree/tax_rate_spec.rb' - 'spec/models/spree/taxon_spec.rb' - 'spec/models/spree/user_spec.rb' - 'spec/models/spree/variant_spec.rb' - - 'spec/models/stock/package_spec.rb' - 'spec/models/stripe_account_spec.rb' - 'spec/models/subscription_line_item_spec.rb' - 'spec/models/subscription_spec.rb' @@ -1289,7 +1407,6 @@ Style/FrozenStringLiteralComment: - 'spec/serializers/api/product_serializer_spec.rb' - 'spec/serializers/api/shipping_method_serializer_spec.rb' - 'spec/serializers/api/variant_serializer_spec.rb' - - 'spec/services/advance_order_service_spec.rb' - 'spec/services/bulk_invoice_service_spec.rb' - 'spec/services/cart_service_spec.rb' - 'spec/services/default_shipping_category_spec.rb' @@ -1305,6 +1422,7 @@ Style/FrozenStringLiteralComment: - 'spec/services/order_cycle_warning_spec.rb' - 'spec/services/order_factory_spec.rb' - 'spec/services/order_syncer_spec.rb' + - 'spec/services/order_workflow_spec.rb' - 'spec/services/permissions/order_spec.rb' - 'spec/services/product_tag_rules_filterer_spec.rb' - 'spec/services/products_renderer_spec.rb' @@ -1355,8 +1473,9 @@ Style/FrozenStringLiteralComment: - 'spec/validators/integer_array_validator_spec.rb' - 'spec/views/spree/admin/orders/edit.html.haml_spec.rb' - 'spec/views/spree/admin/orders/index.html.haml_spec.rb' + - 'spec/views/spree/admin/payment_methods/index.html.haml_spec.rb' -# Offense count: 51 +# Offense count: 48 # Configuration parameters: MinBodyLength. Style/GuardClause: Exclude: @@ -1376,32 +1495,35 @@ Style/GuardClause: - 'app/models/spree/order_decorator.rb' - 'app/models/spree/price_decorator.rb' - 'app/models/spree/product_decorator.rb' - - 'app/services/advance_order_service.rb' - 'app/services/order_syncer.rb' - 'lib/discourse/single_sign_on.rb' - 'lib/open_food_network/order_cycle_form_applicator.rb' - 'lib/open_food_network/rack_request_blocker.rb' - 'lib/open_food_network/variant_and_line_item_naming.rb' - - 'lib/spree/core/controller_helpers/order_decorator.rb' - - 'lib/spree/core/controller_helpers/respond_with_decorator.rb' - 'spec/support/delayed_job_helper.rb' - 'spec/support/request/distribution_helper.rb' - 'spec/support/request/shop_workflow.rb' +# Offense count: 54 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. +# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys +Style/HashSyntax: + Exclude: + - 'spec/models/spree/payment_spec.rb' + # Offense count: 1 Style/MissingRespondToMissing: Exclude: - 'app/helpers/application_helper.rb' -# Offense count: 4 +# Offense count: 2 Style/MixinUsage: Exclude: - 'lib/open_food_network/orders_and_fulfillments_report.rb' - - 'spec/lib/open_food_network/bulk_coop_report_spec.rb' - - 'spec/lib/open_food_network/order_cycle_management_report_spec.rb' - 'spec/lib/open_food_network/packing_report_spec.rb' -# Offense count: 41 +# Offense count: 39 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods. # SupportedStyles: predicate, comparison @@ -1416,11 +1538,9 @@ Style/NumericPredicate: - 'app/models/product_import/product_importer.rb' - 'app/models/product_import/spreadsheet_entry.rb' - 'app/models/spree/adjustment_decorator.rb' - - 'app/models/spree/calculator/flexi_rate_decorator.rb' - 'app/models/spree/gateway/stripe_connect.rb' - 'app/models/spree/line_item_decorator.rb' - 'app/models/spree/order_decorator.rb' - - 'app/models/spree/shipment_decorator.rb' - 'app/models/spree/user.rb' - 'app/models/variant_override.rb' - 'app/services/cart_service.rb' @@ -1433,6 +1553,22 @@ Style/NumericPredicate: - 'lib/spree/money_decorator.rb' - 'lib/tasks/sample_data.rake' +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: compact, exploded +Style/RaiseArgs: + Exclude: + - 'spec/controllers/checkout_controller_spec.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, AllowInnerSlashes. +# SupportedStyles: slashes, percent_r, mixed +Style/RegexpLiteral: + Exclude: + - 'lib/spree/core/controller_helpers/auth.rb' + # Offense count: 231 Style/Send: Exclude: