From 60ef32300b32fa8dcce78e1e9c2a5d3b90284937 Mon Sep 17 00:00:00 2001 From: Luis Ramos Date: Fri, 4 Sep 2020 13:56:16 +0100 Subject: [PATCH] No need to test code with different ability setup, this was a good spec for spree, in ofn we use and test the static auth config in Ability --- .../spree/admin/users_controller_spec.rb | 27 ------------------- 1 file changed, 27 deletions(-) diff --git a/spec/controllers/spree/admin/users_controller_spec.rb b/spec/controllers/spree/admin/users_controller_spec.rb index f67417e1fe..2a67433db3 100644 --- a/spec/controllers/spree/admin/users_controller_spec.rb +++ b/spec/controllers/spree/admin/users_controller_spec.rb @@ -33,33 +33,6 @@ describe Spree::Admin::UsersController do expect(response).to redirect_to(spree.edit_admin_user_path(test_user)) end - describe "with BarAbility" do - class BarAbility - include CanCan::Ability - - def initialize(user) - user ||= Spree::User.new - return unless user.has_spree_role?('bar') - - can [:admin, :index, :show], Spree::Order - end - end - - it 'should deny access to users with an bar role' do - user.spree_roles << Spree::Role.find_or_create_by(name: 'bar') - Spree::Ability.register_ability(BarAbility) - spree_post :index - expect(response).to redirect_to('/unauthorized') - end - - it 'should deny access to users with an bar role' do - user.spree_roles << Spree::Role.find_or_create_by(name: 'bar') - Spree::Ability.register_ability(BarAbility) - spree_post :update, id: '9' - expect(response).to redirect_to('/unauthorized') - end - end - it 'should deny access to users without an admin role' do allow(user).to receive_messages has_spree_role?: false spree_post :index