diff --git a/app/controllers/admin/bulk_line_items_controller.rb b/app/controllers/admin/bulk_line_items_controller.rb index feedc4aa60..837ad47535 100644 --- a/app/controllers/admin/bulk_line_items_controller.rb +++ b/app/controllers/admin/bulk_line_items_controller.rb @@ -49,7 +49,7 @@ module Admin load_line_item authorize! :update, order - order.contents.remove(@line_item.variant, @line_item.quantity) + order.contents.remove(@line_item.variant) render body: nil, status: :no_content # No Content, does not trigger ng resource auto-update end diff --git a/app/models/spree/order_contents.rb b/app/models/spree/order_contents.rb index 1bafe0a82d..53ad53fde6 100644 --- a/app/models/spree/order_contents.rb +++ b/app/models/spree/order_contents.rb @@ -19,7 +19,7 @@ module Spree # Get current line item for variant # Remove variant qty from line_item - def remove(variant, quantity = 1, shipment = nil) + def remove(variant, quantity = nil, shipment = nil) line_item = remove_from_line_item(variant, quantity, shipment) update_shipment(shipment) update_order @@ -66,7 +66,7 @@ module Spree def remove_from_line_item(variant, quantity, shipment = nil) line_item = find_line_item_by_variant(variant, true) - line_item.quantity += -quantity + quantity.present? ? line_item.quantity += -quantity : line_item.quantity = 0 line_item.target_shipment = shipment if line_item.quantity == 0