From 5ee647fd7c3e69b4060c4fe6de334813c7ffd902 Mon Sep 17 00:00:00 2001 From: Pau Perez Date: Tue, 16 Mar 2021 15:21:37 +0100 Subject: [PATCH] Improve specs Better to rely on a verifying double and reveal our intentions using `subject` instead. --- spec/controllers/spree/users_controller_spec.rb | 2 +- spec/queries/outstanding_balance_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/controllers/spree/users_controller_spec.rb b/spec/controllers/spree/users_controller_spec.rb index ed45787d65..49381e997d 100644 --- a/spec/controllers/spree/users_controller_spec.rb +++ b/spec/controllers/spree/users_controller_spec.rb @@ -44,7 +44,7 @@ describe Spree::UsersController, type: :controller do end context 'when the customer_balance feature is enabled' do - let(:outstanding_balance) { double(:outstanding_balance) } + let(:outstanding_balance) { instance_double(OutstandingBalance) } before do allow(OpenFoodNetwork::FeatureToggle) diff --git a/spec/queries/outstanding_balance_spec.rb b/spec/queries/outstanding_balance_spec.rb index af880528f7..bd21b9da9e 100644 --- a/spec/queries/outstanding_balance_spec.rb +++ b/spec/queries/outstanding_balance_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' describe OutstandingBalance do - let(:outstanding_balance) { described_class.new(relation) } + subject(:outstanding_balance) { described_class.new(relation) } describe '#statement' do let(:relation) { Spree::Order.none }