Fix error handling when creating a voucher adjustment

I wrongly assumed that `voucher.create_adjustment` would return nil
if failing to create an adjustment. I will in fact return an
adjustment object with errors.
This commit is contained in:
Gaetan Craig-Riou
2023-05-12 15:01:52 +10:00
committed by Maikel Linke
parent ccff3379ea
commit 5eb6097101
2 changed files with 8 additions and 4 deletions

View File

@@ -226,8 +226,9 @@ class SplitCheckoutController < ::BaseController
adjustment = voucher.create_adjustment(voucher.code, @order)
if adjustment.nil?
if !adjustment.valid?
@order.errors.add(:voucher, I18n.t('split_checkout.errors.add_voucher_error'))
adjustment.errors.each { |error| @order.errors.import(error) }
return false
end